ballerina-core 1.0.190 → 1.0.192

package/package.json

@@ -2,7 +2,7 @@
   "name": "ballerina-core",
   "author": "Dr. Giuseppe Maggiore",
   "private": false,
-  "version": "1.0.190",
+  "version": "1.0.192",
   "main": "main.ts",
   "scripts": {
     "prettier": "prettier --write ."

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/list/state.ts

@@ -8,6 +8,7 @@ import {
   DispatchOnChange,
   ListType,
   ValueCallbackWithOptionalFlags,
+  ValueUnit,
   VoidCallbackWithOptionalFlags,
 } from "../../../../../../../../main";
 import { Unit } from "../../../../../../../fun/domains/unit/state";
@@ -21,7 +22,7 @@ export type ListAbstractRendererReadonlyContext<
   ExtraContext,
 > = CommonAbstractRendererReadonlyContext<
   ListType<any>,
-  ValueTuple,
+  ValueTuple | ValueUnit,
   CustomPresentationContext,
   ExtraContext
 >;

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/list/template.tsx

@@ -16,10 +16,7 @@ import {
 } from "../../../../../../../../main";
 import { Template } from "../../../../../../../template/state";
 import { ListMethods } from "../../../../deserializer/domains/specification/domains/forms/domains/renderer/domains/list/state";
-import {
-  DispatchParsedType,
-  StringSerializedType,
-} from "../../../../deserializer/domains/specification/domains/types/state";
+import { DispatchParsedType } from "../../../../deserializer/domains/specification/domains/types/state";
 import {
   ListAbstractRendererForeignMutationsExpected,
   ListAbstractRendererReadonlyContext,
@@ -63,8 +60,9 @@ export const ListAbstractRenderer = <
           ) => ({
             disabled: _.disabled,
             locked: _.locked,
-            value:
-              _.value.values?.get(elementIndex) || GetDefaultElementValue(),
+            value: PredicateValue.Operations.IsUnit(_.value)
+              ? _.value
+              : _.value.values.get(elementIndex) || GetDefaultElementValue(),
             ...(_.elementFormStates?.get(elementIndex) ||
               GetDefaultElementState()),
             bindings: _.bindings,
@@ -154,15 +152,18 @@ export const ListAbstractRenderer = <
   >((props) => {
     const domNodeId = props.context.domNodeAncestorPath + "[list]";
 
-    if (!PredicateValue.Operations.IsTuple(props.context.value)) {
+    if (
+      !PredicateValue.Operations.IsTuple(props.context.value) &&
+      !PredicateValue.Operations.IsUnit(props.context.value)
+    ) {
       console.error(
-        `Tuple value expected but got: ${JSON.stringify(
+        `Tuple or unit value expected but got: ${JSON.stringify(
           props.context.value,
         )}\n...When rendering \n...${domNodeId}`,
       );
       return (
         <ErrorRenderer
-          message={`${domNodeId}: Tuple value expected for list but got ${JSON.stringify(
+          message={`${domNodeId}: Tuple or unit value expected for list but got ${JSON.stringify(
             props.context.value,
           )}`}
         />

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/record/state.ts

@@ -6,6 +6,7 @@ import {
   simpleUpdater,
   Template,
   Updater,
+  ValueUnit,
   ValueRecord,
   View,
   DispatchOnChange,
@@ -23,7 +24,7 @@ export type RecordAbstractRendererReadonlyContext<
   ExtraContext,
 > = CommonAbstractRendererReadonlyContext<
   RecordType<any>,
-  ValueRecord,
+  ValueRecord | ValueUnit,
   CustomPresentationContext,
   ExtraContext
 >;

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/record/template.tsx

@@ -93,7 +93,9 @@ export const RecordAbstractRenderer = <
             > &
               RecordAbstractRendererState,
           ) => ({
-            value: _.value.fields.get(fieldName)!,
+            value: PredicateValue.Operations.IsUnit(_.value)
+              ? _.value
+              : _.value.fields.get(fieldName)!,
             type: _.type.fields.get(fieldName)!,
             ...(_.fieldStates?.get(fieldName) ||
               FieldTemplates.get(fieldName)!.GetDefaultState()),
@@ -201,15 +203,18 @@ export const RecordAbstractRenderer = <
   >((props) => {
     const domNodeId = props.context.domNodeAncestorPath + "[record]";
 
-    if (!PredicateValue.Operations.IsRecord(props.context.value)) {
+    if (
+      !PredicateValue.Operations.IsRecord(props.context.value) &&
+      !PredicateValue.Operations.IsUnit(props.context.value)
+    ) {
       console.error(
-        `Record expected but got: ${JSON.stringify(
+        `Record or unit value expected but got: ${JSON.stringify(
           props.context.value,
         )}\n...When rendering \n...${domNodeId}`,
       );
       return (
         <ErrorRenderer
-          message={`${domNodeId}: Record value expected but got ${JSON.stringify(
+          message={`${domNodeId}: Record or unit value expected but got ${JSON.stringify(
             props.context.value,
           )}`}
         />

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/table/template.tsx

@@ -504,9 +504,6 @@ export const TableAbstractRenderer = <
               .flatMap((_, column) => {
                 const EmbeddedCell = EmbeddedCellTemplates.get(column);
                 if (EmbeddedCell == undefined) {
-                  console.error(
-                    `Cannot find column ${column} in fields ${rowData.fields.keySeq().toArray()}, this is likely due to a mismatch between the data we are trying to parse and the specs.`,
-                  );
                   return [];
                 }
                 return [

package/src/forms/domains/dispatched-forms/runner/domains/traversal/state.ts

@@ -78,31 +78,77 @@ export const RendererTraversal = {
 
       if (
         renderer.kind == "lookupType-lookupRenderer" ||
-        renderer.kind == "inlinedType-lookupRenderer" ||
-        renderer.kind == "lookupType-inlinedRenderer"
+        renderer.kind == "lookupType-inlinedRenderer" ||
+        renderer.kind == "inlinedType-lookupRenderer"
       ) {
         if (
           renderer.kind == "lookupType-lookupRenderer" ||
-          renderer.kind == "inlinedType-lookupRenderer"
+          renderer.kind == "lookupType-inlinedRenderer"
         ) {
-          // renderer.renderer.renderer is the form name
-          // this is a form lookup, so "local" changes here to the traversed value
           return LookupRenderer.Operations.ResolveRenderer(
             renderer,
             traversalContext.forms,
           ).Then((resolvedRenderer) =>
             rec(resolvedRenderer, traversalContext).Then(
               (valueTraversal: Option<ValueTraversal<T, Res>>) =>
-                ValueOrErrors.Default.return(
-                  mapEvalContext((ctx) => ({
-                    ...ctx,
-                    local: ctx.traversalIterator,
-                  }))(valueTraversal),
-                ),
+                ValueOrErrors.Default.return<
+                  Option<ValueTraversal<T, Res>>,
+                  string
+                >(
+                  // reassign local if it's a lookup renderer
+                  renderer.kind == "lookupType-lookupRenderer"
+                    ? mapEvalContext((ctx) => ({
+                        ...ctx,
+                        local: ctx.traversalIterator,
+                      }))(valueTraversal)
+                    : valueTraversal,
+                ).Then((resolvedTraversal) => {
+                  if (
+                    traverseNode.kind == "l" &&
+                    resolvedTraversal.kind == "l"
+                  ) {
+                    return ValueOrErrors.Default.return(Option.Default.none());
+                  }
+
+                  if (traverseNode.kind == "l") {
+                    return ValueOrErrors.Default.return(resolvedTraversal);
+                  }
+
+                  if (resolvedTraversal.kind == "l") {
+                    return ValueOrErrors.Default.return(
+                      Option.Default.some((evalContext: EvalContext<T, Res>) =>
+                        traverseNode
+                          .value(evalContext)
+                          .Then((nodeResult) =>
+                            ValueOrErrors.Default.return(nodeResult),
+                          ),
+                      ),
+                    );
+                  }
+
+                  return ValueOrErrors.Default.return(
+                    Option.Default.some((evalContext: EvalContext<T, Res>) => {
+                      return resolvedTraversal
+                        .value(evalContext)
+                        .Then((resolvedTraversal) =>
+                          traverseNode
+                            .value(evalContext)
+                            .Then((nodeResult) =>
+                              ValueOrErrors.Default.return<Res, string>(
+                                traversalContext.joinRes([
+                                  nodeResult,
+                                  resolvedTraversal,
+                                ]),
+                              ),
+                            ),
+                        );
+                    }),
+                  );
+                }),
             ),
           );
         }
-        // otherwise the form is inlined, so the local doesn't change
+
         return LookupRenderer.Operations.ResolveRenderer(
           renderer,
           traversalContext.forms,
@@ -113,6 +159,54 @@ export const RendererTraversal = {
           ),
         );
       }
+
+      if (
+        renderer.type.kind == "readOnly" &&
+        renderer.kind == "readOnlyRenderer"
+      ) {
+        return rec(renderer.childRenderer.renderer, traversalContext).Then(
+          (valueTraversal: Option<ValueTraversal<T, Res>>) => {
+            if (valueTraversal.kind == "l" && traverseNode.kind == "l") {
+              return ValueOrErrors.Default.return(Option.Default.none());
+            }
+            return ValueOrErrors.Default.return(
+              Option.Default.some((evalContext: EvalContext<T, Res>) => {
+                const iterator = evalContext.traversalIterator;
+                if (!PredicateValue.Operations.IsReadOnly(iterator)) {
+                  return ValueOrErrors.Default.throwOne<Res, string>(
+                    `Error: traversal iterator is not read only, got ${JSON.stringify(
+                      iterator,
+                      undefined,
+                      2,
+                    )}`,
+                  );
+                }
+                return (
+                  valueTraversal.kind == "r"
+                    ? valueTraversal.value({
+                        ...evalContext,
+                        traversalIterator: iterator.ReadOnly,
+                      })
+                    : ValueOrErrors.Default.return<Res, string>(
+                        traversalContext.zeroRes(unit),
+                      )
+                ).Then((valueResult) =>
+                  traverseNode.kind == "r"
+                    ? traverseNode
+                        .value(evalContext)
+                        .Then((nodeResult) =>
+                          ValueOrErrors.Default.return(
+                            traversalContext.joinRes([valueResult, nodeResult]),
+                          ),
+                        )
+                    : ValueOrErrors.Default.return(valueResult),
+                );
+              }),
+            );
+          },
+        );
+      }
+
       if (renderer.type.kind == "record" && renderer.kind == "recordRenderer") {
         return ValueOrErrors.Operations.All(
           List(