balena-settings-client 5.0.4-build-drop-lodash-1eab7d7f4d034e4efb1b0ae553200b857ca25a43-1 → 5.0.4-build-drop-lodash-e1b494191f5710e3bcd7522b2bf7bc943f249b99-1

package/.versionbot/CHANGELOG.yml

@@ -1,6 +1,13 @@
 - commits:
-    - subject: test fix
-      hash: 1eab7d7f4d034e4efb1b0ae553200b857ca25a43
+    - subject: Fix empty error
+      hash: e1b494191f5710e3bcd7522b2bf7bc943f249b99
+      body: ""
+      footer:
+        Change-type: patch
+        change-type: patch
+      author: Matthew Yarmolinsky
+    - subject: Test without bluebird
+      hash: 680f2497a376b73f40dd5953f1b9e539ea001b17
       body: ""
       footer:
         Change-type: patch
@@ -43,7 +50,7 @@
       author: Matthew Yarmolinsky
   version: 5.0.4
   title: ""
-  date: 2025-12-22T23:22:26.981Z
+  date: 2025-12-23T00:11:29.512Z
 - commits:
     - subject: Update TypeScript to 5.1.3
       hash: 9127d3d46c063abbd8a55af1a53492de54fb1154

package/CHANGELOG.md

@@ -5,9 +5,10 @@ automatically by Versionist. DO NOT EDIT THIS FILE MANUALLY!
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 # v5.0.4
-## (2025-12-22)
+## (2025-12-23)
 
-* test fix [Matthew Yarmolinsky]
+* Fix empty error [Matthew Yarmolinsky]
+* Test without bluebird [Matthew Yarmolinsky]
 * Replace `lodash` with `es-toolkit` [Matthew Yarmolinsky]
 * Add dependency `es-toolkit` [Matthew Yarmolinsky]
 * Drop `lodash` as a dependency [Matthew Yarmolinsky]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "balena-settings-client",
-  "version": "5.0.4-build-drop-lodash-1eab7d7f4d034e4efb1b0ae553200b857ca25a43-1",
+  "version": "5.0.4-build-drop-lodash-e1b494191f5710e3bcd7522b2bf7bc943f249b99-1",
   "description": "Balena client application shared settings",
   "main": "build/settings.js",
   "types": "build/settings.d.ts",
@@ -34,13 +34,11 @@
   "devDependencies": {
     "@balena/lint": "^6.2.2",
     "@resin.io/types-wary": "1.1.1",
-    "@types/bluebird": "^3.5.30",
     "@types/chai": "^4.2.11",
     "@types/chai-as-promised": "^7.1.2",
     "@types/common-tags": "^1.8.0",
     "@types/mocha": "^5.2.7",
     "@types/node": "^8.10.60",
-    "bluebird": "^3.7.2",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
     "common-tags": "^1.8.0",
@@ -75,6 +73,6 @@
     ]
   },
   "versionist": {
-    "publishedAt": "2025-12-22T23:22:27.066Z"
+    "publishedAt": "2025-12-23T00:11:29.601Z"
   }
 }

package/tests/e2e/test.ts

@@ -1,5 +1,3 @@
-import * as Promise from 'bluebird';
-import * as childProcess from 'child_process';
 import { stripIndent } from 'common-tags';
 import * as fs from 'fs';
 import { expect, use } from 'chai';
@@ -10,116 +8,91 @@ import * as chaiAsPromised from 'chai-as-promised';
 use(chaiAsPromised);
 
 import config = require('../../lib/config');
+import { promisify } from 'util';
+import { exec } from 'child_process';
 
-const execAsync = Promise.promisify<[string, string], string, any>(
-	childProcess.exec,
-	{ multiArgs: true },
-);
+const execAsync = promisify(exec);
 
 const handleExecResult = (stdout: string, stderr: string) => {
-	// Inside handleExecResult(error, stdout, stderr)
-
-	if (stderr) {
-		console.log('============= DEBUG CRASH REPORT =============');
-
-		// 1. Log stdout (sometimes errors end up here)
-		if (stdout) {
-			console.log('--- STDOUT ---');
-			console.log(stdout.toString()); // Ensure Buffer is converted
-		}
-
-		// 2. Log stderr
-		if (stderr) {
-			console.log('--- STDERR ---');
-			console.log(stderr.toString());
-		}
-
-		console.log('==============================================');
-
-		// Throw a descriptive error
-		const message = (stderr || stdout || 'Unknown CLI Error').toString();
-		throw new Error(`CLI Failed: ${message}`);
+	if (stderr.length > 0) {
+		throw new Error(stderr);
 	}
 	return stdout.replace(/\n$/, '');
 };
 
 const getSetting = (setting: string) => {
 	const script = path.join(__dirname, 'get.ts');
-	return execAsync(`ts-node ${script} ${setting}`, { encoding: 'utf8' }).spread(
-		handleExecResult,
+	return execAsync(`ts-node ${script} ${setting}`, { encoding: 'utf8' }).then(
+		({ stdout, stderr }) => {
+			return handleExecResult(stdout, stderr);
+		},
 	);
 };
 
 const getAll = () => {
 	const script = path.join(__dirname, 'get-all.ts');
 	return execAsync(`ts-node ${script}`, { encoding: 'utf8' })
-		.spread(handleExecResult)
+		.then(({ stdout, stderr }) => {
+			return handleExecResult(stdout, stderr);
+		})
 		.then(JSON.parse);
 };
 
 wary.it(
 	'should override defaults given a legacy resin configuration',
 	{},
-	() => {
+	async () => {
 		fs.writeFileSync(
 			config.paths.user.replace('balenarc.yml', 'resinrc.yml'),
 			stripIndent`
 				resinUrl: resin.io
 			`,
 		);
-		return Promise.props({
-			balenaUrl: getSetting('balenaUrl'),
-			apiUrl: getSetting('apiUrl'),
-			dashboardUrl: getSetting('dashboardUrl'),
-			vpnUrl: getSetting('vpnUrl'),
-			registryUrl: getSetting('registryUrl'),
-			registry2Url: getSetting('registry2Url'),
-			proxyUrl: getSetting('proxyUrl'),
-		}).then((settings) => {
-			expect(settings.balenaUrl).to.equal('resin.io');
-			expect(settings.apiUrl).to.equal('https://api.resin.io');
-			expect(settings.dashboardUrl).to.equal('https://dashboard.resin.io');
-			expect(settings.vpnUrl).to.equal('vpn.resin.io');
-			expect(settings.registryUrl).to.equal('registry.resin.io');
-			expect(settings.registry2Url).to.equal('registry2.resin.io');
-			expect(settings.proxyUrl).to.equal('resindevice.io');
-		});
+		const balenaUrl = await getSetting('balenaUrl');
+		expect(balenaUrl).to.equal('resin.io');
+		const apiUrl = await getSetting('apiUrl');
+		expect(apiUrl).to.equal('https://api.resin.io');
+		const dashboardUrl = await getSetting('dashboardUrl');
+		expect(dashboardUrl).to.equal('https://dashboard.resin.io');
+		const vpnUrl = await getSetting('vpnUrl');
+		expect(vpnUrl).to.equal('vpn.resin.io');
+		const registryUrl = await getSetting('registryUrl');
+		expect(registryUrl).to.equal('registry.resin.io');
+		const registry2Url = await getSetting('registry2Url');
+		expect(registry2Url).to.equal('registry2.resin.io');
+		const proxyUrl = await getSetting('proxyUrl');
+		expect(proxyUrl).to.equal('resindevice.io');
 	},
 );
 
 wary.it(
 	'should override defaults and resin configuration given a user balena configuration that points to staging',
 	{},
-	() => {
+	async () => {
 		fs.writeFileSync(
 			config.paths.user,
 			stripIndent`
 				balenaUrl: balena-staging.com
 			`,
 		);
-		return Promise.props({
-			balenaUrl: getSetting('balenaUrl'),
-			apiUrl: getSetting('apiUrl'),
-			dashboardUrl: getSetting('dashboardUrl'),
-			vpnUrl: getSetting('vpnUrl'),
-			registryUrl: getSetting('registryUrl'),
-			registry2Url: getSetting('registry2Url'),
-			proxyUrl: getSetting('proxyUrl'),
-		}).then((settings) => {
-			expect(settings.balenaUrl).to.equal('balena-staging.com');
-			expect(settings.apiUrl).to.equal('https://api.balena-staging.com');
-			expect(settings.dashboardUrl).to.equal(
-				'https://dashboard.balena-staging.com',
-			);
-			expect(settings.vpnUrl).to.equal('vpn.balena-staging.com');
-			expect(settings.registryUrl).to.equal('registry.balena-staging.com');
-			expect(settings.registry2Url).to.equal('registry2.balena-staging.com');
-			expect(settings.proxyUrl).to.equal('balena-staging-devices.com');
-		});
+		const balenaUrl = await getSetting('balenaUrl');
+		expect(balenaUrl).to.equal('balena-staging.com');
+		const apiUrl = await getSetting('apiUrl');
+		expect(apiUrl).to.equal('https://api.balena-staging.com');
+		const dashboardUrl = await getSetting('dashboardUrl');
+		expect(dashboardUrl).to.equal('https://dashboard.balena-staging.com');
+		const vpnUrl = await getSetting('vpnUrl');
+		expect(vpnUrl).to.equal('vpn.balena-staging.com');
+		const registryUrl = await getSetting('registryUrl');
+		expect(registryUrl).to.equal('registry.balena-staging.com');
+		const registry2Url = await getSetting('registry2Url');
+		expect(registry2Url).to.equal('registry2.balena-staging.com');
+		const proxyUrl = await getSetting('proxyUrl');
+		expect(proxyUrl).to.equal('balena-staging-devices.com');
 	},
 );
 
-wary.it('should give precedence to project configuration', {}, () => {
+wary.it('should give precedence to project configuration', {}, async () => {
 	fs.writeFileSync(
 		config.paths.user,
 		stripIndent`
@@ -132,25 +105,20 @@ wary.it('should give precedence to project configuration', {}, () => {
 			balenaUrl: balena.custom.com/
 		`,
 	);
-	return Promise.props({
-		balenaUrl: getSetting('balenaUrl'),
-		apiUrl: getSetting('apiUrl'),
-		dashboardUrl: getSetting('dashboardUrl'),
-		vpnUrl: getSetting('vpnUrl'),
-		registryUrl: getSetting('registryUrl'),
-		registry2Url: getSetting('registry2Url'),
-		proxyUrl: getSetting('proxyUrl'),
-	}).then((settings) => {
-		expect(settings.balenaUrl).to.equal('balena.custom.com/');
-		expect(settings.apiUrl).to.equal('https://api.balena.custom.com/');
-		expect(settings.dashboardUrl).to.equal(
-			'https://dashboard.balena.custom.com/',
-		);
-		expect(settings.vpnUrl).to.equal('vpn.balena.custom.com/');
-		expect(settings.registryUrl).to.equal('registry.balena.custom.com/');
-		expect(settings.registry2Url).to.equal('registry2.balena.custom.com/');
-		expect(settings.proxyUrl).to.equal('devices.balena.custom.com/');
-	});
+	const balenaUrl = await getSetting('balenaUrl');
+	expect(balenaUrl).to.equal('balena.custom.com/');
+	const apiUrl = await getSetting('apiUrl');
+	expect(apiUrl).to.equal('https://api.balena.custom.com/');
+	const dashboardUrl = await getSetting('dashboardUrl');
+	expect(dashboardUrl).to.equal('https://dashboard.balena.custom.com/');
+	const vpnUrl = await getSetting('vpnUrl');
+	expect(vpnUrl).to.equal('vpn.balena.custom.com/');
+	const registryUrl = await getSetting('registryUrl');
+	expect(registryUrl).to.equal('registry.balena.custom.com/');
+	const registry2Url = await getSetting('registry2Url');
+	expect(registry2Url).to.equal('registry2.balena.custom.com/');
+	const proxyUrl = await getSetting('proxyUrl');
+	expect(proxyUrl).to.equal('devices.balena.custom.com/');
 });
 
 wary.it(