balena-sdk 16.9.2 → 16.9.4

package/CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file
 automatically by Versionist. DO NOT EDIT THIS FILE MANUALLY!
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 16.9.4 - 2021-12-29
+
+* os: Avoid mutating the args in getAvailableOsVersions & getAllOsVersion [Thodoris Greasidis]
+
+## 16.9.3 - 2021-12-28
+
+* os: Replace semver normalization with balena-semver [Thodoris Greasidis]
+
 ## 16.9.2 - 2021-12-28
 
 * Stop relying on the balena-pine module [Thodoris Greasidis]

package/es2015/balena-browser.js

@@ -9560,7 +9560,9 @@ const releaseSelectedFields = (0, types_1.toWritable)([
     'known_issue_list',
     'raw_version',
 ]);
-const BALENAOS_VERSION_REGEX = /v?\d+\.\d+\.\d+(\.rev\d+)?((\-|\+).+)?/;
+const sortVersions = (a, b) => {
+    return bSemver.rcompare(a.rawVersion, b.rawVersion);
+};
 const getOsModel = function (deps, opts) {
     const { pine, request, pubsub } = deps;
     const { apiUrl, isBrowser } = opts;
@@ -9572,9 +9574,6 @@ const getOsModel = function (deps, opts) {
     () => require('../util/device-types'));
     const hupActionHelper = once(() => require('../util/device-actions/os-update/utils').hupActionHelper);
     const authDependentMemoizer = (0, cache_1.getAuthDependentMemoize)(pubsub);
-    const sortVersions = (a, b) => {
-        return bSemver.rcompare(a.rawVersion, b.rawVersion);
-    };
     const tagsToDictionary = (tags) => {
         const result = {};
         for (const { tag_key, value } of tags) {
@@ -9701,14 +9700,12 @@ const getOsModel = function (deps, opts) {
             const appTags = getOsAppTags((_c = hostApp.application_tag) !== null && _c !== void 0 ? _c : []);
             osVersionsByDeviceType[hostAppDeviceType].push(..._getOsVersionsFromReleases((_d = hostApp.owns__release) !== null && _d !== void 0 ? _d : [], appTags));
         });
-        return osVersionsByDeviceType;
-    };
-    // This mutates the passed object.
-    const _transformVersionSets = (osVersionsByDeviceType) => {
+        // transform version sets
         Object.keys(osVersionsByDeviceType).forEach((deviceType) => {
             osVersionsByDeviceType[deviceType].sort(sortVersions);
-            const recommendedPerOsType = {};
+            // TODO: Drop in next major
             // Note: the recommended version settings might come from the server in the future, for now we just set it to the latest version for each os type.
+            const recommendedPerOsType = {};
             osVersionsByDeviceType[deviceType].forEach((version) => {
                 if (!recommendedPerOsType[version.osType]) {
                     if (version.variant !== 'dev' &&
@@ -9728,7 +9725,7 @@ const getOsModel = function (deps, opts) {
     };
     const _getAllOsVersions = (deviceTypes, options) => (0, tslib_1.__awaiter)(this, void 0, void 0, function* () {
         const hostapps = yield _getOsVersions(deviceTypes, options);
-        return yield _transformVersionSets(_transformHostApps(hostapps));
+        return yield _transformHostApps(hostapps);
     });
     const _memoizedGetAllOsVersions = authDependentMemoizer((deviceTypes, listedByDefault) => (0, tslib_1.__awaiter)(this, void 0, void 0, function* () {
         return yield _getAllOsVersions(deviceTypes, listedByDefault
@@ -9764,7 +9761,7 @@ const getOsModel = function (deps, opts) {
         return (0, tslib_1.__awaiter)(this, void 0, void 0, function* () {
             const singleDeviceTypeArg = typeof deviceTypes === 'string' ? deviceTypes : false;
             deviceTypes = Array.isArray(deviceTypes) ? deviceTypes : [deviceTypes];
-            const versionsByDt = yield _memoizedGetAllOsVersions(deviceTypes.sort(), true);
+            const versionsByDt = yield _memoizedGetAllOsVersions(deviceTypes.slice().sort(), true);
             return singleDeviceTypeArg
                 ? (_a = versionsByDt[singleDeviceTypeArg]) !== null && _a !== void 0 ? _a : []
                 : versionsByDt;
@@ -9798,7 +9795,7 @@ const getOsModel = function (deps, opts) {
             const singleDeviceTypeArg = typeof deviceTypes === 'string' ? deviceTypes : false;
             deviceTypes = Array.isArray(deviceTypes) ? deviceTypes : [deviceTypes];
             const versionsByDt = options == null
-                ? yield _memoizedGetAllOsVersions(deviceTypes.sort(), null)
+                ? yield _memoizedGetAllOsVersions(deviceTypes.slice().sort(), null)
                 : yield _getAllOsVersions(deviceTypes, options);
             return singleDeviceTypeArg
                 ? (_a = versionsByDt[singleDeviceTypeArg]) !== null && _a !== void 0 ? _a : []
@@ -9855,23 +9852,12 @@ const getOsModel = function (deps, opts) {
             return v;
         }
         const vNormalized = v[0] === 'v' ? v.substring(1) : v;
-        if (!BALENAOS_VERSION_REGEX.test(vNormalized)) {
+        // We still don't want to allow `balenaOS` prefixes, which balena-semver allows.
+        if (!bSemver.valid(vNormalized) || !/^\d/.test(vNormalized)) {
             throw new Error(`Invalid semver version: ${v}`);
         }
         return vNormalized;
     };
-    const fixNonSemver = (version) => {
-        if (version == null) {
-            return version;
-        }
-        return version.replace(/\.rev(\d+)/, '+FIXED-rev$1');
-    };
-    const unfixNonSemver = (version) => {
-        if (version == null) {
-            return version;
-        }
-        return version.replace(/\+FIXED-rev(\d+)/, '.rev$1');
-    };
     /**
      * @summary Get the max OS version satisfying the given range.
      * @description Utility method exported for testability.
@@ -9892,16 +9878,13 @@ const getOsModel = function (deps, opts) {
             return (_d = ((_c = osVersions.find((v) => v.isRecommended)) !== null && _c !== void 0 ? _c : osVersions[0])) === null || _d === void 0 ? void 0 : _d.rawVersion;
         }
         const versions = osVersions.map((v) => v.rawVersion);
-        const semverVersions = versions.map(fixNonSemver);
-        // TODO: Once we integrate balena-semver, balena-semver should learn to handle this itself
-        const semverVersionOrRange = fixNonSemver(versionOrRange);
-        if (semverVersions.includes(semverVersionOrRange)) {
+        if (versions.includes(versionOrRange)) {
             // If the _exact_ version you're looking for exists, it's not a range, and
             // we should return it exactly, not any old equivalent version.
-            return unfixNonSemver(semverVersionOrRange);
+            return versionOrRange;
         }
-        const maxVersion = bSemver.maxSatisfying(semverVersions, semverVersionOrRange);
-        return unfixNonSemver(maxVersion);
+        const maxVersion = bSemver.maxSatisfying(versions, versionOrRange);
+        return maxVersion;
     };
     /**
      * @summary Get OS download size estimate
@@ -12115,7 +12098,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 // being embedded in the dist of the consumer project
 // which we want to avoid, both b/c of the dist size increase &
 // the security concerns of including the versions of the dependencies
-const sdkVersion = '16.9.2';
+const sdkVersion = '16.9.4';
 exports.default = sdkVersion;
 
 },{}],47:[function(require,module,exports){