baldart 4.99.0 → 5.0.1

package/CHANGELOG.md

@@ -5,6 +5,120 @@ All notable changes to BALDART will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [5.0.1] - 2026-07-03
+
+**Adversarial-verification fixes on the 5.0.0 wave.** A full release verification
+(distribution machine dogfooded end-to-end on 4 configs — all green; normative-loss audit
+over 4 core agents; pipeline-coherence audit) found the headline mechanisms inert on the
+happy path plus a handful of slot-boundary and consistency defects. All fixed; no gate
+removed, no H2 moved (consumer overlays unaffected), no `baldart.config.yml` change.
+
+- **FIXED (HIGH) — `/new` step 11b clean branch now proceeds to 11c**: previously only the
+  violation branch reached the review-bundle/doc-invariants build, leaving the v5.0.0
+  anti-re-read + PASS-fast machinery unused on every clean card (`implement.md`).
+- **FIXED (HIGH) — `/codexreview` consumes the full lean contract**: Step -0.5 now parses +
+  forwards `review_bundle_path` (anti-re-read phrase in every Step-2 prompt) and
+  `specialist_dispatch` (orchestrated-mode suppression, `dispatch_deferred:<agent>`) — both
+  were produced by `codex-gate.md` but dead-wired on the `/new`→`/codexreview` hop. Optional
+  keys: pre-5.0 contracts keep working unchanged.
+- **FIXED (HIGH) — coder slot boundaries**: `vercel-react-best-practices` un-slotted (no
+  config flag can express React-non-Next → structural normative loss); the NEVER-ad-hoc
+  browser-scripts rule hoisted out of `{{#e2e_playwright}}` (universal pre-5.0). Agents
+  CHANGELOG: coder/doc-reviewer/qa-sentinel v2.0.1.
+- **FIXED (MEDIUM)** — doc-reviewer per-card cited exceptions (`topological-generation`,
+  `schema-drift`) restored + `doc-audit-protocol.md` Contract no longer contradicts the agent
+  core; qa-sentinel bundle `gate_logs` demoted to context-only (own-tier gates always re-run);
+  `build-review-bundle.mjs` diff scoped to `--may-edit` (multi-card batches no longer leak
+  prior cards into card N's bundle/docinv; `new2.js` implement brief mirrors the scoping);
+  `new-card-review.js` + the 2.5x delegation thread `reviewBundlePath` into every brief;
+  Phase 2.55 pre-5.0 fallback uses `git diff "$TRUNK...HEAD"` (bare `git diff` post-commit is
+  vacuous); cap-and-handoff checkpoint-missing branch defined; `/ui-implement`-delegated cards
+  explicitly run 7c–11c; PASS-fast Own-Doc Closure claim corrected; "rule 8" pointers
+  re-anchored to the renumbered Post-Intervention Coherence rule 7 (prd-card-writer, upgrade
+  doc, new2-resolve comment).
+- **FIXED (LOW)** — `doc-invariants.mjs` evaluates `documentation_impact` and `canonical_docs`
+  independently; deferral KEEP list re-includes `balanced`; stale `coding-standards.md`
+  cross-refs to the removed coder H2 updated; `${paths.references_dir}` literals in
+  `doc-audit-protocol.md`.
+- Skills: `new` 2.0.1, `new2` 1.4.1 (per-skill CHANGELOGs). Codex parity: portable — prose +
+  pure-Node scripts, no Claude-only primitive added; the `/codexreview` contract keys are
+  optional and ignored by pre-5.0 readers.
+
+## [5.0.0] - 2026-07-03
+
+**The agent-spine major.** Measured driver (1,934 subagent runs / 191 sessions on the
+`mayo` consumer, one month, deduplicated by API-call id): 5.0B context tokens, of which
+coder 53% and the whole review chain ~10%; the fixed per-spawn preamble (~45k, agent
+definition 6–10k of it) is re-paid on EVERY API call; Read results are 66–75% of
+tool_result bytes with the same hot files re-read at every chain link; the top-10
+monster runs (200–440 calls) alone are 14% of total spend. 5.0 restructures the core
+agents and the `/new` pipeline around those numbers — no gate is removed anywhere.
+
+- **MAJOR — agents install as generated files when slot-bearing.** Core agent
+  definitions are restructured to 3 layers: core inline (I/O contracts + 1-line binding
+  rules) + shared protocol modules read on demand + `{{#flag}}` install-time slots
+  resolved per-consumer from EXISTING `baldart.config.yml` keys (a consumer ships ONE
+  `stack.database` variant, not four). A slot-bearing agent is GENERATED per-consumer
+  (`.baldart/generated/agents/` + symlink, marker gains trailing `config_sha`,
+  byte-stable rewrites); slotless agents stay plain symlinks; H2 headings stay stable
+  (no-op body when a flag is off) so existing overlays keep matching. First
+  `baldart update` after 5.0 flips the affected agents symlink→generated in one
+  auto-committed reconcile (allowlist already covers it). Machinery:
+  `src/utils/agent-slots.js` (new) + `symlinks.js` slot detection (fill → overlay-merge
+  → marker → transpile) + doctor `generatedAgentsStale` probe / `regenerate-agents`
+  action + `configure` re-merge after config writes. NO new config key (schema-change
+  propagation rule: N/A). Codex parity: adapter-generated — the TOML transpile consumes
+  the config-effective markdown, so Codex agents get the same resolved variant.
+- **7 core agents restructured** (`coder`, `code-reviewer`, `doc-reviewer`,
+  `plan-auditor`, `qa-sentinel`, `codebase-architect`, `ui-expert`) — source cuts
+  30–49% with ZERO normative loss (two independent adversarial verification passes:
+  no LOST, no WEAKENED rules). All carry `version:` frontmatter (own SemVer line,
+  history in the new `framework/.claude/agents/CHANGELOG.md` — NOT installed, excluded
+  from every agent enumerator incl. the discovery hooks) and ≤2-line descriptions (the
+  old multi-example descriptions were paid by the orchestrator every session). Codex
+  parity: adapter-generated (transpiler unchanged, consumes the effective markdown).
+- **3 new protocol modules** (`agents/agent-operating-protocol.md`,
+  `agents/review-protocol.md`, `agents/doc-audit-protocol.md`) — the deduplicated SSOT
+  of the shared operating blocks (injection guard / retrieval / memory / tool budget),
+  the reviewer verification engine (Challenge+Actionability / Simulation diff+plan /
+  CoVe / absolute risk scoring / specialist-spawn discipline incl. the new
+  `specialist_dispatch` orchestrated-mode suppression), and doc-reviewer's audit-mode
+  procedures (read ONLY without card context). `SECTION=` dispatch — agents read only
+  the matching section. Codex parity: portable (markdown modules).
+- **`/new` pipeline wave (skill `new` 2.0.0, `new2` 1.4.0)** — six additive mechanisms,
+  each with pre-5.0 graceful degradation and `check-new-parity.mjs` tripwire rules
+  (16 total): review bundle (`build-review-bundle.mjs` — deterministic per-card
+  handoff + binding anti-re-read phrase in every reviewer briefing, Hot-File Map
+  honored downstream); doc-invariants PASS-fast (`doc-invariants.mjs` — the invariant
+  table as executable rules; zero blocking rows + no doc signals + non-deep → per-card
+  doc-reviewer spawn skipped, Final F.3 backstop unchanged; measured headroom: 84/127
+  per-card runs returned PASS); cap-and-handoff (soft 80 / hard 100 tool calls,
+  checkpoint + fresh continuation ×2 — attacks the monster-run tail); explicit i18n
+  fill pass (step 7c, `i18n-translator` BY NAME — closes the measured general-purpose
+  leakage); fix-pass model routing A/B (fix-pass coder → `model: sonnet` best-effort,
+  overlay kill-switch `## [OVERRIDE] Fix-pass model`, `model=` in Fix Application Log
+  for recurrence telemetry; initial builds and specialists untouched). Codex parity:
+  scripts portable (.mjs), prose additive; the new2 workflow mirrors are Claude-only
+  with the /new prose as the inline fallback.
+- **`finding-mine` routine (monthly) + `skill-improver` 2.0.0 `MODE: miner`** — the
+  anticipatory loop: 30 days of pooled findings / QA reports / batch trackers /
+  reviewer memories distilled into CLASSIFIED proposals (author-time coder rules,
+  never-demote rows, deterministic-gate candidates, card-schema proposals —
+  proposal-only, upstream candidates consolidated). Routine count 8 → 9. Codex parity:
+  adapter-generated (3 routine backends; agent transpiled).
+- **`scripts/agent-telemetry.mjs` (maintainer tool)** — fleet-level per-family
+  telemetry (calls p50/p90/max, ctx, read-share, verdicts, rework ratio, cap-hit rate,
+  fix-pass models) with `--baseline save|compare`; the pre-5.0 baseline is saved.
+  Dedup by `message.id` keeping the LAST record (the JSONL double-count trap). Codex
+  parity: N/A (maintainer-only, Claude transcripts).
+- **Post-release measurement plan** (2 weeks on a live consumer, vs the saved
+  baseline): coder ctx/run −30%+, Read-share <66%, p100 calls down, doc-reviewer
+  PASS-fast rate ≈ measured headroom, fix-pass recurrence sonnet ≤ opus, reviewer
+  verdict distributions unchanged.
+
+MAJOR — changes the on-disk layout of installed agents (symlink → generated file for
+slot-bearing agents). No new `baldart.config.yml` keys anywhere in the release.
+
 ## [4.99.0] - 2026-07-03
 
 **Consumer-lessons wave: four recurring failure patterns surfaced by mayo's nightly/weekly routine reports (20260628-skill-improve + 20260701-doc-graph-align) upstreamed into the base framework.** The consumer had fixed each locally via overlays, but three of the four root causes live in the base payload — every future consumer would have re-discovered them. The overarching meta-defect (#2) is that the lesson pipeline itself had no upstream channel: overlay fixes died in the consumer.

package/README.md

@@ -328,6 +328,7 @@ drift-detection loops actually run. Ship-bundled routines:
 | `ds-drift` | weekly Mon 03:00 UTC | doc-reviewer | Design-system drift check (optional) |
 | `full-sweep` | weekly Sun 03:00 UTC | doc-reviewer | Full SSOT audit (optional) |
 | `i18n-align` | weekly Mon 04:00 UTC | i18n-translator | Translates target languages, lints, commits direct to trunk (optional, needs `has_i18n`) |
+| `finding-mine` | monthly 1st 03:00 UTC | skill-improver | Deep 30-day mining of pooled findings/QA/trackers/reviewer memories into classified improvement proposals (`MODE: miner`, v5.0.0) |
 
 Three backend adapters are bundled:
 

package/VERSION

@@ -1 +1 @@
-4.99.0
+5.0.1

package/framework/.claude/agents/CHANGELOG.md

@@ -0,0 +1,105 @@
+# Changelog — agent definitions
+
+Per-agent version history (the `version:` frontmatter each agent carries since
+framework v5.0.0). This file is NOT installed into consumers (excluded from the
+per-item agent merge, the doctor probes, and the discovery hooks — like
+`REGISTRY.md` it is framework metadata living beside the agents).
+
+Formato: [Keep a Changelog](https://keepachangelog.com/) · per-agent SemVer.
+
+## [coder v2.0.1] · [doc-reviewer v2.0.1] · [qa-sentinel v2.0.1] — 2026-07-03 (framework v5.0.1)
+
+Adversarial-verification fixes on the 3-layer restructuring (no H2 moved — overlays unaffected):
+
+- **coder**: `vercel-react-best-practices` un-slotted (it applies to ANY React stack, and no
+  config flag can express "React non-Next" — a structural normative loss for those consumers;
+  "skill absent → skip silently"). The NEVER-ad-hoc-browser-scripts rule hoisted OUT of
+  `{{#e2e_playwright}}` as an unconditional line (it was universal pre-5.0; a Playwright
+  consumer with a stale `stack.testing.e2e` silently lost it); the `playwright-skill` link
+  itself stays slotted.
+- **doc-reviewer**: two per-card cited exceptions restored from the audit module —
+  `SECTION=topological-generation` (multi-file doc passes generate leaf→root; was per-card in
+  v4.99.0 but unreachable behind the module's "per-card NEVER" contract) and
+  `SECTION=schema-drift` (changed field SET on a documented payload → `SCHEMA_DRIFT`/
+  `ORPHAN_FIELD`, diff-driven as in v4.99.0). `doc-audit-protocol.md` Contract reworded to
+  name the cited exceptions instead of contradicting the agent core.
+- **qa-sentinel**: review-bundle `gate_logs` demoted to CONTEXT ONLY (`files_changed` stays
+  authoritative for scope) — own-tier gates are always re-executed, never cited from a stale
+  Phase-2 log; restored the v4.99.0 one-liners "never claim a gate ran when it did not" and
+  "never invent your own classification".
+- (pointer-only, no version bump) **prd-card-writer**: "code-reviewer rule 8" re-anchored to
+  the renumbered rule 7 (Post-Intervention Coherence Check), by name.
+
+## [coder v2.0.0] · [code-reviewer v2.0.0] · [doc-reviewer v2.0.0] · [plan-auditor v2.0.0] · [qa-sentinel v2.0.0] · [codebase-architect v2.0.0] · [ui-expert v2.0.0] · [skill-improver v2.0.0] — 2026-07-03 (framework v5.0.0)
+
+**The 3-layer restructuring** (core inline + shared modules + install-time slots).
+The pre-5.0 monoliths are implicitly `1.x`. Every normative rule survives — either
+inline as a 1-line binding rule, in a shared module the core cites
+(`agents/agent-operating-protocol.md`, `agents/review-protocol.md`,
+`agents/doc-audit-protocol.md`), or in a pre-existing SSOT — verified by two
+independent adversarial passes (zero LOST, zero WEAKENED).
+
+Common changes (all 8):
+- `version:` frontmatter added; `description` trimmed to ≤2 lines (inline examples
+  removed — they were paid by the ORCHESTRATOR's context every session).
+- Shared operating blocks (injection guard, doc-retrieval, persistent-memory
+  hygiene, tool budget) deduplicated into `agent-operating-protocol.md`;
+  reviewer verification passes (Challenge/Actionability, Simulation, CoVe, risk
+  scoring, specialist-spawn discipline) into `review-protocol.md`. Cores keep
+  1-line binding versions + `SECTION=` cites.
+- Conditional content became `{{#flag}}` install-time slots resolved from
+  EXISTING `baldart.config.yml` keys (features.*, stack.database → `db_*`,
+  `fw_nextjs`, `deploy_vercel`, `e2e_playwright`). H2 headings stay STABLE with a
+  one-line no-op body when a flag is off (overlay `[OVERRIDE]/[APPEND]` targets
+  keep matching).
+- I/O contracts stayed VERBATIM inline: completion report, verdict lines, pooled
+  findings YAML, TARGET TAG table, QA report format, 10-section FULL output,
+  Return Contracts, QUICK mode.
+
+Per-agent highlights:
+- **coder**: 4 DB variants → one `{{#db_*}}` slot; Reference-Aliasing lore → 1-line
+  + `coding-standards.md` cite; NEW `## Tool-Call Budget & Checkpoint` (cap-and-
+  handoff, `[CAP-HANDOFF]` marker); completion report ALSO persisted to
+  `/tmp/completion-<CARD-ID>.md`; deterministic DTCG token lookup (never grep the
+  CSS); Linked Skills conditional on stack.
+- **code-reviewer**: DS compliance compressed under `{{#has_design_system}}`
+  (protocol module is the SSOT); NEW review-bundle-first scope rule; NEW
+  `specialist_dispatch` orchestrated-mode suppression (records
+  `dispatch_deferred:<agent>`).
+- **doc-reviewer**: split by mode — per-card core stays; audit-mode procedures
+  (drift validators, DocAgent topological, epistemic metadata, SCIP, schema/
+  registry drift, coverage gauges) moved to `doc-audit-protocol.md`, read ONLY
+  without card context; NEW deterministic-first invariant check (consumes
+  `/tmp/docinv-<CARD-ID>.json` when present).
+- **plan-auditor**: 4-example description → 2 lines; persistence checks →
+  `{{#db_*}}`; QUICK mode, checklist A–H, ADR delta, high-risk triggers, TARGET
+  TAG table, YAML schema, 10-section output all inline; NEW dispatch suppression.
+- **qa-sentinel**: 3-example description → 2 lines; i18n gate / ds-gate /
+  toolchain resolution under their flags; review-bundle `files_changed`+`gate_logs`
+  as authoritative inputs.
+- **codebase-architect**: 4-example description → 2 lines; LSP/graph escalations
+  under `{{#has_lsp_layer}}`/`{{#has_code_graph}}`; investigation engine, terse
+  contract (incl. Hot-File Map) and architect-specific memory hygiene (TTL,
+  archived/, cleanup) kept verbatim-compressed.
+- **ui-expert**: i18n under `{{#has_i18n}}`; Design Reference (code-first) and
+  build-with-eyes kept intact; expertise/delegations/red-flags compressed with no
+  category dropped; deterministic token lookup.
+- **skill-improver**: NEW `## MODE: miner` (monthly deep pass → classified
+  proposals; consumed by the `finding-mine` routine) + COMPACT return contract.
+
+**Heading map (old → new) for consumer overlays** — overlay sections targeting a
+heading that moved/merged are appended as trailing sections with a warning (never
+lost); re-point them to:
+
+| Old H2 (pre-5.0) | Now |
+|---|---|
+| `## Prompt Injection Guard` (code-reviewer, plan-auditor) | `## Operating Protocol` (1-line) + module `SECTION=injection-guard` |
+| `## Memory Retrieval Step` / `## MEMORY RETRIEVAL STEP` | `## Operating Protocol` + module `SECTION=memory` |
+| `## Retrieval Protocol Consumption` (all) | `## Operating Protocol` / `## Retrieval Protocol` + module `SECTION=retrieval` |
+| `## Search discipline` (all) | `## Operating Protocol` (cite `code-search-protocol.md`) |
+| `## Challenge Pass` / `## Diff Simulation Pass` / `## Chain-of-Verification Pass` / `## Quantified Risk Scoring` | `## Verification Passes` + `review-protocol.md` sections |
+| `## Specialist Auto-Spawn` | same name; suppression clause added (matrix unchanged) |
+| `## Reference-Aliasing Mutation Hazards` (coder) | 1-line in `## Code Standards & Author-Time Simplicity Discipline` + `coding-standards.md` |
+| `## Database Index Invariant` variants (coder) / `### Persistence-Specific` (plan-auditor) | same heading, body is now the single `{{#db_*}}` variant |
+| doc-reviewer `## Audit Process`, `## Drift Validator Suite`, `## Dependency-Aware Generation Protocol`, `## Epistemic Metadata Protocol`, `## SCIP Code Reference Protocol`, `## Schema Field-Level Drift Detection`, `## Canonical API registries`, `## Endpoint Count Reconciliation`, `## Coverage Gauges` | `agents/doc-audit-protocol.md` (agent keeps `## Audit Mode` dispatch) |
+| `# Persistent Agent Memory` boilerplate tails | compressed under `# Persistent Agent Memory` + module `SECTION=memory` |

package/framework/.claude/agents/REGISTRY.md

@@ -6,7 +6,9 @@ Quick-reference for all custom agents. Use this to route tasks to the right spec
 
 > **Codex-native (since v4.80.0)**: every agent here is portable to Codex. The same `<name>.md` is **transpiled** to `.codex/agents/<name>.toml` on install/update (`name`/`description` → same, body → `developer_instructions`, `effort` → `model_reasoning_effort`, `model` omitted). Authoring stays single-source: drop a `.md`, it auto-installs for both tools. Keep `name`+`description` frontmatter, put behaviour in the body, and don't rely on an agent spawning a further agent (Codex `agents.max_depth: 1`). Design: [`framework/docs/CODEX-AGENTS.md`](../../docs/CODEX-AGENTS.md).
 
-> **Machine-readable source of truth (since v3.20.0)**: the filesystem directory `framework/.claude/agents/` is authoritative for the list of BALDART agents. The `agent-discovery-gate.js` PreToolUse hook, the `agent-discovery-info.sh` SessionStart hook, and `baldart doctor` enumerate the directory directly (every `<name>.md` except this file is an agent — no manifest JSON is shipped). Adding a new agent means dropping `<name>.md` here; no other touchpoint.
+> **Machine-readable source of truth (since v3.20.0)**: the filesystem directory `framework/.claude/agents/` is authoritative for the list of BALDART agents. The `agent-discovery-gate.js` PreToolUse hook, the `agent-discovery-info.sh` SessionStart hook, and `baldart doctor` enumerate the directory directly (every `<name>.md` except this file and `CHANGELOG.md` is an agent — no manifest JSON is shipped). Adding a new agent means dropping `<name>.md` here; no other touchpoint.
+
+> **3-layer structure + versioning + slots (since v5.0.0)**: the core agents follow a 3-layer authoring contract. (1) **Core inline** — role boundary, gating, I/O contracts (verdict lines, pooled findings YAML, completion reports) and every always-applicable rule as a 1-line BINDING statement. (2) **Modules on demand** — shared procedures live in `agents/agent-operating-protocol.md` (injection guard / retrieval / memory / tool budget) and `agents/review-protocol.md` (Challenge / Simulation / CoVe / risk scoring / specialist-spawn discipline), cited as `SECTION=<name>`; **reading the cited section when the procedure applies is normative**, and degrade is safe (the 1-line rule still binds; contracts never live in modules). (3) **Install-time slots** — `{{#flag}}` conditionals resolved per-consumer from existing `baldart.config.yml` keys (see `src/utils/agent-slots.js`); a slot-bearing agent installs as a GENERATED file (marker + `config_sha`), H2 headings stay stable with a no-op body when the flag is off (overlays keep matching). Every agent carries a `version:` frontmatter (its own SemVer line); bump it + add an entry to `framework/.claude/agents/CHANGELOG.md` (NOT installed) in the same edit. Keep frontmatter `description` ≤2 lines — it is paid by the orchestrator's context every session.
 
 > **Return contract (since v4.59.0)**: every orchestrator-facing subagent bounds its **final message** so a long body doesn't flood the spawning context — COMPACT return (headline/verdict + `path:line` findings + disk pointer), long form persisted to disk. Agents already structured this way are the exemplars (`qa-sentinel` Return Protocol, `visual-fidelity-verifier` JSON, the verdict+pooled-YAML reviewers — `code-reviewer` / `security-reviewer` / `api-perf-cost-auditor`); free-form analysts carry an explicit `## Return Contract` block (`codebase-architect`, `doc-reviewer`, `plan-auditor`, `senior-researcher`). When adding a new analysis/audit/research agent, paste the block from `framework/templates/agent-return-contract.snippet.md`. Protocol: `framework/agents/return-contract-protocol.md`.