baldart 4.53.6 → 4.53.7

package/CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to BALDART will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [4.53.7] - 2026-06-19
+
+**`setup-worktree.sh` no longer turns an empty `toolchain.commands.build` into a spurious `baseline: fail`.** Observed on a real `/new FEAT-0037` run in a consumer (`mayo`) whose `baldart.config.yml` declares `build: ''` (single-quoted empty scalar — the project's build is not a separate toolchain gate; per `toolchain-protocol.md` an empty command must fall back to the default `npm run build`). The deterministic SSOT worktree script (v4.53.0) read that value with a sed that stripped only DOUBLE quotes (`\"?([^\"#]*)\"?`), so `build: ''` came through as the **literal 2-char string `''`** — non-empty — so the `[ -n "$TC_BUILD" ]` fallback never fired and the script ran `bash -c "''"`, an empty *quoted* command → `bash: : command not found` (exit 127) → `baseline: fail`. tsc + biome had actually passed and the worktree was green on disk; the failure was entirely the unresolved empty scalar. Fix: (1) `_tc()` now resolves a YAML scalar to its true value — `build:`, `build: ''`, `build: ""`, `build: ~`, `build: null` all collapse to empty so the default fallback fires (strips one layer of matching single OR double quotes + YAML null markers + inline `# comment`); (2) the script now tracks build provenance and implements the protocol's **SKIP tier** — the *fallback* `npm run build` on a project with no `build` npm script is a no-build library → SKIP (baseline stays pass), never a spurious fail, while a *configured* (non-empty) build command is always run as a real gate. Verified by executing the resolver against every empty-scalar form + real values, the fallback/SKIP decision on a has-build vs no-build `package.json`, and reproducing the exact `bash: : command not found` exit-127 from the old sed. The prose inline fallbacks (`setup.md`, `worktree-manager/SKILL.md`, `new2.js`) are model-driven and never had the sed bug — no parallel fix needed. **PATCH** (deterministic-script bugfix; correctly-configured consumers see no behaviour change; no new agent/skill/command/config key, no install change).
+
+### Fixed
+
+- **`framework/.claude/skills/worktree-manager/scripts/setup-worktree.sh`** — `_tc()` rewritten to dequote single/double quotes + treat `~`/`null` as empty (was stripping double quotes only, so `build: ''` resolved to the literal `''` and skipped the fallback → `bash -c "''"` → `bash: : command not found` → spurious `baseline: fail`). Build resolution now records `BUILD_FROM_CONFIG` and the baseline build step adds the toolchain-protocol SKIP tier: the fallback `npm run build` on a no-`build`-script project is SKIPPED (baseline pass), not failed; a configured command is always a real gate.
+
 ## [4.53.6] - 2026-06-18
 
 **`/new` now caps concurrency at 3 agents per wave — the API rate-limit guardrail, end to end.** Follow-up to the v4.53.5 root-cause finding (parallel coders killed by org-level rate-limiting): the org rate limit is SHARED across every terminal/session on the account, so a wide fan-out saturates the shared pool and the server throttles, killing agents mid-work and forcing full re-spawns (paying twice). Fix puts a hard ceiling of **3 concurrent agents** at every fan-out point in a `/new` epic: (1) `prd-card-writer` caps each `execution_strategy.groups[]` at ≤3 cards — a wider topological layer is split into sequential sub-groups of ≤3 (always safe: same-layer cards are independent by construction, so serializing them is correctness-neutral; the per-card `parallel_group` keeps its true logical layer, only the execution schedule is capped), so the **plan/cards reflect the rule**; (2) team-mode runtime never spawns more than 3 coders per wave and sub-batches a wider group sequentially (protects legacy epics + manual runs — the **guarantee**); (3) the per-wave and final review workflows cap their finder/verify fan-out at 3 via a rolling worker pool (not chunked barriers — those would block fast finders behind the slow background Codex poll). The cap is **3** (the user's choice — prefer never clogging over re-paying), a fixed operational guardrail like the existing retry caps (NOT a `baldart.config.yml` key). Honest limits: BALDART cannot see agents in OTHER terminals — the cap bounds one run; total cross-terminal parallelism is still the user's to manage. `new2` inherits the prd-card-writer group cap (same cards) and the final-review cap (shared workflow); its own per-card scheduling is not separately capped here (follow-up if it sees use). **PATCH** (operational guardrail on existing orchestration; no new agent/skill/command/config key, no install change).

package/VERSION

@@ -1 +1 @@
-4.53.6
+4.53.7

package/framework/.claude/skills/worktree-manager/scripts/setup-worktree.sh

@@ -193,16 +193,36 @@ ENV_FILES=("${_clean[@]:-}")
 [ -n "$BACKLOG_DIR" ] || { BACKLOG_DIR="$(config_scalar paths backlog_dir)"; [ -n "$BACKLOG_DIR" ] || BACKLOG_DIR="backlog"; }
 [ -n "$INSTALL_CMD" ] || INSTALL_CMD="npm install"
 # toolchain.commands.* only when features.has_toolchain: true; else the defaults.
+# Resolves a YAML scalar to its TRUE value: an empty scalar written any of the
+# legal ways — `build:`, `build: ''`, `build: ""`, `build: ~`, `build: null` —
+# MUST collapse to the empty string so the caller falls back to the default.
+# (The old single-line sed stripped only DOUBLE quotes, so `build: ''` came
+# through as the literal 2-char string `''` → non-empty → no fallback →
+# `bash -c "''"` → `bash: : command not found` → spurious `baseline: fail`.)
 _tc() {
-  local cfg="$MAIN/baldart.config.yml"
+  local cfg="$MAIN/baldart.config.yml" raw
   grep -E '^[[:space:]]*has_toolchain:[[:space:]]*true' "$cfg" >/dev/null 2>&1 || return 0
-  grep -A20 '^toolchain:' "$cfg" 2>/dev/null | grep -A15 '^[[:space:]]*commands:' \
+  raw="$(grep -A20 '^toolchain:' "$cfg" 2>/dev/null | grep -A15 '^[[:space:]]*commands:' \
     | grep -E "^[[:space:]]+$1:" | head -1 \
-    | sed -E "s/.*$1:[[:space:]]*\"?([^\"#]*)\"?.*/\1/" | sed -E 's/[[:space:]]+$//'
+    | sed -E "s/^[[:space:]]*$1:[[:space:]]*//" \
+    | sed -E 's/[[:space:]]+#.*$//; s/[[:space:]]+$//')"   # drop YAML inline comment (space + #) + trailing ws
+  # strip ONE layer of matching surrounding quotes (single or double) → '' / "" become empty
+  case "$raw" in
+    \"*\") raw="${raw#\"}"; raw="${raw%\"}" ;;
+    \'*\') raw="${raw#\'}"; raw="${raw%\'}" ;;
+  esac
+  # explicit YAML null markers → empty
+  case "$raw" in '~'|null|Null|NULL) raw="" ;; esac
+  printf '%s' "$raw"
 }
 [ -n "$TC_TC" ]    || TC_TC="$(_tc typecheck)";   [ -n "$TC_TC" ]    || TC_TC="npx tsc --noEmit"
 [ -n "$TC_LINT" ]  || TC_LINT="$(_tc lint)";      [ -n "$TC_LINT" ]  || TC_LINT="npx eslint --max-warnings=0 src/"
-[ -n "$TC_BUILD" ] || TC_BUILD="$(_tc build)";    [ -n "$TC_BUILD" ] || TC_BUILD="npm run build"
+# Build provenance matters for the SKIP tier (toolchain-protocol.md): a CONFIGURED
+# build that fails is a real gate failure; the FALLBACK default `npm run build` on
+# a project with no `build` script is a no-build library → SKIP, never fail.
+BUILD_FROM_CONFIG=1
+[ -n "$TC_BUILD" ] || TC_BUILD="$(_tc build)"
+[ -n "$TC_BUILD" ] || { TC_BUILD="npm run build"; BUILD_FROM_CONFIG=0; }
 
 # --- log sink --------------------------------------------------------------
 [ -n "$LOG" ] || LOG="/tmp/wt-setup-${SLUG}.log"
@@ -427,23 +447,35 @@ TIMEOUT_BIN=""
 command -v timeout >/dev/null 2>&1 && TIMEOUT_BIN="timeout"
 [ -z "$TIMEOUT_BIN" ] && command -v gtimeout >/dev/null 2>&1 && TIMEOUT_BIN="gtimeout"
 
-err "… baseline build ($TC_BUILD, timeout ${BUILD_TIMEOUT}s)"
-if [ -n "$TIMEOUT_BIN" ]; then
-  CI=1 "$TIMEOUT_BIN" "$BUILD_TIMEOUT" bash -c "$TC_BUILD" </dev/null >>"$LOG" 2>&1
-  BUILD_RC=$?
-else
-  err "WARN: no 'timeout'/'gtimeout' binary — running build WITHOUT a hard timeout."
-  CI=1 bash -c "$TC_BUILD" </dev/null >>"$LOG" 2>&1
-  BUILD_RC=$?
+# SKIP tier (toolchain-protocol.md): the FALLBACK default `npm run build` is only
+# a real gate when the project actually defines a `build` script. A library with
+# none → no-build project → SKIP (baseline stays pass), never a spurious fail. A
+# CONFIGURED build command is always run as-is (its failure IS a real failure).
+RUN_BUILD=1
+if [ "$BUILD_FROM_CONFIG" = 0 ] && [ -f package.json ]; then
+  node -e 'const s=(require("./package.json").scripts)||{};process.exit(s.build?0:1)' 2>/dev/null \
+    || { RUN_BUILD=0; err "… baseline build SKIPPED (no toolchain build command + no 'build' npm script → no-build project, per toolchain-protocol tier 3)"; }
 fi
 
-if [ "$BUILD_RC" -eq 124 ] && [ -n "$TIMEOUT_BIN" ]; then
-  M_BASELINE="timeout"; M_BLOG="$LOG"
-  # leave buildVerified:false in the registry (already provisional)
-  fail "baseline build TIMED OUT after ${BUILD_TIMEOUT}s — partial log at $LOG" 7
-elif [ "$BUILD_RC" -ne 0 ]; then
-  M_BASELINE="fail"; M_BLOG="$LOG"
-  fail "baseline build FAILED (do NOT fix here — the coder repairs it) — see $LOG" 7
+if [ "$RUN_BUILD" = 1 ]; then
+  err "… baseline build ($TC_BUILD, timeout ${BUILD_TIMEOUT}s)"
+  if [ -n "$TIMEOUT_BIN" ]; then
+    CI=1 "$TIMEOUT_BIN" "$BUILD_TIMEOUT" bash -c "$TC_BUILD" </dev/null >>"$LOG" 2>&1
+    BUILD_RC=$?
+  else
+    err "WARN: no 'timeout'/'gtimeout' binary — running build WITHOUT a hard timeout."
+    CI=1 bash -c "$TC_BUILD" </dev/null >>"$LOG" 2>&1
+    BUILD_RC=$?
+  fi
+
+  if [ "$BUILD_RC" -eq 124 ] && [ -n "$TIMEOUT_BIN" ]; then
+    M_BASELINE="timeout"; M_BLOG="$LOG"
+    # leave buildVerified:false in the registry (already provisional)
+    fail "baseline build TIMED OUT after ${BUILD_TIMEOUT}s — partial log at $LOG" 7
+  elif [ "$BUILD_RC" -ne 0 ]; then
+    M_BASELINE="fail"; M_BLOG="$LOG"
+    fail "baseline build FAILED (do NOT fix here — the coder repairs it) — see $LOG" 7
+  fi
 fi
 
 # 10. Build passed → flip buildVerified:true in the registry and finish clean.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "baldart",
-  "version": "4.53.6",
+  "version": "4.53.7",
   "description": "Claude Agent Framework - Reusable framework for coordinating AI agents and humans in software projects",
   "bin": {
     "baldart": "./bin/baldart.js"