baldart 3.32.0 → 3.33.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +34 -0
- package/VERSION +1 -1
- package/bin/baldart.js +1 -0
- package/framework/.claude/skills/baldart-update/SKILL.md +10 -2
- package/package.json +1 -1
- package/src/commands/add.js +66 -24
- package/src/commands/update.js +27 -6
- package/src/utils/__tests__/classify-divergence.test.js +82 -0
- package/src/utils/git.js +45 -1
- package/src/utils/hooks.js +33 -0
- package/src/utils/overlay-merger.js +41 -0
- package/src/utils/symlinks.js +10 -1
package/CHANGELOG.md
CHANGED
|
@@ -5,6 +5,40 @@ All notable changes to BALDART will be documented in this file.
|
|
|
5
5
|
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
|
|
6
6
|
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
7
7
|
|
|
8
|
+
## [3.33.0] - 2026-05-30
|
|
9
|
+
|
|
10
|
+
Closes a **structural silent-partial-install** failure mode (observed on the `mayo` consumer, 3.28→3.31, still live in 3.32.0; same class as the historic v3.27.1 bug): `add` was **non-atomic** — the hook registration ran *after* optional blocking prompts (git aliases, configure). In a non-TTY context (Claude's Bash tool never has a TTY on stdin) or on any interruption, those `inquirer` prompts throw/hang, so `.framework/` + `state.json` landed on the new version while `Hooks.registerAll` never ran — a half-install that `baldart status` still reported as "Valid". The fix makes install atomic (correctness-critical mutations run **before** every optional prompt), adds a **post-flight hook assert** that refuses to declare success with any active hook missing, and finally exposes `add --yes` so agents/CI can install unattended. Two additive, non-breaking follow-ups ship alongside. **No new `baldart.config.yml` keys** — `--yes` is a CLI flag, so the schema-propagation rule does not apply.
|
|
11
|
+
|
|
12
|
+
### Fixed — `add` is now atomic + never declares a half-install successful
|
|
13
|
+
|
|
14
|
+
- **[src/commands/add.js](src/commands/add.js)**: `Hooks.registerAll` is **reordered ahead of** the optional git-aliases and configure prompts. Hook registration determines install correctness and must never sit behind a blocking prompt — if `add` is interrupted at an optional prompt, the hooks are already in place. The drift callback now passes `{ autoYes: nonInteractive }` (parity with `update.js`), so a drifted hook in non-TTY no longer throws.
|
|
15
|
+
- **[src/utils/hooks.js](src/utils/hooks.js)**: new exported `verifyAll(cwd)` — a pure read over `getStatus` returning `{ ok, malformed, missing, path }`. It iterates only the **active** `HOOK_REGISTRY` (commented-out entries like `capture-detect` excluded for free). A malformed `settings.json` counts as a failure (registration was skipped).
|
|
16
|
+
- **[src/commands/add.js](src/commands/add.js)**: **post-flight assert** before the success summary — re-reads `settings.json`, attempts a single best-effort re-registration if anything is missing, then exits non-zero ("Install is NOT complete") if a hook is still absent. Covers `update --reset` too, since that path delegates to `add(undefined, { yes: true })`.
|
|
17
|
+
|
|
18
|
+
### Added — `add --yes` (non-interactive install for CI / agents)
|
|
19
|
+
|
|
20
|
+
- **[bin/baldart.js](bin/baldart.js)**: registers `-y, --yes` on the `add` subcommand (the underlying `add(repo, options)` already honored `options.yes`, it was just unreachable from the CLI). With `--yes`, `add` auto-confirms optional prompts and passes `{ nonInteractive: true }` to `configure` so its wizard writes autodetected values without blocking.
|
|
21
|
+
- **[src/commands/add.js](src/commands/add.js)**: `add --yes` on a repo that **already has** `.framework/` now fails fast with a clear pointer to `npx baldart update --reset --yes --i-know` instead of hitting the deliberately-interactive destructive "Remove and reinstall?" prompt (which would throw under non-TTY and surface as a generic failure). Clean installs only; reinstall goes through `--reset`.
|
|
22
|
+
|
|
23
|
+
### Added — divergence classifier flags overlay-covered edits (`--reset` is safe)
|
|
24
|
+
|
|
25
|
+
- **[src/utils/git.js](src/utils/git.js)**: `classifyDivergence` now tags each `custom-overlay-able` commit with `overlayCovered` — true when **every** framework file it touches already has a matching overlay in `.baldart/overlays/`. New pure static `overlayRelForFrameworkFile(path)` mirrors the `overlay.js` path conventions (unit-tested).
|
|
26
|
+
- **[src/commands/update.js](src/commands/update.js)**: in the overlay-able divergence branch, when all commits are `overlayCovered` the UI/JSON now recommend `--reset --yes --i-know` as the **safe** resolution (intent already preserved in the overlays) and note that `scaffold-overlays` would create redundant skeletons. New `overlay_already_covered` field in the `--json` output.
|
|
27
|
+
|
|
28
|
+
### Added — deterministic `overlay drift` via base-sha backfill
|
|
29
|
+
|
|
30
|
+
- **[src/utils/overlay-merger.js](src/utils/overlay-merger.js)**: new `ensureBaseFileShaInOverlay(overlayPath, baseSha)` — **additive-only, idempotent, fail-safe**: stamps `base_file_sha` into an overlay's frontmatter when absent (never overwrites, never fabricates frontmatter). Called from the merger in **[src/utils/symlinks.js](src/utils/symlinks.js)** `_generateOverlayedFile` at `add`/`update` time, so `baldart overlay drift` becomes deterministic for **every** overlay — not just freshly-scaffolded ones (hand-written / pre-v3.19.0 overlays were "unknown" to drift).
|
|
31
|
+
|
|
32
|
+
### Tests
|
|
33
|
+
|
|
34
|
+
- **[scripts/test-add-postflight.sh](scripts/test-add-postflight.sh)**: new — encodes the post-flight **invariant** (a `settings.json` missing an active hook → `verifyAll().ok === false`; the dropped hook in the test is literally `baldart-overlay-telemetry`, the mayo failure). Fails on pre-v3.33.0 code (no `verifyAll`).
|
|
35
|
+
- **[scripts/test-overlay-backfill.sh](scripts/test-overlay-backfill.sh)**: new — backfill is additive, idempotent, never overwrites an existing sha, never fabricates frontmatter, fail-safe.
|
|
36
|
+
- **[src/utils/__tests__/classify-divergence.test.js](src/utils/__tests__/classify-divergence.test.js)**: extended with overlay-path-mapping fixtures (38 assertions, all green).
|
|
37
|
+
|
|
38
|
+
### Changed — `/baldart-update` skill
|
|
39
|
+
|
|
40
|
+
- **[framework/.claude/skills/baldart-update/SKILL.md](framework/.claude/skills/baldart-update/SKILL.md)**: post-flight report (step 4) documents the new CLI hook assert in `add`/`--reset`; `last_verified` v3.32.0 → v3.33.0 (`hook_registry_entries`/`update_js_prompts` unchanged).
|
|
41
|
+
|
|
8
42
|
## [3.32.0] - 2026-05-30
|
|
9
43
|
|
|
10
44
|
Makes the CLI **agent-native at the output layer**: `npx baldart version --json` and `npx baldart update --json --yes` now emit a single **machine-readable JSON object** on stdout (schemas `baldart.version/1` / `baldart.update/1`), with every human line routed to stderr. This closes the last fragile seam in the autonomous-update path — the `/baldart-update` skill previously had to **regex-scrape human-readable prose** (the v3.26.0 wording change had already forced a dual-format tolerant parser in Step 0). An agent now reads a field instead of matching a sentence. Borrowed from the [CLI-Anything](https://github.com/HKUDS/CLI-Anything) philosophy (`--json` on every command) — but BALDART is already a headless CLI, so this is a thin, hand-rolled output layer, not a generated wrapper. **No new `baldart.config.yml` keys** — `--json` is a CLI flag, not a config key, so the schema-propagation rule does not apply.
|
package/VERSION
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
3.
|
|
1
|
+
3.33.0
|
package/bin/baldart.js
CHANGED
|
@@ -65,6 +65,7 @@ program
|
|
|
65
65
|
.command('add [repo]')
|
|
66
66
|
.description('Install the framework in your project')
|
|
67
67
|
.option('-b, --branch <branch>', 'Branch to use', 'main')
|
|
68
|
+
.option('-y, --yes', 'Non-interactive install (CI / agents): auto-confirm all optional prompts and skip the interactive configure wizard. Refuses to reinstall over an existing .framework/ — use `update --reset` for that.')
|
|
68
69
|
.action(async (repo, options) => {
|
|
69
70
|
const addCommand = require('../src/commands/add');
|
|
70
71
|
await addCommand(repo || 'antbald/BALDART', options);
|
|
@@ -15,7 +15,7 @@ this skill needs an update is left to a human reviewer.
|
|
|
15
15
|
update_js_prompts: 6
|
|
16
16
|
hook_registry_entries: 4
|
|
17
17
|
config_template_top_level_keys: features,git,identity,lsp,paths,stack,tools,version
|
|
18
|
-
last_verified: v3.
|
|
18
|
+
last_verified: v3.33.0
|
|
19
19
|
-->
|
|
20
20
|
|
|
21
21
|
<!--
|
|
@@ -498,7 +498,15 @@ Report to the user, in order:
|
|
|
498
498
|
3. **CLI self-upgrade**: if stdout mentions "Auto-relaunching via npx
|
|
499
499
|
baldart@…", surface it once so the user knows the CLI bumped too.
|
|
500
500
|
4. **Hooks reconciled**: any hook backfilled (parse "Auto-registered N
|
|
501
|
-
missing hook(s)" or per-line "Registered hook" from stdout).
|
|
501
|
+
missing hook(s)" or per-line "Registered hook" from stdout). Since v3.33.0
|
|
502
|
+
the CLI also runs a **post-flight hook assert** at the end of `add` (and
|
|
503
|
+
therefore of `update --reset`, which delegates to `add`): it re-reads
|
|
504
|
+
`.claude/settings.json` and refuses to declare success — exiting non-zero
|
|
505
|
+
with "Install is NOT complete" — if any active `HOOK_REGISTRY` entry is
|
|
506
|
+
missing. So a clean `--reset` can no longer leave a half-install that
|
|
507
|
+
reports "Valid" (the mayo 3.28→3.31 / v3.27.1 failure class). If you see
|
|
508
|
+
that error, the repo is in an inconsistent state: run `npx baldart doctor`
|
|
509
|
+
to repair, do NOT report success.
|
|
502
510
|
5. **Agent layout migration (v3.27.0+)**: parse stdout for lines matching
|
|
503
511
|
`agent generated (overlay applied): .claude/agents/<name>.md → ../../.baldart/generated/agents/<name>.md`.
|
|
504
512
|
Pre-v3.27.0 overlay-merged agents (`coder`, `ui-expert`, `code-reviewer`,
|
package/package.json
CHANGED
package/src/commands/add.js
CHANGED
|
@@ -44,6 +44,15 @@ async function add(repo, options) {
|
|
|
44
44
|
const exists = await git.frameworkExists();
|
|
45
45
|
if (exists) {
|
|
46
46
|
UI.warning('Framework already installed!');
|
|
47
|
+
// A non-interactive `add --yes` must never block on (or auto-confirm) the
|
|
48
|
+
// destructive "Remove and reinstall?" prompt. Reinstalling is an explicit
|
|
49
|
+
// user decision routed through `update --reset` (which rm -rf's
|
|
50
|
+
// `.framework/` itself, so this branch is never reached on that path).
|
|
51
|
+
// Fail fast with a clear pointer instead of a generic catch below.
|
|
52
|
+
if (nonInteractive) {
|
|
53
|
+
UI.error('.framework/ already present — a non-interactive reinstall must go through `npx baldart update --reset --yes --i-know`.');
|
|
54
|
+
process.exit(1);
|
|
55
|
+
}
|
|
47
56
|
const shouldReinstall = await UI.confirm(
|
|
48
57
|
'Remove and reinstall? (You will lose customizations)',
|
|
49
58
|
false
|
|
@@ -163,6 +172,35 @@ async function add(repo, options) {
|
|
|
163
172
|
UI.newline();
|
|
164
173
|
symlinks.copyCustomizableFiles();
|
|
165
174
|
|
|
175
|
+
// BALDART hooks (multi-hook registry since v3.18.0)
|
|
176
|
+
// Auto-register every hook in src/utils/hooks.js HOOK_REGISTRY into
|
|
177
|
+
// .claude/settings.json. Drift on an existing entry triggers an
|
|
178
|
+
// interactive prompt (Keep / Replace / Show diff), or 'keep' in --yes mode.
|
|
179
|
+
//
|
|
180
|
+
// This runs BEFORE the optional prompts below (git aliases, configure) —
|
|
181
|
+
// hook registration determines the correctness of the install and must
|
|
182
|
+
// never sit behind a blocking prompt. If `add` is interrupted at an
|
|
183
|
+
// optional prompt (non-TTY, Ctrl-C), the hooks are already in place.
|
|
184
|
+
// (Reordered in v3.33.0 to close the silent partial-install gap.)
|
|
185
|
+
try {
|
|
186
|
+
const res = await Hooks.registerAll(process.cwd(), {
|
|
187
|
+
onDrift: Hooks.createDriftPrompt(UI, { autoYes: nonInteractive }),
|
|
188
|
+
});
|
|
189
|
+
if (res.malformed) {
|
|
190
|
+
UI.warning('.claude/settings.json is malformed; skipped hook registration. Run `npx baldart doctor` after fixing it.');
|
|
191
|
+
} else {
|
|
192
|
+
for (const r of res.results) {
|
|
193
|
+
if (r.status === 'created') UI.success(`Registered hook \`${r.id}\` in .claude/settings.json`);
|
|
194
|
+
else if (r.status === 'legacy-migrated') UI.success(`Migrated legacy hook to \`${r.id}\` (previous: ${r.previousCommand})`);
|
|
195
|
+
else if (r.status === 'drift-replaced') UI.success(`Replaced drifted hook \`${r.id}\` (was: ${r.previousCommand})`);
|
|
196
|
+
else if (r.status === 'drift-kept') UI.info(`Kept user-customized hook \`${r.id}\` as-is.`);
|
|
197
|
+
else if (r.status === 'already') UI.info(`Hook \`${r.id}\` already registered.`);
|
|
198
|
+
}
|
|
199
|
+
}
|
|
200
|
+
} catch (err) {
|
|
201
|
+
UI.warning(`Hook registration skipped: ${err.message}`);
|
|
202
|
+
}
|
|
203
|
+
|
|
166
204
|
// Configure Git aliases
|
|
167
205
|
UI.section('Configuring Git Aliases');
|
|
168
206
|
|
|
@@ -201,29 +239,6 @@ async function add(repo, options) {
|
|
|
201
239
|
}
|
|
202
240
|
}
|
|
203
241
|
|
|
204
|
-
// BALDART hooks (multi-hook registry since v3.18.0)
|
|
205
|
-
// Auto-register every hook in src/utils/hooks.js HOOK_REGISTRY into
|
|
206
|
-
// .claude/settings.json. Drift on an existing entry triggers an
|
|
207
|
-
// interactive prompt (Keep / Replace / Show diff).
|
|
208
|
-
try {
|
|
209
|
-
const res = await Hooks.registerAll(process.cwd(), {
|
|
210
|
-
onDrift: Hooks.createDriftPrompt(UI),
|
|
211
|
-
});
|
|
212
|
-
if (res.malformed) {
|
|
213
|
-
UI.warning('.claude/settings.json is malformed; skipped hook registration. Run `npx baldart doctor` after fixing it.');
|
|
214
|
-
} else {
|
|
215
|
-
for (const r of res.results) {
|
|
216
|
-
if (r.status === 'created') UI.success(`Registered hook \`${r.id}\` in .claude/settings.json`);
|
|
217
|
-
else if (r.status === 'legacy-migrated') UI.success(`Migrated legacy hook to \`${r.id}\` (previous: ${r.previousCommand})`);
|
|
218
|
-
else if (r.status === 'drift-replaced') UI.success(`Replaced drifted hook \`${r.id}\` (was: ${r.previousCommand})`);
|
|
219
|
-
else if (r.status === 'drift-kept') UI.info(`Kept user-customized hook \`${r.id}\` as-is.`);
|
|
220
|
-
else if (r.status === 'already') UI.info(`Hook \`${r.id}\` already registered.`);
|
|
221
|
-
}
|
|
222
|
-
}
|
|
223
|
-
} catch (err) {
|
|
224
|
-
UI.warning(`Hook registration skipped: ${err.message}`);
|
|
225
|
-
}
|
|
226
|
-
|
|
227
242
|
// Routines wizard (since v2.1.0)
|
|
228
243
|
try {
|
|
229
244
|
const routinesCmd = require('./routines');
|
|
@@ -245,7 +260,9 @@ async function add(repo, options) {
|
|
|
245
260
|
if (runConfigure) {
|
|
246
261
|
try {
|
|
247
262
|
const configureCmd = require('./configure');
|
|
248
|
-
|
|
263
|
+
// In --yes mode, configure must write autodetected values without
|
|
264
|
+
// prompting — otherwise its inquirer prompts block in non-TTY.
|
|
265
|
+
await configureCmd(nonInteractive ? { nonInteractive: true } : undefined);
|
|
249
266
|
} catch (err) {
|
|
250
267
|
UI.warning(`Configure step failed: ${err.message}`);
|
|
251
268
|
UI.info('Run `npx baldart configure` later to complete setup.');
|
|
@@ -254,6 +271,31 @@ async function add(repo, options) {
|
|
|
254
271
|
UI.info('Skipped. Run `npx baldart configure` before invoking skills.');
|
|
255
272
|
}
|
|
256
273
|
|
|
274
|
+
// Post-flight assert — never declare success with missing hooks.
|
|
275
|
+
// Re-reads .claude/settings.json and confirms every active hook in
|
|
276
|
+
// HOOK_REGISTRY is present. Guards against the silent partial-install
|
|
277
|
+
// class (v3.27.1 / mayo 3.28→3.31). Covers `update --reset` too, since
|
|
278
|
+
// that path delegates to add(undefined, { yes: true }).
|
|
279
|
+
let verify = Hooks.verifyAll(process.cwd());
|
|
280
|
+
if (!verify.ok && !verify.malformed) {
|
|
281
|
+
// A single best-effort re-registration before failing hard.
|
|
282
|
+
try {
|
|
283
|
+
await Hooks.registerAll(process.cwd(), {
|
|
284
|
+
onDrift: Hooks.createDriftPrompt(UI, { autoYes: nonInteractive }),
|
|
285
|
+
});
|
|
286
|
+
} catch (_) { /* fall through to the assert below */ }
|
|
287
|
+
verify = Hooks.verifyAll(process.cwd());
|
|
288
|
+
}
|
|
289
|
+
if (!verify.ok) {
|
|
290
|
+
UI.error(
|
|
291
|
+
verify.malformed
|
|
292
|
+
? '.claude/settings.json is malformed — cannot verify hooks. Install is NOT complete.'
|
|
293
|
+
: `Hooks missing after install: ${verify.missing.join(', ')}. Install is NOT complete.`
|
|
294
|
+
);
|
|
295
|
+
UI.info('Run `npx baldart doctor` to repair, then re-check `npx baldart status`.');
|
|
296
|
+
process.exit(1);
|
|
297
|
+
}
|
|
298
|
+
|
|
257
299
|
// Success summary
|
|
258
300
|
UI.header('✓ INSTALLATION COMPLETE');
|
|
259
301
|
|
package/src/commands/update.js
CHANGED
|
@@ -592,6 +592,19 @@ async function update(options = {}) {
|
|
|
592
592
|
UI.info(` • ${c.sha.slice(0, 7)} — ${c.subject}`);
|
|
593
593
|
}
|
|
594
594
|
|
|
595
|
+
// If every overlay-able commit only touches files that ALREADY have a
|
|
596
|
+
// matching overlay in `.baldart/overlays/`, the divergent edit's intent
|
|
597
|
+
// is already preserved — `--reset` is safe and `scaffold-overlays`
|
|
598
|
+
// would only create redundant skeletons. Surface that so the user/agent
|
|
599
|
+
// picks the cheap, correct resolution. (v3.33.0)
|
|
600
|
+
const allCovered = overlayCommits.length > 0
|
|
601
|
+
&& overlayCommits.every((c) => c.overlayCovered === true);
|
|
602
|
+
if (allCovered) {
|
|
603
|
+
UI.newline();
|
|
604
|
+
UI.success('These edits are already preserved in `.baldart/overlays/` — `--reset` is safe (your overlays are re-applied); scaffolding new overlays would be redundant.');
|
|
605
|
+
UI.info('Fast path: `npx baldart update --reset --yes --i-know`.');
|
|
606
|
+
}
|
|
607
|
+
|
|
595
608
|
// Non-interactive resolution (agents / CI) via --on-divergence.
|
|
596
609
|
if (divStrategy === 'scaffold-overlays') {
|
|
597
610
|
UI.newline();
|
|
@@ -604,7 +617,7 @@ async function update(options = {}) {
|
|
|
604
617
|
'Alternatively, push the edits upstream with `/baldart-push` if they are generic improvements.',
|
|
605
618
|
], 'cyan');
|
|
606
619
|
emitUpdateJson({ ok: false, action: 'divergence-scaffolded',
|
|
607
|
-
divergence_class: status.divergenceClass,
|
|
620
|
+
divergence_class: status.divergenceClass, overlay_already_covered: allCovered,
|
|
608
621
|
installed_before: status.installedVersion, remote_version: status.remoteVersion,
|
|
609
622
|
reason: 'Scaffolded overlay skeleton(s); fill them in, then re-run.',
|
|
610
623
|
next_command: 'npx baldart update --reset --yes --i-know' }, 0);
|
|
@@ -624,15 +637,23 @@ async function update(options = {}) {
|
|
|
624
637
|
UI.error('Custom edits present — refusing to resolve them unattended under --yes.');
|
|
625
638
|
UI.info('Re-run with one of:');
|
|
626
639
|
UI.list([
|
|
627
|
-
|
|
640
|
+
allCovered
|
|
641
|
+
? '--reset --yes --i-know → SAFE here: these edits are already in `.baldart/overlays/` (recommended)'
|
|
642
|
+
: '--on-divergence scaffold-overlays → auto-create overlay skeleton(s), then stop so you can fill them',
|
|
628
643
|
'--on-divergence pull → keep the commits and merge the update (non-destructive)',
|
|
629
|
-
|
|
644
|
+
allCovered
|
|
645
|
+
? '--on-divergence scaffold-overlays → would create redundant skeletons (edits already covered)'
|
|
646
|
+
: '--reset --yes --i-know → discard .framework/ edits and reinstall clean (destructive)',
|
|
630
647
|
], 'cyan');
|
|
631
648
|
emitUpdateJson({ ok: false, action: 'divergence-refused',
|
|
632
|
-
divergence_class: status.divergenceClass,
|
|
649
|
+
divergence_class: status.divergenceClass, overlay_already_covered: allCovered,
|
|
633
650
|
installed_before: status.installedVersion, remote_version: status.remoteVersion,
|
|
634
|
-
reason:
|
|
635
|
-
|
|
651
|
+
reason: allCovered
|
|
652
|
+
? 'Custom edits present but already preserved in .baldart/overlays/ — `--reset --yes --i-know` is the safe resolution.'
|
|
653
|
+
: 'Custom edits present — refusing to resolve them unattended under --yes.',
|
|
654
|
+
next_command: allCovered
|
|
655
|
+
? 'npx baldart update --reset --yes --i-know'
|
|
656
|
+
: 'npx baldart update --json --yes --on-divergence scaffold-overlays' }, 1);
|
|
636
657
|
} else {
|
|
637
658
|
const choice = await UI.select('How would you like to proceed?', [
|
|
638
659
|
{ name: 'Scaffold overlay skeleton(s) now (recommended — then fill them in & re-run)', value: 'overlay' },
|
|
@@ -149,6 +149,45 @@ const PATH_FIXTURES = [
|
|
|
149
149
|
},
|
|
150
150
|
];
|
|
151
151
|
|
|
152
|
+
// overlayRelForFrameworkFile(p) — pure mapping of a touched .framework/ payload
|
|
153
|
+
// file to the consumer overlay path that would preserve a customization of it.
|
|
154
|
+
// Mirrors src/commands/overlay.js conventions (overlayPath). null when no
|
|
155
|
+
// overlay maps to the file. Used by overlayCoversTouched() to flag commits
|
|
156
|
+
// whose intent is already preserved (→ `--reset` safe, scaffold redundant).
|
|
157
|
+
const path = require('path');
|
|
158
|
+
const OVERLAY_REL_FIXTURES = [
|
|
159
|
+
{
|
|
160
|
+
name: 'skill SKILL.md → flat overlay',
|
|
161
|
+
file: '.framework/framework/.claude/skills/ui-design/SKILL.md',
|
|
162
|
+
expected: path.join('.baldart', 'overlays', 'ui-design.md'),
|
|
163
|
+
},
|
|
164
|
+
{
|
|
165
|
+
name: 'skill nested script → same flat overlay',
|
|
166
|
+
file: '.framework/framework/.claude/skills/ui-design/scripts/foo.sh',
|
|
167
|
+
expected: path.join('.baldart', 'overlays', 'ui-design.md'),
|
|
168
|
+
},
|
|
169
|
+
{
|
|
170
|
+
name: 'agent .md → agents/ overlay',
|
|
171
|
+
file: '.framework/framework/.claude/agents/ui-expert.md',
|
|
172
|
+
expected: path.join('.baldart', 'overlays', 'agents', 'ui-expert.md'),
|
|
173
|
+
},
|
|
174
|
+
{
|
|
175
|
+
name: 'command .md → commands/ overlay',
|
|
176
|
+
file: '.framework/framework/.claude/commands/check.md',
|
|
177
|
+
expected: path.join('.baldart', 'overlays', 'commands', 'check.md'),
|
|
178
|
+
},
|
|
179
|
+
{
|
|
180
|
+
name: 'src file → null (no overlay maps)',
|
|
181
|
+
file: '.framework/src/utils/git.js',
|
|
182
|
+
expected: null,
|
|
183
|
+
},
|
|
184
|
+
{
|
|
185
|
+
name: 'nested agent path → null (agents are flat .md)',
|
|
186
|
+
file: '.framework/framework/.claude/agents/sub/x.md',
|
|
187
|
+
expected: null,
|
|
188
|
+
},
|
|
189
|
+
];
|
|
190
|
+
|
|
152
191
|
let pass = 0, fail = 0;
|
|
153
192
|
|
|
154
193
|
console.log('─── Subject classifier ───');
|
|
@@ -187,5 +226,48 @@ for (const f of AGGREGATE_FIXTURES) {
|
|
|
187
226
|
}
|
|
188
227
|
}
|
|
189
228
|
|
|
229
|
+
console.log('\n─── Overlay path mapping ───');
|
|
230
|
+
for (const f of OVERLAY_REL_FIXTURES) {
|
|
231
|
+
const actual = GitUtils.overlayRelForFrameworkFile(f.file);
|
|
232
|
+
if (actual === f.expected) {
|
|
233
|
+
pass++;
|
|
234
|
+
console.log(` ✓ ${f.name} → ${actual}`);
|
|
235
|
+
} else {
|
|
236
|
+
fail++;
|
|
237
|
+
console.log(` ✗ ${f.name} → ${actual} (expected ${f.expected})`);
|
|
238
|
+
}
|
|
239
|
+
}
|
|
240
|
+
|
|
241
|
+
// overlayCoversTouched(touched) — fs-backed: true only when EVERY touched file
|
|
242
|
+
// maps to an EXISTING overlay. This is the `overlayCovered` field that flows
|
|
243
|
+
// (via classifyDivergence → getUpdateStatus.divergenceCommits, a direct
|
|
244
|
+
// pass-through) into update.js's "reset is safe" branch. Lock the fs semantics.
|
|
245
|
+
console.log('\n─── overlayCoversTouched (fs-backed) ───');
|
|
246
|
+
{
|
|
247
|
+
const fsMod = require('fs');
|
|
248
|
+
const os = require('os');
|
|
249
|
+
const tmp = fsMod.mkdtempSync(path.join(os.tmpdir(), 'baldart-ovl-'));
|
|
250
|
+
fsMod.mkdirSync(path.join(tmp, '.baldart', 'overlays', 'agents'), { recursive: true });
|
|
251
|
+
fsMod.writeFileSync(path.join(tmp, '.baldart', 'overlays', 'agents', 'coder.md'), '---\n---\n');
|
|
252
|
+
const g2 = new GitUtils(tmp);
|
|
253
|
+
const cases = [
|
|
254
|
+
{ name: 'touched file has an existing overlay → covered',
|
|
255
|
+
touched: ['.framework/framework/.claude/agents/coder.md'], expected: true },
|
|
256
|
+
{ name: 'touched file has NO overlay → not covered',
|
|
257
|
+
touched: ['.framework/framework/.claude/agents/ui-expert.md'], expected: false },
|
|
258
|
+
{ name: 'one covered + one uncovered → not covered (every)',
|
|
259
|
+
touched: ['.framework/framework/.claude/agents/coder.md',
|
|
260
|
+
'.framework/framework/.claude/agents/ui-expert.md'], expected: false },
|
|
261
|
+
{ name: 'empty touched → not covered',
|
|
262
|
+
touched: [], expected: false },
|
|
263
|
+
];
|
|
264
|
+
for (const c of cases) {
|
|
265
|
+
const actual = g2.overlayCoversTouched(c.touched);
|
|
266
|
+
if (actual === c.expected) { pass++; console.log(` ✓ ${c.name} → ${actual}`); }
|
|
267
|
+
else { fail++; console.log(` ✗ ${c.name} → ${actual} (expected ${c.expected})`); }
|
|
268
|
+
}
|
|
269
|
+
fsMod.rmSync(tmp, { recursive: true, force: true });
|
|
270
|
+
}
|
|
271
|
+
|
|
190
272
|
console.log(`\nResult: ${pass} pass, ${fail} fail`);
|
|
191
273
|
process.exit(fail > 0 ? 1 : 0);
|
package/src/utils/git.js
CHANGED
|
@@ -256,6 +256,47 @@ class GitUtils {
|
|
|
256
256
|
return allOverlayable ? 'custom-overlay-able' : 'custom-other';
|
|
257
257
|
}
|
|
258
258
|
|
|
259
|
+
// Maps a touched `.framework/` payload file to the consumer overlay path that
|
|
260
|
+
// would preserve a customization of it, or null when no overlay maps to it.
|
|
261
|
+
// Mirrors the conventions in src/commands/overlay.js (overlayPath):
|
|
262
|
+
// .framework/framework/.claude/skills/<name>/... → .baldart/overlays/<name>.md
|
|
263
|
+
// .framework/framework/.claude/agents/<name>.md → .baldart/overlays/agents/<name>.md
|
|
264
|
+
// .framework/framework/.claude/commands/<name>.md → .baldart/overlays/commands/<name>.md
|
|
265
|
+
// Pure (no fs) so it stays unit-testable.
|
|
266
|
+
static overlayRelForFrameworkFile(p) {
|
|
267
|
+
const prefix = '.framework/framework/.claude/';
|
|
268
|
+
if (!p.startsWith(prefix)) return null;
|
|
269
|
+
const rest = p.slice(prefix.length);
|
|
270
|
+
const slash = rest.indexOf('/');
|
|
271
|
+
if (slash < 0) return null;
|
|
272
|
+
const dir = rest.slice(0, slash);
|
|
273
|
+
if (dir === 'skills') {
|
|
274
|
+
const name = rest.slice(slash + 1).split('/')[0];
|
|
275
|
+
if (!name) return null;
|
|
276
|
+
return path.join('.baldart', 'overlays', `${name}.md`);
|
|
277
|
+
}
|
|
278
|
+
if (dir === 'agents' || dir === 'commands') {
|
|
279
|
+
const file = rest.slice(slash + 1);
|
|
280
|
+
if (!file || file.includes('/')) return null; // flat <name>.md files only
|
|
281
|
+
const name = file.replace(/\.md$/, '');
|
|
282
|
+
if (!name) return null;
|
|
283
|
+
return path.join('.baldart', 'overlays', dir, `${name}.md`);
|
|
284
|
+
}
|
|
285
|
+
return null;
|
|
286
|
+
}
|
|
287
|
+
|
|
288
|
+
// True when EVERY overlay-able file touched by the commit already has an
|
|
289
|
+
// existing overlay in `.baldart/overlays/` — i.e. the divergent edit's intent
|
|
290
|
+
// is already preserved, so `--reset` is safe and `scaffold-overlays` would
|
|
291
|
+
// only create redundant skeletons.
|
|
292
|
+
overlayCoversTouched(touched) {
|
|
293
|
+
if (!touched || !touched.length) return false;
|
|
294
|
+
return touched.every((p) => {
|
|
295
|
+
const rel = GitUtils.overlayRelForFrameworkFile(p);
|
|
296
|
+
return rel ? fs.existsSync(path.join(this.cwd, rel)) : false;
|
|
297
|
+
});
|
|
298
|
+
}
|
|
299
|
+
|
|
259
300
|
async classifyDivergence() {
|
|
260
301
|
// Inspect aheadScoped commits — those not on FETCH_HEAD that touch .framework/.
|
|
261
302
|
const commits = [];
|
|
@@ -297,7 +338,10 @@ class GitUtils {
|
|
|
297
338
|
} catch (_) { /* leave empty → custom-other */ }
|
|
298
339
|
category = this.classifyCommitByPaths(touched);
|
|
299
340
|
}
|
|
300
|
-
|
|
341
|
+
const overlayCovered = category === 'custom-overlay-able'
|
|
342
|
+
? this.overlayCoversTouched(touched)
|
|
343
|
+
: false;
|
|
344
|
+
commits.push({ sha, subject, category, parents, touched: touched || [], overlayCovered });
|
|
301
345
|
}
|
|
302
346
|
} catch (_) {
|
|
303
347
|
return { class: 'unknown', commits: [] };
|
package/src/utils/hooks.js
CHANGED
|
@@ -384,6 +384,38 @@ function unregisterAll(cwd = process.cwd()) {
|
|
|
384
384
|
return { malformed: false, path: settingsPath, results };
|
|
385
385
|
}
|
|
386
386
|
|
|
387
|
+
// ---------------------------------------------------------------------------
|
|
388
|
+
// Verify — post-flight assertion that every active hook is registered
|
|
389
|
+
// ---------------------------------------------------------------------------
|
|
390
|
+
|
|
391
|
+
/**
|
|
392
|
+
* Confirms that every active hook in HOOK_REGISTRY is present in
|
|
393
|
+
* `.claude/settings.json`. Pure read (delegates to `getStatus`). Designed as
|
|
394
|
+
* the post-flight gate for `add` / `update --reset`: the install must never
|
|
395
|
+
* declare success while a hook is missing (the silent partial-install class,
|
|
396
|
+
* v3.27.1 / mayo 3.28→3.31). Commented-out registry entries (e.g.
|
|
397
|
+
* capture-detect) are excluded for free — `getStatus` only iterates the array.
|
|
398
|
+
*
|
|
399
|
+
* A malformed settings.json counts as a failure: registration was skipped, so
|
|
400
|
+
* the hooks are not verifiably present.
|
|
401
|
+
*
|
|
402
|
+
* @param {string} [cwd]
|
|
403
|
+
* @returns {{ ok: boolean, malformed: boolean, missing: string[], path: string }}
|
|
404
|
+
*/
|
|
405
|
+
function verifyAll(cwd = process.cwd()) {
|
|
406
|
+
const status = getStatus(cwd);
|
|
407
|
+
if (status.malformed) {
|
|
408
|
+
return {
|
|
409
|
+
ok: false,
|
|
410
|
+
malformed: true,
|
|
411
|
+
missing: HOOK_REGISTRY.map((d) => d.id),
|
|
412
|
+
path: status.path,
|
|
413
|
+
};
|
|
414
|
+
}
|
|
415
|
+
const missing = status.hooks.filter((h) => !h.registered).map((h) => h.id);
|
|
416
|
+
return { ok: missing.length === 0, malformed: false, missing, path: status.path };
|
|
417
|
+
}
|
|
418
|
+
|
|
387
419
|
// ---------------------------------------------------------------------------
|
|
388
420
|
// Drift prompt helper (interactive Keep / Replace / Show diff)
|
|
389
421
|
// ---------------------------------------------------------------------------
|
|
@@ -434,6 +466,7 @@ module.exports = {
|
|
|
434
466
|
HOOK_REGISTRY,
|
|
435
467
|
SETTINGS_FILE,
|
|
436
468
|
getStatus,
|
|
469
|
+
verifyAll,
|
|
437
470
|
registerAll,
|
|
438
471
|
unregisterAll,
|
|
439
472
|
createDriftPrompt,
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
const crypto = require('crypto');
|
|
2
|
+
const fs = require('fs');
|
|
2
3
|
const yaml = require('js-yaml');
|
|
3
4
|
|
|
4
5
|
/**
|
|
@@ -41,6 +42,45 @@ function computeBaseFileSha(content) {
|
|
|
41
42
|
return shortSha(content);
|
|
42
43
|
}
|
|
43
44
|
|
|
45
|
+
/**
|
|
46
|
+
* Idempotently backfill `base_file_sha` into an overlay file's frontmatter so
|
|
47
|
+
* `baldart overlay drift` is deterministic for EVERY overlay — not only those
|
|
48
|
+
* freshly scaffolded by `overlay scaffold` (which already writes it). Overlays
|
|
49
|
+
* authored by hand or by pre-v3.19.0 versions are otherwise "unknown" to drift
|
|
50
|
+
* (overlay.js drift § no base_file_sha). The merger knows the base file, so it
|
|
51
|
+
* stamps the sha here at `add`/`update` time.
|
|
52
|
+
*
|
|
53
|
+
* Contract: ADDITIVE-ONLY. Never overwrites an existing `base_file_sha`. Only
|
|
54
|
+
* touches a file that already has a leading YAML frontmatter block — never
|
|
55
|
+
* fabricates frontmatter on a file that lacks it. Fail-safe: any I/O error is
|
|
56
|
+
* swallowed (returns `changed:false`) so a backfill can never block a merge.
|
|
57
|
+
*
|
|
58
|
+
* @param {string} overlayPath absolute path to `.baldart/overlays/<…>.md`
|
|
59
|
+
* @param {string} baseSha 12-char hex from computeBaseFileSha(baseContent)
|
|
60
|
+
* @returns {{ changed: boolean, reason: string }}
|
|
61
|
+
*/
|
|
62
|
+
function ensureBaseFileShaInOverlay(overlayPath, baseSha) {
|
|
63
|
+
if (!baseSha) return { changed: false, reason: 'no-base-sha' };
|
|
64
|
+
let content;
|
|
65
|
+
try { content = fs.readFileSync(overlayPath, 'utf8'); }
|
|
66
|
+
catch (_) { return { changed: false, reason: 'unreadable' }; }
|
|
67
|
+
// Leading frontmatter block only (optionally after a BOM / blank lines).
|
|
68
|
+
const m = content.match(/^(\uFEFF?\s*)---\n([\s\S]*?)\n---(\r?\n|$)/);
|
|
69
|
+
if (!m) return { changed: false, reason: 'no-frontmatter' };
|
|
70
|
+
const fmBody = m[2];
|
|
71
|
+
if (/^\s*base_file_sha\s*:/m.test(fmBody)) {
|
|
72
|
+
return { changed: false, reason: 'already-present' };
|
|
73
|
+
}
|
|
74
|
+
// Quote the value — a 12-char hex can be all digits, which YAML would
|
|
75
|
+
// otherwise parse as a number (matches overlay.js buildFrontmatter).
|
|
76
|
+
const newFmBody = `${fmBody.replace(/\n+$/, '')}\nbase_file_sha: "${baseSha}"`;
|
|
77
|
+
const replaced = `${m[1]}---\n${newFmBody}\n---${m[3]}`;
|
|
78
|
+
const updated = content.slice(0, m.index) + replaced + content.slice(m.index + m[0].length);
|
|
79
|
+
try { fs.writeFileSync(overlayPath, updated, 'utf8'); }
|
|
80
|
+
catch (_) { return { changed: false, reason: 'unwritable' }; }
|
|
81
|
+
return { changed: true, reason: 'backfilled' };
|
|
82
|
+
}
|
|
83
|
+
|
|
44
84
|
function buildMarker({ kind, name, baseVersion, baseSha, overlaySha }) {
|
|
45
85
|
const baseShaField = baseSha ? ` base_sha=${baseSha}` : '';
|
|
46
86
|
return `${MARKER_PREFIX} kind=${kind} name=${name} base_version=${baseVersion}${baseShaField} overlay_sha=${overlaySha}
|
|
@@ -239,5 +279,6 @@ module.exports = {
|
|
|
239
279
|
parseMarkdown,
|
|
240
280
|
shortSha,
|
|
241
281
|
computeBaseFileSha,
|
|
282
|
+
ensureBaseFileShaInOverlay,
|
|
242
283
|
MARKER_PREFIX
|
|
243
284
|
};
|
package/src/utils/symlinks.js
CHANGED
|
@@ -484,8 +484,17 @@ class SymlinkUtils {
|
|
|
484
484
|
}
|
|
485
485
|
|
|
486
486
|
_generateOverlayedFile({ kind, name, fwAbsolute, overlayAbs, linkPath, lstat, frameworkVersion, aggregate, adapter, targetRel }) {
|
|
487
|
-
const { mergeOverlay,
|
|
487
|
+
const { mergeOverlay, isGeneratedFile, computeBaseFileSha, ensureBaseFileShaInOverlay } = require('./overlay-merger');
|
|
488
488
|
const baseContent = fs.readFileSync(fwAbsolute, 'utf8');
|
|
489
|
+
// Backfill base_file_sha into the overlay frontmatter so `overlay drift` is
|
|
490
|
+
// deterministic for EVERY overlay, not just freshly-scaffolded ones
|
|
491
|
+
// (additive-only, never overwrites). Done BEFORE reading overlayContent so
|
|
492
|
+
// the marker's overlay_sha already reflects it — no one-time regen churn.
|
|
493
|
+
// (v3.33.0)
|
|
494
|
+
try {
|
|
495
|
+
const bf = ensureBaseFileShaInOverlay(overlayAbs, computeBaseFileSha(baseContent));
|
|
496
|
+
if (bf.changed) UI.info(`[${adapter.label}] ${kind} ${name}: backfilled base_file_sha into overlay frontmatter.`);
|
|
497
|
+
} catch (_) { /* non-fatal — never block a merge on backfill */ }
|
|
489
498
|
const overlayContent = fs.readFileSync(overlayAbs, 'utf8');
|
|
490
499
|
const merged = mergeOverlay({ kind, name, baseContent, overlayContent, frameworkVersion });
|
|
491
500
|
|