balanceofsatoshis 11.52.2 → 11.53.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Versions
 
+## 11.53.0
+
+- `call`: Add support for `getPendingPayments` to show in-flight payments
+
+## 11.52.5
+
+- `open-balanced-channel`: Fix error preventing internal funding
+
+## 11.52.4
+
+- `telegram`: Fix crash when getting /liquidity and there is no liquidity
+
 ## 11.52.2
 
 - `telegram`: Fix connected node offline notifications

package/CONTRIBUTING.md

@@ -10,13 +10,9 @@ If you want to help with style, here are some rough guidelines on style ideas:
 
 ### Formatting
 
-- Spaces not tabs, 2 spaces
 - Arguments to methods are snake_case
 - Regular variables are camelCase
 - Returned attributes are snake_case
-- Minimize function nesting, make new files if nesting is required
-- No extraneous whitespace
-- A single newline should appear at the end of a file
 - A single line should contain max 80 characters including the newline
 - If a top level scalar would go over 80 characters in a line, that's ok
 - Don't bother with () in functions when not needed: `const a = b => c`
@@ -25,13 +21,20 @@ If you want to help with style, here are some rough guidelines on style ideas:
 - Lines should be terminated by explicit semicolons
 - Logic like ternary operators should not extend beyond a single line
 - Don't let any lines linger when they don't do anything
-- Tightly space objects, like `{attribute: value}` not `{ attribute : value }`
 - Use single '' quotes not double "" quotes, except when `` is required
-- If conditions should avoid spanning multiple lines
 - Avoid double specifying an attribute and value, `{type: type}` vs `{type}`
 - Always use {} with if, else, etc statements
 - Document the top of methods with what the arguments are and what is returned
 
+### White Space
+
+- Spaces not tabs, 2 spaces
+- Minimize function nesting, make new files if nesting is required
+- No extraneous whitespace
+- A single newline should appear at the end of a file
+- Tightly space objects, like `{attribute: value}` not `{ attribute : value }`
+- If conditions should avoid spanning multiple lines
+
 ### Control Flow
 
 - Async functions should support both cbk and Promise style
@@ -82,3 +85,10 @@ If you want to help with style, here are some rough guidelines on style ideas:
 - Try to be very specific with error messages and try to not repeat one
 - Callbacks should always be called as (err, result)
 - Try and catch should not be used unless an error is expected
+
+### Testing
+
+- Ideally there is a tap unit test that has 100% coverage, using mock-lnd
+- Also good is a ln-docker-daemons integration test for common scenarios
+- Design methods so that they can easily tested with self-contained unit tests
+- Avoid breaking existing tests, changes should also change relevant tests

package/README.md

@@ -188,6 +188,7 @@ bos utxos
 - Running `telegram` [via nohup/tmux howto](https://plebnet.wiki/wiki/Umbrel_-_Installing_BoS#Installing_Telegram_Bot)
 - Running `telegram` [via systemd](https://github.com/ziggie1984/miscellanous/blob/97c4905747fe23a824b6e53dc674c4a571ac0f5c/automation_telegram_bot.md)
 - Another `rebalance` + `tags` & `telegram` [commands howto](https://raspibolt.org/bonus/lightning/balance-of-satoshis.html#balance-of-satoshis-in-action)
+- Documentation for bos commands [commands howto](https://github.com/niteshbalusu11/BOS-Commands-Document#balance-of-satoshis-commands)
 
 Want to stack some sats? Write your own LN paywalled guide!
 

package/commands/api.json

@@ -490,6 +490,22 @@
     {
       "method": "getPendingChannels"
     },
+    {
+      "arguments": [
+        {
+          "description": "Results limit",
+          "named": "limit",
+          "optional": true,
+          "type": "number"
+        },
+        {
+          "description": "Paging token",
+          "named": "token",
+          "optional": true
+        }
+      ],
+      "method": "getPendingPayments"
+    },
     {
       "arguments": [
         {

package/package.json

@@ -35,9 +35,9 @@
     "inquirer": "8.2.0",
     "invoices": "2.0.4",
     "ln-accounting": "5.0.5",
-    "ln-service": "53.8.0",
-    "ln-sync": "3.10.0",
-    "ln-telegram": "3.17.1",
+    "ln-service": "53.9.0",
+    "ln-sync": "3.10.1",
+    "ln-telegram": "3.17.3",
     "moment": "2.29.1",
     "paid-services": "3.11.0",
     "probing": "2.0.3",
@@ -81,5 +81,5 @@
     "postpublish": "docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v7 -t alexbosworth/balanceofsatoshis --push .",
     "test": "tap --branches=1 --functions=1 --lines=1 --statements=1 -t 60 test/arrays/*.js test/balances/*.js test/chain/*.js test/display/*.js test/encryption/*.js test/lnd/*.js test/network/*.js test/nodes/*.js test/peers/*.js test/responses/*.js test/routing/*.js test/services/*.js test/swaps/*.js test/tags/*.js test/telegram/*.js test/wallets/*.js"
   },
-  "version": "11.52.2"
+  "version": "11.53.0"
 }

package/telegram/start_telegram_bot.js

@@ -865,7 +865,8 @@ module.exports = (args, cbk) => {
                 from,
                 confirmed: transaction.is_confirmed,
                 id: connectedId,
-                send: (id, msg) => args.bot.api.sendMessage(id, msg, markdown),
+                nodes: getNodes,
+                send: (id, msg, opt) => args.bot.api.sendMessage(id, msg, opt),
                 transaction: record,
               });
             } catch (err) {