badgr-cli 1.0.32 → 1.0.34

package/tests/launch-readiness.test.js

@@ -0,0 +1,326 @@
+/**
+ * Launch readiness — gap-filling tests for features on the outreach checklist
+ *
+ * Covers items missing from run-lifecycle and serve-lifecycle:
+ *   - badgr down  → terminates, writes receipt, prints cost summary
+ *   - badgr status → shows running deployments, rate, endpoint; empty state
+ *   - compat_failure error → correct user-facing message for CUDA mismatch
+ *   - failure_category surfaced → compat failure receipt shows failure reason
+ */
+
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+
+// ── Module mocks ──────────────────────────────────────────────────────────────
+
+vi.mock('../src/api.js', () => ({
+  callApi:             vi.fn(),
+  terminateDeployment: vi.fn(),
+  listDeployments:     vi.fn(),
+}));
+
+vi.mock('../src/store.js', () => ({
+  addDeployment:        vi.fn(),
+  addReceipt:           vi.fn(),
+  updateReceipt:        vi.fn(),
+  generateReceiptId:    vi.fn(() => 'rcpt-down-001'),
+  generateDeploymentId: vi.fn(() => 'dep-down-001'),
+  listDeployments:      vi.fn(() => []),
+  listReceipts:         vi.fn(() => []),
+  findDeployment:       vi.fn(() => null),
+  updateDeployment:     vi.fn(),
+  removeDeployment:     vi.fn(),
+}));
+
+vi.mock('../src/config.js', () => ({
+  requireApiKey: vi.fn(),
+  loadConfig:    vi.fn(() => ({ apiKey: 'sk-test', baseUrl: 'https://api.test/v1' })),
+  saveConfig:    vi.fn(),
+}));
+
+import { downCommand }   from '../src/commands/down.js';
+import { statusCommand } from '../src/commands/status.js';
+import { callWithFallback, CapacityError } from '../src/fallback.js';
+import * as api   from '../src/api.js';
+import * as store from '../src/store.js';
+
+// ── Helpers ───────────────────────────────────────────────────────────────────
+
+const config = { apiKey: 'sk-test', baseUrl: 'https://api.test/v1' };
+
+const chalk = {
+  bold:   s => s,
+  dim:    s => s,
+  red:    s => s,
+  yellow: s => s,
+  green:  s => s,
+  cyan:   s => s,
+};
+
+const NOW = 1_700_000_000;   // fixed unix timestamp
+const STARTED = NOW - 600;   // 10 minutes ago
+
+function makeTerminatedDep(overrides = {}) {
+  return {
+    deployment_id: 'dep-abc123',
+    gpu_type:      'RTX_4090',
+    cost_per_hour: 0.85,
+    started_at:    STARTED,
+    stopped_at:    NOW,
+    status:        'stopped',
+    ...overrides,
+  };
+}
+
+function makeRunningDep(overrides = {}) {
+  return {
+    deployment_id: 'dep-run-001',
+    workload_type: 'job',
+    gpu_type:      'A100',
+    gpu_count:     1,
+    cost_per_hour: 2.50,
+    status:        'running',
+    endpoint_url:  null,
+    model:         null,
+    ...overrides,
+  };
+}
+
+beforeEach(() => {
+  vi.spyOn(console, 'log').mockImplementation(() => {});
+  vi.spyOn(console, 'error').mockImplementation(() => {});
+  vi.spyOn(process.stdout, 'write').mockImplementation(() => true);
+  vi.clearAllMocks();
+  store.generateReceiptId.mockReturnValue('rcpt-down-001');
+  store.findDeployment.mockReturnValue(null);
+});
+
+afterEach(() => {
+  vi.restoreAllMocks();
+});
+
+// ─────────────────────────────────────────────────────────────────────────────
+// 1. badgr down
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe('badgr down', () => {
+  it('calls terminateDeployment with the provided deployment ID', async () => {
+    api.terminateDeployment.mockResolvedValue(makeTerminatedDep());
+
+    await downCommand(config, ['dep-abc123'], chalk);
+
+    expect(api.terminateDeployment).toHaveBeenCalledWith(config, 'dep-abc123');
+  });
+
+  it('writes a receipt with runtime, finalCost, and action=badgr down', async () => {
+    api.terminateDeployment.mockResolvedValue(makeTerminatedDep());
+
+    await downCommand(config, ['dep-abc123'], chalk);
+
+    expect(store.addReceipt).toHaveBeenCalledWith(expect.objectContaining({
+      action:         'badgr down',
+      deploymentId:   'dep-abc123',
+      gpu:            'RTX_4090',
+      status:         'terminated',
+    }));
+    // Runtime should be ~600s (10 min window)
+    const call = store.addReceipt.mock.calls[0][0];
+    expect(call.runtimeSeconds).toBeGreaterThan(0);
+    expect(call.finalCost).toBeGreaterThan(0);
+  });
+
+  it('removes the local deployment record', async () => {
+    api.terminateDeployment.mockResolvedValue(makeTerminatedDep());
+
+    await downCommand(config, ['dep-abc123'], chalk);
+
+    expect(store.removeDeployment).toHaveBeenCalledWith('dep-abc123');
+  });
+
+  it('resolves local name to deployment ID via findDeployment', async () => {
+    store.findDeployment.mockReturnValue({ id: 'dep-abc123', name: 'my-job' });
+    api.terminateDeployment.mockResolvedValue(makeTerminatedDep());
+
+    await downCommand(config, ['my-job'], chalk);
+
+    expect(api.terminateDeployment).toHaveBeenCalledWith(config, 'dep-abc123');
+  });
+
+  it('prints error and returns without crashing on API failure', async () => {
+    api.terminateDeployment.mockRejectedValue(new Error('network error'));
+
+    await downCommand(config, ['dep-abc123'], chalk);
+
+    expect(console.error).toHaveBeenCalledWith(
+      expect.stringContaining('Could not stop deployment'),
+    );
+    expect(store.addReceipt).not.toHaveBeenCalled();
+  });
+
+  it('prints usage hint when no deployment ID given', async () => {
+    await downCommand(config, [], chalk);
+
+    expect(console.error).toHaveBeenCalledWith(
+      expect.stringContaining('Usage'),
+    );
+    expect(api.terminateDeployment).not.toHaveBeenCalled();
+  });
+});
+
+// ─────────────────────────────────────────────────────────────────────────────
+// 2. badgr status
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe('badgr status', () => {
+  it('shows "Nothing running" when no active deployments', async () => {
+    api.listDeployments.mockResolvedValue({ deployments: [] });
+
+    await statusCommand(config, [], chalk);
+
+    const allOutput = console.log.mock.calls.flat().join(' ');
+    expect(allOutput).toContain('Nothing running');
+  });
+
+  it('displays running deployment with GPU type and billing rate', async () => {
+    api.listDeployments.mockResolvedValue({ deployments: [makeRunningDep()] });
+
+    await statusCommand(config, [], chalk);
+
+    const allOutput = console.log.mock.calls.flat().join(' ');
+    expect(allOutput).toContain('dep-run-001');
+    expect(allOutput).toContain('A100');
+    expect(allOutput).toContain('2.50');
+  });
+
+  it('shows endpoint URL for endpoint workloads', async () => {
+    api.listDeployments.mockResolvedValue({
+      deployments: [makeRunningDep({
+        workload_type: 'endpoint',
+        endpoint_url:  'https://dep-run-001.aibadgr.com/v1',
+      })],
+    });
+
+    await statusCommand(config, [], chalk);
+
+    const allOutput = console.log.mock.calls.flat().join(' ');
+    expect(allOutput).toContain('dep-run-001.aibadgr.com');
+  });
+
+  it('shows total billing rate when multiple deployments are running', async () => {
+    api.listDeployments.mockResolvedValue({
+      deployments: [
+        makeRunningDep({ deployment_id: 'dep-1', cost_per_hour: 1.20 }),
+        makeRunningDep({ deployment_id: 'dep-2', cost_per_hour: 2.50 }),
+      ],
+    });
+
+    await statusCommand(config, [], chalk);
+
+    const allOutput = console.log.mock.calls.flat().join(' ');
+    // Total: 1.20 + 2.50 = 3.70
+    expect(allOutput).toContain('3.70');
+  });
+
+  it('shows provisioning-state deployment as starting', async () => {
+    api.listDeployments.mockResolvedValue({
+      deployments: [makeRunningDep({ status: 'provisioning', cost_per_hour: 0 })],
+    });
+
+    await statusCommand(config, [], chalk);
+
+    const allOutput = console.log.mock.calls.flat().join(' ');
+    expect(allOutput).toContain('starting');
+  });
+
+  it('falls back to local store when API is unavailable', async () => {
+    api.listDeployments.mockRejectedValue(new Error('connection refused'));
+    store.listDeployments.mockReturnValue([
+      { id: 'dep-local-001', name: 'local-job', gpu: 'L40S', status: 'running', costPerHour: 1.10 },
+    ]);
+
+    await statusCommand(config, [], chalk);
+
+    const allOutput = console.log.mock.calls.flat().join(' ');
+    expect(allOutput).toContain('dep-local-001');
+  });
+});
+
+// ─────────────────────────────────────────────────────────────────────────────
+// 3. CUDA / compat failure error messages
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe('compat_failure error message', () => {
+  function makeCompatError() {
+    const err = new Error('PROVISIONING_FAILED');
+    err.errorData = {
+      code:             'PROVISIONING_FAILED',
+      failure_category: 'compat_failure',
+    };
+    return err;
+  }
+
+  it('shows GPU/CUDA incompatibility message when failure_category is compat_failure', async () => {
+    api.callApi.mockRejectedValue(makeCompatError());
+
+    let thrown;
+    try {
+      await callWithFallback(
+        '/run',
+        { apiKey: 'sk-test', baseUrl: 'https://api.test/v1' },
+        () => ({ gpu: 'RTX_4090' }),
+        '1',
+        chalk,
+        { thing: 'job', cmd: 'badgr run' },
+      );
+    } catch (err) {
+      thrown = err;
+    }
+
+    expect(thrown).toBeInstanceOf(CapacityError);
+    expect(thrown.message).toContain('incompatib');
+  });
+
+  it('shows generic provisioning failure when failure_category is infrastructure', async () => {
+    const err = new Error('PROVISIONING_FAILED');
+    err.errorData = { code: 'PROVISIONING_FAILED', failure_category: 'infrastructure' };
+    api.callApi.mockRejectedValue(err);
+
+    let thrown;
+    try {
+      await callWithFallback(
+        '/run',
+        { apiKey: 'sk-test', baseUrl: 'https://api.test/v1' },
+        () => ({}),
+        '1',
+        chalk,
+        { thing: 'job', cmd: 'badgr run' },
+      );
+    } catch (err2) {
+      thrown = err2;
+    }
+
+    expect(thrown).toBeInstanceOf(CapacityError);
+    // Should NOT mention CUDA/compat
+    expect(thrown.message).not.toContain('incompatib');
+    expect(thrown.message).toContain('failed to start');
+  });
+
+  it('compat message mentions trying a different GPU type or image', async () => {
+    api.callApi.mockRejectedValue(makeCompatError());
+
+    let thrown;
+    try {
+      await callWithFallback(
+        '/run',
+        { apiKey: 'sk-test', baseUrl: 'https://api.test/v1' },
+        () => ({}),
+        '2',
+        chalk,
+        { thing: 'job', cmd: 'badgr run' },
+      );
+    } catch (err) {
+      thrown = err;
+    }
+
+    expect(thrown.message).toMatch(/GPU type|image/i);
+  });
+});

package/tests/run-lifecycle.test.js

@@ -85,15 +85,25 @@ function setupSuccessfulRun(depOverrides = {}, exitCode = 0) {
 process.setMaxListeners(50);
 
 beforeEach(() => {
-  vi.useFakeTimers();
+  // Explicitly list what to fake — vitest 4.x also fakes queueMicrotask and
+  // nextTick by default which deadlocks await-inside-while-loop patterns.
+  vi.useFakeTimers({
+    toFake: ['setTimeout', 'setInterval', 'clearTimeout', 'clearInterval', 'Date', 'performance', 'setImmediate', 'clearImmediate'],
+  });
   process.exitCode = undefined;
   vi.spyOn(console, 'log').mockImplementation(() => {});
   vi.spyOn(console, 'error').mockImplementation(() => {});
   vi.spyOn(process.stdout, 'write').mockImplementation(() => true);
-  // Reset call counts between tests
-  vi.clearAllMocks();
-  // Restore default mock return values that clearAllMocks wipes
+  // resetAllMocks clears both call history AND the mockResolvedValueOnce queue
+  // (clearAllMocks only clears history in vitest 4.x, leaving stale queued values
+  // that can corrupt subsequent tests).
+  vi.resetAllMocks();
+  // Restore default mock return values cleared by resetAllMocks
   store.generateReceiptId.mockReturnValue('rcpt-launch-001');
+  store.generateDeploymentId.mockReturnValue('dep-launch-001');
+  store.listDeployments.mockReturnValue([]);
+  store.listReceipts.mockReturnValue([]);
+  store.findDeployment.mockReturnValue(null);
   api.terminateDeployment.mockResolvedValue({});
 });