backend-manager 5.9.15 → 5.9.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.9.15",
+  "version": "5.9.16",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "files": [

package/src/cli/commands/deploy.js

@@ -2,25 +2,11 @@ const BaseCommand = require('./base-command');
 const chalk = require('chalk').default;
 const powertools = require('node-powertools');
 const attachLogFile = require('../utils/attach-log-file');
-const { execSync } = require('child_process');
-const { homedir } = require('os');
 const path = require('path');
 const jetpack = require('fs-jetpack');
 
 const DEFAULT_REGION = 'us-central1';
 
-function gcloudExec(cmd, options = {}) {
-  const env = { ...process.env };
-  env.PATH = `${path.join(homedir(), 'google-cloud-sdk', 'bin')}:${env.PATH}`;
-
-  return execSync(cmd, {
-    encoding: 'utf8',
-    timeout: options.timeout || 30000,
-    stdio: ['pipe', 'pipe', 'pipe'],
-    env,
-  });
-}
-
 class DeployCommand extends BaseCommand {
   async execute() {
     const self = this.main;
@@ -63,8 +49,8 @@ class DeployCommand extends BaseCommand {
    * runtime transition. Without it, HTTP requests get a 403 at the IAM level
    * before BEM's application-level auth (backendManagerKey) can run.
    *
-   * Dynamically discovers all deployed functions and fixes any HTTP-triggered
-   * function missing the allUsers invoker binding.
+   * Dynamically discovers all deployed functions via gcloud and fixes any
+   * HTTP-triggered function missing the allUsers invoker binding.
    */
   async ensurePublicInvoker() {
     const projectId = this.getProjectId();
@@ -77,13 +63,12 @@ class DeployCommand extends BaseCommand {
     let httpFunctions;
 
     try {
-      const output = gcloudExec(
+      const output = await powertools.execute(
         `gcloud functions list --project ${projectId} --regions ${DEFAULT_REGION} --format="json(name,httpsTrigger)"`,
+        { log: false },
       );
 
-      const allFunctions = JSON.parse(output);
-
-      httpFunctions = allFunctions
+      httpFunctions = JSON.parse(output)
         .filter((fn) => fn.httpsTrigger)
         .map((fn) => fn.name.split('/').pop());
     } catch {
@@ -101,9 +86,9 @@ class DeployCommand extends BaseCommand {
 
     for (const fnName of httpFunctions) {
       try {
-        const policyOutput = gcloudExec(
+        const policyOutput = await powertools.execute(
           `gcloud functions get-iam-policy ${fnName} --project ${projectId} --region ${DEFAULT_REGION} --format=json`,
-          { timeout: 15000 },
+          { log: false },
         );
 
         const policy = JSON.parse(policyOutput);
@@ -117,8 +102,9 @@ class DeployCommand extends BaseCommand {
           continue;
         }
 
-        gcloudExec(
+        await powertools.execute(
           `gcloud functions add-iam-policy-binding ${fnName} --project ${projectId} --region ${DEFAULT_REGION} --member="allUsers" --role="roles/cloudfunctions.invoker"`,
+          { log: false },
         );
 
         this.log(`  ${chalk.green('✓')} Set public invoker on ${chalk.cyan(fnName)}`);

package/src/cli/commands/setup-tests/gcloud-cli.js

@@ -0,0 +1,26 @@
+const BaseTest = require('./base-test');
+const powertools = require('node-powertools');
+
+class GcloudCliTest extends BaseTest {
+  getName() {
+    return 'gcloud CLI is installed (required by deploy)';
+  }
+
+  getWarning() {
+    return [
+      'gcloud CLI is not installed.',
+      'Install with: https://cloud.google.com/sdk/docs/install',
+    ];
+  }
+
+  async run() {
+    try {
+      await powertools.execute('gcloud --version', { log: false });
+      return true;
+    } catch (error) {
+      return 'warn';
+    }
+  }
+}
+
+module.exports = GcloudCliTest;

package/src/cli/commands/setup-tests/index.js

@@ -10,6 +10,7 @@ const NvmrcVersionTest = require('./nvmrc-version');
 const FirebaseCLITest = require('./firebase-cli');
 const FirebaseAuthTest = require('./firebase-auth');
 const JavaInstalledTest = require('./java-installed');
+const GcloudCliTest = require('./gcloud-cli');
 const FunctionsPackageTest = require('./functions-package');
 const FirebaseAdminTest = require('./firebase-admin');
 const FirebaseFunctionsTest = require('./firebase-functions');
@@ -56,6 +57,7 @@ function getTests(context) {
     new FirebaseCLITest(context),
     new FirebaseAuthTest(context),
     new JavaInstalledTest(context),
+    new GcloudCliTest(context),
     new FunctionsPackageTest(context),
     new FirebaseAdminTest(context),
     new FirebaseFunctionsTest(context),