backend-manager 5.9.14 → 5.9.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.9.14",
+  "version": "5.9.16",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "files": [

package/src/cli/commands/deploy.js

@@ -2,16 +2,10 @@ const BaseCommand = require('./base-command');
 const chalk = require('chalk').default;
 const powertools = require('node-powertools');
 const attachLogFile = require('../utils/attach-log-file');
-const { execSync } = require('child_process');
 const path = require('path');
 const jetpack = require('fs-jetpack');
 
 const DEFAULT_REGION = 'us-central1';
-const PUBLIC_HTTP_FUNCTIONS = [
-  'bm_api',
-  'bm_authBeforeCreate',
-  'bm_authBeforeSignIn',
-];
 
 class DeployCommand extends BaseCommand {
   async execute() {
@@ -49,11 +43,14 @@ class DeployCommand extends BaseCommand {
   }
 
   /**
-   * Ensure HTTP-triggered functions have allUsers as cloudfunctions.invoker.
+   * Ensure all HTTP-triggered functions have allUsers as cloudfunctions.invoker.
    *
    * Firebase CLI used to set this automatically but stopped around the Node 10
    * runtime transition. Without it, HTTP requests get a 403 at the IAM level
    * before BEM's application-level auth (backendManagerKey) can run.
+   *
+   * Dynamically discovers all deployed functions via gcloud and fixes any
+   * HTTP-triggered function missing the allUsers invoker binding.
    */
   async ensurePublicInvoker() {
     const projectId = this.getProjectId();
@@ -62,10 +59,23 @@ class DeployCommand extends BaseCommand {
       return;
     }
 
-    const gcloud = this.findGcloud();
+    // Discover all deployed HTTP-triggered functions
+    let httpFunctions;
+
+    try {
+      const output = await powertools.execute(
+        `gcloud functions list --project ${projectId} --regions ${DEFAULT_REGION} --format="json(name,httpsTrigger)"`,
+        { log: false },
+      );
+
+      httpFunctions = JSON.parse(output)
+        .filter((fn) => fn.httpsTrigger)
+        .map((fn) => fn.name.split('/').pop());
+    } catch {
+      return;
+    }
 
-    if (!gcloud) {
-      this.log(chalk.gray('\n  Skipping public invoker check (gcloud not found)\n'));
+    if (!httpFunctions.length) {
       return;
     }
 
@@ -74,12 +84,11 @@ class DeployCommand extends BaseCommand {
     let fixed = 0;
     let ok = 0;
 
-    for (const fnName of PUBLIC_HTTP_FUNCTIONS) {
+    for (const fnName of httpFunctions) {
       try {
-        // Check current IAM policy
-        const policyOutput = execSync(
-          `${gcloud} functions get-iam-policy ${fnName} --project ${projectId} --region ${DEFAULT_REGION} --format=json`,
-          { encoding: 'utf8', timeout: 15000, stdio: ['pipe', 'pipe', 'pipe'] },
+        const policyOutput = await powertools.execute(
+          `gcloud functions get-iam-policy ${fnName} --project ${projectId} --region ${DEFAULT_REGION} --format=json`,
+          { log: false },
         );
 
         const policy = JSON.parse(policyOutput);
@@ -93,16 +102,15 @@ class DeployCommand extends BaseCommand {
           continue;
         }
 
-        // Add allUsers as invoker
-        execSync(
-          `${gcloud} functions add-iam-policy-binding ${fnName} --project ${projectId} --region ${DEFAULT_REGION} --member="allUsers" --role="roles/cloudfunctions.invoker"`,
-          { encoding: 'utf8', timeout: 30000, stdio: ['pipe', 'pipe', 'pipe'] },
+        await powertools.execute(
+          `gcloud functions add-iam-policy-binding ${fnName} --project ${projectId} --region ${DEFAULT_REGION} --member="allUsers" --role="roles/cloudfunctions.invoker"`,
+          { log: false },
         );
 
         this.log(`  ${chalk.green('✓')} Set public invoker on ${chalk.cyan(fnName)}`);
         fixed++;
       } catch {
-        // Function might not exist (not all projects use all functions) — skip silently
+        // Skip silently — function may be in a transient state
       }
     }
 
@@ -121,23 +129,6 @@ class DeployCommand extends BaseCommand {
       return null;
     }
   }
-
-  findGcloud() {
-    const homeDir = require('os').homedir();
-    const sdkPath = path.join(homeDir, 'google-cloud-sdk', 'bin', 'gcloud');
-
-    if (jetpack.exists(sdkPath)) {
-      return sdkPath;
-    }
-
-    // Try PATH
-    try {
-      execSync('which gcloud', { encoding: 'utf8', stdio: ['pipe', 'pipe', 'pipe'] });
-      return 'gcloud';
-    } catch {
-      return null;
-    }
-  }
 }
 
 module.exports = DeployCommand;

package/src/cli/commands/setup-tests/gcloud-cli.js

@@ -0,0 +1,26 @@
+const BaseTest = require('./base-test');
+const powertools = require('node-powertools');
+
+class GcloudCliTest extends BaseTest {
+  getName() {
+    return 'gcloud CLI is installed (required by deploy)';
+  }
+
+  getWarning() {
+    return [
+      'gcloud CLI is not installed.',
+      'Install with: https://cloud.google.com/sdk/docs/install',
+    ];
+  }
+
+  async run() {
+    try {
+      await powertools.execute('gcloud --version', { log: false });
+      return true;
+    } catch (error) {
+      return 'warn';
+    }
+  }
+}
+
+module.exports = GcloudCliTest;

package/src/cli/commands/setup-tests/index.js

@@ -10,6 +10,7 @@ const NvmrcVersionTest = require('./nvmrc-version');
 const FirebaseCLITest = require('./firebase-cli');
 const FirebaseAuthTest = require('./firebase-auth');
 const JavaInstalledTest = require('./java-installed');
+const GcloudCliTest = require('./gcloud-cli');
 const FunctionsPackageTest = require('./functions-package');
 const FirebaseAdminTest = require('./firebase-admin');
 const FirebaseFunctionsTest = require('./firebase-functions');
@@ -56,6 +57,7 @@ function getTests(context) {
     new FirebaseCLITest(context),
     new FirebaseAuthTest(context),
     new JavaInstalledTest(context),
+    new GcloudCliTest(context),
     new FunctionsPackageTest(context),
     new FirebaseAdminTest(context),
     new FirebaseFunctionsTest(context),