backend-manager 5.3.0 → 5.3.1

package/CHANGELOG.md

@@ -14,6 +14,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - `Fixed` for any bug fixes.
 - `Security` in case of vulnerabilities.
 
+# [5.3.1] - 2026-06-02
+
+### Fixed
+- **Leaking `wonderful-fetch` mock in the webhook-forward unit test.** `test/helpers/webhook-forward.js` installs a stub into `require.cache['wonderful-fetch']` at module load (the sanctioned cross-project fan-out exception — there's no second BEM emulator to receive the real fan-out POSTs), but never restored it. Because every test file is `require()`d into the same process, the stub leaked process-wide: every later test whose route did `require('wonderful-fetch')` got `{ received: true }` in 0ms instead of a real HTTP round-trip (observed breaking consumer sponsorship + inbound-email route tests). The helper now saves the original cache entry and restores it in a suite-level `cleanup()`, confining the mock to its own file.
+
 # [5.3.0] - 2026-06-02
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.3.0",
+  "version": "5.3.1",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "bin": {

package/test/helpers/webhook-forward.js

@@ -21,7 +21,15 @@
 
 // Mock wonderful-fetch before requiring the route — the route does
 // `require('wonderful-fetch')` at module load time.
+//
+// CRITICAL: every test file is `require()`d into the SAME Node process by the
+// runner, so the require cache is shared. We MUST save the original
+// wonderful-fetch cache entry here and restore it in the suite-level `cleanup`
+// below — otherwise this mock leaks into every test file that runs afterwards
+// (e.g. emulator route tests whose `Manager.require('wonderful-fetch')` would
+// then return our stub instead of doing a real HTTP round-trip).
 const originalFetchPath = require.resolve('wonderful-fetch');
+const originalFetchCacheEntry = require.cache[originalFetchPath];
 const fetchCalls = [];
 let fetchMockBehavior = () => ({ received: true });
 
@@ -38,6 +46,17 @@ require.cache[originalFetchPath] = {
 
 const route = require('../../src/manager/routes/marketing/webhook/forward/post.js');
 
+// Restore the real wonderful-fetch in the require cache so the mock is confined
+// to this file. Without this, the stub leaks process-wide and poisons every
+// later test file's HTTP calls.
+function restoreFetch() {
+  if (originalFetchCacheEntry) {
+    require.cache[originalFetchPath] = originalFetchCacheEntry;
+  } else {
+    delete require.cache[originalFetchPath];
+  }
+}
+
 // --- Test scaffolding ---
 
 function makeFirestoreMock(brandDocs) {
@@ -114,6 +133,13 @@ function withEnv(envOverrides, fn) {
 module.exports = {
   description: 'webhook/forward unit tests (mocked admin + fetch)',
   type: 'group',
+
+  // Restore the real wonderful-fetch after this file's tests so the require-cache
+  // stub does not leak into any test file that runs later in the same process.
+  cleanup() {
+    restoreFetch();
+  },
+
   tests: [
     // ─── Gating ───