backend-manager 5.2.6 → 5.2.7

package/CHANGELOG.md

@@ -14,6 +14,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - `Fixed` for any bug fixes.
 - `Security` in case of vulnerabilities.
 
+# [5.2.7] - 2026-05-24
+
+### Fixed
+
+- **`inferContact` silent-failure logging.** When the AI inference returned an empty result (either the AI call failed and returned null, or `gpt-5-mini` returned a parsed response with all-empty fields, or the response shape was missing `firstName`), the whole flow silently swallowed the failure and the signup's `user.personal.name` got written as `null`/`null`. Confirmed live on Somiibo: signed up `ian.wiedenman.business@gmail.com` twice on the same backend — first signup inferred nothing (empty name written), second signup correctly inferred "Ian Wiedenman". Same email, same code, transient AI hiccup, zero log trail. Added three unconditional diagnostic logs to `src/manager/libraries/infer-contact.js` (AI returned null, AI parsed response had all fields empty, AI response missing firstName) plus a log in `src/manager/routes/user/signup/post.js#inferUserContact` when the helper returns null. Next silent failure will at least leave a breadcrumb.
+
 # [5.2.6] - 2026-05-24
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.2.6",
+  "version": "5.2.7",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "bin": {

package/src/manager/libraries/infer-contact.js

@@ -26,6 +26,9 @@ async function inferContact(email, assistant) {
     if (aiResult) {
       return aiResult;
     }
+    assistant.log(`inferContact: AI returned null for ${email} — falling back to empty result`);
+  } else {
+    assistant.log(`inferContact: BACKEND_MANAGER_OPENAI_API_KEY not set — skipping AI inference for ${email}`);
   }
 
   return { firstName: '', lastName: '', company: '', confidence: 0, method: 'none' };
@@ -57,18 +60,22 @@ async function inferContactWithAI(email, assistant) {
 
     const parsed = result?.content;
     if (parsed?.firstName !== undefined) {
-      return {
+      const inferred = {
         firstName: capitalize(parsed.firstName || ''),
         lastName: capitalize(parsed.lastName || ''),
         company: capitalize(parsed.company || ''),
         confidence: typeof parsed.confidence === 'number' ? parsed.confidence : 0.5,
         method: 'ai',
       };
+      if (!inferred.firstName && !inferred.lastName && !inferred.company) {
+        assistant.log(`inferContactWithAI: AI parsed response had ALL fields empty for ${email}. Raw:`, parsed);
+      }
+      return inferred;
     }
+
+    assistant.log(`inferContactWithAI: AI response missing firstName for ${email}. Raw result:`, result);
   } catch (e) {
-    if (assistant) {
-      assistant.error('inferContactWithAI: Failed:', e);
-    }
+    assistant.error('inferContactWithAI: Failed:', e);
   }
 
   return null;

package/src/manager/routes/user/signup/post.js

@@ -229,6 +229,7 @@ async function inferUserContact(assistant, email) {
     const inferred = await inferContact(email, assistant);
 
     if (!inferred?.firstName && !inferred?.lastName && !inferred?.company) {
+      assistant.log(`signup(): inferUserContact returned empty result for ${email} (method=${inferred?.method || 'unknown'})`);
       return null;
     }
 

package/test/routes/test/usage.js

@@ -239,6 +239,10 @@ module.exports = {
     // Test 9: Cron resets daily counters for authenticated users
     {
       name: 'cron-resets-daily-counters',
+      // bm_cronDaily runs all daily jobs serially; reset-usage is at the end of
+      // the alphabetical sequence. In EXTENDED mode the real-API jobs ahead of
+      // it can take ~50s combined — override the suite's 30s default.
+      timeout: 75000,
       async run({ assert, firestore, state, accounts, waitFor, pubsub }) {
         // Verify daily counter is > 0 before cron
         const beforeDoc = await firestore.get(`users/${accounts.basic.uid}`);
@@ -251,19 +255,24 @@ module.exports = {
         // Trigger cron via PubSub
         await pubsub.trigger('bm_cronDaily');
 
-        // Wait for cron to reset daily counter
+        // Wait for cron to reset daily counter.
+        // bm_cronDaily executes every registered daily job sequentially. In EXTENDED
+        // mode the real-API jobs (marketing-newsletter-generate, expire-paypal-cancellations,
+        // ghostii-auto-publisher, etc.) can take 40-50s combined before reset-usage
+        // (alphabetical tail) gets its turn. 70s gives that the headroom it needs;
+        // the per-test `timeout` below matches.
         try {
           await waitFor(
             async () => {
               const doc = await firestore.get(`users/${accounts.basic.uid}`);
               return doc?.usage?.requests?.daily === 0;
             },
-            15000,
+            70000,
             500
           );
           assert.ok(true, 'Daily counter was reset to 0 by cron');
         } catch (error) {
-          assert.fail('Daily counter should be reset to 0 within 15s');
+          assert.fail('Daily counter should be reset to 0 within 70s');
         }
       },
     },