backend-manager 5.11.4 → 5.11.6

package/src/test/fixtures/firebase-project/pubsub-debug.log

@@ -1,17 +1,19 @@
 This is the Google Pub/Sub fake.
 Implementation may be incomplete or differ from the real system.
-Jul 02, 2026 1:48:11 AM com.google.cloud.pubsub.testing.v1.Main main
+Jul 03, 2026 4:27:25 PM com.google.cloud.pubsub.testing.v1.Main main
 INFO: IAM integration is disabled. IAM policy methods and ACL checks are not supported
 SLF4J(W): No SLF4J providers were found.
 SLF4J(W): Defaulting to no-operation (NOP) logger implementation
 SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
 WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
-WARNING: sun.misc.Unsafe::allocateMemory has been called by io.netty.util.internal.PlatformDependent0$2 (file:/Users/ian/.cache/firebase/emulators/pubsub-emulator-0.8.33/pubsub-emulator/lib/cloud-pubsub-emulator-0.8.33-all.jar)
+WARNING: sun.misc.Unsafe::allocateMemory has been called by io.netty.util.internal.PlatformDependent0$2 (file:/Users/ian/.cache/firebase/emulators/pubsub-emulator-0.8.34/pubsub-emulator/lib/cloud-pubsub-emulator-0.8.34-all.jar)
 WARNING: Please consider reporting this to the maintainers of class io.netty.util.internal.PlatformDependent0$2
 WARNING: sun.misc.Unsafe::allocateMemory will be removed in a future release
-Jul 02, 2026 1:48:11 AM com.google.cloud.pubsub.testing.v1.Main main
+Jul 03, 2026 4:27:25 PM com.google.cloud.pubsub.testing.v1.Main main
 INFO: Server started, listening on 8085
-Jul 02, 2026 1:48:18 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
+Jul 03, 2026 4:27:31 PM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
+INFO: Detected HTTP/2 connection.
+Jul 03, 2026 4:27:45 PM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
 INFO: Detected HTTP/2 connection.
 *** shutting down gRPC server since JVM is shutting down
 *** server shut down

package/test/email/campaign-cron-pipeline.js

@@ -255,7 +255,11 @@ module.exports = {
             const unknownGenerator = await firestore.get('marketing-campaigns/_test-unknown-generator');
             const unknownType = await firestore.get('marketing-campaigns/_test-unknown-type');
 
-            return oneoff?.status !== 'pending'
+            // 'sent'/'failed' — NOT merely !== 'pending': the claim flips the
+            // doc to 'processing' first, and proceeding on that mid-flight
+            // state races the send (oneoff-campaign-processed then reads
+            // 'processing' and fails).
+            return ['sent', 'failed'].includes(oneoff?.status)
               && recurring?.sendAt !== state.pastSendAt
               && recurringStale?.sendAt !== state.staleSendAt
               && ['sent', 'failed'].includes(staleProcessing?.status)

package/test/email/marketing-lifecycle.js

@@ -37,6 +37,11 @@ module.exports = {
           firstName: 'Lifecycle',
           lastName: 'Test',
           source: 'bem-test-lifecycle',
+          // skipValidation bypasses the mailbox verification check — the lifecycle
+          // address has no real mailbox so the provider (correctly) marks it
+          // undeliverable. This suite tests add → sync → remove against the real
+          // providers, not deliverability (covered by email/validation + contact tests).
+          skipValidation: true,
         });
 
         assert.isSuccess(response, 'Add contact should succeed');

package/test/email/validation.js

@@ -679,8 +679,10 @@ module.exports = {
       async run({ assert, skip }) {
         const result = await validate('disposable@gmail.com', { checks: ALL_CHECKS });
 
-        if (result.checks.mailbox?.error?.includes('out of credits')) {
-          skip('Mailbox verification out of credits');
+        // Provider errors fail open as { valid: true, error } with NO status field —
+        // out of credits, bad key, timeouts. Nothing assertable; skip.
+        if (result.checks.mailbox?.error) {
+          skip(`Mailbox verification unavailable: ${result.checks.mailbox.error}`);
         }
 
         assert.hasProperty(result, 'checks.mailbox', 'Should have mailbox check');
@@ -689,7 +691,7 @@ module.exports = {
     },
 
     {
-      name: 'mailbox-fake-domain-fails',
+      name: 'mailbox-not-called-when-dns-fails',
       timeout: 15000,
       skip: !process.env.TEST_EXTENDED_MODE || !HAS_MAILBOX_API_KEY
         ? 'TEST_EXTENDED_MODE or mailbox API key not set'
@@ -698,12 +700,45 @@ module.exports = {
       async run({ assert, skip }) {
         const result = await validate('rachel.greene@thisfakedomain99999.com', { checks: ALL_CHECKS });
 
-        if (result.checks.mailbox?.error?.includes('out of credits')) {
-          skip('Mailbox verification out of credits');
+        // Transient resolver errors fail open (dns: { valid: true, skipped: true })
+        // and let mailbox run — the short-circuit can't be observed that run.
+        if (result.checks.dns?.skipped) {
+          skip(`DNS lookup errored (${result.checks.dns.reason}) — cannot observe short-circuit`);
         }
 
-        assert.hasProperty(result, 'checks.mailbox.status', 'Should have status');
-        assert.notEqual(result.checks.mailbox.status, 'valid', 'Fake domain should not be valid');
+        assert.equal(result.valid, false, 'Fake domain should be invalid');
+        assert.propertyEquals(result, 'checks.dns.valid', false, 'DNS check should fail (NXDOMAIN)');
+        assert.equal(
+          result.checks.mailbox,
+          undefined,
+          'Mailbox must NOT run after dns fails — the short-circuit saves a paid API call'
+        );
+      },
+    },
+
+    {
+      name: 'mailbox-nonexistent-mailbox-not-valid',
+      timeout: 15000,
+      skip: !process.env.TEST_EXTENDED_MODE || !HAS_MAILBOX_API_KEY
+        ? 'TEST_EXTENDED_MODE or mailbox API key not set'
+        : false,
+
+      async run({ assert, skip }) {
+        // Real-MX domain (gmail passes dns) with a fabricated local part — this is
+        // the case that actually reaches the paid mailbox provider.
+        const result = await validate('rachel.greene.zk84qx@gmail.com', { checks: ALL_CHECKS });
+
+        assert.hasProperty(result, 'checks.mailbox', 'Should have mailbox check');
+
+        const mb = result.checks.mailbox;
+
+        // Provider errors fail open as { valid: true, error } with NO status; skip.
+        if (mb.error) {
+          skip(`Mailbox verification unavailable: ${mb.error}`);
+        }
+
+        assert.hasProperty(mb, 'status', 'Should have status');
+        assert.notEqual(mb.status, 'valid', 'Fabricated gmail mailbox should not verify as valid');
       },
     },
   ],

package/test/events/auth-delete-race.js

@@ -47,7 +47,7 @@ module.exports = {
 
     {
       name: 'no-wait-gets-clobbered',
-      async run({ Manager, assert }) {
+      async run({ Manager, assert, skip }) {
         const admin = Manager.libraries.admin;
         const testUid = '_test-race-no-wait';
         const testEmail = '_test.race-no-wait@test.com';
@@ -76,7 +76,16 @@ module.exports = {
         const doc = await userRef.get();
         const survived = doc.exists && !!(doc.data()?.api?.clientId);
 
-        assert.ok(!survived, 'Doc should be clobbered by late on-delete (proves the race exists)');
+        // The race resolves either way: when the emulator happens to finish
+        // the on-delete BEFORE the re-create's onCreate writes the doc, the
+        // dangerous late-clobber ordering never materializes that run —
+        // scheduler luck, not a regression. Only the clobber outcome is
+        // assertable; the benign ordering skips.
+        if (survived) {
+          await admin.auth().deleteUser(testUid).catch(() => {});
+          await pollUntilGone(userRef);
+          return skip('on-delete completed before the re-create this run — race did not manifest');
+        }
 
         await admin.auth().deleteUser(testUid).catch(() => {});
         await pollUntilGone(userRef);

package/test/functions/admin/edit-post.js

@@ -243,10 +243,10 @@ module.exports = {
     {
       name: 'verify-edit',
       auth: 'admin',
-      timeout: 30000,
+      timeout: 90000, // waitFor polls up to 60s for GitHub content propagation
       skip: !process.env.GH_TOKEN ? 'GH_TOKEN env var not set' : false,
 
-      async run({ assert, state }) {
+      async run({ assert, state, waitFor }) {
         if (!state.postPath || state.editSkipped) {
           assert.ok(true, 'Skipping verify - edit was not performed');
           return;
@@ -254,15 +254,19 @@ module.exports = {
 
         const octokit = new Octokit({ auth: process.env.GH_TOKEN });
 
-        // Fetch the file directly from GitHub
-        const { data: fileData } = await octokit.rest.repos.getContent({
-          owner: state.owner,
-          repo: state.repo,
-          path: state.postPath,
-        });
+        // GitHub's contents API is eventually consistent after createOrUpdateFileContents —
+        // an immediate read-back can serve the pre-edit blob. Poll until the edit lands.
+        const content = await waitFor(async () => {
+          const { data: fileData } = await octokit.rest.repos.getContent({
+            owner: state.owner,
+            repo: state.repo,
+            path: state.postPath,
+          });
+
+          const decoded = Buffer.from(fileData.content, 'base64').toString();
 
-        // Decode the content
-        const content = Buffer.from(fileData.content, 'base64').toString();
+          return decoded.includes('EDITED by the BEM test suite') ? decoded : false;
+        }, 60000, 3000);
 
         assert.ok(
           content.includes('EDITED by the BEM test suite'),

package/test/functions/general/add-marketing-contact.js

@@ -7,9 +7,11 @@
  */
 
 // Test email patterns - look like real emails but +bem suffix identifies them for cleanup.
-// Fixed `acme.com` test domain — deterministic across brands. Avoids cross-brand
-// state contamination in SendGrid/Beehiiv when the same test runs under different brands.
-const TEST_DOMAIN = 'acme.com';
+// Fixed `itwcreativeworks.com` test domain — deterministic across brands (avoids cross-brand
+// state contamination in SendGrid/Beehiiv) and we control it: mailbox verdicts are stable
+// and the AI won't flag it as a placeholder (which `acme.com` now is — empty names,
+// confidence 0 — breaking inference).
+const TEST_DOMAIN = 'itwcreativeworks.com';
 const TEST_EMAILS = {
   valid: () => `sarah.martinez+bem@${TEST_DOMAIN}`,         // Should infer: Sarah Martinez
   invalid: () => `nonexistent.user+bem@${TEST_DOMAIN}`,     // No such mailbox — mailbox verification should flag invalid
@@ -32,7 +34,11 @@ module.exports = {
         const response = await http.command('general:add-marketing-contact', {
           email: testEmail,
           source: 'bem-test',
-          // No firstName/lastName - should be inferred as "Rachel Greene"
+          // No firstName/lastName - should be inferred
+          // skipValidation bypasses the mailbox verification check — the test email
+          // doesn't have a real mailbox so the provider (correctly) marks it as not
+          // deliverable. We're testing the command flow, not the deliverability check.
+          skipValidation: true,
         });
 
         assert.isSuccess(response, 'Add marketing contact should succeed for admin');
@@ -146,6 +152,10 @@ module.exports = {
           email: testEmail,
           source: 'bem-test',
           // No firstName/lastName - should be inferred
+          // skipValidation bypasses the mailbox verification check — this test's concern
+          // is AI name inference (which runs after validation); without it the mailbox
+          // check 400s the fabricated address before the inference asserts run.
+          skipValidation: true,
         });
 
         assert.isSuccess(response, 'Add marketing contact should succeed');
@@ -227,6 +237,27 @@ module.exports = {
           source: 'bem-test',
         });
 
+        // Outcome A: the provider rejected the fabricated mailbox → admin 400. Every
+        // earlier check passes deterministically for this address (format/localPart/
+        // disposable/corporate return their own dedicated messages, typo can't match,
+        // and the domain has real MX), so reaching the generic validation-failed 400
+        // proves the paid mailbox pipeline ran and rejected. Nothing was added, so
+        // cleanup is a no-op.
+        if (response.status === 400) {
+          assert.ok(
+            response.error?.includes('Email validation failed'),
+            `400 should be the validation-failed branch, got: ${response.error}`
+          );
+
+          if (response.error.includes('(dns)')) {
+            skip('Transient DNS failure — mailbox check never ran');
+          }
+
+          assert.ok(response.error.includes('(mailbox)'), `Failed check should be mailbox, got: ${response.error}`);
+          return;
+        }
+
+        // Outcome B: provider accepted (valid/catch-all/unknown) or failed open.
         assert.isSuccess(response, 'Add marketing contact should succeed');
 
         // Check that validation info is included
@@ -238,9 +269,10 @@ module.exports = {
 
         const mbResult = response.data.validation.checks.mailbox;
 
-        // If out of credits, skip test - not a failure
-        if (mbResult.error?.includes('out of credits')) {
-          skip('Mailbox verification out of credits');
+        // Provider errors fail open as { valid: true, error, provider } with NO status
+        // field — out of credits, bad key, timeouts. Nothing assertable; skip.
+        if (mbResult.error) {
+          skip(`Mailbox verification unavailable: ${mbResult.error}`);
         }
 
         assert.hasProperty(mbResult, 'status', 'Mailbox check should return status');
@@ -268,7 +300,8 @@ module.exports = {
         : false,
 
       async run({ http, assert, skip }) {
-        // Use fake email that mailbox verification should flag as invalid
+        // Email that should reach the mailbox provider and be flagged as undeliverable.
+        // Must NOT trip earlier checks (localPart blocklist, disposable, corporate).
         const testEmail = TEST_EMAILS.invalid();
 
         const response = await http.command('general:add-marketing-contact', {
@@ -276,20 +309,27 @@ module.exports = {
           source: 'bem-test',
         });
 
-        // Should still succeed (we fail open) but mailbox should report invalid
-        assert.isSuccess(response, 'Request should succeed even with invalid email');
-
         const mbResult = response.data?.validation?.checks?.mailbox;
 
-        // If out of credits, skip test - not a failure
-        if (mbResult?.error?.includes('out of credits')) {
-          skip('Mailbox verification out of credits');
+        // Provider errors fail open with no status — the test can't exercise rejection; skip.
+        if (mbResult?.error) {
+          skip(`Mailbox verification unavailable: ${mbResult.error}`);
+        }
+
+        // If the response was a 400, that's the legitimate rejection path — done.
+        if (response.status === 400) {
+          if (response.error?.includes('(dns)')) {
+            skip('Transient DNS failure — mailbox check never ran');
+          }
+
+          assert.ok(response.error?.includes('(mailbox)'), `Failed check should be mailbox, got: ${response.error}`);
+          return;
         }
 
-        // Mailbox should return a status indicating the email is not valid
+        // Otherwise expect a 200 with a non-"valid" mailbox status.
+        assert.isSuccess(response, 'Request should succeed (fail-open) or error 400');
         if (mbResult) {
           assert.hasProperty(mbResult, 'status', 'Should have status');
-          // Status should NOT be 'valid' for this fake email
           assert.notEqual(mbResult.status, 'valid', 'Fake email should not be marked valid');
         }
       },

package/test/routes/admin/post.js

@@ -245,10 +245,10 @@ module.exports = {
     {
       name: 'verify-edit',
       auth: 'admin',
-      timeout: 30000,
+      timeout: 90000, // waitFor polls up to 60s for GitHub content propagation
       skip: !process.env.GH_TOKEN ? 'GH_TOKEN env var not set' : false,
 
-      async run({ assert, state }) {
+      async run({ assert, state, waitFor }) {
         if (!state.postPath || state.editSkipped) {
           assert.ok(true, 'Skipping verify - edit was not performed');
           return;
@@ -256,15 +256,19 @@ module.exports = {
 
         const octokit = new Octokit({ auth: process.env.GH_TOKEN });
 
-        // Fetch the file directly from GitHub
-        const { data: fileData } = await octokit.rest.repos.getContent({
-          owner: state.owner,
-          repo: state.repo,
-          path: state.postPath,
-        });
+        // GitHub's contents API is eventually consistent after createOrUpdateFileContents —
+        // an immediate read-back can serve the pre-edit blob. Poll until the edit lands.
+        const content = await waitFor(async () => {
+          const { data: fileData } = await octokit.rest.repos.getContent({
+            owner: state.owner,
+            repo: state.repo,
+            path: state.postPath,
+          });
+
+          const decoded = Buffer.from(fileData.content, 'base64').toString();
 
-        // Decode the content
-        const content = Buffer.from(fileData.content, 'base64').toString();
+          return decoded.includes('EDITED by the BEM test suite') ? decoded : false;
+        }, 60000, 3000);
 
         assert.ok(
           content.includes('EDITED by the BEM test suite'),

package/test/routes/marketing/contact.js

@@ -9,9 +9,11 @@
 // Test email patterns - look like real emails but +bem suffix identifies them for cleanup.
 // Names should be inferred by AI from the email local part.
 //
-// Fixed test domain (`acme.com`) — deterministic across brands. Using the running brand's
-// domain caused cross-brand state divergence in SendGrid/Beehiiv and non-deterministic
-// company inference (different domain → different inferred company name).
+// Fixed test domain (`itwcreativeworks.com`) — deterministic across brands (using the
+// running brand's domain caused cross-brand state divergence in SendGrid/Beehiiv and
+// non-deterministic company inference), and we control it: mailbox verdicts are stable
+// and any double-opt-in email lands on our own domain. Was `acme.com`, but the AI now
+// treats that domain as a placeholder (empty names, confidence 0), breaking inference.
 //
 // `valid`: use a name that won't be flagged as fictional/placeholder by the AI prompt.
 // (The infer-contact prompt rejects fictional names — e.g. "rachel.greene" sometimes
@@ -21,7 +23,7 @@
 // NOT start with "test"/"example" which are in BLOCKED_LOCAL_PATTERNS, NOT be on
 // a corporate/disposable domain). Real-looking name on a real domain with no actual
 // mailbox there is the safest pick.
-const TEST_DOMAIN = 'acme.com';
+const TEST_DOMAIN = 'itwcreativeworks.com';
 const TEST_EMAILS = {
   valid: () => `sarah.martinez+bem@${TEST_DOMAIN}`,         // Should infer: Sarah Martinez
   invalid: () => `nonexistent.user+bem@${TEST_DOMAIN}`,     // No such mailbox — mailbox verification should flag as invalid
@@ -164,6 +166,10 @@ module.exports = {
           email: testEmail,
           source: 'bem-test',
           // No firstName/lastName - should be inferred
+          // skipValidation bypasses the mailbox verification check — this test's concern
+          // is AI name inference (which runs after validation); without it the mailbox
+          // check 400s the fabricated address before the inference asserts run.
+          skipValidation: true,
         });
 
         assert.isSuccess(response, 'Add marketing contact should succeed');
@@ -245,6 +251,27 @@ module.exports = {
           source: 'bem-test',
         });
 
+        // Outcome A: the provider rejected the fabricated mailbox → admin 400. Every
+        // earlier check passes deterministically for this address (format/localPart/
+        // disposable/corporate return their own dedicated messages, typo can't match,
+        // and the domain has real MX), so reaching the generic validation-failed 400
+        // proves the paid mailbox pipeline ran and rejected. Nothing was added, so
+        // cleanup is a no-op.
+        if (response.status === 400) {
+          assert.ok(
+            response.error?.includes('Email validation failed'),
+            `400 should be the validation-failed branch, got: ${response.error}`
+          );
+
+          if (response.error.includes('(dns)')) {
+            skip('Transient DNS failure — mailbox check never ran');
+          }
+
+          assert.ok(response.error.includes('(mailbox)'), `Failed check should be mailbox, got: ${response.error}`);
+          return;
+        }
+
+        // Outcome B: provider accepted (valid/catch-all/unknown) or failed open.
         assert.isSuccess(response, 'Add marketing contact should succeed');
 
         // Check that validation info is included
@@ -256,9 +283,10 @@ module.exports = {
 
         const mbResult = response.data.validation.checks.mailbox;
 
-        // If out of credits, skip test - not a failure
-        if (mbResult.error?.includes('out of credits')) {
-          skip('Mailbox verification out of credits');
+        // Provider errors fail open as { valid: true, error, provider } with NO status
+        // field — out of credits, bad key, timeouts. Nothing assertable; skip.
+        if (mbResult.error) {
+          skip(`Mailbox verification unavailable: ${mbResult.error}`);
         }
 
         assert.hasProperty(mbResult, 'status', 'Mailbox check should return status');
@@ -301,13 +329,18 @@ module.exports = {
         // verify here is that mailbox check ran and didn't mark the email as `valid`.
         const mbResult = response.data?.validation?.checks?.mailbox;
 
-        // If credits are out, the test can't actually exercise rejection — skip.
-        if (mbResult?.error?.includes('out of credits') || mbResult?.error?.includes('Invalid API key')) {
-          skip('Mailbox verification out of credits');
+        // Provider errors fail open with no status — the test can't exercise rejection; skip.
+        if (mbResult?.error) {
+          skip(`Mailbox verification unavailable: ${mbResult.error}`);
         }
 
         // If the response was a 400, that's the legitimate rejection path — done.
         if (response.status === 400) {
+          if (response.error?.includes('(dns)')) {
+            skip('Transient DNS failure — mailbox check never ran');
+          }
+
+          assert.ok(response.error?.includes('(mailbox)'), `Failed check should be mailbox, got: ${response.error}`);
           return;
         }