backend-manager 5.11.4 → 5.11.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.11.4",
+  "version": "5.11.5",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "files": [

package/src/manager/events/cron/frequent/marketing-campaigns.js

@@ -39,6 +39,9 @@ const moment = require('moment');
 const pushid = require('pushid');
 const notification = require('../../../libraries/notification.js');
 const { getNextFutureOccurrence } = require('../../../libraries/email/constants.js');
+// firebase-admin v13 dropped the admin.firestore.FieldValue static — import
+// the modular way (same pattern as admin/send-email.js).
+const { FieldValue } = require('firebase-admin/firestore');
 
 // How long a 'processing' lease is honored before the campaign of a crashed or
 // timed-out run is reclaimed for retry. Must comfortably exceed the function
@@ -147,7 +150,7 @@ module.exports = async ({ Manager, assistant, libraries }) => {
             await doc.ref.set({
               status: 'pending',
               sendAt: nextSendAt,
-              generatorAttempts: admin.firestore.FieldValue.delete(),
+              generatorAttempts: FieldValue.delete(),
               metadata: { updated: stamp() },
             }, { merge: true });
 
@@ -216,7 +219,7 @@ module.exports = async ({ Manager, assistant, libraries }) => {
         await doc.ref.set({
           status: 'pending',
           sendAt: nextSendAt,
-          generatorAttempts: admin.firestore.FieldValue.delete(),
+          generatorAttempts: FieldValue.delete(),
           metadata: { updated: stamp() },
         }, { merge: true });
 
@@ -226,7 +229,7 @@ module.exports = async ({ Manager, assistant, libraries }) => {
         await doc.ref.set({
           status: success ? 'sent' : 'failed',
           results: campaignResults,
-          generatorAttempts: admin.firestore.FieldValue.delete(),
+          generatorAttempts: FieldValue.delete(),
           metadata: { updated: stamp() },
         }, { merge: true });
 

package/src/manager/index.js

@@ -1127,11 +1127,11 @@ Manager.prototype.setupFunctions = function (exporter, options) {
   .onRun((context) => self.EventMiddleware({ context }).run(`${cron}/daily.js`));
 
   // Frequent cron runs the inline newsletter generator (AI structure + section
-  // images + article + uploads) — needs the v1 max timeout and headroom for
-  // image buffers. If a run still times out, the campaign lease reclaim in
-  // marketing-campaigns.js retries it safely.
+  // images + article + uploads) — needs the v1 max timeout. If a run times out
+  // or OOMs, the campaign lease reclaim in marketing-campaigns.js retries it
+  // safely.
   exporter.bm_cronFrequent =
-  fn({memory: '512MB', timeoutSeconds: 540})
+  fn({memory: '256MB', timeoutSeconds: 540})
   .pubsub.schedule('*/10 * * * *')
   .onRun((context) => self.EventMiddleware({ context }).run(`${cron}/frequent.js`));
 };

package/test/email/campaign-cron-pipeline.js

@@ -255,7 +255,11 @@ module.exports = {
             const unknownGenerator = await firestore.get('marketing-campaigns/_test-unknown-generator');
             const unknownType = await firestore.get('marketing-campaigns/_test-unknown-type');
 
-            return oneoff?.status !== 'pending'
+            // 'sent'/'failed' — NOT merely !== 'pending': the claim flips the
+            // doc to 'processing' first, and proceeding on that mid-flight
+            // state races the send (oneoff-campaign-processed then reads
+            // 'processing' and fails).
+            return ['sent', 'failed'].includes(oneoff?.status)
               && recurring?.sendAt !== state.pastSendAt
               && recurringStale?.sendAt !== state.staleSendAt
               && ['sent', 'failed'].includes(staleProcessing?.status)

package/test/events/auth-delete-race.js

@@ -47,7 +47,7 @@ module.exports = {
 
     {
       name: 'no-wait-gets-clobbered',
-      async run({ Manager, assert }) {
+      async run({ Manager, assert, skip }) {
         const admin = Manager.libraries.admin;
         const testUid = '_test-race-no-wait';
         const testEmail = '_test.race-no-wait@test.com';
@@ -76,7 +76,16 @@ module.exports = {
         const doc = await userRef.get();
         const survived = doc.exists && !!(doc.data()?.api?.clientId);
 
-        assert.ok(!survived, 'Doc should be clobbered by late on-delete (proves the race exists)');
+        // The race resolves either way: when the emulator happens to finish
+        // the on-delete BEFORE the re-create's onCreate writes the doc, the
+        // dangerous late-clobber ordering never materializes that run —
+        // scheduler luck, not a regression. Only the clobber outcome is
+        // assertable; the benign ordering skips.
+        if (survived) {
+          await admin.auth().deleteUser(testUid).catch(() => {});
+          await pollUntilGone(userRef);
+          return skip('on-delete completed before the re-create this run — race did not manifest');
+        }
 
         await admin.auth().deleteUser(testUid).catch(() => {});
         await pollUntilGone(userRef);