backend-manager 5.1.2 → 5.1.4

package/test/marketing/fixtures/clean.json

@@ -2,24 +2,23 @@
   "_comment": "Predefined fixture for the `clean` template. Loaded via NEWSLETTER_FIXTURE=clean. Edit freely — no AI involved. Classic content shape: intro + sections[{title, body, cta, image_prompt}].",
   "subject": "Identity is the new growth lever",
   "preheader": "Three platform shifts to lock in this week.",
+  "summary": "LinkedIn, YouTube, and the broader creator stack are all tightening identity controls this week. The operators with documented attribution histories will outrun the rest. Documentation is no longer overhead — it's the moat.",
+  "tags": ["linkedin", "youtube", "platform-policy", "creator-economy", "operator-tools"],
   "intro": "Identity matters because trust is the new growth lever. Teams that handle this well will spend less time cleaning up later.",
   "sections": [
     {
       "title": "LinkedIn ships verified-profile gates for business accounts",
       "body": "LinkedIn now requires verified identity attestations on any business profile claiming more than 500 followers. Accounts with documented attribution histories sail through verification in under twelve hours. The practical implication is to lock down your attribution log this week, not next.",
-      "cta": { "label": "Read the brief", "url": "https://somiibo.com/blog/linkedin-verification" },
       "image_prompt": "Abstract geometric illustration of a verification checkmark inside a layered profile card."
     },
     {
       "title": "Documentation is the new operator moat",
       "body": "Operator playbooks are now the difference between an account that recovers from a flag and one that gets permanently restricted. Teams running documented processes recover in days. The ones without burn weeks negotiating with support queues.",
-      "cta": { "label": "See the playbook", "url": "https://somiibo.com/blog/operator-playbook" },
       "image_prompt": "Stack of geometric document layers casting clean shadows on a flat surface."
     },
     {
       "title": "YouTube tests creator-attribution metadata on uploads",
       "body": "A subset of channels saw a new upload checkbox this week asking whether content was assisted by automation. The checkbox is optional today. Reading the room: it will not stay optional. Creators with clear internal workflows will adapt in an afternoon.",
-      "cta": null,
       "image_prompt": "Minimalist play button morphing into a label tag, flat geometric style."
     }
   ],

package/test/marketing/fixtures/editorial.json

@@ -2,24 +2,23 @@
   "_comment": "Predefined fixture for the `editorial` template. Loaded via NEWSLETTER_FIXTURE=editorial. Same classic content shape as clean.json — both templates render the same data.",
   "subject": "Identity is the new growth lever",
   "preheader": "Three platform shifts to lock in this week.",
+  "summary": "LinkedIn, YouTube, and the broader creator stack are all tightening identity controls this week. The operators with documented attribution histories will outrun the rest. Documentation is no longer overhead — it's the moat.",
+  "tags": ["linkedin", "youtube", "platform-policy", "creator-economy", "operator-tools"],
   "intro": "Identity matters because trust is the new growth lever. Teams that handle this well will spend less time cleaning up later, and the patterns emerging this week tell you exactly where to focus.",
   "sections": [
     {
       "title": "LinkedIn ships verified-profile gates for business accounts",
       "body": "LinkedIn now requires verified identity attestations on any business profile claiming more than 500 followers. The rollout is fast and uneven — some accounts hit the gate inside two days of profile activity, others sit unchallenged for weeks. The pattern that matters is this: accounts with documented attribution histories sail through verification in under twelve hours. Accounts without get queued. The practical implication is to lock down your attribution log this week, not next.",
-      "cta": { "label": "Read the brief", "url": "https://somiibo.com/blog/linkedin-verification" },
       "image_prompt": "Abstract geometric illustration of a verification checkmark inside a layered profile card."
     },
     {
       "title": "Documentation is the new operator moat",
       "body": "Operator playbooks — once dismissed as overhead — are now the difference between an account that recovers from a flag and one that gets permanently restricted. The teams already running on documented processes recover in days. The ones without burn weeks negotiating with support queues. Treat your playbook as a compliance artifact, not a knowledge-management nice-to-have.",
-      "cta": { "label": "See the playbook", "url": "https://somiibo.com/blog/operator-playbook" },
       "image_prompt": "Stack of geometric document layers casting clean shadows on a flat surface."
     },
     {
       "title": "YouTube tests creator-attribution metadata on uploads",
       "body": "A subset of channels saw a new upload checkbox this week asking whether content was assisted by automation. The checkbox is optional today. Reading the room: it will not stay optional. Creators with clear internal workflows already labeled will adapt in an afternoon. Everyone else will spend a quarter retrofitting.",
-      "cta": null,
       "image_prompt": "Minimalist play button morphing into a label tag, flat geometric style."
     }
   ],

package/test/marketing/fixtures/field-report.json

@@ -1,7 +1,9 @@
 {
-  "_comment": "Predefined fixture for the `field-report` template. Loaded via NEWSLETTER_FIXTURE=field-report. Wire-service content shape: tldr + dateline + dispatches[{kicker, headline, byline, location, lede, dispatch, dataPoints, cta, image_prompt}].",
+  "_comment": "Predefined fixture for the `field-report` template. Loaded via NEWSLETTER_FIXTURE=field-report. Wire-service content shape: tldr + dateline + dispatches[{kicker, headline, byline, location, lede, dispatch, dataPoints, image_prompt}].",
   "subject": "LinkedIn tightens identity — operators document everything",
   "preheader": "Three filings from this week's platform front lines.",
+  "summary": "Wire from the platform front: LinkedIn is rolling identity verification across every business profile, YouTube is piloting upload-time attribution metadata, and the operators with clean documentation are outrunning everyone else.",
+  "tags": ["linkedin", "youtube", "platform-policy", "verification", "operator-playbook"],
   "tldr": "LinkedIn is rolling out verified-account scrutiny across every business profile. Operators with paper trails will outrun the rest. Documentation is the new growth lever.",
   "dateline": "OAKLAND",
   "signoff": "— Stay sharp,\nThe Somiibo Desk",
@@ -22,7 +24,6 @@
         { "label": "AVG REVIEW TIME", "value": "14HR" },
         { "label": "WoW APPROVAL", "value": "+38%" }
       ],
-      "cta": { "label": "READ THE BRIEF", "url": "https://somiibo.com/blog/linkedin-verification" },
       "image_prompt": "Abstract geometric illustration of a verification checkmark inside a layered profile card."
     },
     {
@@ -36,7 +37,6 @@
         { "label": "RECOVERY (DOCUMENTED)", "value": "4D" },
         { "label": "RECOVERY (UNDOC)", "value": "21D" }
       ],
-      "cta": { "label": "SEE THE PLAYBOOK", "url": "https://somiibo.com/blog/operator-playbook" },
       "image_prompt": "Stack of geometric document layers casting clean shadows on a flat surface."
     },
     {
@@ -47,7 +47,6 @@
       "lede": "A small pilot suggests YouTube will soon ask creators to declare automated tooling and cross-posting workflows at upload time.",
       "dispatch": "A subset of channels saw a new upload checkbox this week asking whether content was assisted by automation. The checkbox is optional today. Reading the room: it will not stay optional. Creators with clear internal workflows already labeled will adapt in an afternoon. Everyone else will spend a quarter retrofitting.",
       "dataPoints": [],
-      "cta": null,
       "image_prompt": "Minimalist play button morphing into a label tag, flat geometric style."
     }
   ]

package/test/marketing/newsletter-generate.js

@@ -79,7 +79,7 @@ module.exports = {
   // CI). Set TEST_EXTENDED_MODE=1 to switch to the full AI pipeline that fetches
   // real sources, calls the structure + SVG providers, and writes a preview.
   // Other modes (FIXTURE, THEME_ONLY, RELEASE, PEEK) are also opt-in via env.
-  async run({ assert, config }) {
+  async run({ assert, config, Manager, assistant }) {
     const env = process.env;
 
     // --- Apply env overrides into newsletterConfig ---
@@ -158,6 +158,7 @@ module.exports = {
       }
 
       const { renderNewsletter } = require('../../src/manager/libraries/email/generators/lib/mjml-template.js');
+      const { renderMarkdown } = require('../../src/manager/libraries/email/generators/lib/markdown-renderer.js');
 
       const renderStart = Date.now();
       const { html, mjml, template: templateName } = await renderNewsletter({
@@ -167,10 +168,26 @@ module.exports = {
         imagePaths: [],
         campaign: `fixture-${requestedFixture}`,
       });
+      // Force the template metadata onto structure so renderMarkdown picks
+      // the right body strategy (fixtures don't carry _meta on their own).
+      Object.defineProperty(structure, '_meta', {
+        enumerable: false,
+        configurable: true,
+        value: { template: templateName },
+      });
+      const markdown = renderMarkdown({
+        structure,
+        brand: config.brand,
+        imagePaths: [],
+      });
       const renderMs = Date.now() - renderStart;
 
       const previewPath = path.join(runDir, 'newsletter.html');
       jetpack.write(previewPath, html);
+      jetpack.write(path.join(runDir, 'newsletter.md'), markdown);
+      if (structure.summary) {
+        jetpack.write(path.join(runDir, 'summary.md'), structure.summary + '\n');
+      }
       jetpack.write(path.join(runDir, 'newsletter.mjml'), mjml || '');
       jetpack.write(path.join(runDir, 'structure.json'), JSON.stringify(structure, null, 2));
       jetpack.write(path.join(runDir, 'metadata.json'), JSON.stringify({
@@ -178,11 +195,13 @@ module.exports = {
         fixture: requestedFixture,
         template: templateName,
         renderMs,
+        tags: structure.tags || [],
         timestamp: new Date().toISOString(),
       }, null, 2));
 
       console.log(`\n[fixture=${requestedFixture}] Rendered in ${renderMs}ms using template: ${templateName}`);
       console.log(`[fixture=${requestedFixture}] Preview: ${previewPath}`);
+      console.log(`[fixture=${requestedFixture}] Markdown: ${path.join(runDir, 'newsletter.md')}`);
       console.log(`[fixture=${requestedFixture}] (Set TEST_EXTENDED_MODE=1 to switch to the full AI pipeline.)`);
 
       if (!env.NEWSLETTER_NO_OPEN && process.platform === 'darwin') {
@@ -190,6 +209,7 @@ module.exports = {
       }
 
       assert.ok(html.includes('<html'), 'Rendered HTML');
+      assert.ok(markdown.includes('# '), 'Rendered markdown has a heading');
       return;
     }
 
@@ -226,6 +246,7 @@ module.exports = {
       }
 
       const { renderNewsletter } = require('../../src/manager/libraries/email/generators/lib/mjml-template.js');
+      const { renderMarkdown } = require('../../src/manager/libraries/email/generators/lib/markdown-renderer.js');
 
       const renderStart = Date.now();
       const { html, mjml, template: templateName } = await renderNewsletter({
@@ -235,10 +256,26 @@ module.exports = {
         imagePaths,
         campaign: `theme-only-${stamp}`,
       });
+      // Force the template metadata onto structure so renderMarkdown picks
+      // the right body strategy (reused structures may have lost _meta).
+      Object.defineProperty(structure, '_meta', {
+        enumerable: false,
+        configurable: true,
+        value: { template: templateName },
+      });
+      const markdown = renderMarkdown({
+        structure,
+        brand: config.brand,
+        imagePaths,
+      });
       const renderMs = Date.now() - renderStart;
 
       const previewPath = path.join(runDir, 'newsletter.html');
       jetpack.write(previewPath, html);
+      jetpack.write(path.join(runDir, 'newsletter.md'), markdown);
+      if (structure.summary) {
+        jetpack.write(path.join(runDir, 'summary.md'), structure.summary + '\n');
+      }
       jetpack.write(path.join(runDir, 'newsletter.mjml'), mjml || '');
       jetpack.write(path.join(runDir, 'structure.json'), JSON.stringify(structure, null, 2));
       jetpack.write(path.join(runDir, 'metadata.json'), JSON.stringify({
@@ -246,6 +283,7 @@ module.exports = {
         reusedFrom: path.basename(sourceRun),
         template: templateName,
         renderMs,
+        tags: structure.tags || [],
         timestamp: new Date().toISOString(),
       }, null, 2));
 
@@ -316,22 +354,20 @@ module.exports = {
     // Track claimed IDs for later --release-all
     appendClaimed(claimedFile, sources.map((s) => s.id));
 
-    // --- Build a stub Manager + assistant to call the BEM generator library ---
-    // Newsletter config nests under beehiiv. Force `beehiiv.enabled: true` because
-    // the iteration test IS the explicit trigger — we're not checking whether
-    // beehiiv is configured for prod use, we're driving the generator directly.
-    const Manager = buildManagerStub({
-      ...config,
-      marketing: {
-        ...config.marketing,
-        beehiiv: {
-          ...(config.marketing?.beehiiv || {}),
-          enabled: true,
-          content: newsletterConfig,
-        },
+    // Force `beehiiv.enabled: true` and inject the per-run newsletter config
+    // overrides onto Manager.config. The iteration test IS the explicit trigger
+    // — we're not checking whether beehiiv is configured for prod use, we're
+    // driving the generator directly. Mutating Manager.config is fine here
+    // because this is a `type: 'standalone'` test (one test per process — no
+    // cross-test config leakage).
+    Manager.config.marketing = {
+      ...(Manager.config.marketing || {}),
+      beehiiv: {
+        ...(Manager.config.marketing?.beehiiv || {}),
+        enabled: true,
+        content: newsletterConfig,
       },
-    });
-    const assistant = buildAssistantStub(Manager);
+    };
 
     // --- Run the production generator with the local-persist image hook ---
     const generator = require('../../src/manager/libraries/email/generators/newsletter.js');
@@ -380,14 +416,23 @@ module.exports = {
 
     assert.ok(result, 'Generator returned a result');
     assert.ok(result.contentHtml, 'Generator returned contentHtml');
+    assert.ok(result.contentMarkdown, 'Generator returned contentMarkdown');
     assert.ok(result.structure?.sections?.length >= 2, 'Has at least 2 sections');
 
     // --- Write outputs ---
     const previewPath = path.join(runDir, 'newsletter.html');
     jetpack.write(previewPath, result.contentHtml);
+    jetpack.write(path.join(runDir, 'newsletter.md'), result.contentMarkdown);
+    if (result.summary) {
+      jetpack.write(path.join(runDir, 'summary.md'), result.summary + '\n');
+    }
     jetpack.write(path.join(runDir, 'structure.json'), JSON.stringify(result.structure, null, 2));
     jetpack.write(path.join(runDir, 'newsletter.mjml'), result.mjml || '');
-    jetpack.write(path.join(runDir, 'metadata.json'), JSON.stringify(result.meta || {}, null, 2));
+    jetpack.write(path.join(runDir, 'metadata.json'), JSON.stringify({
+      ...(result.meta || {}),
+      tags: result.tags || [],
+      assets: result.assets || null,
+    }, null, 2));
 
     console.log(`\nNewsletter preview written: ${previewPath}`);
     console.log(`Subject:   ${result.subject}`);
@@ -698,34 +743,3 @@ async function releaseAll(claimedFile) {
   return released;
 }
 
-/**
- * Minimal Manager stub for tests. Provides what newsletter.js + lib/* read:
- *   Manager.config         — full config (used for brand, marketing.beehiiv.content, parent)
- *   Manager.AI(assistant)  — instantiates the unified AI library
- */
-function buildManagerStub(config) {
-  return {
-    config,
-    libraries: {},
-    AI(assistant) {
-      const AI = require('../../src/manager/libraries/ai/index.js');
-      return new AI(assistant);
-    },
-  };
-}
-
-function buildAssistantStub(Manager) {
-  return {
-    Manager,
-    user: null,
-    request: { geolocation: { ip: 'local' } },
-    log: (...args) => console.log('[ASSIST]', ...args),
-    error: (...args) => console.error('[ASSIST ERROR]', ...args),
-    getUser: () => null,
-    errorify: (msg, opts) => {
-      const err = new Error(typeof msg === 'string' ? msg : String(msg));
-      if (opts) Object.assign(err, opts);
-      return err;
-    },
-  };
-}

package/test/marketing/newsletter-templates.js

@@ -48,19 +48,16 @@ const CLASSIC_STRUCTURE = {
     {
       title: 'Section one',
       body: 'First section body. Identity matters because trust is the new growth lever. Teams that handle this well will spend less time cleaning up later.',
-      cta: { label: 'Learn more', url: 'https://testco.example/one' },
       image_prompt: 'abstract illustration',
     },
     {
       title: 'Section two',
       body: 'Second section body. The practical takeaway is straightforward: keep your account hygiene tight and document your processes.',
-      cta: { label: 'Take action', url: 'https://testco.example/two' },
       image_prompt: 'abstract illustration',
     },
     {
       title: 'Section three',
-      body: 'Third section body. This one has no CTA on purpose — to verify that templates handle missing CTAs gracefully.',
-      cta: null,
+      body: 'Third section body. Self-contained, no outbound links.',
       image_prompt: 'abstract illustration',
     },
   ],
@@ -84,7 +81,6 @@ const FIELD_REPORT_STRUCTURE = {
         { label: 'USERS REACHED', value: '12.4K' },
         { label: 'WoW GROWTH',    value: '+38%' },
       ],
-      cta: { label: 'READ THE BRIEF', url: 'https://testco.example/one' },
       image_prompt: 'abstract illustration',
     },
     {
@@ -95,18 +91,16 @@ const FIELD_REPORT_STRUCTURE = {
       lede: 'The accounts that survive the next platform sweep are the ones with paper trails.',
       dispatch: 'Account hygiene is now a documentation problem, not a tooling problem. Save your processes. The teams already running on documented playbooks are ahead.',
       dataPoints: [],
-      cta: { label: 'SEE THE PLAYBOOK', url: 'https://testco.example/two' },
       image_prompt: 'abstract illustration',
     },
     {
       kicker: 'WATCH',
-      headline: 'A third dispatch with no CTA',
+      headline: 'A third dispatch',
       byline: 'Filed by The TestCo signals desk',
       location: 'NEW YORK',
-      lede: 'Some filings just observe — no call to action attached.',
-      dispatch: 'This one has no CTA on purpose, to verify the template handles missing CTAs gracefully.',
+      lede: 'Some filings just observe.',
+      dispatch: 'Self-contained dispatch, no outbound links.',
       dataPoints: [{ label: 'OBSERVATIONS', value: '3' }],
-      cta: null,
       image_prompt: 'abstract illustration',
     },
   ],
@@ -253,21 +247,6 @@ module.exports = {
         }
       },
     },
-    {
-      name: 'CTAs render only when both label+url present',
-      async run({ assert }) {
-        // Classic templates use section CTAs; Field Report uses dispatch CTAs.
-        // Either way the fixture has 2 CTAs in items 1-2 and null in item 3.
-        for (const templateName of ['clean', 'editorial']) {
-          const result = await render(templateName);
-          assert.ok(result.html.includes('Learn more'),  `${templateName}: section 1 CTA renders`);
-          assert.ok(result.html.includes('Take action'), `${templateName}: section 2 CTA renders`);
-        }
-        const fr = await render('field-report');
-        assert.ok(fr.html.includes('READ THE BRIEF'),   `field-report: dispatch 1 CTA renders`);
-        assert.ok(fr.html.includes('SEE THE PLAYBOOK'), `field-report: dispatch 2 CTA renders`);
-      },
-    },
     {
       name: 'signoff renders without dramatic dark-block treatment',
       async run({ assert }) {
@@ -384,35 +363,35 @@ module.exports = {
     {
       name: 'gracefully omits missing optional fields without breaking the template',
       async run({ assert }) {
-        // Classic templates — missing intro, missing one section body, missing all CTAs.
+        // Classic templates — missing intro, missing one section body.
         for (const templateName of ['clean', 'editorial']) {
           const partial = {
             ...CLASSIC_STRUCTURE,
             intro: '',
             sections: [
-              { title: 'Has body', body: 'Body text here.', cta: null, image_prompt: '' },
-              { title: 'No body',  body: '',                cta: null, image_prompt: '' },
-              { title: 'Has CTA',  body: 'Body.',           cta: { label: 'Go', url: 'https://testco.example/go' }, image_prompt: '' },
+              { title: 'Has body', body: 'Body text here.', image_prompt: '' },
+              { title: 'No body',  body: '',                image_prompt: '' },
+              { title: 'Has third', body: 'Body.',          image_prompt: '' },
             ],
           };
           const result = await render(templateName, partial);
           assert.equal(result.errors.length, 0, `${templateName}: partial sections produce no MJML errors`);
           assert.ok(result.html.includes('Has body'), `${templateName}: section with body renders`);
           assert.ok(result.html.includes('No body'),  `${templateName}: section with empty body renders title`);
-          assert.ok(result.html.includes('Go'),       `${templateName}: third-section CTA still renders`);
+          assert.ok(result.html.includes('Has third'), `${templateName}: third section title renders`);
         }
 
-        // Field Report — missing tldr, missing one dispatch body+lede, missing dataPoints + CTAs.
+        // Field Report — missing tldr, missing one dispatch body+lede, missing dataPoints.
         const fr = await render('field-report', {
           tldr: '',
           dispatches: [
             {
               kicker: 'DISPATCH', headline: 'Only headline + body', byline: 'Filed by desk',
-              location: 'REMOTE', lede: '', dispatch: 'Some body text.', dataPoints: [], cta: null, image_prompt: '',
+              location: 'REMOTE', lede: '', dispatch: 'Some body text.', dataPoints: [], image_prompt: '',
             },
             {
               kicker: 'WATCH', headline: 'Just data, no body', byline: 'Filed by desk',
-              location: 'REMOTE', lede: '', dispatch: '', dataPoints: [{ label: 'STAT', value: '99%' }], cta: null, image_prompt: '',
+              location: 'REMOTE', lede: '', dispatch: '', dataPoints: [{ label: 'STAT', value: '99%' }], image_prompt: '',
             },
           ],
         });

package/test/routes/admin/create-post.js

@@ -142,11 +142,11 @@ module.exports = {
 
         assert.isSuccess(response, 'Create post should succeed');
         assert.hasProperty(response, 'data.id', 'Response should have post id');
-        assert.hasProperty(response, 'data.path', 'Response should have post path');
+        assert.hasProperty(response, 'data.path', 'Response should have post file path');
 
         // Store for cleanup
         state.postId = response.data.id;
-        state.postPath = `${response.data.path}/${response.data.date}-bem-test-create-post.md`;
+        state.postPath = response.data.path;
       },
     },