backend-manager 5.0.65 → 5.0.67

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.0.65",
+  "version": "5.0.67",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "bin": {

package/src/cli/commands/setup-tests/emulators-config.js

@@ -11,7 +11,7 @@ const DEFAULT_EMULATOR_PORTS = {
   hosting: 5002,
   storage: 9199,
   pubsub: 8085,
-  ui: 4000,
+  ui: 4050,
 };
 
 const REQUIRED_EMULATORS = {
@@ -22,7 +22,7 @@ const REQUIRED_EMULATORS = {
   hosting: { port: DEFAULT_EMULATOR_PORTS.hosting },
   storage: { port: DEFAULT_EMULATOR_PORTS.storage },
   pubsub: { port: DEFAULT_EMULATOR_PORTS.pubsub },
-  ui: { enabled: true },
+  ui: { enabled: true, port: DEFAULT_EMULATOR_PORTS.ui },
 };
 
 class EmulatorsConfigTest extends BaseTest {

package/src/cli/commands/setup-tests/index.js

@@ -14,7 +14,7 @@ const FirebaseFunctionsTest = require('./firebase-functions');
 const BackendManagerTest = require('./backend-manager');
 const NpmProjectScriptsTest = require('./npm-project-scripts');
 const BemConfigTest = require('./bem-config');
-const BemConfigIdTest = require('./bem-config-id');
+const ProjectIdConsistencyTest = require('./project-id-consistency');
 const ServiceAccountTest = require('./service-account');
 const GitignoreTest = require('./gitignore');
 const EnvFileTest = require('./env-file');
@@ -54,8 +54,8 @@ function getTests(context) {
     new BackendManagerTest(context),
     new NpmProjectScriptsTest(context),
     new BemConfigTest(context),
-    new BemConfigIdTest(context),
     new ServiceAccountTest(context),
+    new ProjectIdConsistencyTest(context),
     new GitignoreTest(context),
     new EnvFileTest(context),
     new EnvRuntimeConfigDeprecatedTest(context),

package/src/cli/commands/setup-tests/project-id-consistency.js

@@ -0,0 +1,161 @@
+const BaseTest = require('./base-test');
+const jetpack = require('fs-jetpack');
+const JSON5 = require('json5');
+const chalk = require('chalk');
+
+/**
+ * Ensures projectId is consistent across all configuration files:
+ * - .firebaserc (projects.default)
+ * - functions/backend-manager-config.json (firebaseConfig.projectId)
+ * - functions/service-account.json (project_id)
+ *
+ * Mismatches cause tests to fail when running emulators in separate terminals
+ * because different parts of the system connect to different Firestore databases.
+ */
+class ProjectIdConsistencyTest extends BaseTest {
+  getName() {
+    return 'project IDs are consistent across all config files';
+  }
+
+  async run() {
+    const sources = this.getProjectIdSources();
+
+    // Check if we have at least .firebaserc (the source of truth)
+    if (!sources.firebaserc.exists) {
+      console.error(chalk.red('Missing .firebaserc file'));
+      return false;
+    }
+
+    if (!sources.firebaserc.projectId) {
+      console.error(chalk.red('Missing projects.default in .firebaserc'));
+      return false;
+    }
+
+    const expectedProjectId = sources.firebaserc.projectId;
+    const mismatches = [];
+
+    // Check backend-manager-config.json
+    if (sources.bemConfig.exists) {
+      if (!sources.bemConfig.projectId) {
+        mismatches.push({
+          file: 'backend-manager-config.json',
+          field: 'firebaseConfig.projectId',
+          expected: expectedProjectId,
+          actual: '(missing)',
+        });
+      } else if (sources.bemConfig.projectId !== expectedProjectId) {
+        mismatches.push({
+          file: 'backend-manager-config.json',
+          field: 'firebaseConfig.projectId',
+          expected: expectedProjectId,
+          actual: sources.bemConfig.projectId,
+        });
+      }
+    }
+
+    // Check service-account.json
+    if (sources.serviceAccount.exists) {
+      if (!sources.serviceAccount.projectId) {
+        mismatches.push({
+          file: 'service-account.json',
+          field: 'project_id',
+          expected: expectedProjectId,
+          actual: '(missing)',
+        });
+      } else if (sources.serviceAccount.projectId !== expectedProjectId) {
+        mismatches.push({
+          file: 'service-account.json',
+          field: 'project_id',
+          expected: expectedProjectId,
+          actual: sources.serviceAccount.projectId,
+        });
+      }
+    }
+
+    if (mismatches.length > 0) {
+      console.error(chalk.red('\nProject ID mismatches detected:'));
+      console.error(chalk.gray(`  Source of truth: .firebaserc → ${expectedProjectId}\n`));
+
+      for (const mismatch of mismatches) {
+        console.error(chalk.red(`  ${mismatch.file} (${mismatch.field})`));
+        console.error(chalk.gray(`    Expected: ${mismatch.expected}`));
+        console.error(chalk.gray(`    Actual:   ${mismatch.actual}\n`));
+      }
+
+      return false;
+    }
+
+    return true;
+  }
+
+  getProjectIdSources() {
+    const projectPath = this.self.firebaseProjectPath;
+
+    // .firebaserc
+    const firebasercPath = `${projectPath}/.firebaserc`;
+    const firebasercContent = jetpack.read(firebasercPath);
+    const firebasercData = firebasercContent ? JSON5.parse(firebasercContent) : null;
+
+    // backend-manager-config.json
+    const bemConfigPath = `${projectPath}/functions/backend-manager-config.json`;
+    const bemConfigContent = jetpack.read(bemConfigPath);
+    const bemConfigData = bemConfigContent ? JSON5.parse(bemConfigContent) : null;
+
+    // service-account.json
+    const serviceAccountPath = `${projectPath}/functions/service-account.json`;
+    const serviceAccountContent = jetpack.read(serviceAccountPath);
+    const serviceAccountData = serviceAccountContent ? JSON5.parse(serviceAccountContent) : null;
+
+    return {
+      firebaserc: {
+        exists: !!firebasercContent,
+        projectId: firebasercData?.projects?.default || null,
+      },
+      bemConfig: {
+        exists: !!bemConfigContent,
+        projectId: bemConfigData?.firebaseConfig?.projectId || null,
+      },
+      serviceAccount: {
+        exists: !!serviceAccountContent,
+        projectId: serviceAccountData?.project_id || null,
+      },
+    };
+  }
+
+  async fix() {
+    const sources = this.getProjectIdSources();
+
+    if (!sources.firebaserc.projectId) {
+      console.log(chalk.red('Cannot fix: .firebaserc is missing or has no projects.default'));
+      console.log(chalk.yellow('Run: firebase use --add'));
+      throw new Error('Missing .firebaserc configuration');
+    }
+
+    const expectedProjectId = sources.firebaserc.projectId;
+
+    // Fix backend-manager-config.json
+    if (sources.bemConfig.exists && sources.bemConfig.projectId !== expectedProjectId) {
+      const bemConfigPath = `${this.self.firebaseProjectPath}/functions/backend-manager-config.json`;
+      const bemConfigContent = jetpack.read(bemConfigPath);
+      const bemConfigData = JSON5.parse(bemConfigContent);
+
+      bemConfigData.firebaseConfig = bemConfigData.firebaseConfig || {};
+      bemConfigData.firebaseConfig.projectId = expectedProjectId;
+
+      jetpack.write(bemConfigPath, JSON.stringify(bemConfigData, null, 2));
+      console.log(chalk.green(`Fixed: backend-manager-config.json → firebaseConfig.projectId = ${expectedProjectId}`));
+    }
+
+    // Cannot auto-fix service-account.json - must download correct one from Firebase Console
+    if (sources.serviceAccount.exists && sources.serviceAccount.projectId !== expectedProjectId) {
+      console.log(chalk.red(`\nCannot auto-fix service-account.json`));
+      console.log(chalk.yellow(`  Current project_id: ${sources.serviceAccount.projectId}`));
+      console.log(chalk.yellow(`  Expected project_id: ${expectedProjectId}`));
+      console.log(chalk.yellow(`\n  Download the correct service account from:`));
+      console.log(chalk.cyan(`  https://console.firebase.google.com/project/${expectedProjectId}/settings/serviceaccounts/adminsdk`));
+      throw new Error('service-account.json has wrong project_id - download correct one from Firebase Console');
+    }
+  }
+}
+
+module.exports = ProjectIdConsistencyTest;

package/src/cli/commands/setup-tests/service-account.js

@@ -1,6 +1,5 @@
 const BaseTest = require('./base-test');
 const jetpack = require('fs-jetpack');
-const JSON5 = require('json5');
 const chalk = require('chalk');
 
 class ServiceAccountTest extends BaseTest {
@@ -9,7 +8,7 @@ class ServiceAccountTest extends BaseTest {
   }
 
   async run() {
-    let serviceAccount = jetpack.read(`${this.self.firebaseProjectPath}/functions/service-account.json`);
+    const serviceAccount = jetpack.read(`${this.self.firebaseProjectPath}/functions/service-account.json`);
 
     // Make sure the service account exists
     if (!serviceAccount) {
@@ -17,15 +16,6 @@ class ServiceAccountTest extends BaseTest {
       return false;
     }
 
-    // Parse the service account
-    serviceAccount = JSON5.parse(serviceAccount);
-
-    // Check if project_id matches the project's ID
-    if (this.self.projectId !== serviceAccount.project_id) {
-      console.error(chalk.red('Mismatch between project name and service account project_id'));
-      return false;
-    }
-
     return true;
   }
 

package/src/manager/events/auth/on-create.js

@@ -63,10 +63,10 @@ module.exports = async ({ Manager, assistant, user, context, libraries }) => {
       // Create user doc
       batch.set(admin.firestore().doc(`users/${user.uid}`), userRecord);
 
-      // Increment user count
-      batch.update(admin.firestore().doc('meta/stats'), {
+      // Increment user count (use set+merge so doc is created if missing)
+      batch.set(admin.firestore().doc('meta/stats'), {
         'users.total': FieldValue.increment(1),
-      });
+      }, { merge: true });
 
       await batch.commit();
     }, MAX_RETRIES, RETRY_DELAY_MS);

package/src/manager/events/auth/on-delete.js

@@ -41,10 +41,10 @@ module.exports = async ({ Manager, assistant, user, context, libraries }) => {
       // Delete user doc
       batch.delete(admin.firestore().doc(`users/${user.uid}`));
 
-      // Decrement user count
-      batch.update(admin.firestore().doc('meta/stats'), {
+      // Decrement user count (use set+merge so doc is created if missing)
+      batch.set(admin.firestore().doc('meta/stats'), {
         'users.total': FieldValue.increment(-1),
-      });
+      }, { merge: true });
 
       await batch.commit();
     }, MAX_RETRIES, RETRY_DELAY_MS);

package/src/manager/events/firestore/notifications/on-write.js

@@ -35,9 +35,9 @@ module.exports = async ({ Manager, assistant, change, context, libraries }) => {
   // Delete event
   if (eventType === 'delete') {
     await admin.firestore().doc('meta/stats')
-      .update({
+      .set({
         'notifications.total': FieldValue.increment(-1),
-      });
+      }, { merge: true });
 
     Manager.Analytics({
       assistant: assistant,
@@ -60,9 +60,9 @@ module.exports = async ({ Manager, assistant, change, context, libraries }) => {
   // Create event
   if (eventType === 'create') {
     await admin.firestore().doc('meta/stats')
-      .update({
+      .set({
         'notifications.total': FieldValue.increment(1),
-      });
+      }, { merge: true });
 
     Manager.Analytics({
       assistant: assistant,

package/src/manager/functions/core/actions/api/admin/sync-users.js

@@ -93,11 +93,11 @@ Module.prototype.main = function () {
             // Save to database only if there is a page token
             if (batch.pageToken) {
               await self.libraries.admin.firestore().doc(`meta/stats`)
-                .update({
+                .set({
                   syncUsers: {
                     lastPageToken: batch.pageToken,
                   }
-                })
+                }, { merge: true })
                 .then(r => {
                   assistant.log(`Saved lastPageToken: ${batch.pageToken}`);
                 })

package/src/manager/helpers/middleware.js

@@ -184,8 +184,8 @@ Middleware.prototype.run = function (libPath, options) {
 
     // Build context object for route handler
     const context = {
-      assistant: assistant,
       Manager: Manager,
+      assistant: assistant,
       user: assistant.getUser(),
       usage: assistant.usage,
       settings: assistant.settings,

package/src/manager/routes/admin/users/sync/post.js

@@ -94,11 +94,11 @@ module.exports = async ({ assistant, Manager, user, settings, analytics, librari
       // Save pageToken for resume
       if (batch.pageToken) {
         await admin.firestore().doc('meta/stats')
-          .update({
+          .set({
             syncUsers: {
               lastPageToken: batch.pageToken,
             }
-          })
+          }, { merge: true })
           .then(() => {
             assistant.log(`Saved lastPageToken: ${batch.pageToken}`);
           })

package/src/test/run-tests.js

@@ -25,7 +25,7 @@ async function main() {
       // When running in emulator, we can initialize without credentials
       // The emulator environment variables tell it where to connect
       firebaseAdmin.initializeApp({
-        projectId: process.env.GCLOUD_PROJECT || testConfig.appId,
+        projectId: process.env.GCLOUD_PROJECT || testConfig.projectId,
       });
     }
     admin = firebaseAdmin;

package/src/cli/commands/setup-tests/bem-config-id.js

@@ -1,25 +0,0 @@
-const BaseTest = require('./base-test');
-const chalk = require('chalk');
-
-class BemConfigIdTest extends BaseTest {
-  getName() {
-    return 'has correct ID in backend-manager-config.json';
-  }
-
-  async run() {
-    // Check if the project name matches the projectId
-    if (this.self.projectId !== this.self.bemConfigJSON?.firebaseConfig?.projectId) {
-      console.error(chalk.red('Mismatch between project name and firebaseConfig.projectId in backend-manager-config.json'));
-      return false;
-    }
-
-    // Return pass
-    return true;
-  }
-
-  async fix() {
-    throw new Error('No automatic fix available for this test');
-  }
-}
-
-module.exports = BemConfigIdTest;