backend-manager 5.0.167 → 5.0.169

package/CHANGELOG.md

@@ -14,6 +14,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - `Fixed` for any bug fixes.
 - `Security` in case of vulnerabilities.
 
+# [5.0.168] - 2026-03-21
+### Fixed
+- Immediately suspend subscription on payment denial (PAYMENT.SALE.DENIED, invoice.payment_failed) instead of waiting for the processor to give up retrying — recovery via PAYMENT.SALE.COMPLETED restores active status
+
 # [5.0.167] - 2026-03-20
 ### Changed
 - Extracted `resolveTemperature()` helper for consistency with `resolveFormatting()` and `resolveReasoning()`

package/TODO-2.md

@@ -10,6 +10,24 @@ payments/reactivate
 payments/upgrade
   * takes a subscription id and a new plan id and upgrades the user's subscription to the new plan. this can only be done if the user has an active subscription.
 
+
+-------
+USER OBJECT UPDGRADE --> INSTANCE?
+
+const User = require('backend-manager/src/manager/helpers/user');
++
+User.resolveSubscription(self.request.user);
+-->
+one object that cna do resolveSubscription(), getAccount(), etc
+
+since you changed some things, do all tests in all projects align still?
+
+after that, udpate README, CLAUDE.md and ANY TOPLEVLE CLAUDE SKILLS so that we never make this mistake again
+
+including
+
+---------
+
 TEST NEWSLETTER
 POST /admin/cron { id: 'daily/marketing-newsletter-generate' }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.0.167",
+  "version": "5.0.169",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "bin": {

package/src/manager/cron/frequent/abandoned-carts.js

@@ -1,5 +1,6 @@
 const powertools = require('node-powertools');
 const { REMINDER_DELAYS, COLLECTION } = require('../../libraries/abandoned-cart-config.js');
+const User = require('../../helpers/user.js');
 
 /**
  * Abandoned cart reminder cron job
@@ -49,8 +50,7 @@ module.exports = async ({ Manager, assistant, context, libraries }) => {
       const userDoc = userSnap.data();
 
       // Belt-and-suspenders: skip if user already has active paid subscription
-      if (userDoc.subscription?.status === 'active'
-        && userDoc.subscription?.product?.id !== 'basic') {
+      if (User.resolveSubscription(userDoc).active) {
         assistant.log(`User ${uid} now has active subscription, marking cart completed`);
         await markCompleted(doc, admin, nowUNIX);
         skipped++;

package/src/manager/events/firestore/payments-webhooks/on-write.js

@@ -218,6 +218,16 @@ async function processPaymentEvent({ category, library, resource, resourceType,
     ? library.toUnifiedSubscription(resource, transformOptions)
     : library.toUnifiedOneTime(resource, transformOptions);
 
+  // Override: immediately suspend on payment denial
+  // Processors keep the sub active while retrying, but we revoke access right away.
+  // If the retry succeeds (e.g. PAYMENT.SALE.COMPLETED), it will restore active status.
+  // PayPal: PAYMENT.SALE.DENIED, Stripe: invoice.payment_failed, Chargebee: payment_failed
+  const PAYMENT_DENIED_EVENTS = ['PAYMENT.SALE.DENIED', 'invoice.payment_failed', 'payment_failed'];
+  if (isSubscription && PAYMENT_DENIED_EVENTS.includes(eventType) && unified.status === 'active') {
+    assistant.log(`Overriding status to suspended: ${eventType} received but provider still says active`);
+    unified.status = 'suspended';
+  }
+
   assistant.log(`Unified ${category}: product=${unified.product.id}, status=${unified.status}`, unified);
 
   // Read checkout context from payments-intents (attribution, discount, supplemental)

package/src/manager/helpers/middleware.js

@@ -7,6 +7,7 @@ const path = require('path');
 const powertools = require('node-powertools');
 const { merge } = require('lodash');
 const JSON5 = require('json5');
+const User = require('./user.js');
 
 function Middleware(m, req, res) {
   const self = this;
@@ -126,7 +127,8 @@ Middleware.prototype.run = function (libPath, options) {
 
     // Log working user
     const workingUser = assistant.getUser();
-    assistant.log(`Middleware.process(): User (${workingUser.auth.uid}, ${workingUser.auth.email}, ${workingUser.subscription.product.id}=${workingUser.subscription.status}):`, safeStringify(workingUser));
+    const resolvedSub = User.resolveSubscription(workingUser);
+    assistant.log(`Middleware.process(): User (${workingUser.auth.uid}, ${workingUser.auth.email}, ${workingUser.subscription.product.id}=${workingUser.subscription.status} (resolved: ${resolvedSub.plan})):`, safeStringify(workingUser));
 
     // Setup analytics
     if (options.setupAnalytics) {

package/src/manager/helpers/usage.js

@@ -8,6 +8,7 @@
 const moment = require('moment');
 const _ = require('lodash');
 const hcaptcha = require('hcaptcha');
+const User = require('./user.js');
 
 function Usage(m) {
   const self = this;
@@ -319,8 +320,8 @@ Usage.prototype.getProduct = function (id) {
 
   const products = Manager.config.payment?.products || [];
 
-  // Look up by provided ID, or fall back to user's subscription product
-  id = id || self.user.subscription.product.id;
+  // Look up by provided ID, or fall back to user's resolved plan
+  id = id || User.resolveSubscription(self.user).plan;
 
   return products.find(p => p.id === id)
     || products.find(p => p.id === 'basic')