backend-manager 5.0.147 → 5.0.149

package/test/helpers/user.js

@@ -410,7 +410,7 @@ module.exports = {
         const user = createUser({});
         const expectedKeys = [
           'auth', 'subscription', 'roles', 'flags', 'affiliate',
-          'activity', 'api', 'usage', 'personal', 'oauth2', 'attribution',
+          'activity', 'api', 'usage', 'personal', 'oauth2', 'attribution', 'metadata',
         ];
 
         for (const key of expectedKeys) {
@@ -425,7 +425,7 @@ module.exports = {
         const user = createUser({});
         const expectedKeys = [
           'auth', 'subscription', 'roles', 'flags', 'affiliate',
-          'activity', 'api', 'usage', 'personal', 'oauth2', 'attribution',
+          'activity', 'api', 'usage', 'personal', 'oauth2', 'attribution', 'metadata',
         ];
 
         for (const key of Object.keys(user)) {

package/test/routes/admin/create-post.js

@@ -113,13 +113,13 @@ module.exports = {
           return;
         }
 
-        if (!config.githubRepoWebsite) {
+        if (!config.github?.repo_website) {
           assert.fail('githubRepoWebsite not configured');
           return;
         }
 
         // Parse owner/repo for cleanup later
-        const repoMatch = config.githubRepoWebsite.match(/github\.com\/([^/]+)\/([^/]+)/);
+        const repoMatch = config.github?.repo_website.match(/github\.com\/([^/]+)\/([^/]+)/);
         if (!repoMatch) {
           assert.fail('Could not parse githubRepoWebsite');
           return;

package/test/routes/admin/post.js

@@ -115,7 +115,7 @@ module.exports = {
       skip: !process.env.GITHUB_TOKEN ? 'GITHUB_TOKEN env var not set' : false,
 
       async run({ assert, state, config }) {
-        if (!config.githubRepoWebsite) {
+        if (!config.github?.repo_website) {
           assert.fail('githubRepoWebsite not configured');
           return;
         }
@@ -123,7 +123,7 @@ module.exports = {
         const octokit = new Octokit({ auth: process.env.GITHUB_TOKEN });
 
         // Parse owner/repo from githubRepoWebsite
-        const repoMatch = config.githubRepoWebsite.match(/github\.com\/([^/]+)\/([^/]+)/);
+        const repoMatch = config.github?.repo_website.match(/github\.com\/([^/]+)\/([^/]+)/);
         if (!repoMatch) {
           assert.fail('Could not parse githubRepoWebsite');
           return;

package/test/routes/admin/repo-content.js

@@ -155,14 +155,14 @@ module.exports = {
       timeout: 60000,
 
       async run({ state, config }) {
-        if (!process.env.GITHUB_TOKEN || !config.githubRepoWebsite) {
+        if (!process.env.GITHUB_TOKEN || !config.github?.repo_website) {
           return;
         }
 
         const octokit = new Octokit({ auth: process.env.GITHUB_TOKEN });
 
         // Parse owner/repo from githubRepoWebsite (e.g., 'https://github.com/owner/repo')
-        const repoMatch = config.githubRepoWebsite.match(/github\.com\/([^/]+)\/([^/]+)/);
+        const repoMatch = config.github?.repo_website.match(/github\.com\/([^/]+)\/([^/]+)/);
         if (!repoMatch) {
           return;
         }

package/test/routes/marketing/contact.js

@@ -245,9 +245,9 @@ module.exports = {
       },
     },
 
-    // Test 8: ZeroBounce validation (only runs if TEST_EXTENDED_MODE and ZEROBOUNCE_API_KEY are set)
+    // Test 8: Mailbox verification (only runs if TEST_EXTENDED_MODE and ZEROBOUNCE_API_KEY are set)
     {
-      name: 'add-zerobounce-validation',
+      name: 'add-mailbox-validation',
       auth: 'admin',
       timeout: 30000,
       skip: !process.env.TEST_EXTENDED_MODE || !process.env.ZEROBOUNCE_API_KEY
@@ -261,7 +261,6 @@ module.exports = {
         const response = await http.post('marketing/contact', {
           email: testEmail,
           source: 'bem-test',
-          // No firstName/lastName - should be inferred as "Rachel Greene"
         });
 
         assert.isSuccess(response, 'Add marketing contact should succeed');
@@ -270,17 +269,17 @@ module.exports = {
         assert.hasProperty(response, 'data.validation', 'Response should contain validation');
         assert.hasProperty(response, 'data.validation.checks', 'Validation should contain checks');
 
-        // ZeroBounce should be in checks when key is set
-        assert.hasProperty(response, 'data.validation.checks.zerobounce', 'Should have ZeroBounce check');
+        // Mailbox check should be in checks when key is set
+        assert.hasProperty(response, 'data.validation.checks.mailbox', 'Should have mailbox check');
 
-        const zbResult = response.data.validation.checks.zerobounce;
+        const mbResult = response.data.validation.checks.mailbox;
 
-        // If ZeroBounce is out of credits, skip test - not a failure
-        if (zbResult.error?.includes('out of credits')) {
-          skip('ZeroBounce out of credits');
+        // If out of credits, skip test - not a failure
+        if (mbResult.error?.includes('out of credits')) {
+          skip('Mailbox verification out of credits');
         }
 
-        assert.hasProperty(zbResult, 'status', 'ZeroBounce should return status');
+        assert.hasProperty(mbResult, 'status', 'Mailbox check should return status');
 
         state.sendgridAdded = response.data?.providers?.sendgrid?.success;
         state.beehiivAdded = response.data?.providers?.beehiiv?.success;
@@ -295,9 +294,9 @@ module.exports = {
       },
     },
 
-    // Test 9: ZeroBounce rejects invalid email (only runs if TEST_EXTENDED_MODE and ZEROBOUNCE_API_KEY are set)
+    // Test 9: Mailbox verification rejects invalid email (only runs if TEST_EXTENDED_MODE and ZEROBOUNCE_API_KEY are set)
     {
-      name: 'add-zerobounce-rejects-invalid',
+      name: 'add-mailbox-rejects-invalid',
       auth: 'admin',
       timeout: 30000,
       skip: !process.env.TEST_EXTENDED_MODE || !process.env.ZEROBOUNCE_API_KEY
@@ -305,30 +304,28 @@ module.exports = {
         : false,
 
       async run({ http, assert, skip }) {
-        // Use fake email that ZeroBounce should flag as invalid
+        // Use fake email that mailbox verification should flag as invalid
         const testEmail = TEST_EMAILS.invalid();
 
         const response = await http.post('marketing/contact', {
           email: testEmail,
           source: 'bem-test',
-          // No firstName/lastName - AI will try to infer from "test"
         });
 
-        // Should still succeed (we fail open) but ZeroBounce should report invalid
+        // Should still succeed (we fail open) but mailbox should report invalid
         assert.isSuccess(response, 'Request should succeed even with invalid email');
 
-        const zbResult = response.data?.validation?.checks?.zerobounce;
+        const mbResult = response.data?.validation?.checks?.mailbox;
 
-        // If ZeroBounce is out of credits, skip test - not a failure
-        if (zbResult?.error?.includes('out of credits')) {
-          skip('ZeroBounce out of credits');
+        // If out of credits, skip test - not a failure
+        if (mbResult?.error?.includes('out of credits')) {
+          skip('Mailbox verification out of credits');
         }
 
-        // ZeroBounce should return a status indicating the email is not valid
-        if (zbResult) {
-          assert.hasProperty(zbResult, 'status', 'Should have status');
-          // Status should NOT be 'valid' for this fake email
-          assert.notEqual(zbResult.status, 'valid', 'Fake email should not be marked valid');
+        // Mailbox should return a status indicating the email is not valid
+        if (mbResult) {
+          assert.hasProperty(mbResult, 'status', 'Should have status');
+          assert.notEqual(mbResult.status, 'valid', 'Fake email should not be marked valid');
         }
       },
     },

package/test/routes/payments/cancel.js

@@ -66,6 +66,18 @@ module.exports = {
       },
     },
 
+    {
+      name: 'rejects-subscription-younger-than-24-hours',
+      async run({ http, assert }) {
+        // cancel-too-young starts with startDate set to now (< 24 hours old)
+        const response = await http.as('cancel-too-young').post('payments/cancel', {
+          confirmed: true,
+        });
+
+        assert.isError(response, 400, 'Should reject subscription younger than 24 hours');
+      },
+    },
+
     {
       name: 'rejects-unknown-processor',
       async run({ http, assert }) {
@@ -101,6 +113,12 @@ module.exports = {
             && userDoc?.subscription?.status === 'active';
         }, 15000, 500);
 
+        // Backdate startDate so the 24-hour guard doesn't block cancellation
+        const twoDaysAgo = new Date(Date.now() - 2 * 24 * 60 * 60 * 1000);
+        await firestore.set(`users/${uid}`, {
+          subscription: { payment: { startDate: { timestamp: twoDaysAgo.toISOString(), timestampUNIX: twoDaysAgo.getTime() } } },
+        }, { merge: true });
+
         // Step 2: Call the cancel endpoint
         const cancelResponse = await http.as('route-cancel-success').post('payments/cancel', {
           confirmed: true,