backend-manager 5.0.114 → 5.0.116

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.0.114",
+  "version": "5.0.116",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "bin": {

package/src/cli/commands/logs.js

@@ -56,11 +56,11 @@ class LogsCommand extends BaseCommand {
 
   /**
    * Fetch historical logs.
-   * Usage: npx bm logs:read [--fn bm_api] [--severity ERROR] [--since 1h] [--limit 50]
+   * Usage: npx bm logs:read [--fn bm_api] [--severity ERROR] [--since 1h] [--limit 300]
    */
   async read(projectId, argv) {
     const filter = this.buildFilter(argv);
-    const limit = parseInt(argv.limit, 10) || 50;
+    const limit = parseInt(argv.limit, 10) || 300;
 
     const cmd = [
       'gcloud', 'logging', 'read',
@@ -88,8 +88,8 @@ class LogsCommand extends BaseCommand {
 
       const entries = JSON.parse(output || '[]');
 
-      // Save raw JSON to log file for Claude/tooling to read
-      jetpack.write(logPath, JSON.stringify(entries, null, 2));
+      // Save as newline-delimited JSON (matches tail format)
+      jetpack.write(logPath, entries.map(e => JSON.stringify(e)).join('\n'));
 
       if (entries.length === 0) {
         this.logWarning('No log entries found.');

package/src/cli/commands/setup-tests/bem-config.js

@@ -20,6 +20,11 @@ class BemConfigTest extends BaseTest {
 
     // Loop through all the keys in the template
     powertools.getKeys(bemConfigTemplate).forEach((key) => {
+      // Skip if an ancestor is explicitly set to a non-object value (e.g. stripe: false)
+      if (this._isAncestorDisabled(key)) {
+        return;
+      }
+
       const userValue = _.get(this.self.bemConfigJSON, key, undefined);
 
       // If the user value is undefined, then we need to set pass to false
@@ -43,6 +48,11 @@ class BemConfigTest extends BaseTest {
 
     // Log what keys are missing
     powertools.getKeys(bemConfigTemplate).forEach((key) => {
+      // Skip if an ancestor is explicitly set to a non-object value (e.g. stripe: false)
+      if (this._isAncestorDisabled(key)) {
+        return;
+      }
+
       const userValue = _.get(this.self.bemConfigJSON, key, undefined);
 
       if (typeof userValue === 'undefined') {
@@ -54,6 +64,24 @@ class BemConfigTest extends BaseTest {
 
     throw new Error('Missing required backend-manager-config.json keys');
   }
+  /**
+   * Check if any ancestor of a dot-notation key is a non-object value (e.g. false)
+   * This means the key is intentionally disabled, not missing
+   */
+  _isAncestorDisabled(key) {
+    const parts = key.split('.');
+    let current = this.self.bemConfigJSON;
+
+    for (let i = 0; i < parts.length - 1; i++) {
+      current = current?.[parts[i]];
+
+      if (current !== undefined && current !== null && typeof current !== 'object') {
+        return true;
+      }
+    }
+
+    return false;
+  }
 }
 
 module.exports = BemConfigTest;

package/src/manager/cron/daily/data-requests.js

@@ -2,8 +2,8 @@
  * Data requests cron job
  *
  * Processes data request status transitions:
- * - pending → complete: 14 days after creation
- * - complete → expired: 30 days after becoming complete (44 days after creation)
+ * - pending → completed: 14 days after creation
+ * - completed → expired: 30 days after becoming completed (44 days after creation)
  *
  * Scans the entire collection (no index required) since data-requests is small.
  */
@@ -33,7 +33,7 @@ module.exports = async ({ Manager, assistant, context, libraries }) => {
     const age = nowUNIX - createdUNIX;
 
     if (data.status === 'pending' && age >= FOURTEEN_DAYS) {
-      await doc.ref.update({ status: 'complete' })
+      await doc.ref.update({ status: 'completed' })
         .then(() => {
           completed++;
           assistant.log(`Completed request ${doc.id} (age: ${Math.round(age / 86400)}d)`);
@@ -41,7 +41,7 @@ module.exports = async ({ Manager, assistant, context, libraries }) => {
         .catch((e) => {
           assistant.error(`Failed to complete request ${doc.id}: ${e.message}`);
         });
-    } else if (data.status === 'complete' && age >= FORTY_FOUR_DAYS) {
+    } else if (data.status === 'completed' && age >= FORTY_FOUR_DAYS) {
       await doc.ref.update({ status: 'expired' })
         .then(() => {
           expired++;

package/src/manager/events/firestore/payments-webhooks/on-write.js

@@ -86,7 +86,7 @@ module.exports = async ({ assistant, change, context }) => {
     // Build timestamps
     const now = powertools.timestamp(new Date(), { output: 'string' });
     const nowUNIX = powertools.timestamp(now, { output: 'unix' });
-    const webhookReceivedUNIX = dataAfter.metadata?.received?.timestampUNIX || nowUNIX;
+    const webhookReceivedUNIX = dataAfter.metadata?.created?.timestampUNIX || nowUNIX;
 
     // Extract orderId from resource (processor-agnostic)
     orderId = library.getOrderId(resource);
@@ -105,7 +105,7 @@ module.exports = async ({ assistant, change, context }) => {
       orderId: orderId,
       transition: transitionName,
       metadata: {
-        processed: {
+        completed: {
           timestamp: now,
           timestampUNIX: nowUNIX,
         },
@@ -199,6 +199,7 @@ async function processPaymentEvent({ category, library, resource, resourceType,
     id: orderId,
     type: category,
     owner: uid,
+    productId: unified.product.id,
     processor: processor,
     resourceId: resourceId,
     unified: unified,

package/src/manager/libraries/payment/processors/paypal.js

@@ -268,7 +268,7 @@ const PayPal = {
 
     return {
       product: product,
-      status: rawResource.status === 'COMPLETED' ? 'complete' : rawResource.status?.toLowerCase() || 'unknown',
+      status: rawResource.status === 'COMPLETED' ? 'completed' : rawResource.status?.toLowerCase() || 'unknown',
       payment: {
         processor: 'paypal',
         orderId: customData.orderId || null,
@@ -314,6 +314,7 @@ const PayPal = {
     }
 
     // Fetch plans with full details (Prefer header includes billing_cycles in list response)
+    // TODO: Paginate — page_size=20 only returns first page. Fine for now (each product has ~2-4 plans in 1:1 model) but will break if a product ever accumulates >20 plans.
     const response = await this.request(`/v1/billing/plans?product_id=${paypalProductId}&page_size=20&total_required=true`, {
       headers: { 'Prefer': 'return=representation' },
     });

package/src/manager/libraries/payment/processors/stripe.js

@@ -304,7 +304,7 @@ const Stripe = {
 
     return {
       product: product,
-      status: rawResource.status || 'unknown',
+      status: rawResource.status === 'complete' ? 'completed' : rawResource.status || 'unknown',
       payment: {
         processor: 'stripe',
         orderId: rawResource.metadata?.orderId || null,

package/src/manager/routes/payments/intent/post.js

@@ -116,7 +116,7 @@ module.exports = async ({ assistant, Manager, user, settings, libraries }) => {
     owner: uid,
     status: 'pending',
     productId: productId,
-    productType: productType,
+    type: productType,
     frequency: frequency,
     trial: trial,
     raw: result.raw,

package/src/manager/routes/payments/webhook/post.js

@@ -91,11 +91,11 @@ module.exports = async ({ assistant, Manager, libraries }) => {
     },
     error: null,
     metadata: {
-      received: {
+      created: {
         timestamp: now,
         timestampUNIX: nowUNIX,
       },
-      processed: {
+      completed: {
         timestamp: null,
         timestampUNIX: null,
       },

package/src/manager/routes/user/data-request/get.js

@@ -2,11 +2,11 @@
  * GET /user/data-request - Check data request status or download data
  *
  * action=status (default): Returns the most recent request with its stored status.
- * action=download: Compiles user data live and returns it. Only works when status is 'complete'.
+ * action=download: Compiles user data live and returns it. Only works when status is 'completed'.
  *
  * Statuses:
- *   pending  — request submitted, waiting to be processed (bm_cronDaily sets to 'complete' after 14 days)
- *   complete — data is available for download (downloads counter tracks how many times downloaded)
+ *   pending   — request submitted, waiting to be processed (bm_cronDaily sets to 'completed' after 14 days)
+ *   completed — data is available for download (downloads counter tracks how many times downloaded)
  */
 module.exports = async ({ assistant, Manager, user, settings, libraries }) => {
   const { admin } = libraries;
@@ -43,8 +43,8 @@ module.exports = async ({ assistant, Manager, user, settings, libraries }) => {
     });
   }
 
-  // Download action — only allowed when status is 'complete'
-  if (status !== 'complete') {
+  // Download action — only allowed when status is 'completed'
+  if (status !== 'completed') {
     return assistant.respond('Your data request is still being processed. Please check back later.', { code: 400 });
   }
 

package/test/helpers/payment/paypal/to-unified-one-time.js

@@ -45,7 +45,7 @@ module.exports = {
       name: 'status-completed',
       async run({ assert }) {
         const result = toUnifiedOneTime({ status: 'COMPLETED' });
-        assert.equal(result.status, 'complete', 'PayPal COMPLETED → unified complete');
+        assert.equal(result.status, 'completed', 'PayPal COMPLETED → unified completed');
       },
     },
 
@@ -250,7 +250,7 @@ module.exports = {
         assert.ok(result.payment, 'Should have payment');
 
         assert.equal(result.product.id, 'credits-100', 'Product should be credits-100');
-        assert.equal(result.status, 'complete', 'Status should be complete');
+        assert.equal(result.status, 'completed', 'Status should be completed');
         assert.equal(result.payment.processor, 'paypal', 'Processor should be paypal');
         assert.equal(result.payment.resourceId, 'PAYID-FULL', 'Resource ID should match');
         assert.equal(result.payment.orderId, '1234-5678-9012', 'orderId should match');
@@ -336,7 +336,7 @@ module.exports = {
       async run({ assert }) {
         const result = toUnifiedOneTime(FIXTURE_ORDER_COMPLETED);
 
-        assert.equal(result.status, 'complete', 'COMPLETED fixture → complete');
+        assert.equal(result.status, 'completed', 'COMPLETED fixture → completed');
         assert.equal(result.payment.processor, 'paypal', 'Processor is paypal');
         assert.equal(result.payment.resourceId, '5UX02069M9686893E', 'Resource ID from fixture');
         assert.equal(result.payment.orderId, 'ord-test-456', 'orderId from purchase_units custom_id');

package/test/helpers/payment/stripe/to-unified-one-time.js

@@ -44,7 +44,7 @@ module.exports = {
       name: 'status-complete',
       async run({ assert }) {
         const result = toUnifiedOneTime({ status: 'complete' });
-        assert.equal(result.status, 'complete', 'Status passes through as-is');
+        assert.equal(result.status, 'completed', 'Stripe complete → unified completed');
       },
     },
 
@@ -211,7 +211,7 @@ module.exports = {
         assert.ok(result.payment, 'Should have payment');
 
         assert.equal(result.product.id, 'credits-100', 'Product should be credits-100');
-        assert.equal(result.status, 'complete', 'Status should be complete');
+        assert.equal(result.status, 'completed', 'Status should be completed');
         assert.equal(result.payment.processor, 'stripe', 'Processor should be stripe');
         assert.equal(result.payment.resourceId, 'cs_test_full', 'Resource ID should match');
         assert.equal(result.payment.orderId, '1234-5678-9012', 'orderId should match');
@@ -253,7 +253,7 @@ module.exports = {
         const result = toUnifiedOneTime(FIXTURE_SESSION);
 
         assert.ok(result.product, 'Should have product');
-        assert.equal(result.status, 'complete', 'Real session fixture → complete');
+        assert.equal(result.status, 'completed', 'Real session fixture → completed');
         assert.equal(result.payment.processor, 'stripe', 'Processor is stripe');
         assert.equal(result.payment.resourceId, FIXTURE_SESSION.id, 'resourceId matches fixture ID');
       },