backend-manager 5.0.108 → 5.0.109

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "backend-manager",
-  "version": "5.0.108",
+  "version": "5.0.109",
   "description": "Quick tools for developing Firebase functions",
   "main": "src/manager/index.js",
   "bin": {

package/src/manager/events/firestore/payments-webhooks/on-write.js

@@ -31,6 +31,9 @@ module.exports = async ({ assistant, change, context }) => {
   // Set status to processing
   await webhookRef.set({ status: 'processing' }, { merge: true });
 
+  // Hoisted so orderId is available in catch block for audit trail
+  let orderId = null;
+
   try {
     const processor = dataAfter.processor;
     const uid = dataAfter.owner;
@@ -73,7 +76,7 @@ module.exports = async ({ assistant, change, context }) => {
     const webhookReceivedUNIX = dataAfter.metadata?.received?.timestampUNIX || nowUNIX;
 
     // Extract orderId from resource (processor-agnostic)
-    const orderId = library.getOrderId(resource);
+    orderId = library.getOrderId(resource);
 
     // Process the payment event (subscription or one-time)
     if (category !== 'subscription' && category !== 'one-time') {
@@ -100,11 +103,28 @@ module.exports = async ({ assistant, change, context }) => {
   } catch (e) {
     assistant.error(`Webhook ${eventId} failed: ${e.message}`, e);
 
+    const now = powertools.timestamp(new Date(), { output: 'string' });
+    const nowUNIX = powertools.timestamp(now, { output: 'unix' });
+
     // Mark as failed with error message
     await webhookRef.set({
       status: 'failed',
       error: e.message || String(e),
     }, { merge: true });
+
+    // Mark intent as failed if we resolved the orderId before the error
+    if (orderId) {
+      await admin.firestore().doc(`payments-intents/${orderId}`).set({
+        status: 'failed',
+        error: e.message || String(e),
+        metadata: {
+          completed: {
+            timestamp: now,
+            timestampUNIX: nowUNIX,
+          },
+        },
+      }, { merge: true });
+    }
   }
 };
 
@@ -220,6 +240,20 @@ async function processPaymentEvent({ category, library, resource, resourceType,
     assistant.log(`Updated payments-orders/${orderId}: type=${category}, uid=${uid}, eventType=${eventType}`);
   }
 
+  // Update payments-intents/{orderId} status to match webhook outcome
+  if (orderId) {
+    await admin.firestore().doc(`payments-intents/${orderId}`).set({
+      status: 'completed',
+      metadata: {
+        completed: {
+          timestamp: now,
+          timestampUNIX: nowUNIX,
+        },
+      },
+    }, { merge: true });
+    assistant.log(`Updated payments-intents/${orderId}: status=completed`);
+  }
+
   return transitionName;
 }
 

package/src/manager/routes/payments/cancel/processors/stripe.js

@@ -1,22 +1,35 @@
 /**
  * Stripe cancel processor
- * Sets a subscription to cancel at the end of the current billing period
+ * Cancels a subscription — immediately if trialing, at period end otherwise.
  */
 module.exports = {
   /**
-   * Cancel a Stripe subscription at period end
+   * Cancel a Stripe subscription
+   *
+   * If the subscription is currently trialing, cancel immediately to avoid
+   * giving free premium access for the remainder of the trial.
+   * Otherwise, cancel at the end of the current billing period.
    *
    * @param {object} options
    * @param {string} options.resourceId - Stripe subscription ID (e.g., 'sub_xxx')
    * @param {string} options.uid - User's UID (for logging)
+   * @param {object} options.subscription - User's current subscription object
    * @param {object} options.assistant - Assistant instance for logging
    */
-  async cancelAtPeriodEnd({ resourceId, uid, assistant }) {
+  async cancelAtPeriodEnd({ resourceId, uid, subscription, assistant }) {
     const StripeLib = require('../../../../libraries/payment/processors/stripe.js');
     const stripe = StripeLib.init();
 
-    await stripe.subscriptions.update(resourceId, { cancel_at_period_end: true });
+    const isTrialing = subscription?.trial?.claimed
+      && subscription?.status === 'active'
+      && subscription?.trial?.expires?.timestampUNIX === subscription?.expires?.timestampUNIX;
 
-    assistant.log(`Stripe cancel at period end: sub=${resourceId}, uid=${uid}`);
+    if (isTrialing) {
+      await stripe.subscriptions.cancel(resourceId);
+      assistant.log(`Stripe cancel immediate (trialing): sub=${resourceId}, uid=${uid}`);
+    } else {
+      await stripe.subscriptions.update(resourceId, { cancel_at_period_end: true });
+      assistant.log(`Stripe cancel at period end: sub=${resourceId}, uid=${uid}`);
+    }
   },
 };

package/src/manager/routes/payments/cancel/processors/test.js

@@ -2,9 +2,13 @@ const powertools = require('node-powertools');
 
 /**
  * Test cancel processor
- * Simulates the Stripe webhook that results from cancel_at_period_end=true
+ * Simulates the Stripe webhook that results from cancellation
  * by writing directly to payments-webhooks/{eventId} with status=pending.
  * The on-write trigger picks it up and runs the full pipeline.
+ *
+ * If the user is trialing, simulates immediate cancellation (customer.subscription.deleted).
+ * Otherwise, simulates cancel at period end (customer.subscription.updated with cancel_at_period_end=true).
+ *
  * Only available in non-production environments.
  */
 module.exports = {
@@ -16,7 +20,6 @@ module.exports = {
     const admin = assistant.Manager.libraries.admin;
 
     const timestamp = Date.now();
-    const eventId = `_test-evt-cancel-${timestamp}`;
     const now = Math.floor(timestamp / 1000);
     const periodEnd = now + (30 * 86400);
 
@@ -35,21 +38,31 @@ module.exports = {
       }
     }
 
-    // Build a Stripe-shaped customer.subscription.updated payload
-    // with cancel_at_period_end=true — mirrors what Stripe sends after cancellation
+    // Detect if user is on a trial
+    const isTrialing = subscription?.trial?.claimed
+      && subscription?.status === 'active'
+      && subscription?.trial?.expires?.timestampUNIX === subscription?.expires?.timestampUNIX;
+
+    // Trialing: immediate cancel (customer.subscription.deleted)
+    // Non-trialing: cancel at period end (customer.subscription.updated)
+    const eventType = isTrialing
+      ? 'customer.subscription.deleted'
+      : 'customer.subscription.updated';
+    const eventId = `_test-evt-cancel-${timestamp}`;
+
     const subscriptionObj = {
       id: resourceId,
       object: 'subscription',
-      status: 'active',
+      status: isTrialing ? 'canceled' : 'active',
       metadata: { uid, orderId },
-      cancel_at_period_end: true,
-      cancel_at: periodEnd,
-      canceled_at: null,
-      current_period_end: periodEnd,
+      cancel_at_period_end: !isTrialing,
+      cancel_at: isTrialing ? now : periodEnd,
+      canceled_at: isTrialing ? now : null,
+      current_period_end: isTrialing ? now : periodEnd,
       current_period_start: now - (30 * 86400),
       start_date: now - (30 * 86400),
-      trial_start: null,
-      trial_end: null,
+      trial_start: isTrialing ? (now - 86400) : null,
+      trial_end: isTrialing ? now : null,
       plan: { product: stripeProductId, interval: 'month' },
     };
 
@@ -64,11 +77,11 @@ module.exports = {
       owner: uid,
       raw: {
         id: eventId,
-        type: 'customer.subscription.updated',
+        type: eventType,
         data: { object: subscriptionObj },
       },
       event: {
-        type: 'customer.subscription.updated',
+        type: eventType,
         category: 'subscription',
         resourceType: 'subscription',
         resourceId: resourceId,
@@ -86,6 +99,6 @@ module.exports = {
       },
     });
 
-    assistant.log(`Test cancel processor: wrote payments-webhooks/${eventId} for sub=${resourceId}, uid=${uid}`);
+    assistant.log(`Test cancel processor: wrote payments-webhooks/${eventId} (${eventType}) for sub=${resourceId}, uid=${uid}, trialing=${isTrialing}`);
   },
 };

package/src/test/test-accounts.js

@@ -166,6 +166,15 @@ const JOURNEY_ACCOUNTS = {
       subscription: { product: { id: 'basic' }, status: 'active' }, // Starts as basic, upgraded via trial webhook
     },
   },
+  'journey-payments-trial-cancel': {
+    id: 'journey-payments-trial-cancel',
+    uid: '_test-journey-payments-trial-cancel',
+    email: '_test.journey-payments-trial-cancel@{domain}',
+    properties: {
+      roles: {},
+      subscription: { product: { id: 'basic' }, status: 'active' }, // Starts as basic, trial then immediate cancel
+    },
+  },
   'journey-payments-failure': {
     id: 'journey-payments-failure',
     uid: '_test-journey-payments-failure',

package/test/events/payments/journey-payments-one-time.js

@@ -112,7 +112,7 @@ module.exports = {
     },
 
     {
-      name: 'intent-doc-created',
+      name: 'intent-doc-completed',
       async run({ firestore, assert, state }) {
         const intentDoc = await firestore.get(`payments-intents/${state.orderId}`);
 
@@ -121,7 +121,9 @@ module.exports = {
         assert.equal(intentDoc.intentId, state.intentId, 'Intent ID should match processor session ID');
         assert.equal(intentDoc.owner, state.uid, 'Owner should match');
         assert.equal(intentDoc.processor, 'test', 'Processor should be test');
+        assert.equal(intentDoc.status, 'completed', 'Intent status should be completed after webhook processing');
         assert.equal(intentDoc.productId, state.productId, `Product should be ${state.productId}`);
+        assert.ok(intentDoc.metadata?.completed?.timestampUNIX > 0, 'Completed timestamp should be set');
       },
     },
   ],

package/test/events/payments/journey-payments-trial-cancel.js

@@ -0,0 +1,109 @@
+/**
+ * Test: Payment Journey - Trial Cancel
+ * Simulates: basic user → trial activation → cancel during trial → immediate cancellation
+ *
+ * When a user cancels during a free trial, the subscription should be cancelled immediately
+ * (not scheduled for period end) to avoid giving free premium access for the remainder of the trial.
+ *
+ * Uses the test processor for initial trial, then cancel endpoint for cancellation.
+ * Product-agnostic: resolves the first paid product from config.payment.products
+ */
+module.exports = {
+  description: 'Payment journey: trial → cancel during trial → immediate cancellation',
+  type: 'suite',
+  timeout: 30000,
+
+  tests: [
+    {
+      name: 'verify-starts-as-basic',
+      async run({ accounts, firestore, assert, state, config }) {
+        const uid = accounts['journey-payments-trial-cancel'].uid;
+        const userDoc = await firestore.get(`users/${uid}`);
+
+        assert.ok(userDoc, 'User doc should exist');
+        assert.equal(userDoc.subscription?.product?.id, 'basic', 'Should start as basic');
+        assert.equal(userDoc.subscription?.trial?.claimed, false, 'Trial should not be claimed');
+
+        // Resolve first paid product with trial from config
+        const trialProduct = config.payment.products.find(p => p.id !== 'basic' && p.prices && p.trial?.days);
+        assert.ok(trialProduct, 'Config should have at least one paid product with trial');
+
+        state.uid = uid;
+        state.paidProductId = trialProduct.id;
+        state.paidProductName = trialProduct.name;
+      },
+    },
+
+    {
+      name: 'create-trial-intent',
+      async run({ http, assert, state }) {
+        const response = await http.as('journey-payments-trial-cancel').post('payments/intent', {
+          processor: 'test',
+          productId: state.paidProductId,
+          frequency: 'monthly',
+          trial: true,
+        });
+
+        assert.isSuccess(response, 'Intent should succeed');
+        assert.ok(response.data.id, 'Should return intent ID');
+        assert.ok(response.data.orderId, 'Should return orderId');
+
+        state.intentId = response.data.id;
+        state.orderId = response.data.orderId;
+        state.eventId = response.data.id.replace('_test-cs-', '_test-evt-');
+      },
+    },
+
+    {
+      name: 'trial-activated',
+      async run({ firestore, assert, state, waitFor }) {
+        await waitFor(async () => {
+          const userDoc = await firestore.get(`users/${state.uid}`);
+          return userDoc?.subscription?.trial?.claimed === true;
+        }, 15000, 500);
+
+        const userDoc = await firestore.get(`users/${state.uid}`);
+
+        assert.equal(userDoc.subscription.product.id, state.paidProductId, `Product should be ${state.paidProductId}`);
+        assert.equal(userDoc.subscription.status, 'active', 'Status should be active');
+        assert.equal(userDoc.subscription.trial.claimed, true, 'Trial should be claimed');
+        assert.equal(userDoc.subscription.trial.expires.timestampUNIX, userDoc.subscription.expires.timestampUNIX, 'Trial expires should match subscription expires (still in trial period)');
+
+        state.subscriptionId = userDoc.subscription.payment.resourceId;
+      },
+    },
+
+    {
+      name: 'cancel-during-trial',
+      async run({ http, assert }) {
+        // Cancel via endpoint — test processor should detect trial and simulate immediate cancel
+        const response = await http.as('journey-payments-trial-cancel').post('payments/cancel', {
+          confirmed: true,
+          reason: 'Changed my mind during trial',
+          feedback: 'Testing trial cancellation',
+        });
+
+        assert.isSuccess(response, 'Cancel endpoint should succeed');
+        assert.equal(response.data.success, true, 'Should return { success: true }');
+      },
+    },
+
+    {
+      name: 'verify-immediate-cancellation',
+      async run({ firestore, assert, state, waitFor }) {
+        // Poll until subscription is cancelled (NOT just pending)
+        await waitFor(async () => {
+          const userDoc = await firestore.get(`users/${state.uid}`);
+          return userDoc?.subscription?.status === 'cancelled';
+        }, 15000, 500);
+
+        const userDoc = await firestore.get(`users/${state.uid}`);
+
+        // During trial cancel: subscription should be immediately cancelled, not pending
+        assert.equal(userDoc.subscription.status, 'cancelled', 'Status should be cancelled (not active with pending)');
+        assert.equal(userDoc.subscription.cancellation.pending, false, 'Should NOT be pending — should be fully cancelled');
+        assert.equal(userDoc.subscription.product.id, state.paidProductId, `Product should still be ${state.paidProductId}`);
+      },
+    },
+  ],
+};

package/test/events/payments/journey-payments-trial.js

@@ -79,6 +79,18 @@ module.exports = {
       },
     },
 
+    {
+      name: 'intent-doc-completed',
+      async run({ firestore, assert, state }) {
+        const intentDoc = await firestore.get(`payments-intents/${state.orderId}`);
+
+        assert.ok(intentDoc, 'Intent doc should exist');
+        assert.equal(intentDoc.id, state.orderId, 'ID should match orderId');
+        assert.equal(intentDoc.status, 'completed', 'Intent status should be completed after webhook processing');
+        assert.ok(intentDoc.metadata?.completed?.timestampUNIX > 0, 'Completed timestamp should be set');
+      },
+    },
+
     {
       name: 'send-trial-to-active-webhook',
       async run({ http, assert, state, config }) {

package/test/events/payments/journey-payments-upgrade.js

@@ -109,7 +109,7 @@ module.exports = {
     },
 
     {
-      name: 'intent-doc-created',
+      name: 'intent-doc-completed',
       async run({ firestore, assert, state }) {
         const intentDoc = await firestore.get(`payments-intents/${state.orderId}`);
 
@@ -118,8 +118,9 @@ module.exports = {
         assert.equal(intentDoc.intentId, state.intentId, 'Intent ID should match processor session ID');
         assert.equal(intentDoc.owner, state.uid, 'Owner should match');
         assert.equal(intentDoc.processor, 'test', 'Processor should be test');
-        assert.equal(intentDoc.status, 'pending', 'Intent status should be pending');
+        assert.equal(intentDoc.status, 'completed', 'Intent status should be completed after webhook processing');
         assert.equal(intentDoc.productId, state.paidProductId, `Product should be ${state.paidProductId}`);
+        assert.ok(intentDoc.metadata?.completed?.timestampUNIX > 0, 'Completed timestamp should be set');
       },
     },
   ],