babel-plugin-react-compiler 0.0.0-experimental-54240be-20241206 → 0.0.0-experimental-ba7b8e5-20241210

package/dist/index.js

@@ -129921,9 +129921,7 @@ function lowerStatement(builder, stmtPath, label = null) {
     _26,
     _27,
     _28,
-    _29,
-    _30,
-    _31;
+    _29;
   const stmtNode = stmtPath.node;
   switch (stmtNode.type) {
     case 'ThrowStatement': {
@@ -130765,6 +130763,12 @@ function lowerStatement(builder, stmtPath, label = null) {
           ? _14
           : GeneratedSource;
       let test;
+      const advanceIterator = lowerValueToTemporary(builder, {
+        kind: 'IteratorNext',
+        loc: leftLoc,
+        iterator: Object.assign({}, iterator),
+        collection: Object.assign({}, value),
+      });
       if (left.isVariableDeclaration()) {
         const declarations = left.get('declarations');
         CompilerError.invariant(declarations.length === 1, {
@@ -130774,12 +130778,6 @@ function lowerStatement(builder, stmtPath, label = null) {
           suggestions: null,
         });
         const id = declarations[0].get('id');
-        const advanceIterator = lowerValueToTemporary(builder, {
-          kind: 'IteratorNext',
-          loc: leftLoc,
-          iterator: Object.assign({}, iterator),
-          collection: Object.assign({}, value),
-        });
         const assign = lowerAssignment(
           builder,
           leftLoc,
@@ -130790,13 +130788,19 @@ function lowerStatement(builder, stmtPath, label = null) {
         );
         test = lowerValueToTemporary(builder, assign);
       } else {
-        builder.errors.push({
-          reason: `(BuildHIR::lowerStatement) Handle ${left.type} inits in ForOfStatement`,
-          severity: exports.ErrorSeverity.Todo,
-          loc: (_16 = left.node.loc) !== null && _16 !== void 0 ? _16 : null,
-          suggestions: null,
+        CompilerError.invariant(left.isLVal(), {
+          loc: leftLoc,
+          reason: 'Expected ForOf init to be a variable declaration or lval',
         });
-        return;
+        const assign = lowerAssignment(
+          builder,
+          leftLoc,
+          InstructionKind.Reassign,
+          left,
+          advanceIterator,
+          'Assignment'
+        );
+        test = lowerValueToTemporary(builder, assign);
       }
       builder.terminateWithContinuation(
         {
@@ -130806,8 +130810,8 @@ function lowerStatement(builder, stmtPath, label = null) {
           consequent: loopBlock,
           alternate: continuationBlock.id,
           loc:
-            (_17 = stmt.node.loc) !== null && _17 !== void 0
-              ? _17
+            (_16 = stmt.node.loc) !== null && _16 !== void 0
+              ? _16
               : GeneratedSource,
           fallthrough: continuationBlock.id,
         },
@@ -130837,8 +130841,8 @@ function lowerStatement(builder, stmtPath, label = null) {
         })
       );
       const loc =
-        (_18 = stmt.node.loc) !== null && _18 !== void 0
-          ? _18
+        (_17 = stmt.node.loc) !== null && _17 !== void 0
+          ? _17
           : GeneratedSource;
       const value = lowerExpressionToTemporary(builder, stmt.get('right'));
       builder.terminateWithContinuation(
@@ -130854,24 +130858,24 @@ function lowerStatement(builder, stmtPath, label = null) {
       );
       const left = stmt.get('left');
       const leftLoc =
-        (_19 = left.node.loc) !== null && _19 !== void 0
-          ? _19
+        (_18 = left.node.loc) !== null && _18 !== void 0
+          ? _18
           : GeneratedSource;
       let test;
+      const nextPropertyTemp = lowerValueToTemporary(builder, {
+        kind: 'NextPropertyOf',
+        loc: leftLoc,
+        value: value,
+      });
       if (left.isVariableDeclaration()) {
         const declarations = left.get('declarations');
         CompilerError.invariant(declarations.length === 1, {
           reason: `Expected only one declaration in the init of a ForInStatement, got ${declarations.length}`,
           description: null,
-          loc: (_20 = left.node.loc) !== null && _20 !== void 0 ? _20 : null,
+          loc: (_19 = left.node.loc) !== null && _19 !== void 0 ? _19 : null,
           suggestions: null,
         });
         const id = declarations[0].get('id');
-        const nextPropertyTemp = lowerValueToTemporary(builder, {
-          kind: 'NextPropertyOf',
-          loc: leftLoc,
-          value: value,
-        });
         const assign = lowerAssignment(
           builder,
           leftLoc,
@@ -130882,13 +130886,19 @@ function lowerStatement(builder, stmtPath, label = null) {
         );
         test = lowerValueToTemporary(builder, assign);
       } else {
-        builder.errors.push({
-          reason: `(BuildHIR::lowerStatement) Handle ${left.type} inits in ForInStatement`,
-          severity: exports.ErrorSeverity.Todo,
-          loc: (_21 = left.node.loc) !== null && _21 !== void 0 ? _21 : null,
-          suggestions: null,
+        CompilerError.invariant(left.isLVal(), {
+          loc: leftLoc,
+          reason: 'Expected ForIn init to be a variable declaration or lval',
         });
-        return;
+        const assign = lowerAssignment(
+          builder,
+          leftLoc,
+          InstructionKind.Reassign,
+          left,
+          nextPropertyTemp,
+          'Assignment'
+        );
+        test = lowerValueToTemporary(builder, assign);
       }
       builder.terminateWithContinuation(
         {
@@ -130899,8 +130909,8 @@ function lowerStatement(builder, stmtPath, label = null) {
           alternate: continuationBlock.id,
           fallthrough: continuationBlock.id,
           loc:
-            (_22 = stmt.node.loc) !== null && _22 !== void 0
-              ? _22
+            (_20 = stmt.node.loc) !== null && _20 !== void 0
+              ? _20
               : GeneratedSource,
         },
         continuationBlock
@@ -130910,8 +130920,8 @@ function lowerStatement(builder, stmtPath, label = null) {
     case 'DebuggerStatement': {
       const stmt = stmtPath;
       const loc =
-        (_23 = stmt.node.loc) !== null && _23 !== void 0
-          ? _23
+        (_21 = stmt.node.loc) !== null && _21 !== void 0
+          ? _21
           : GeneratedSource;
       builder.push({
         id: makeInstructionId(0),
@@ -130932,7 +130942,7 @@ function lowerStatement(builder, stmtPath, label = null) {
         builder.errors.push({
           reason: `(BuildHIR::lowerStatement) Handle TryStatement without a catch clause`,
           severity: exports.ErrorSeverity.Todo,
-          loc: (_24 = stmt.node.loc) !== null && _24 !== void 0 ? _24 : null,
+          loc: (_22 = stmt.node.loc) !== null && _22 !== void 0 ? _22 : null,
           suggestions: null,
         });
         return;
@@ -130941,7 +130951,7 @@ function lowerStatement(builder, stmtPath, label = null) {
         builder.errors.push({
           reason: `(BuildHIR::lowerStatement) Handle TryStatement with a finalizer ('finally') clause`,
           severity: exports.ErrorSeverity.Todo,
-          loc: (_25 = stmt.node.loc) !== null && _25 !== void 0 ? _25 : null,
+          loc: (_23 = stmt.node.loc) !== null && _23 !== void 0 ? _23 : null,
           suggestions: null,
         });
       }
@@ -130951,15 +130961,15 @@ function lowerStatement(builder, stmtPath, label = null) {
         const place = {
           kind: 'Identifier',
           identifier: builder.makeTemporary(
-            (_26 = handlerBindingPath.node.loc) !== null && _26 !== void 0
-              ? _26
+            (_24 = handlerBindingPath.node.loc) !== null && _24 !== void 0
+              ? _24
               : GeneratedSource
           ),
           effect: exports.Effect.Unknown,
           reactive: false,
           loc:
-            (_27 = handlerBindingPath.node.loc) !== null && _27 !== void 0
-              ? _27
+            (_25 = handlerBindingPath.node.loc) !== null && _25 !== void 0
+              ? _25
               : GeneratedSource,
         };
         promoteTemporary(place.identifier);
@@ -130971,8 +130981,8 @@ function lowerStatement(builder, stmtPath, label = null) {
           },
           type: null,
           loc:
-            (_28 = handlerBindingPath.node.loc) !== null && _28 !== void 0
-              ? _28
+            (_26 = handlerBindingPath.node.loc) !== null && _26 !== void 0
+              ? _26
               : GeneratedSource,
         });
         handlerBinding = {path: handlerBindingPath, place: place};
@@ -131032,8 +131042,8 @@ function lowerStatement(builder, stmtPath, label = null) {
           fallthrough: continuationBlock.id,
           id: makeInstructionId(0),
           loc:
-            (_29 = stmt.node.loc) !== null && _29 !== void 0
-              ? _29
+            (_27 = stmt.node.loc) !== null && _27 !== void 0
+              ? _27
               : GeneratedSource,
         },
         continuationBlock
@@ -131073,14 +131083,14 @@ function lowerStatement(builder, stmtPath, label = null) {
       builder.errors.push({
         reason: `(BuildHIR::lowerStatement) Handle ${stmtPath.type} statements`,
         severity: exports.ErrorSeverity.Todo,
-        loc: (_30 = stmtPath.node.loc) !== null && _30 !== void 0 ? _30 : null,
+        loc: (_28 = stmtPath.node.loc) !== null && _28 !== void 0 ? _28 : null,
         suggestions: null,
       });
       lowerValueToTemporary(builder, {
         kind: 'UnsupportedNode',
         loc:
-          (_31 = stmtPath.node.loc) !== null && _31 !== void 0
-            ? _31
+          (_29 = stmtPath.node.loc) !== null && _29 !== void 0
+            ? _29
             : GeneratedSource,
         node: stmtPath.node,
       });
@@ -141722,15 +141732,14 @@ function createPropsProperties(
   let refProperty;
   let keyProperty;
   const props = [];
-  const jsxAttributesWithoutKeyAndRef = propAttributes.filter(
-    p => p.kind === 'JsxAttribute' && p.name !== 'key' && p.name !== 'ref'
+  const jsxAttributesWithoutKey = propAttributes.filter(
+    p => p.kind === 'JsxAttribute' && p.name !== 'key'
   );
   const jsxSpreadAttributes = propAttributes.filter(
     p => p.kind === 'JsxSpreadAttribute'
   );
   const spreadPropsOnly =
-    jsxAttributesWithoutKeyAndRef.length === 0 &&
-    jsxSpreadAttributes.length === 1;
+    jsxAttributesWithoutKey.length === 0 && jsxSpreadAttributes.length === 1;
   propAttributes.forEach(prop => {
     switch (prop.kind) {
       case 'JsxAttribute': {
@@ -145203,19 +145212,6 @@ function codegenInstructionNullable(cx, instr) {
 }
 function codegenForInit(cx, init) {
   if (init.kind === 'SequenceExpression') {
-    for (const instr of init.instructions) {
-      if (instr.value.kind === 'DeclareContext') {
-        CompilerError.throwTodo({
-          reason: `Support for loops where the index variable is a context variable`,
-          loc: instr.loc,
-          description:
-            instr.value.lvalue.place.identifier.name != null
-              ? `\`${instr.value.lvalue.place.identifier.name.value}\` is a context variable`
-              : null,
-          suggestions: null,
-        });
-      }
-    }
     const body = codegenBlock(
       cx,
       init.instructions.map(instruction => ({
@@ -145226,20 +145222,37 @@ function codegenForInit(cx, init) {
     const declarators = [];
     let kind = 'const';
     body.forEach(instr => {
-      CompilerError.invariant(
-        instr.type === 'VariableDeclaration' &&
-          (instr.kind === 'let' || instr.kind === 'const'),
-        {
-          reason: 'Expected a variable declaration',
-          loc: init.loc,
-          description: `Got ${instr.type}`,
-          suggestions: null,
+      var _a;
+      let top = undefined;
+      if (
+        instr.type === 'ExpressionStatement' &&
+        instr.expression.type === 'AssignmentExpression' &&
+        instr.expression.operator === '=' &&
+        instr.expression.left.type === 'Identifier' &&
+        ((_a = top = declarators.at(-1)) === null || _a === void 0
+          ? void 0
+          : _a.id.type) === 'Identifier' &&
+        (top === null || top === void 0 ? void 0 : top.id.name) ===
+          instr.expression.left.name &&
+        (top === null || top === void 0 ? void 0 : top.init) == null
+      ) {
+        top.init = instr.expression.right;
+      } else {
+        CompilerError.invariant(
+          instr.type === 'VariableDeclaration' &&
+            (instr.kind === 'let' || instr.kind === 'const'),
+          {
+            reason: 'Expected a variable declaration',
+            loc: init.loc,
+            description: `Got ${instr.type}`,
+            suggestions: null,
+          }
+        );
+        if (instr.kind === 'let') {
+          kind = 'let';
         }
-      );
-      if (instr.kind === 'let') {
-        kind = 'let';
+        declarators.push(...instr.declarations);
       }
-      declarators.push(...instr.declarations);
     });
     CompilerError.invariant(declarators.length > 0, {
       reason: 'Expected a variable declaration',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "babel-plugin-react-compiler",
-  "version": "0.0.0-experimental-54240be-20241206",
+  "version": "0.0.0-experimental-ba7b8e5-20241210",
   "description": "Babel plugin for React Compiler.",
   "main": "dist/index.js",
   "license": "MIT",