azure-pipelines-tasks-webdeployment-common 4.230.2 → 4.230.4

package/Strings/resources.resjson/en-US/resources.resjson

@@ -29,5 +29,8 @@
   "loc.messages.VariableSubstitutionInitiated": "Initiated variable substitution in config file : %s",
   "loc.messages.ConfigFileUpdated": "Config file : %s updated.",
   "loc.messages.SkippedUpdatingFile": "Skipped Updating file: %s",
-  "loc.messages.PwshNotAvailable": "##WARNING##:PowerShell Core (pwsh.exe) is not available on agent machine. Falling back to using Windows PowerShell (powershell.exe). This can cause reduced performance. Please install the newer version of PowerShell for improved performance."
+  "loc.messages.PwshNotAvailable": "##WARNING##:PowerShell Core (pwsh.exe) is not available on agent machine. Falling back to using Windows PowerShell (powershell.exe). This can cause reduced performance. Please install the newer version of PowerShell for improved performance.",
+  "loc.messages.UnabletofindthelocationofMSDeployfromregistryonmachineError": "Unable to find the location of MSDeploy from registry. Error: %s",
+  "loc.messages.MissingMSDeployInstallPathRegistryKey": "Missing MSDeploy InstallPath registry key.",
+  "loc.messages.UnsupportedinstalledversionfoundforMSDeployversionshouldbeatleast3orabove": "Unsupported installed version: %s found for MSDeploy. Version should be at least 3 or above."
 }

package/Tests/L0.js

@@ -9,6 +9,7 @@ const L1JSONVarSubWithComments_1 = require("./L1JSONVarSubWithComments");
 const L1JsonVarSub_1 = require("./L1JsonVarSub");
 const L1JsonVarSubV2_1 = require("./L1JsonVarSubV2");
 const L1ValidateFileEncoding_1 = require("./L1ValidateFileEncoding");
+const L0ParameterParserUtility_1 = require("./L0ParameterParserUtility");
 describe('Web deployment common tests', () => {
     describe('GetMSDeployCmdArgs tests', L0MSDeployUtility_1.runGetMSDeployCmdArgsTests);
     describe('GetWebDeployErrorCode tests', L0MSDeployUtility_1.runGetWebDeployErrorCodeTests);
@@ -20,4 +21,5 @@ describe('Web deployment common tests', () => {
     describe("L1JsonVarSub tests", L1JsonVarSub_1.runL1JsonVarSubTests);
     describe("L1JsonVarSubV2 tests", L1JsonVarSubV2_1.runL1JsonVarSubV2Tests);
     describe("L1ValidateFileEncoding tests", L1ValidateFileEncoding_1.runL1ValidateFileEncodingTests);
+    describe("ParameterParserUtility tests", L0ParameterParserUtility_1.runParameterParserUtilityTests);
 });

package/Tests/L0.ts

@@ -7,6 +7,7 @@ import { runL1JSONVarSubWithCommentsTests } from "./L1JSONVarSubWithComments";
 import { runL1JsonVarSubTests } from "./L1JsonVarSub";
 import { runL1JsonVarSubV2Tests } from "./L1JsonVarSubV2";
 import { runL1ValidateFileEncodingTests } from "./L1ValidateFileEncoding";
+import { runParameterParserUtilityTests } from "./L0ParameterParserUtility";
 
 describe('Web deployment common tests', () => {
     describe('GetMSDeployCmdArgs tests', runGetMSDeployCmdArgsTests);
@@ -19,4 +20,5 @@ describe('Web deployment common tests', () => {
     describe("L1JsonVarSub tests", runL1JsonVarSubTests);
     describe("L1JsonVarSubV2 tests", runL1JsonVarSubV2Tests);
     describe("L1ValidateFileEncoding tests", runL1ValidateFileEncodingTests);
+    describe("ParameterParserUtility tests", runParameterParserUtilityTests);
 });

package/Tests/L0MSDeployUtility.ts

@@ -1,8 +1,6 @@
 import assert = require("assert");
 import { getMSDeployCmdArgs, getWebDeployErrorCode } from "../msdeployutility";
 
-
-
 export function runGetMSDeployCmdArgsTests() {
 
     it('Should produce default valid args', () => {

package/Tests/L0ParameterParserUtility.d.ts

@@ -0,0 +1 @@
+export declare function runParameterParserUtilityTests(): void;

package/Tests/L0ParameterParserUtility.js

@@ -0,0 +1,59 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.runParameterParserUtilityTests = void 0;
+const assert = require("assert");
+const ParameterParserUtility_1 = require("../ParameterParserUtility");
+function runParameterParserUtilityTests() {
+    it("Should parse parameters", () => {
+        const paramString = "-port 8080 -Release.ReleaseName Release-1173";
+        const expectedJSON = {
+            "port": {
+                value: "8080"
+            },
+            "Release.ReleaseName": {
+                value: "Release-1173"
+            }
+        };
+        const result = ParameterParserUtility_1.parse(paramString);
+        assert.deepStrictEqual(result, expectedJSON);
+    });
+    it("Should parse parameters with empty values", () => {
+        const paramString = "-port 8080 -ErrorCode -ErrorMessage -Release.ReleaseName Release-1173";
+        const expectedJSON = {
+            "port": {
+                value: "8080"
+            },
+            "ErrorCode": {
+                value: ""
+            },
+            "ErrorMessage": {
+                value: ""
+            },
+            "Release.ReleaseName": {
+                value: "Release-1173"
+            }
+        };
+        const result = ParameterParserUtility_1.parse(paramString);
+        assert.deepStrictEqual(result, expectedJSON);
+    });
+    it("Should parse parameters with extra spaces", () => {
+        const paramString = "-port         8080    -ErrorCode    -ErrorMessage     -Release.ReleaseName         Release-1173";
+        const expectedJSON = {
+            "port": {
+                value: "8080"
+            },
+            "ErrorCode": {
+                value: ""
+            },
+            "ErrorMessage": {
+                value: ""
+            },
+            "Release.ReleaseName": {
+                value: "Release-1173"
+            }
+        };
+        const result = ParameterParserUtility_1.parse(paramString);
+        assert.deepStrictEqual(result, expectedJSON);
+    });
+}
+exports.runParameterParserUtilityTests = runParameterParserUtilityTests;

package/Tests/L0ParameterParserUtility.ts

@@ -0,0 +1,65 @@
+import assert = require('assert');
+import { parse } from '../ParameterParserUtility';
+
+export function runParameterParserUtilityTests(): void {
+
+    it("Should parse parameters", () => {
+        const paramString = "-port 8080 -Release.ReleaseName Release-1173";
+        const expectedJSON = {
+            "port": {
+                value: "8080"
+            },
+            "Release.ReleaseName": {
+                value: "Release-1173"
+            }
+        };
+
+        const result = parse(paramString);
+
+        assert.deepStrictEqual(result, expectedJSON);
+    });
+
+    it("Should parse parameters with empty values", () => {
+        const paramString = "-port 8080 -ErrorCode -ErrorMessage -Release.ReleaseName Release-1173";
+        const expectedJSON = {
+            "port": {
+                value: "8080"
+            },
+            "ErrorCode": {
+                value: ""
+            },
+            "ErrorMessage": {
+                value: ""
+            },
+            "Release.ReleaseName": {
+                value: "Release-1173"
+            }
+        };
+
+        const result = parse(paramString);
+
+        assert.deepStrictEqual(result, expectedJSON);
+    });
+
+    it("Should parse parameters with extra spaces", () => {
+        const paramString = "-port         8080    -ErrorCode    -ErrorMessage     -Release.ReleaseName         Release-1173";
+        const expectedJSON = {
+            "port": {
+                value: "8080"
+            },
+            "ErrorCode": {
+                value: ""
+            },
+            "ErrorMessage": {
+                value: ""
+            },
+            "Release.ReleaseName": {
+                value: "Release-1173"
+            }
+        };
+
+        const result = parse(paramString);
+
+        assert.deepStrictEqual(result, expectedJSON);
+    });
+}

package/Tests/L1JSONVarSubWithComments.js

@@ -28,7 +28,6 @@ function runL1JSONVarSubWithCommentsTests() {
     it("Should throw exception for invalid JSON with comments", (done) => {
         const fileContent = fs.readFileSync(path.join(__dirname, 'L1JSONVarSub', 'InvalidJSONWithComments.json'), 'utf-8');
         const jsonContent = jsonvariablesubstitutionutility_1.stripJsonComments(fileContent);
-        console.log(jsonContent);
         assert.throws(() => JSON.parse(jsonContent), "Parse is expected to throw an error");
         done();
     });

package/Tests/L1JSONVarSubWithComments.ts

@@ -33,7 +33,6 @@ export function runL1JSONVarSubWithCommentsTests(): void {
     it("Should throw exception for invalid JSON with comments", (done: Mocha.Done) => {
         const fileContent = fs.readFileSync(path.join(__dirname, 'L1JSONVarSub', 'InvalidJSONWithComments.json'), 'utf-8');
         const jsonContent = stripJsonComments(fileContent);
-        console.log(jsonContent);
         assert.throws(() => JSON.parse(jsonContent), "Parse is expected to throw an error");
         done();
     });

package/deployusingmsdeploy.js

@@ -13,10 +13,8 @@ exports.executeWebDeploy = exports.DeployUsingMSDeploy = void 0;
 const tl = require("azure-pipelines-task-lib/task");
 const fs = require("fs");
 const path = require("path");
-const Q = require("q");
+const utility_1 = require("./utility");
 const msdeployutility_1 = require("./msdeployutility");
-var msDeployUtility = require('./msdeployutility.js');
-var utility = require('./utility.js');
 const DEFAULT_RETRY_COUNT = 3;
 /**
  * Executes Web Deploy command
@@ -34,17 +32,17 @@ const DEFAULT_RETRY_COUNT = 3;
  */
 function DeployUsingMSDeploy(webDeployPkg, webAppName, publishingProfile, removeAdditionalFilesFlag, excludeFilesFromAppDataFlag, takeAppOfflineFlag, virtualApplication, setParametersFile, additionalArguments, isFolderBasedDeployment, useWebDeploy, authType) {
     return __awaiter(this, void 0, void 0, function* () {
-        var msDeployPath = yield msDeployUtility.getMSDeployFullPath();
+        var msDeployPath = yield msdeployutility_1.getMSDeployFullPath();
         var msDeployDirectory = msDeployPath.slice(0, msDeployPath.lastIndexOf('\\') + 1);
         var pathVar = process.env.PATH;
         process.env.PATH = msDeployDirectory + ";" + process.env.PATH;
-        setParametersFile = utility.copySetParamFileIfItExists(setParametersFile);
+        setParametersFile = utility_1.copySetParamFileIfItExists(setParametersFile);
         var setParametersFileName = null;
         if (setParametersFile != null) {
             setParametersFileName = setParametersFile.slice(setParametersFile.lastIndexOf('\\') + 1, setParametersFile.length);
         }
-        var isParamFilePresentInPackage = isFolderBasedDeployment ? false : yield utility.isMSDeployPackage(webDeployPkg);
-        var msDeployCmdArgs = msDeployUtility.getMSDeployCmdArgs(webDeployPkg, webAppName, publishingProfile, removeAdditionalFilesFlag, excludeFilesFromAppDataFlag, takeAppOfflineFlag, virtualApplication, setParametersFileName, additionalArguments, isParamFilePresentInPackage, isFolderBasedDeployment, useWebDeploy, authType);
+        var isParamFilePresentInPackage = isFolderBasedDeployment ? false : yield utility_1.isMSDeployPackage(webDeployPkg);
+        var msDeployCmdArgs = msdeployutility_1.getMSDeployCmdArgs(webDeployPkg, webAppName, publishingProfile, removeAdditionalFilesFlag, excludeFilesFromAppDataFlag, takeAppOfflineFlag, virtualApplication, setParametersFileName, additionalArguments, isParamFilePresentInPackage, isFolderBasedDeployment, useWebDeploy, authType);
         var retryCountParam = tl.getVariable("appservice.msdeployretrycount");
         var retryCount = (retryCountParam && !(isNaN(Number(retryCountParam)))) ? Number(retryCountParam) : DEFAULT_RETRY_COUNT;
         try {
@@ -69,7 +67,7 @@ function DeployUsingMSDeploy(webDeployPkg, webAppName, publishingProfile, remove
         catch (error) {
             tl.error(tl.loc('PackageDeploymentFailed'));
             tl.debug(JSON.stringify(error));
-            msDeployUtility.redirectMSDeployErrorToConsole();
+            msdeployutility_1.redirectMSDeployErrorToConsole();
             throw Error(error.message);
         }
         finally {
@@ -95,6 +93,7 @@ function executeWebDeploy(webDeployArguments) {
             };
         }
         catch (exception) {
+            tl.debug(JSON.stringify(exception));
             const msDeployErrorFilePath = tl.getVariable('System.DefaultWorkingDirectory') + '\\' + 'error.txt';
             const errorFileContent = tl.exist(msDeployErrorFilePath) ? fs.readFileSync(msDeployErrorFilePath, 'utf-8') : "";
             return {
@@ -158,36 +157,42 @@ function argStringToArray(argString) {
 }
 function executeMSDeploy(msDeployCmdArgs) {
     return __awaiter(this, void 0, void 0, function* () {
-        var deferred = Q.defer();
-        var msDeployError = null;
-        var errorFile = path.join(tl.getVariable('System.DefaultWorkingDirectory'), "error.txt");
-        var fd = fs.openSync(errorFile, "w");
-        var errObj = fs.createWriteStream("", { fd: fd });
-        errObj.on('finish', () => __awaiter(this, void 0, void 0, function* () {
-            if (msDeployError) {
-                deferred.reject(msDeployError);
+        return new Promise((resolve, reject) => __awaiter(this, void 0, void 0, function* () {
+            const errorFile = path.join(tl.getVariable('System.DefaultWorkingDirectory'), msdeployutility_1.ERROR_FILE_NAME);
+            const fd = fs.openSync(errorFile, "w");
+            const errorStream = fs.createWriteStream("", { fd: fd });
+            let msDeployError = null;
+            errorStream.on('finish', () => __awaiter(this, void 0, void 0, function* () {
+                if (msDeployError) {
+                    reject(msDeployError);
+                }
+            }));
+            try {
+                tl.debug("the argument string is:");
+                tl.debug(msDeployCmdArgs);
+                tl.debug("converting the argument string into an array of arguments");
+                const msDeployCmdArgsArray = argStringToArray(msDeployCmdArgs);
+                tl.debug("the array of arguments is:");
+                for (let i = 0; i < msDeployCmdArgsArray.length; i++) {
+                    tl.debug("arg#" + i + ": " + msDeployCmdArgsArray[i]);
+                }
+                // set shell: true because C:\Program Files\IIS\Microsoft Web Deploy V3\msdeploy.exe has folder with spaces 
+                // see https://github.com/microsoft/azure-pipelines-tasks/issues/17634
+                const options = {
+                    failOnStdErr: true,
+                    errStream: errorStream,
+                    windowsVerbatimArguments: true,
+                    shell: true
+                };
+                yield tl.exec("msdeploy", msDeployCmdArgsArray, options);
+                resolve("Azure App service successfully deployed");
             }
-        }));
-        try {
-            tl.debug("the argument string is:");
-            tl.debug(msDeployCmdArgs);
-            tl.debug("converting the argument string into an array of arguments");
-            msDeployCmdArgs = argStringToArray(msDeployCmdArgs);
-            tl.debug("the array of arguments is:");
-            for (var i = 0; i < msDeployCmdArgs.length; i++) {
-                tl.debug("arg#" + i + ": " + msDeployCmdArgs[i]);
+            catch (error) {
+                msDeployError = error;
             }
-            // set shell: true because C:\Program Files\IIS\Microsoft Web Deploy V3\msdeploy.exe has folder with spaces 
-            // see https://github.com/microsoft/azure-pipelines-tasks/issues/17634
-            yield tl.exec("msdeploy", msDeployCmdArgs, { failOnStdErr: true, errStream: errObj, windowsVerbatimArguments: true, shell: true });
-            deferred.resolve("Azure App service successfully deployed");
-        }
-        catch (error) {
-            msDeployError = error;
-        }
-        finally {
-            errObj.end();
-        }
-        return deferred.promise;
+            finally {
+                errorStream.end();
+            }
+        }));
     });
 }

package/module.json

@@ -32,8 +32,7 @@
         "SkippedUpdatingFile" : "Skipped Updating file: %s",
         "PwshNotAvailable": "##WARNING##:PowerShell Core (pwsh.exe) is not available on agent machine. Falling back to using Windows PowerShell (powershell.exe). This can cause reduced performance. Please install the newer version of PowerShell for improved performance.",
         "UnabletofindthelocationofMSDeployfromregistryonmachineError": "Unable to find the location of MSDeploy from registry. Error: %s",
-        "MissingMSDeployVersionRegistryKey": "Missing MSDeploy Version registry key.",
-        "UnsupportedMSDeployVersion": "MSDeploy %s does not support token base authentication. Please upgrade to MSDeploy 9.0.7225.0 or higher.",
-        "MissingMSDeployInstallPathRegistryKey": "Missing MSDeploy InstallPath registry key."
-    }
+        "MissingMSDeployInstallPathRegistryKey": "Missing MSDeploy InstallPath registry key.",
+        "UnsupportedinstalledversionfoundforMSDeployversionshouldbeatleast3orabove": "Unsupported installed version: %s found for MSDeploy. Version should be at least 3 or above."
+   }
 }

package/msdeployutility.d.ts

@@ -1,4 +1,5 @@
 import { Package } from './packageUtility';
+export declare const ERROR_FILE_NAME = "error.txt";
 /**
  * Constructs argument for MSDeploy command
  *
@@ -26,6 +27,8 @@ export declare function shouldUseMSDeployTokenAuth(): boolean;
  * @returns    string
  */
 export declare function getMSDeployFullPath(): Promise<string>;
+export declare function getInstalledMSDeployVersion(): Promise<string>;
+export declare function installedMSDeployVersionSupportsTokenAuth(): Promise<boolean | undefined>;
 /**
  * 1. Checks if msdeploy during execution redirected any error to
  * error stream ( saved in error.txt) , display error to console

package/msdeployutility.js

@@ -9,13 +9,13 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getWebDeployErrorCode = exports.redirectMSDeployErrorToConsole = exports.getMSDeployFullPath = exports.shouldUseMSDeployTokenAuth = exports.getWebDeployArgumentsString = exports.getMSDeployCmdArgs = void 0;
+exports.getWebDeployErrorCode = exports.redirectMSDeployErrorToConsole = exports.installedMSDeployVersionSupportsTokenAuth = exports.getInstalledMSDeployVersion = exports.getMSDeployFullPath = exports.shouldUseMSDeployTokenAuth = exports.getWebDeployArgumentsString = exports.getMSDeployCmdArgs = exports.ERROR_FILE_NAME = void 0;
 const tl = require("azure-pipelines-task-lib/task");
 const fs = require("fs");
 const path = require("path");
-var winreg = require('winreg');
-var parseString = require('xml2js').parseString;
-const ERROR_FILE_NAME = "error.txt";
+const winreg = require("winreg");
+const semver = require("semver");
+exports.ERROR_FILE_NAME = "error.txt";
 /**
  * Constructs argument for MSDeploy command
  *
@@ -213,9 +213,8 @@ exports.shouldUseMSDeployTokenAuth = shouldUseMSDeployTokenAuth;
 function getMSDeployFullPath() {
     return __awaiter(this, void 0, void 0, function* () {
         try {
-            const msDeployInstallPathRegKey = "\\SOFTWARE\\Microsoft\\IIS Extensions\\MSDeploy";
-            const msDeployLatestPathRegKey = yield getMSDeployLatestRegKey(msDeployInstallPathRegKey);
-            return (yield getMSDeployInstallPath(msDeployLatestPathRegKey)) + "msdeploy.exe";
+            const msDeployFolder = yield getMSDeployInstallPath();
+            return path.join(msDeployFolder, "msdeploy.exe");
         }
         catch (error) {
             tl.debug(error);
@@ -225,31 +224,84 @@ function getMSDeployFullPath() {
     });
 }
 exports.getMSDeployFullPath = getMSDeployFullPath;
-function getMSDeployLatestRegKey(registryKey) {
+function getMSDeployInstallPath() {
+    return __awaiter(this, void 0, void 0, function* () {
+        const regKey = yield getMSDeployLatestRegKey();
+        return new Promise((resolve, reject) => {
+            regKey.get("InstallPath", function (err, item) {
+                if (err) {
+                    reject(tl.loc("MissingMSDeployInstallPathRegistryKey"));
+                }
+                resolve(item.value);
+            });
+        });
+    });
+}
+function getInstalledMSDeployVersion() {
+    return __awaiter(this, void 0, void 0, function* () {
+        let regKey;
+        try {
+            regKey = yield getMSDeployLatestRegKey();
+        }
+        catch (err) {
+            tl.debug("An error occured while loading msdeploy registry values: " + err);
+            return undefined;
+        }
+        return new Promise((resolve, _) => {
+            regKey.get("Version", function (err, item) {
+                if (err) {
+                    tl.debug("An error occured while loading msdeploy version from registry: " + err);
+                    resolve(undefined);
+                }
+                const version = item.value;
+                tl.debug(`Installed MSDeploy Version: ${version}`);
+                resolve(version);
+            });
+        });
+    });
+}
+exports.getInstalledMSDeployVersion = getInstalledMSDeployVersion;
+function installedMSDeployVersionSupportsTokenAuth() {
+    return __awaiter(this, void 0, void 0, function* () {
+        // MSDeploy 9.0.7225 is the first product version to support token auth
+        const minimalMSDeployVersion = "9.0.7225";
+        const msDeployVersion = yield getInstalledMSDeployVersion();
+        if (!msDeployVersion) {
+            tl.debug('Could not determine MSDeploy version. Assuming it is not installed.');
+            return undefined;
+        }
+        return semver.gte(semver.coerce(msDeployVersion), semver.coerce(minimalMSDeployVersion));
+    });
+}
+exports.installedMSDeployVersionSupportsTokenAuth = installedMSDeployVersionSupportsTokenAuth;
+function getMSDeployLatestRegKey() {
     return new Promise((resolve, reject) => {
-        var regKey = new winreg({
+        const minimalSupportedMSDeployVersion = 3;
+        const msdeployRegistryPath = "\\SOFTWARE\\Microsoft\\IIS Extensions\\MSDeploy";
+        const regKey = new winreg({
             hive: winreg.HKLM,
-            key: registryKey
+            key: msdeployRegistryPath
         });
         regKey.keys(function (err, subRegKeys) {
             if (err) {
                 reject(tl.loc("UnabletofindthelocationofMSDeployfromregistryonmachineError", err));
                 return;
             }
-            var latestKeyVersion = 0;
-            var latestSubKey;
+            tl.debug(`Found ${subRegKeys.length} subkeys under ${msdeployRegistryPath}`);
+            let latestKeyVersion = 0;
+            let latestSubKey;
             for (var index in subRegKeys) {
-                var subRegKey = subRegKeys[index].key;
-                var subKeyVersion = subRegKey.substr(subRegKey.lastIndexOf('\\') + 1, subRegKey.length - 1);
-                if (!isNaN(subKeyVersion)) {
-                    var subKeyVersionNumber = parseFloat(subKeyVersion);
-                    if (subKeyVersionNumber > latestKeyVersion) {
-                        latestKeyVersion = subKeyVersionNumber;
-                        latestSubKey = subRegKey;
-                    }
+                const subRegKey = subRegKeys[index].key;
+                tl.debug("Found subkey " + subRegKey);
+                const subKeyVersion = subRegKey.substring(subRegKey.lastIndexOf("\\") + 1);
+                const subKeyVersionNumber = parseFloat(subKeyVersion);
+                if (!isNaN(subKeyVersionNumber) && subKeyVersionNumber > latestKeyVersion) {
+                    latestKeyVersion = subKeyVersionNumber;
+                    latestSubKey = subRegKeys[index];
                 }
             }
-            if (latestKeyVersion < 3) {
+            if (latestKeyVersion < minimalSupportedMSDeployVersion) {
+                // previous versions are not compatible either with app services or web deployment tasks
                 reject(tl.loc("UnsupportedinstalledversionfoundforMSDeployversionshouldbeatleast3orabove", latestKeyVersion));
                 return;
             }
@@ -257,68 +309,13 @@ function getMSDeployLatestRegKey(registryKey) {
         });
     });
 }
-function getMSDeployInstallPath(registryKey) {
-    return new Promise((resolve, reject) => {
-        var regKey = new winreg({
-            hive: winreg.HKLM,
-            key: registryKey
-        });
-        regKey.values(function (err, items) {
-            if (err) {
-                reject(tl.loc("UnabletofindthelocationofMSDeployfromregistryonmachineError", err));
-            }
-            if (shouldUseMSDeployTokenAuth()) {
-                const versionItem = items.find(item => item.name === "Version");
-                if (!versionItem) {
-                    reject(tl.loc("MissingMSDeployVersionRegistryKey"));
-                }
-                const minimalSupportedVersion = "9.0.7225.0";
-                const version = versionItem.value;
-                tl.debug(`Installed MSDeploy Version: ${version}`);
-                // MSDeploy 9.0.7225.0 is the first version to support token auth
-                if (compareVersions(version, minimalSupportedVersion) < 0) {
-                    reject(tl.loc("UnsupportedMSDeployVersion", version));
-                }
-            }
-            const installPathItem = items.find(item => item.name === "InstallPath");
-            if (!installPathItem) {
-                reject(tl.loc("MissingMSDeployInstallPathRegistryKey"));
-            }
-            resolve(installPathItem.value);
-        });
-    });
-}
-function compareVersions(version1, version2) {
-    if (version1 === version2) {
-        return 0;
-    }
-    const separator = ".";
-    const parts1 = version1.split(separator).map(Number);
-    const parts2 = version2.split(separator).map(Number);
-    const length = Math.min(parts1.length, parts2.length);
-    for (let i = 0; i < length; i++) {
-        if (parts1[i] > parts2[i]) {
-            return 1;
-        }
-        if (parts1[i] < parts2[i]) {
-            return -1;
-        }
-    }
-    if (parts1.length > parts2.length) {
-        return 1;
-    }
-    if (parts1.length < parts2.length) {
-        return -1;
-    }
-    return 0;
-}
 /**
  * 1. Checks if msdeploy during execution redirected any error to
  * error stream ( saved in error.txt) , display error to console
  * 2. Checks if there is file in use error , suggest to try app offline.
  */
 function redirectMSDeployErrorToConsole() {
-    var msDeployErrorFilePath = tl.getVariable('System.DefaultWorkingDirectory') + '\\' + ERROR_FILE_NAME;
+    var msDeployErrorFilePath = tl.getVariable('System.DefaultWorkingDirectory') + '\\' + exports.ERROR_FILE_NAME;
     if (tl.exist(msDeployErrorFilePath)) {
         var errorFileContent = fs.readFileSync(msDeployErrorFilePath).toString();
         if (errorFileContent !== "") {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "azure-pipelines-tasks-webdeployment-common",
-    "version": "4.230.2",
+    "version": "4.230.4",
     "description": "Common Lib for MSDeploy Utility",
     "repository": {
         "type": "git",
@@ -17,22 +17,25 @@
     },
     "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
     "dependencies": {
+        "@types/ltx": "3.0.6",
         "@types/mocha": "^5.2.7",
         "@types/node": "^10.17.0",
         "@xmldom/xmldom": "git+https://github.com/xmldom/xmldom.git#0.8.6",
-        "@types/ltx": "3.0.6",
         "archiver": "1.2.0",
         "azure-pipelines-task-lib": "^4.2.0",
         "decompress-zip": "^0.3.3",
         "ltx": "2.8.0",
         "node-stream-zip": "^1.15.0",
         "q": "1.4.1",
+        "semver": "^7.5.4",
         "winreg": "1.2.2",
         "xml2js": "0.6.2"
     },
     "devDependencies": {
-        "typescript": "4.0.2",
+        "@types/semver": "^7.5.4",
+        "@types/winreg": "^1.2.34",
         "mocha": "^6.2.3",
-        "nyc": "^15.1.0"
+        "nyc": "^15.1.0",
+        "typescript": "4.0.2"
     }
 }