azure-pipelines-tasks-webdeployment-common 4.227.0 → 4.230.0

package/msdeployutility.js

@@ -82,7 +82,7 @@ function getMSDeployCmdArgs(webAppPackage, webAppName, publishingProfile, remove
             msDeployCmdArgs += ' -skip:Directory=App_Data';
         }
     }
-    additionalArguments = additionalArguments ? additionalArguments : ' ';
+    additionalArguments = additionalArguments ? escapeQuotes(additionalArguments) : ' ';
     msDeployCmdArgs += ' ' + additionalArguments;
     if (!(removeAdditionalFilesFlag && useWebDeploy)) {
         msDeployCmdArgs += " -enableRule:DoNotDeleteRule";
@@ -97,6 +97,99 @@ function getMSDeployCmdArgs(webAppPackage, webAppName, publishingProfile, remove
     return msDeployCmdArgs;
 }
 exports.getMSDeployCmdArgs = getMSDeployCmdArgs;
+/**
+ * Escapes quotes in a string to ensure proper command-line parsing.
+ * @param {string} additionalArguments - The string to format.
+ * @returns {string} The formatted string with escaped quotes.
+ */
+function escapeQuotes(additionalArguments) {
+    const parsedArgs = parseAdditionalArguments(additionalArguments);
+    const separator = ",";
+    const formattedArgs = parsedArgs.map(function (arg) {
+        let formattedArg = '';
+        let equalsSignEncountered = false;
+        for (let i = 0; i < arg.length; i++) {
+            const char = arg.charAt(i);
+            if (char == separator && equalsSignEncountered) {
+                equalsSignEncountered = false;
+                arg = arg.replace(formattedArg, escapeArg(formattedArg));
+                formattedArg = '';
+                continue;
+            }
+            if (equalsSignEncountered) {
+                formattedArg += char;
+            }
+            if (char == '=') {
+                equalsSignEncountered = true;
+            }
+        }
+        ;
+        if (formattedArg.length > 0) {
+            arg = arg.replace(formattedArg, escapeArg(formattedArg));
+        }
+        return arg;
+    });
+    return formattedArgs.join(' ');
+}
+exports.escapeQuotes = escapeQuotes;
+/**
+ * Escapes special characters in a string to ensure proper command-line parsing.
+ * @param {string} arg - The string to format.
+ * @returns {string} The formatted string with escaped characters.
+ */
+function escapeArg(arg) {
+    var escapedChars = new RegExp(/[\\\^\.\*\?\-\&\|\(\)\<\>\t\n\r\f]/);
+    // If the argument starts with dowble quote and ends with double quote, the replace it with escaped double quotes
+    if (arg.startsWith('"') && arg.endsWith('"')) {
+        return '"\\' + arg.slice(0, arg.length - 1) + '\\""';
+    }
+    // If the argument starts with single quote and ends with single quote, then replace it with escaped double qoutes
+    if (arg.startsWith("'") && arg.endsWith("'")) {
+        return '"\\"' + arg.slice(1, arg.length - 1) + '\\""';
+    }
+    if (escapedChars.test(arg)) {
+        return '"\\"' + arg + '\\""';
+    }
+    return arg;
+}
+/**
+ * Parses additional arguments for the msdeploy command-line utility.
+ * @param {string} additionalArguments - The additional arguments to parse.
+ * @returns {string[]} An array of parsed arguments.
+ */
+function parseAdditionalArguments(additionalArguments) {
+    var parsedArgs = [];
+    var isInsideQuotes = false;
+    for (let i = 0; i < additionalArguments.length; i++) {
+        var arg = '';
+        var qouteSymbol = '';
+        let char = additionalArguments.charAt(i);
+        // command parse start
+        if (char === '-') {
+            while (i < additionalArguments.length) {
+                char = additionalArguments.charAt(i);
+                const prevSym = additionalArguments.charAt(i - 1);
+                // If we reach space and we are not inside quotes, then it is the end of the argument
+                if (char === ' ' && !isInsideQuotes)
+                    break;
+                // If we reach unescaped comma and we inside qoutes we assume that it is the end of quoted line
+                if (isInsideQuotes && char === qouteSymbol && prevSym !== '\\') {
+                    isInsideQuotes = false;
+                    qouteSymbol = '';
+                    // If we reach unescaped comma and we are not inside qoutes we assume that it is the beggining of quoted line
+                }
+                else if (!isInsideQuotes && (char === '"' || char === "'") && prevSym !== '\\') {
+                    isInsideQuotes = !isInsideQuotes;
+                    qouteSymbol = char;
+                }
+                arg += char;
+                i += 1;
+            }
+            parsedArgs.push(arg);
+        }
+    }
+    return parsedArgs;
+}
 function getWebDeployArgumentsString(webDeployArguments, publishingProfile) {
     return __awaiter(this, void 0, void 0, function* () {
         return getMSDeployCmdArgs(webDeployArguments.package.getPath(), webDeployArguments.appName, publishingProfile, webDeployArguments.removeAdditionalFilesFlag, webDeployArguments.excludeFilesFromAppDataFlag, webDeployArguments.takeAppOfflineFlag, webDeployArguments.virtualApplication, webDeployArguments.setParametersFile, webDeployArguments.additionalArguments, yield webDeployArguments.package.isMSBuildPackage(), webDeployArguments.package.isFolder(), webDeployArguments.useWebDeploy);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "azure-pipelines-tasks-webdeployment-common",
-    "version": "4.227.0",
+    "version": "4.230.0",
     "description": "Common Lib for MSDeploy Utility",
     "repository": {
         "type": "git",
@@ -23,6 +23,7 @@
         "azure-pipelines-task-lib": "^4.2.0",
         "decompress-zip": "^0.3.3",
         "ltx": "2.8.0",
+        "node-stream-zip": "^1.15.0",
         "q": "1.4.1",
         "winreg": "1.2.2",
         "xml2js": "0.6.2"

package/packageUtility.js

@@ -74,15 +74,7 @@ class Package {
     isMSBuildPackage() {
         return __awaiter(this, void 0, void 0, function* () {
             if (this._isMSBuildPackage == undefined) {
-                this._isMSBuildPackage = false;
-                if (this.getPackageType() != PackageType.folder) {
-                    var pacakgeComponent = yield zipUtility.getArchivedEntries(this._path);
-                    if (((pacakgeComponent["entries"].indexOf("parameters.xml") > -1) || (pacakgeComponent["entries"].indexOf("Parameters.xml") > -1)) &&
-                        ((pacakgeComponent["entries"].indexOf("systemInfo.xml") > -1) || (pacakgeComponent["entries"].indexOf("systeminfo.xml") > -1)
-                            || (pacakgeComponent["entries"].indexOf("SystemInfo.xml") > -1))) {
-                        this._isMSBuildPackage = true;
-                    }
-                }
+                this._isMSBuildPackage = this.getPackageType() != PackageType.folder && (yield zipUtility.checkIfFilesExistsInZip(this._path, ["parameters.xml", "systeminfo.xml"]));
                 tl.debug("Is the package an msdeploy package : " + this._isMSBuildPackage);
             }
             return this._isMSBuildPackage;

package/ziputility.d.ts

@@ -4,3 +4,4 @@ export declare function archiveFolder(folderPath: any, targetPath: any, zipName:
  *  Returns array of files present in archived package
  */
 export declare function getArchivedEntries(archivedPackage: string): Promise<any>;
+export declare function checkIfFilesExistsInZip(archivedPackage: string, files: string[]): any;

package/ziputility.js

@@ -9,11 +9,12 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getArchivedEntries = exports.archiveFolder = exports.unzip = void 0;
+exports.checkIfFilesExistsInZip = exports.getArchivedEntries = exports.archiveFolder = exports.unzip = void 0;
 const tl = require("azure-pipelines-task-lib/task");
 const path = require("path");
 const Q = require("q");
 const fs = require("fs");
+const StreamZip = require("node-stream-zip");
 var DecompressZip = require('decompress-zip');
 var archiver = require('archiver');
 const deleteDir = (path) => tl.exist(path) && tl.rmRF(path);
@@ -155,3 +156,28 @@ function getArchivedEntries(archivedPackage) {
     });
 }
 exports.getArchivedEntries = getArchivedEntries;
+function checkIfFilesExistsInZip(archivedPackage, files) {
+    let deferred = Q.defer();
+    for (let i = 0; i < files.length; i++) {
+        files[i] = files[i].toLowerCase();
+    }
+    const zip = new StreamZip({
+        file: archivedPackage,
+        storeEntries: true
+    });
+    zip.on('ready', () => {
+        let fileCount = 0;
+        for (let entry in zip.entries()) {
+            if (files.indexOf(entry.toLowerCase()) != -1) {
+                fileCount += 1;
+            }
+        }
+        zip.close();
+        deferred.resolve(fileCount == files.length);
+    });
+    zip.on('error', error => {
+        deferred.reject(error);
+    });
+    return deferred.promise;
+}
+exports.checkIfFilesExistsInZip = checkIfFilesExistsInZip;