azure-pipelines-tasks-azurermdeploycommon 3.221.2 → 3.221.3

package/operations/AzureAppServiceUtility.js

@@ -143,13 +143,24 @@ class AzureAppServiceUtility {
             const scmPolicyCheck = yield this.isSitePublishingCredentialsEnabled();
             let token = "";
             let method = "";
+            const password = publishingCredentials.properties["publishingPassword"];
+            const userName = publishingCredentials.properties["publishingUserName"];
             if (scmPolicyCheck === false) {
                 token = yield this._appService._client.getCredentials().getToken();
                 method = "Bearer";
+                // Though bearer AuthN is used, lets try to set publish profile password for mask hints to maintain compat with old behavior for MSDEPLOY. 
+                // This needs to be cleaned up once MSDEPLOY suppport is reomve. Safe handle the exception setting up mask hint as we dont want to fail here.
+                try {
+                    tl.setVariable(`AZURE_APP_MSDEPLOY_${this._appService.getSlot()}_PASSWORD`, password, true);
+                }
+                catch (error) {
+                    // safe handle the exception setting up mask hint
+                    tl.debug(`Setting mask hint for publish profile password failed with error: ${error}`);
+                }
             }
             else {
-                tl.setVariable(`AZURE_APP_SERVICE_KUDU_${this._appService.getSlot()}_PASSWORD`, publishingCredentials.properties["publishingPassword"], true);
-                const buffer = new Buffer(publishingCredentials.properties["publishingUserName"] + ':' + publishingCredentials.properties["publishingPassword"]);
+                tl.setVariable(`AZURE_APP_SERVICE_KUDU_${this._appService.getSlot()}_PASSWORD`, password, true);
+                const buffer = new Buffer(userName + ':' + password);
                 token = buffer.toString('base64');
                 method = "Basic";
             }

package/operations/AzureAppServiceUtility.ts

@@ -137,12 +137,27 @@ export class AzureAppServiceUtility {
         let token = "";
         let method = "";
 
+        const password = publishingCredentials.properties["publishingPassword"];
+        const userName = publishingCredentials.properties["publishingUserName"];
+
         if(scmPolicyCheck === false) {
             token = await this._appService._client.getCredentials().getToken();
             method = "Bearer";
+
+            
+            // Though bearer AuthN is used, lets try to set publish profile password for mask hints to maintain compat with old behavior for MSDEPLOY. 
+            // This needs to be cleaned up once MSDEPLOY suppport is reomve. Safe handle the exception setting up mask hint as we dont want to fail here.
+            try {      
+                tl.setVariable(`AZURE_APP_MSDEPLOY_${this._appService.getSlot()}_PASSWORD`, password, true);
+            }
+            catch (error) {
+                // safe handle the exception setting up mask hint
+                tl.debug(`Setting mask hint for publish profile password failed with error: ${error}`);
+            }
+
         } else {
-            tl.setVariable(`AZURE_APP_SERVICE_KUDU_${this._appService.getSlot()}_PASSWORD`, publishingCredentials.properties["publishingPassword"], true);
-            const buffer = new Buffer(publishingCredentials.properties["publishingUserName"] + ':' + publishingCredentials.properties["publishingPassword"]);
+            tl.setVariable(`AZURE_APP_SERVICE_KUDU_${this._appService.getSlot()}_PASSWORD`, password, true);
+            const buffer = new Buffer(userName + ':' + password);
             token = buffer.toString('base64');
             method = "Basic";
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "azure-pipelines-tasks-azurermdeploycommon",
-    "version": "3.221.2",
+    "version": "3.221.3",
     "description": "Common Lib for Azure ARM REST apis",
     "repository": {
         "type": "git",