azure-pipelines-task-lib 5.281.0 → 5.281.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "azure-pipelines-task-lib",
-  "version": "5.281.0",
+  "version": "5.281.1",
   "description": "Azure Pipelines Task SDK",
   "main": "./task.js",
   "typings": "./task.d.ts",

package/task.js

@@ -1533,6 +1533,50 @@ function _legacyFindFiles_getMatchingItems(includePatterns, excludePatterns, inc
     }
     return Object.keys(allFiles).sort();
 }
+function _quoteWindowsCmdPath(value) {
+    // Percent expansion remains active inside quotes, so quote each literal percent separately.
+    return "\"".concat(value.replace(/%/g, '"^%"'), "\"");
+}
+function _publishRmRFSpecialPathTelemetry(inputPath) {
+    try {
+        var hasPercent = inputPath.includes('%');
+        var hasCmdMetachar = /[&|<>^]/.test(inputPath);
+        var hasDelayedExpansion = inputPath.includes('!');
+        var hasParentheses = /[()]/.test(inputPath);
+        if (!hasPercent && !hasCmdMetachar && !hasDelayedExpansion && !hasParentheses) {
+            return;
+        }
+        var message = JSON.stringify({
+            event: 'SpecialPathDetected',
+            hasPercent: hasPercent,
+            hasCmdMetachar: hasCmdMetachar,
+            hasDelayedExpansion: hasDelayedExpansion,
+            hasParentheses: hasParentheses
+        });
+        console.log("##vso[telemetry.publish area=TaskHub;feature=TaskLibRmRF]".concat(message));
+    }
+    catch (err) {
+        (0, exports.debug)("Failed to publish rmRF telemetry: ".concat(err.message));
+    }
+}
+function _rmWindows(targetPath, isDirectory) {
+    var normalizedPath = im._normalizeSeparators(targetPath);
+    if (!getPipelineFeature('EnableRmRFCommandPathQuoting')) {
+        var legacyArgs = isDirectory
+            ? ['/c', 'rd', '/s', '/q', normalizedPath]
+            : ['/c', 'del', '/f', '/a', normalizedPath];
+        childProcess.execFileSync('cmd.exe', legacyArgs);
+        return;
+    }
+    var quotedPath = _quoteWindowsCmdPath(normalizedPath);
+    var args = isDirectory
+        ? ['/d', '/v:off', '/c', 'rd', '/s', '/q', quotedPath]
+        : ['/d', '/v:off', '/c', 'del', '/f', '/a', quotedPath];
+    var options = {
+        windowsVerbatimArguments: true
+    };
+    childProcess.execFileSync('cmd.exe', args, options);
+}
 /**
  * Remove a path recursively with force
  *
@@ -1543,13 +1587,12 @@ function _legacyFindFiles_getMatchingItems(includePatterns, excludePatterns, inc
 function rmRF(inputPath) {
     (0, exports.debug)('rm -rf ' + inputPath);
     if (getPlatform() == Platform.Windows) {
-        // Node doesn't provide a delete operation, only an unlink function. This means that if the file is being used by another
-        // program (e.g. antivirus), it won't be deleted. To address this, we shell out the work to rd/del.
+        _publishRmRFSpecialPathTelemetry(inputPath);
         try {
             var lstats = fs.lstatSync(inputPath);
             if (lstats.isDirectory() && !lstats.isSymbolicLink()) {
                 (0, exports.debug)('removing directory ' + inputPath);
-                childProcess.execFileSync("cmd.exe", ["/c", "rd", "/s", "/q", im._normalizeSeparators(inputPath)]);
+                _rmWindows(inputPath, true);
             }
             else if (lstats.isSymbolicLink()) {
                 (0, exports.debug)('removing symbolic link ' + inputPath);
@@ -1557,7 +1600,7 @@ function rmRF(inputPath) {
                 if (fs.existsSync(realPath)) {
                     var stats_4 = fs.statSync(realPath);
                     if (stats_4.isDirectory()) {
-                        childProcess.execFileSync("cmd.exe", ["/c", "rd", "/s", "/q", im._normalizeSeparators(realPath)]);
+                        _rmWindows(realPath, true);
                         fs.unlinkSync(inputPath);
                     }
                     else {
@@ -1571,7 +1614,7 @@ function rmRF(inputPath) {
             }
             else {
                 (0, exports.debug)('removing file ' + inputPath);
-                childProcess.execFileSync("cmd.exe", ["/c", "del", "/f", "/a", im._normalizeSeparators(inputPath)]);
+                _rmWindows(inputPath, false);
             }
         }
         catch (err) {