azure-pipelines-task-lib 5.2.3 → 5.2.5

package/internal.js

@@ -919,13 +919,15 @@ exports._exposeCertSettings = _exposeCertSettings;
 // downstream vsts-node-api will retrieve the secret later
 function _exposeTaskLibSecret(keyFile, secret) {
     if (secret) {
-        var encryptKey = crypto.randomBytes(256);
-        var cipher = crypto.createCipher("aes-256-ctr", encryptKey);
+        var encryptKey = crypto.randomBytes(32);
+        var iv = crypto.randomBytes(16);
+        var cipher = crypto.createCipheriv("aes-256-ctr", encryptKey, iv);
         var encryptedContent = cipher.update(secret, "utf8", "hex"); // CodeQL [SM01511] agent need to retrieve password later to connect to proxy server
         encryptedContent += cipher.final("hex");
         var storageFile = path.join(_getVariable('Agent.TempDirectory') || _getVariable("agent.workFolder") || process.cwd(), keyFile);
-        fs.writeFileSync(storageFile, encryptKey.toString('base64'), { encoding: 'utf8' });
-        return new Buffer(storageFile).toString('base64') + ':' + new Buffer(encryptedContent).toString('base64');
+        var keyAndIv = encryptKey.toString('base64') + ':' + iv.toString('base64');
+        fs.writeFileSync(storageFile, keyAndIv, { encoding: 'utf8' });
+        return Buffer.from(storageFile).toString('base64') + ':' + Buffer.from(encryptedContent).toString('base64');
     }
 }
 function isSigPipeError(e) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "azure-pipelines-task-lib",
-  "version": "5.2.3",
+  "version": "5.2.5",
   "description": "Azure Pipelines Task SDK",
   "main": "./task.js",
   "typings": "./task.d.ts",

package/task.js

@@ -977,7 +977,7 @@ function ls(optionsOrPaths) {
             if (!includeHidden && entrybasename.startsWith('.') && entrybasename !== '.' && entrybasename !== '..') {
                 return "continue";
             }
-            var baseDir = pathsCopy.find(function (p) { return entry.startsWith(path.resolve(p)); }) || path.resolve('.');
+            var baseDir = safeFind(pathsCopy, function (p) { return entry.startsWith(path.resolve(p)); }) || path.resolve('.');
             if (fs.lstatSync(entry).isDirectory() && isRecursive) {
                 preparedPaths.push.apply(preparedPaths, fs.readdirSync(entry).map(function (x) { return path.join(entry, x); }));
                 entries.push(path.relative(baseDir, entry));
@@ -2404,3 +2404,19 @@ if (!global['_vsts_task_lib_loaded']) {
     im._exposeProxySettings();
     im._exposeCertSettings();
 }
+//Helper Functions for internal use only
+/**
+ * safeFind - safe replacement for Array.prototype.find
+ *
+ * @param {Array} arr - the array to search
+ * @param {Function} predicate - function to test each element, returns true if match
+ * @returns {*} - first element that matches or undefined
+ */
+function safeFind(arr, predicate) {
+    for (var i = 0; i < arr.length; i++) {
+        if (predicate(arr[i])) {
+            return arr[i];
+        }
+    }
+    return undefined;
+}