azure-pipelines-task-lib 4.17.0 → 4.17.2

package/toolrunner.d.ts

@@ -1,4 +1,6 @@
 /// <reference types="node" />
+/// <reference types="node" />
+/// <reference types="node" />
 import Q = require('q');
 import events = require('events');
 /**

package/toolrunner.js

@@ -7,6 +7,8 @@ var __extends = (this && this.__extends) || (function () {
         return extendStatics(d, b);
     };
     return function (d, b) {
+        if (typeof b !== "function" && b !== null)
+            throw new TypeError("Class extends value " + String(b) + " is not a constructor or null");
         extendStatics(d, b);
         function __() { this.constructor = d; }
         d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
@@ -107,7 +109,7 @@ var ToolRunner = /** @class */ (function (_super) {
             }
             // Windows + verbatim
             else if (options.windowsVerbatimArguments) {
-                commandParts.push("\"" + toolPath + "\"");
+                commandParts.push("\"".concat(toolPath, "\""));
                 commandParts = commandParts.concat(args);
             }
             else if (options.shell) {
@@ -134,23 +136,23 @@ var ToolRunner = /** @class */ (function (_super) {
         }
         return cmd;
     };
-    ToolRunner.prototype._processLineBuffer = function (data, strBuffer, onLine) {
+    ToolRunner.prototype._processLineBuffer = function (data, buffer, onLine) {
+        var newBuffer = buffer + data.toString();
         try {
-            var s = strBuffer + data.toString();
-            var n = s.indexOf(os.EOL);
-            while (n > -1) {
-                var line = s.substring(0, n);
+            var eolIndex = newBuffer.indexOf(os.EOL);
+            while (eolIndex > -1) {
+                var line = newBuffer.substring(0, eolIndex);
                 onLine(line);
                 // the rest of the string ...
-                s = s.substring(n + os.EOL.length);
-                n = s.indexOf(os.EOL);
+                newBuffer = newBuffer.substring(eolIndex + os.EOL.length);
+                eolIndex = newBuffer.indexOf(os.EOL);
             }
-            strBuffer = s;
         }
         catch (err) {
             // streaming lines to console is best effort.  Don't fail a build.
             this._debug('error processing line');
         }
+        return newBuffer;
     };
     /**
      * Wraps an arg string with specified char if it's not already wrapped
@@ -160,7 +162,7 @@ var ToolRunner = /** @class */ (function (_super) {
      */
     ToolRunner.prototype._wrapArg = function (arg, wrapChar) {
         if (!this._isWrapped(arg, wrapChar)) {
-            return "" + wrapChar + arg + wrapChar;
+            return "".concat(wrapChar).concat(arg).concat(wrapChar);
         }
         return arg;
     };
@@ -171,7 +173,7 @@ var ToolRunner = /** @class */ (function (_super) {
      */
     ToolRunner.prototype._unwrapArg = function (arg, wrapChar) {
         if (this._isWrapped(arg, wrapChar)) {
-            var pattern = new RegExp("(^\\\\?" + wrapChar + ")|(\\\\?" + wrapChar + "$)", 'g');
+            var pattern = new RegExp("(^\\\\?".concat(wrapChar, ")|(\\\\?").concat(wrapChar, "$)"), 'g');
             return arg.trim().replace(pattern, '');
         }
         return arg;
@@ -181,7 +183,7 @@ var ToolRunner = /** @class */ (function (_super) {
      * @param arg Input arg string
      */
     ToolRunner.prototype._isWrapped = function (arg, wrapChar) {
-        var pattern = new RegExp("^\\\\?" + wrapChar + ".+\\\\?" + wrapChar + "$");
+        var pattern = new RegExp("^\\\\?".concat(wrapChar, ".+\\\\?").concat(wrapChar, "$"));
         return pattern.test(arg.trim());
     };
     ToolRunner.prototype._getSpawnFileName = function (options) {
@@ -199,7 +201,7 @@ var ToolRunner = /** @class */ (function (_super) {
         var _this = this;
         if (process.platform == 'win32') {
             if (this._isCmdFile()) {
-                var argline = "/D /S /C \"" + this._windowsQuoteCmdArg(this.toolPath);
+                var argline = "/D /S /C \"".concat(this._windowsQuoteCmdArg(this.toolPath));
                 for (var i = 0; i < this.args.length; i++) {
                     argline += ' ';
                     argline += options.windowsVerbatimArguments ? this.args[i] : this._windowsQuoteCmdArg(this.args[i]);
@@ -243,7 +245,7 @@ var ToolRunner = /** @class */ (function (_super) {
                     if (arguments.length != 1) {
                         throw new Error('Unexpected arguments passed to args.unshift when windowsVerbatimArguments flag is set.');
                     }
-                    return Array.prototype.unshift.call(args_1, "\"" + arguments[0] + "\""); // quote the file name
+                    return Array.prototype.unshift.call(args_1, "\"".concat(arguments[0], "\"")); // quote the file name
                 };
                 return args_1;
             }
@@ -447,7 +449,7 @@ var ToolRunner = /** @class */ (function (_super) {
         if (arg.indexOf('"') < 0 && arg.indexOf('\\') < 0) {
             // No embedded double quotes or backslashes, so I can just wrap
             // quote marks around the whole thing.
-            return "\"" + arg + "\"";
+            return "\"".concat(arg, "\"");
         }
         // Expected input/output:
         //   input : hello"world
@@ -564,7 +566,7 @@ var ToolRunner = /** @class */ (function (_super) {
                 });
                 fileStream.on('error', function (err) {
                     waitingEvents--; //there were errors writing to the file, write is done
-                    _this._debug("Failed to pipe output of " + toolPathFirst + " to file " + _this.pipeOutputToFile + ". Error = " + err);
+                    _this._debug("Failed to pipe output of ".concat(toolPathFirst, " to file ").concat(_this.pipeOutputToFile, ". Error = ").concat(err));
                     fileStream = null;
                     if (waitingEvents == 0) {
                         if (error) {
@@ -636,17 +638,17 @@ var ToolRunner = /** @class */ (function (_super) {
                     }
                 }
             });
-            var stdbuffer = '';
+            var stdLineBuffer = '';
             (_c = cp.stdout) === null || _c === void 0 ? void 0 : _c.on('data', function (data) {
                 _this.emit('stdout', data);
                 if (!optionsNonNull.silent) {
                     optionsNonNull.outStream.write(data);
                 }
-                _this._processLineBuffer(data, stdbuffer, function (line) {
+                stdLineBuffer = _this._processLineBuffer(data, stdLineBuffer, function (line) {
                     _this.emit('stdline', line);
                 });
             });
-            var errbuffer = '';
+            var errLineBuffer = '';
             (_d = cp.stderr) === null || _d === void 0 ? void 0 : _d.on('data', function (data) {
                 _this.emit('stderr', data);
                 success = !optionsNonNull.failOnStdErr;
@@ -654,7 +656,7 @@ var ToolRunner = /** @class */ (function (_super) {
                     var s = optionsNonNull.failOnStdErr ? optionsNonNull.errStream : optionsNonNull.outStream;
                     s.write(data);
                 }
-                _this._processLineBuffer(data, errbuffer, function (line) {
+                errLineBuffer = _this._processLineBuffer(data, errLineBuffer, function (line) {
                     _this.emit('errline', line);
                 });
             });
@@ -669,11 +671,11 @@ var ToolRunner = /** @class */ (function (_super) {
                 waitingEvents--; //process is complete
                 _this._debug('rc:' + code);
                 returnCode = code;
-                if (stdbuffer.length > 0) {
-                    _this.emit('stdline', stdbuffer);
+                if (stdLineBuffer.length > 0) {
+                    _this.emit('stdline', stdLineBuffer);
                 }
-                if (errbuffer.length > 0) {
-                    _this.emit('errline', errbuffer);
+                if (errLineBuffer.length > 0) {
+                    _this.emit('errline', errLineBuffer);
                 }
                 if (code != 0 && !optionsNonNull.ignoreReturnCode) {
                     success = false;
@@ -744,7 +746,7 @@ var ToolRunner = /** @class */ (function (_super) {
             });
             fileStream.on('error', function (err) {
                 waitingEvents--; //there were errors writing to the file, write is done
-                _this._debug("Failed to pipe output of " + toolPathFirst + " to file " + _this.pipeOutputToFile + ". Error = " + err);
+                _this._debug("Failed to pipe output of ".concat(toolPathFirst, " to file ").concat(_this.pipeOutputToFile, ". Error = ").concat(err));
                 fileStream = null;
                 if (waitingEvents == 0) {
                     if (error) {
@@ -814,17 +816,17 @@ var ToolRunner = /** @class */ (function (_super) {
                 }
             }
         });
-        var stdbuffer = '';
+        var stdLineBuffer = '';
         (_c = cp.stdout) === null || _c === void 0 ? void 0 : _c.on('data', function (data) {
             _this.emit('stdout', data);
             if (!optionsNonNull.silent) {
                 optionsNonNull.outStream.write(data);
             }
-            _this._processLineBuffer(data, stdbuffer, function (line) {
+            stdLineBuffer = _this._processLineBuffer(data, stdLineBuffer, function (line) {
                 _this.emit('stdline', line);
             });
         });
-        var errbuffer = '';
+        var errLineBuffer = '';
         (_d = cp.stderr) === null || _d === void 0 ? void 0 : _d.on('data', function (data) {
             _this.emit('stderr', data);
             success = !optionsNonNull.failOnStdErr;
@@ -832,7 +834,7 @@ var ToolRunner = /** @class */ (function (_super) {
                 var s = optionsNonNull.failOnStdErr ? optionsNonNull.errStream : optionsNonNull.outStream;
                 s.write(data);
             }
-            _this._processLineBuffer(data, errbuffer, function (line) {
+            errLineBuffer = _this._processLineBuffer(data, errLineBuffer, function (line) {
                 _this.emit('errline', line);
             });
         });
@@ -847,11 +849,11 @@ var ToolRunner = /** @class */ (function (_super) {
             waitingEvents--; //process is complete
             _this._debug('rc:' + code);
             returnCode = code;
-            if (stdbuffer.length > 0) {
-                _this.emit('stdline', stdbuffer);
+            if (stdLineBuffer.length > 0) {
+                _this.emit('stdline', stdLineBuffer);
             }
-            if (errbuffer.length > 0) {
-                _this.emit('errline', errbuffer);
+            if (errLineBuffer.length > 0) {
+                _this.emit('errline', errLineBuffer);
             }
             if (code != 0 && !optionsNonNull.ignoreReturnCode) {
                 success = false;
@@ -966,16 +968,15 @@ var ToolRunner = /** @class */ (function (_super) {
         state.on('debug', function (message) {
             _this._debug(message);
         });
-        var stdbuffer = '';
-        var errbuffer = '';
+        var stdLineBuffer = '';
+        var errLineBuffer = '';
         var emitDoneEvent = function (resolve, reject) {
-            var _this = this;
             state.on('done', function (error, exitCode) {
-                if (stdbuffer.length > 0) {
-                    _this.emit('stdline', stdbuffer);
+                if (stdLineBuffer.length > 0) {
+                    _this.emit('stdline', stdLineBuffer);
                 }
-                if (errbuffer.length > 0) {
-                    _this.emit('errline', errbuffer);
+                if (errLineBuffer.length > 0) {
+                    _this.emit('errline', errLineBuffer);
                 }
                 if (cp) {
                     cp.removeAllListeners();
@@ -1016,7 +1017,7 @@ var ToolRunner = /** @class */ (function (_super) {
             if (!optionsNonNull.silent) {
                 optionsNonNull.outStream.write(data);
             }
-            _this._processLineBuffer(data, stdbuffer, function (line) {
+            stdLineBuffer = _this._processLineBuffer(data, stdLineBuffer, function (line) {
                 _this.emit('stdline', line);
             });
         });
@@ -1027,7 +1028,7 @@ var ToolRunner = /** @class */ (function (_super) {
                 var s = optionsNonNull.failOnStdErr ? optionsNonNull.errStream : optionsNonNull.outStream;
                 s.write(data);
             }
-            _this._processLineBuffer(data, errbuffer, function (line) {
+            errLineBuffer = _this._processLineBuffer(data, errLineBuffer, function (line) {
                 _this.emit('errline', line);
             });
         });
@@ -1037,17 +1038,18 @@ var ToolRunner = /** @class */ (function (_super) {
             state.processClosed = true;
             state.CheckComplete();
         });
+        // Do not write debug logs here. Sometimes stdio not closed yet and you can damage user output commands.
         cp.on('exit', function (code, signal) {
             state.processExitCode = code;
+            state.processExitSignal = signal;
             state.processExited = true;
-            _this._debug("STDIO streams have closed and received exit code " + code + " and signal " + signal + " for tool '" + _this.toolPath + "'");
             state.CheckComplete();
         });
         cp.on('close', function (code, signal) {
-            state.processExitCode = code;
-            state.processExited = true;
+            state.processCloseCode = code;
+            state.processCloseSignal = signal;
             state.processClosed = true;
-            _this._debug("STDIO streams have closed and received exit code " + code + " and signal " + signal + " for tool '" + _this.toolPath + "'");
+            state.processExited = true;
             state.CheckComplete();
         });
         return new Promise(emitDoneEvent);
@@ -1082,14 +1084,14 @@ var ToolRunner = /** @class */ (function (_super) {
         state.on('debug', function (message) {
             _this._debug(message);
         });
-        var stdbuffer = '';
-        var errbuffer = '';
+        var stdLineBuffer = '';
+        var errLineBuffer = '';
         state.on('done', function (error, exitCode) {
-            if (stdbuffer.length > 0) {
-                _this.emit('stdline', stdbuffer);
+            if (stdLineBuffer.length > 0) {
+                _this.emit('stdline', stdLineBuffer);
             }
-            if (errbuffer.length > 0) {
-                _this.emit('errline', errbuffer);
+            if (errLineBuffer.length > 0) {
+                _this.emit('errline', errLineBuffer);
             }
             if (cp) {
                 cp.removeAllListeners();
@@ -1127,7 +1129,7 @@ var ToolRunner = /** @class */ (function (_super) {
             if (!optionsNonNull.silent) {
                 optionsNonNull.outStream.write(data);
             }
-            _this._processLineBuffer(data, stdbuffer, function (line) {
+            stdLineBuffer = _this._processLineBuffer(data, stdLineBuffer, function (line) {
                 _this.emit('stdline', line);
             });
         });
@@ -1138,7 +1140,7 @@ var ToolRunner = /** @class */ (function (_super) {
                 var s = optionsNonNull.failOnStdErr ? optionsNonNull.errStream : optionsNonNull.outStream;
                 s.write(data);
             }
-            _this._processLineBuffer(data, errbuffer, function (line) {
+            errLineBuffer = _this._processLineBuffer(data, errLineBuffer, function (line) {
                 _this.emit('errline', line);
             });
         });
@@ -1148,17 +1150,18 @@ var ToolRunner = /** @class */ (function (_super) {
             state.processClosed = true;
             state.CheckComplete();
         });
+        // Do not write debug logs here. Sometimes stdio not closed yet and you can damage user output commands.
         cp.on('exit', function (code, signal) {
             state.processExitCode = code;
+            state.processExitSignal = signal;
             state.processExited = true;
-            _this._debug("STDIO streams have closed and received exit code " + code + " and signal " + signal + " for tool '" + _this.toolPath + "'");
             state.CheckComplete();
         });
         cp.on('close', function (code, signal) {
-            state.processExitCode = code;
-            state.processExited = true;
+            state.processCloseCode = code;
+            state.processCloseSignal = signal;
             state.processClosed = true;
-            _this._debug("STDIO streams have closed and received exit code " + code + " and signal " + signal + " for tool '" + _this.toolPath + "'");
+            state.processExited = true;
             state.CheckComplete();
         });
         return defer.promise;
@@ -1204,7 +1207,7 @@ var ToolRunner = /** @class */ (function (_super) {
     ToolRunner.prototype.killChildProcess = function (signal) {
         if (signal === void 0) { signal = "SIGTERM"; }
         if (this.childProcess) {
-            this._debug("[killChildProcess] Signal " + signal + " received");
+            this._debug("[killChildProcess] Signal ".concat(signal, " received"));
             this.childProcess.kill(signal);
         }
     };
@@ -1246,6 +1249,7 @@ var ExecState = /** @class */ (function (_super) {
         // determine whether there is an error
         var error;
         if (this.processExited) {
+            this._debug("Process exited with code ".concat(this.processExitCode, " and signal ").concat(this.processExitSignal, " for tool '").concat(this.toolPath, "'"));
             if (this.processError) {
                 error = new Error(im._loc('LIB_ProcessError', this.toolPath, this.processError));
             }
@@ -1256,6 +1260,9 @@ var ExecState = /** @class */ (function (_super) {
                 error = new Error(im._loc('LIB_ProcessStderr', this.toolPath));
             }
         }
+        if (this.processClosed) {
+            this._debug("STDIO streams have closed and received exit code ".concat(this.processCloseCode, " and signal ").concat(this.processCloseSignal, " for tool '").concat(this.toolPath, "'"));
+        }
         // clear the timeout
         if (this.timeout) {
             clearTimeout(this.timeout);