azdo-cli 0.24.0-feature-059-project-operations-guide.922 → 0.24.0-feature-061-fix-sonar.925

package/README.md

@@ -162,7 +162,6 @@ azdo relations list 1000 --json             # JSON: { workItemId, relations: [..
 | Linux credential store setup | [docs/linux-credential-store.md](docs/linux-credential-store.md) |
 | Full command reference — every command, alias and option, credential resolution order, and the `--json` output contracts | [docs/commands.md](docs/commands.md) |
 | Development setup | [docs/development.md](docs/development.md) |
-| Project operations and automation (Dev Container, VM, Hermes) | [instructions/README.md](instructions/README.md) |
 
 ## License
 

package/dist/{chunk-DNOOZIXA.js → chunk-5PPUTWGL.js}

@@ -1047,6 +1047,21 @@ var DpapiEntry = class {
   }
 };
 
+// src/lib/async.ts
+function runSequentially(items, task) {
+  return items.reduce(
+    (previous, item, index) => previous.then(() => task(item, index)),
+    Promise.resolve()
+  );
+}
+function asPromise(fn) {
+  try {
+    return Promise.resolve(fn());
+  } catch (err) {
+    return Promise.reject(err instanceof Error ? err : new Error(String(err)));
+  }
+}
+
 // src/services/credential-store.ts
 var SERVICE = "azdo-cli";
 var LEGACY_ACCOUNT = "pat";
@@ -1187,7 +1202,7 @@ function serializeCredential(cred) {
   }
   return JSON.stringify(cred);
 }
-async function maybeMigrateLegacy(targetOrg) {
+function maybeMigrateLegacy(targetOrg) {
   if (activeCredentialStore() === "dpapi") return null;
   const config = loadConfig();
   if (!config.org || config.org !== targetOrg) {
@@ -1235,30 +1250,31 @@ async function getPat(org) {
   if (cred.kind === "pat") return cred.token;
   return null;
 }
-async function getStoredCredential(org) {
-  const entry = entryFor(accountFor(org));
-  const value = wrapUnavailable(() => entry.getPassword());
-  if (value === null) {
-    const migrated = await maybeMigrateLegacy(org);
-    if (migrated === null) return null;
-    return parseStoredValue(migrated);
-  }
-  return parseStoredValue(value);
+function getStoredCredential(org) {
+  return asPromise(() => {
+    const entry = entryFor(accountFor(org));
+    const value = wrapUnavailable(() => entry.getPassword()) ?? maybeMigrateLegacy(org);
+    return value === null ? null : parseStoredValue(value);
+  });
 }
-async function storePat(org, pat) {
-  const cred = { kind: "pat", token: pat };
-  const entry = entryFor(accountFor(org));
-  wrapUnavailable(() => entry.setPassword(serializeCredential(cred)));
-  appendAuthAuditEvent({
-    event: "auth.store",
-    org,
-    backend: probeBackend(),
-    masked_pat: maskedDisplay(pat)
+function storePat(org, pat) {
+  return asPromise(() => {
+    const cred = { kind: "pat", token: pat };
+    const entry = entryFor(accountFor(org));
+    wrapUnavailable(() => entry.setPassword(serializeCredential(cred)));
+    appendAuthAuditEvent({
+      event: "auth.store",
+      org,
+      backend: probeBackend(),
+      masked_pat: maskedDisplay(pat)
+    });
   });
 }
-async function storeOAuthCredential(org, cred) {
-  const entry = entryFor(accountFor(org));
-  wrapUnavailable(() => entry.setPassword(serializeCredential(cred)));
+function storeOAuthCredential(org, cred) {
+  return asPromise(() => {
+    const entry = entryFor(accountFor(org));
+    wrapUnavailable(() => entry.setPassword(serializeCredential(cred)));
+  });
 }
 async function deletePat(org) {
   const entry = entryFor(accountFor(org));
@@ -1290,13 +1306,16 @@ async function deletePat(org) {
   }
   try {
     const { unlinkSync: unlinkSync2 } = await import("fs");
-    const { lockPath: lockPath2 } = await import("./oauth-token-refresh-RLDAAR5D.js");
+    const { lockPath: lockPath2 } = await import("./oauth-token-refresh-MFVKQFJI.js");
     unlinkSync2(lockPath2(org));
   } catch {
   }
   return true;
 }
-async function listOrgsWithStoredPat() {
+function listOrgsWithStoredPat() {
+  return asPromise(listOrgsWithStoredPatSync);
+}
+function listOrgsWithStoredPatSync() {
   const seen = /* @__PURE__ */ new Set();
   for (const ev of readAuditEvents()) {
     if (ev.event === "auth.store" || ev.event === "oauth-login-success") {
@@ -1387,25 +1406,26 @@ function lockPath(org) {
 async function defaultAcquireLock(org, waitMs = DEFAULT_LOCK_WAIT_MS) {
   const path4 = lockPath(org);
   mkdirSync(locksDir(), { recursive: true, mode: 448 });
-  const deadline = Date.now() + waitMs;
-  for (; ; ) {
-    try {
-      const fd = openSync2(path4, "wx");
-      closeSync2(fd);
-      return {
-        release: () => {
-          try {
-            unlinkSync(path4);
-          } catch {
-          }
+  return tryAcquireLock(path4, Date.now() + waitMs);
+}
+async function tryAcquireLock(path4, deadline) {
+  try {
+    const fd = openSync2(path4, "wx");
+    closeSync2(fd);
+    return {
+      release: () => {
+        try {
+          unlinkSync(path4);
+        } catch {
         }
-      };
-    } catch (err) {
-      if (err.code !== "EEXIST") throw err;
-      if (Date.now() > deadline) return null;
-      await new Promise((r) => setTimeout(r, 100));
-    }
+      }
+    };
+  } catch (err) {
+    if (err.code !== "EEXIST") throw err;
+    if (Date.now() > deadline) return null;
   }
+  await new Promise((r) => setTimeout(r, 100));
+  return tryAcquireLock(path4, deadline);
 }
 function classifyRefreshFailure(error) {
   const code = typeof error === "string" ? error : error.error ?? "";
@@ -1543,6 +1563,7 @@ export {
   CredentialStoreUnavailableError,
   CredentialMissingError,
   CredentialRefreshError,
+  runSequentially,
   appendAuthAuditEvent,
   readAuditEvents,
   SETTINGS,

package/dist/index.js

@@ -37,6 +37,7 @@ import {
   resolveOAuthConfig,
   resolveScopedConfig,
   runAuthCodeFlow,
+  runSequentially,
   setConfigValue,
   setOrgScopedValue,
   storeOAuthCredential,
@@ -45,7 +46,7 @@ import {
   tokenResponseToCredential,
   unsetConfigValue,
   unsetOrgScopedValue
-} from "./chunk-DNOOZIXA.js";
+} from "./chunk-5PPUTWGL.js";
 
 // src/program.ts
 import { Command as Command20 } from "commander";
@@ -154,6 +155,14 @@ function handleCommandError(err, id, context, scope = "write", exit = true) {
     return;
   }
   const error = err instanceof Error ? err : new Error(String(err));
+  writeCommandError(error, id, context, scope);
+  if (exit) {
+    process.exit(1);
+  } else {
+    process.exitCode = 1;
+  }
+}
+function writeCommandError(error, id, context, scope) {
   const msg = error.message;
   const scopeLabel = scope === "read" ? "Work Items (read)" : "Work Items (Read & Write)";
   if (isSentinel(msg, "AUTH_FAILED")) {
@@ -193,11 +202,6 @@ function handleCommandError(err, id, context, scope = "write", exit = true) {
     process.stderr.write(`Error: ${msg}
 `);
   }
-  if (exit) {
-    process.exit(1);
-  } else {
-    process.exitCode = 1;
-  }
 }
 var STDIN_PATH = "-";
 function readTextSource(file) {
@@ -340,9 +344,8 @@ async function downloadImagesFromFields(fields, args, credential) {
     }
   }
   const results = [];
-  let index = 0;
-  for (const reference of references) {
-    index += 1;
+  await runSequentially(references, async (reference, position) => {
+    const index = position + 1;
     try {
       const bytes = await downloadAttachment(reference.url, credential);
       const processed = await processImageBytes(bytes, options.maxWidth);
@@ -363,7 +366,7 @@ async function downloadImagesFromFields(fields, args, credential) {
         error: err instanceof Error ? err.message : String(err)
       });
     }
-  }
+  });
   return results;
 }
 async function runImageDownload(fields, args, credential) {
@@ -846,23 +849,22 @@ async function getWorkItemFieldValue(context, id, cred, fieldName) {
   }
   return stringifyFieldValue(value);
 }
+async function listWorkItemCommentPages(context, id, cred, continuationToken) {
+  const response = await fetchWithErrors(
+    buildWorkItemCommentsListUrl(context, id, continuationToken ?? void 0).toString(),
+    { headers: authHeaders(cred) }
+  );
+  if (!response.ok) {
+    throw httpError(response);
+  }
+  const data = await response.json();
+  const comments = (data.comments ?? []).map((comment) => mapWorkItemComment(comment, id)).filter((comment) => !comment.isDeleted);
+  const next = readContinuationToken(response, data);
+  if (next === null) return comments;
+  return [...comments, ...await listWorkItemCommentPages(context, id, cred, next)];
+}
 async function listWorkItemComments(context, id, cred) {
-  const comments = [];
-  let continuationToken = null;
-  do {
-    const response = await fetchWithErrors(
-      buildWorkItemCommentsListUrl(context, id, continuationToken ?? void 0).toString(),
-      { headers: authHeaders(cred) }
-    );
-    if (!response.ok) {
-      throw httpError(response);
-    }
-    const data = await response.json();
-    comments.push(
-      ...(data.comments ?? []).map((comment) => mapWorkItemComment(comment, id)).filter((comment) => !comment.isDeleted)
-    );
-    continuationToken = readContinuationToken(response, data);
-  } while (continuationToken !== null);
+  const comments = await listWorkItemCommentPages(context, id, cred, null);
   return {
     workItemId: id,
     count: comments.length,
@@ -1442,29 +1444,26 @@ async function loginWithOAuth(org, opts = {}) {
 async function logout(opts = {}) {
   if (opts.all) {
     const orgs = await listOrgsWithStoredPat();
-    const removed = [];
-    for (const o of orgs) {
-      const cred2 = await getStoredCredential(o);
-      const ok2 = await deletePat(o);
-      if (ok2 && cred2 !== null) {
-        removed.push({ org: o, kind: cred2.kind });
-      }
-    }
-    return { removed };
+    const perOrg = await Promise.all(orgs.map((o) => logoutOrg(o)));
+    return { removed: perOrg.flat() };
   }
   if (!opts.org) {
     throw new Error("logout requires an org or --all");
   }
-  const cred = await getStoredCredential(opts.org);
-  const ok = await deletePat(opts.org);
-  return { removed: ok && cred !== null ? [{ org: opts.org, kind: cred.kind }] : [] };
+  return { removed: await logoutOrg(opts.org) };
+}
+async function logoutOrg(org) {
+  const cred = await getStoredCredential(org);
+  const ok = await deletePat(org);
+  return ok && cred !== null ? [{ org, kind: cred.kind }] : [];
 }
 async function status() {
   const orgs = await listOrgsWithStoredPat();
+  const creds = await Promise.all(orgs.map((org) => getStoredCredential(org)));
   const out = [];
-  for (const org of orgs) {
-    const cred = await getStoredCredential(org);
-    if (cred === null) continue;
+  orgs.forEach((org, i) => {
+    const cred = creds[i];
+    if (cred === null) return;
     if (cred.kind === "pat") {
       out.push({ org, kind: "pat", backend: probeBackend() });
     } else {
@@ -1477,7 +1476,7 @@ async function status() {
         backend: probeBackend()
       });
     }
-  }
+  });
   return { orgs: out };
 }
 async function exportCredential(org) {
@@ -3128,10 +3127,8 @@ ${renderSettingsHelp()}`);
     const ask = createAsk(rl);
     process.stderr.write("Azure DevOps CLI - Configuration Wizard\n");
     process.stderr.write("=======================================\n\n");
-    for (const setting of SETTINGS) {
-      if (setting.key === "credentialStore") continue;
-      await promptForSetting(cfg, setting, ask);
-    }
+    const wizardSettings = SETTINGS.filter((setting) => setting.key !== "credentialStore");
+    await runSequentially(wizardSettings, (setting) => promptForSetting(cfg, setting, ask));
     rl.close();
     process.stderr.write("Configuration complete!\n");
   });
@@ -3771,7 +3768,8 @@ function stringifyValue(value) {
   if (value === null || value === void 0) return "";
   if (typeof value === "string") return value;
   if (typeof value === "object") return JSON.stringify(value);
-  if (typeof value === "symbol" || typeof value === "function") return value.toString();
+  if (typeof value === "symbol") return value.toString();
+  if (typeof value === "function") return `[function ${value.name || "anonymous"}]`;
   return String(value);
 }
 function formatRichValue(raw) {
@@ -6871,26 +6869,25 @@ async function getTestSummary(context, cred, buildId) {
 var MAX_FAILED_TESTS = 50;
 async function getFailedTests(context, cred, buildId) {
   const testRuns = await listTestRuns(context, cred, buildId);
-  const failed = [];
-  for (const testRun of testRuns) {
-    if (failed.length >= MAX_FAILED_TESTS) break;
-    const resultsUrl = withApiVersion(
-      new URL(`${orgProjectBase(context)}/_apis/test/runs/${testRun.id}/results`)
-    );
-    resultsUrl.searchParams.set("outcomes", "Failed");
-    resultsUrl.searchParams.set("$top", String(MAX_FAILED_TESTS - failed.length));
-    const resultsResponse = await fetchWithErrors(resultsUrl.toString(), {
-      headers: authHeaders(cred)
-    });
-    const resultsData = await readJsonResponse2(resultsResponse);
-    for (const result of resultsData.value) {
-      failed.push({
-        name: result.testCaseTitle ?? result.automatedTestName ?? "(unnamed test)",
-        errorMessage: result.errorMessage ?? null
-      });
-    }
-  }
-  return failed;
+  return collectFailedTests(context, cred, testRuns, []);
+}
+async function collectFailedTests(context, cred, testRuns, failed) {
+  const [testRun, ...rest] = testRuns;
+  if (testRun === void 0 || failed.length >= MAX_FAILED_TESTS) return failed;
+  const resultsUrl = withApiVersion(
+    new URL(`${orgProjectBase(context)}/_apis/test/runs/${testRun.id}/results`)
+  );
+  resultsUrl.searchParams.set("outcomes", "Failed");
+  resultsUrl.searchParams.set("$top", String(MAX_FAILED_TESTS - failed.length));
+  const resultsResponse = await fetchWithErrors(resultsUrl.toString(), {
+    headers: authHeaders(cred)
+  });
+  const resultsData = await readJsonResponse2(resultsResponse);
+  const page = resultsData.value.map((result) => ({
+    name: result.testCaseTitle ?? result.automatedTestName ?? "(unnamed test)",
+    errorMessage: result.errorMessage ?? null
+  }));
+  return collectFailedTests(context, cred, rest, [...failed, ...page]);
 }
 function secondsBetween(start, finish) {
   if (!start || !finish) return null;
@@ -7163,6 +7160,17 @@ function sleep(ms) {
     setTimeout(resolve2, ms);
   });
 }
+async function pollRunUntilDone(context, cred, runId, timing) {
+  const status2 = await getBuildStatus(context, cred, runId);
+  if (status2.state === "completed") {
+    return { id: runId, state: status2.state, result: status2.result, timedOut: false };
+  }
+  if (Date.now() >= timing.deadline) {
+    return { id: runId, state: status2.state, result: status2.result, timedOut: true };
+  }
+  await sleep(timing.pollMs);
+  return pollRunUntilDone(context, cred, runId, timing);
+}
 function formatTable(rows, rightAlign = /* @__PURE__ */ new Set()) {
   const widths = [];
   for (const row of rows) {
@@ -7325,19 +7333,10 @@ function createPipelineWaitCommand() {
       const resolved = await resolvePipelineContext(options);
       context = resolved.context;
       const deadline = Date.now() + timeoutSec * 1e3;
-      let waitResult = null;
-      for (; ; ) {
-        const status2 = await getBuildStatus(resolved.context, resolved.cred, runId);
-        if (status2.state === "completed") {
-          waitResult = { id: runId, state: status2.state, result: status2.result, timedOut: false };
-          break;
-        }
-        if (Date.now() >= deadline) {
-          waitResult = { id: runId, state: status2.state, result: status2.result, timedOut: true };
-          break;
-        }
-        await sleep(pollSec * 1e3);
-      }
+      const waitResult = await pollRunUntilDone(resolved.context, resolved.cred, runId, {
+        deadline,
+        pollMs: pollSec * 1e3
+      });
       applyWaitExitCode(waitResult);
       if (options.json) {
         process.stdout.write(`${JSON.stringify(waitResult, null, 2)}

package/dist/{oauth-token-refresh-RLDAAR5D.js → oauth-token-refresh-MFVKQFJI.js}

@@ -5,7 +5,7 @@ import {
   lockPath,
   locksDir,
   refreshIfNeeded
-} from "./chunk-DNOOZIXA.js";
+} from "./chunk-5PPUTWGL.js";
 export {
   _resetInFlight,
   classifyRefreshFailure,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "azdo-cli",
-  "version": "0.24.0-feature-059-project-operations-guide.922",
+  "version": "0.24.0-feature-061-fix-sonar.925",
   "description": "Azure DevOps CLI tool",
   "type": "module",
   "bin": {