axe-core 4.2.0 → 4.2.1

package/.prettierrc.json

@@ -0,0 +1,10 @@
+{
+  "printWidth": 80,
+  "useTabs": false,
+  "tabWidth": 2,
+  "semi": true,
+  "singleQuote": true,
+  "trailingComma": "none",
+  "bracketSpacing": true,
+  "arrowParens": "avoid"
+}

package/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [4.2.1](https://github.com/dequelabs/axe-core/compare/v4.2.0...v4.2.1) (2021-05-18)
+
+### Bug Fixes
+
+- **aria-allowed-attr:** pass aria-label on some HTML elements ([#2935](https://github.com/dequelabs/axe-core/issues/2935)) ([695aa77](https://github.com/dequelabs/axe-core/commit/695aa7751246c0e5e786a66df7808faa7a244576))
+- treat input with no role as textbox ([#2929](https://github.com/dequelabs/axe-core/issues/2929)) ([de18030](https://github.com/dequelabs/axe-core/commit/de180307fd876cfc6a1a0bdb828818a323976c81))
+- **autocomplete-appropriate:** pass for autocomplete=username and type=email ([#2896](https://github.com/dequelabs/axe-core/issues/2896)) ([8b478c8](https://github.com/dequelabs/axe-core/commit/8b478c82b3362fc27df8a0087c779327e6a9d6d0))
+- **getStandards:** Read standards from utils ([#2903](https://github.com/dequelabs/axe-core/issues/2903)) ([52ad4c6](https://github.com/dequelabs/axe-core/commit/52ad4c69991e433d413846c4c9778fdd863aebeb))
+- **required-parent:** Allow *item > group > *item nesting ([#2898](https://github.com/dequelabs/axe-core/issues/2898)) ([3acd229](https://github.com/dequelabs/axe-core/commit/3acd229b08b806ea359e7e08e37e8721cddc5290))
+- **types:** make `evaluate` check optional ([#2902](https://github.com/dequelabs/axe-core/issues/2902)) ([75fabfe](https://github.com/dequelabs/axe-core/commit/75fabfef3adeade350902f2dd18928e44fbb7cf4))
+
 ## [4.2.0](https://github.com/dequelabs/axe-core/compare/v4.1.2...v4.2.0) (2021-04-23)
 
 ### Features

package/README.md

@@ -16,7 +16,7 @@ Axe is an accessibility testing engine for websites and other HTML-based user in
 
 Axe-core has different types of rules, for WCAG 2.0 and 2.1 on level A and AA, as well as a number of best practices that help you identify common accessibility practices like ensuring every page has an `h1` heading, and to help you avoid "gotchas" in ARIA like where an ARIA attribute you used will get ignored.
 
-With axe-core, you can find **up to 50% of WCAG issues automatically**. Additionally, axe-core will return elements as "incomplete" where axe-core could not be certain, and manual review is needed. To further improve test coverage we recommend the [intelligent guided tests](https://www.youtube.com/watch?v=AtsX0dPCG_4&feature=youtu.be&ab_channel=DequeSystems) in the [axe Extension](https://www.deque.com/axe/browser-extensions/).
+With axe-core, you can find **on average 57% of WCAG issues automatically**. Additionally, axe-core will return elements as "incomplete" where axe-core could not be certain, and manual review is needed. To further improve test coverage we recommend the [intelligent guided tests](https://www.youtube.com/watch?v=AtsX0dPCG_4&feature=youtu.be&ab_channel=DequeSystems) in the [axe Extension](https://www.deque.com/axe/browser-extensions/).
 
 The complete list of rules, grouped WCAG level and best practice, can found in [doc/rule-descriptions.md](./doc/rule-descriptions.md).
 

package/axe.d.ts

@@ -206,7 +206,7 @@ declare namespace axe {
   }
   interface Check {
     id: string;
-    evaluate: Function | string;
+    evaluate?: Function | string;
     after?: Function | string;
     options?: any;
     matches?: string;

package/axe.js

@@ -1,4 +1,4 @@
-/*! axe v4.2.0
+/*! axe v4.2.1
  * Copyright (c) 2021 Deque Systems, Inc.
  *
  * Your use of this Source Code Form is subject to the terms of the Mozilla Public
@@ -27,7 +27,7 @@
     return _typeof(obj);
   }
   var axe = axe || {};
-  axe.version = '4.2.0';
+  axe.version = '4.2.1';
   if (typeof define === 'function' && define.amd) {
     define('axe-core', [], function() {
       return axe;
@@ -5067,6 +5067,9 @@
       getShadowSelector: function getShadowSelector() {
         return get_shadow_selector_default;
       },
+      getStandards: function getStandards() {
+        return _getStandards;
+      },
       getStyleSheetFactory: function getStyleSheetFactory() {
         return get_stylesheet_factory_default;
       },
@@ -8483,7 +8486,7 @@
       },
       listitem: {
         type: 'structure',
-        requiredContext: [ 'list' ],
+        requiredContext: [ 'list', 'group' ],
         allowedAttrs: [ 'aria-level', 'aria-posinset', 'aria-setsize', 'aria-expanded' ],
         superclassRole: [ 'section' ],
         nameFromContent: true
@@ -10751,6 +10754,9 @@
       return windowScroll.concat(getElmScrollRecursive(document.body));
     }
     var get_scroll_state_default = getScrollState;
+    function _getStandards() {
+      return clone_default(standards_default);
+    }
     function getStyleSheetFactory(dynamicDoc) {
       if (!dynamicDoc) {
         throw new Error('axe.utils.getStyleSheetFactory should be invoked with an argument');
@@ -12155,22 +12161,9 @@
           suggestionsSourceElement = listElement && listElement.nodeName.toLowerCase() === 'datalist';
         }
         switch (vNode.props.type) {
-         case 'button':
-         case 'image':
-         case 'reset':
-         case 'submit':
-          return 'button';
-
          case 'checkbox':
           return 'checkbox';
 
-         case 'email':
-         case 'tel':
-         case 'text':
-         case 'url':
-         case '':
-          return !suggestionsSourceElement ? 'textbox' : 'combobox';
-
          case 'number':
           return 'spinbutton';
 
@@ -12182,6 +12175,22 @@
 
          case 'search':
           return !suggestionsSourceElement ? 'searchbox' : 'combobox';
+
+         case 'button':
+         case 'image':
+         case 'reset':
+         case 'submit':
+          return 'button';
+
+         case 'text':
+         case 'tel':
+         case 'url':
+         case 'email':
+         case '':
+          return !suggestionsSourceElement ? 'textbox' : 'combobox';
+
+         default:
+          return 'textbox';
         }
       },
       li: 'listitem',
@@ -15425,29 +15434,35 @@
       return virtualNode.attr('aria-hidden') !== 'true';
     }
     var aria_hidden_body_evaluate_default = ariaHiddenBodyEvaluate;
-    function ariaProhibitedAttrEvaluate(node, options, virtualNode) {
-      var prohibited = [];
-      var role = get_role_default(virtualNode);
-      var attrs = virtualNode.attrNames;
-      var prohibitedAttrs = role ? standards_default.ariaRoles[role].prohibitedAttrs : [ 'aria-label', 'aria-labelledby' ];
-      if (!prohibitedAttrs) {
+    function ariaProhibitedAttrEvaluate(node) {
+      var options = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
+      var virtualNode = arguments.length > 2 ? arguments[2] : undefined;
+      var _options$elementsAllo = options.elementsAllowedAriaLabel, elementsAllowedAriaLabel = _options$elementsAllo === void 0 ? [] : _options$elementsAllo;
+      var prohibitedList = listProhibitedAttrs(virtualNode, elementsAllowedAriaLabel);
+      var prohibited = prohibitedList.filter(function(attrName) {
+        if (!virtualNode.attrNames.includes(attrName)) {
+          return false;
+        }
+        return sanitize_default(virtualNode.attr(attrName)) !== '';
+      });
+      if (prohibited.length === 0) {
         return false;
       }
-      for (var _i14 = 0; _i14 < attrs.length; _i14++) {
-        var attrName = attrs[_i14];
-        var attrValue = sanitize_default(virtualNode.attr(attrName));
-        if (prohibitedAttrs.includes(attrName) && attrValue !== '') {
-          prohibited.push(attrName);
-        }
+      this.data(prohibited);
+      var hasTextContent = sanitize_default(subtree_text_default(virtualNode)) !== '';
+      return hasTextContent ? void 0 : true;
+    }
+    function listProhibitedAttrs(virtualNode, elementsAllowedAriaLabel) {
+      var role = get_role_default(virtualNode);
+      var roleSpec = standards_default.ariaRoles[role];
+      if (roleSpec) {
+        return roleSpec.prohibitedAttrs || [];
       }
-      if (prohibited.length) {
-        this.data(prohibited);
-        if (!role && sanitize_default(subtree_text_default(virtualNode)) !== '') {
-          return void 0;
-        }
-        return true;
+      var nodeName2 = virtualNode.props.nodeName;
+      if (elementsAllowedAriaLabel.includes(nodeName2)) {
+        return [];
       }
-      return false;
+      return [ 'aria-label', 'aria-labelledby' ];
     }
     var aria_prohibited_attr_evaluate_default = ariaProhibitedAttrEvaluate;
     var standards_exports = {};
@@ -15484,8 +15499,8 @@
           required = unique_array_default(options[role], required);
         }
         if (role && required) {
-          for (var _i15 = 0, l = required.length; _i15 < l; _i15++) {
-            var attr = required[_i15];
+          for (var _i14 = 0, l = required.length; _i14 < l; _i14++) {
+            var attr = required[_i14];
             if (!virtualNode.attr(attr) && !(elmSpec.implicitAttrs && typeof elmSpec.implicitAttrs[attr] !== 'undefined')) {
               missing.push(attr);
             }
@@ -15502,8 +15517,8 @@
     function getOwnedRoles(virtualNode, required) {
       var ownedRoles = [];
       var ownedElements = get_owned_virtual_default(virtualNode);
-      var _loop4 = function _loop4(_i16) {
-        var ownedElement = ownedElements[_i16];
+      var _loop4 = function _loop4(_i15) {
+        var ownedElement = ownedElements[_i15];
         var role = get_role_default(ownedElement, {
           noPresentational: true
         });
@@ -15515,8 +15530,8 @@
           ownedRoles.push(role);
         }
       };
-      for (var _i16 = 0; _i16 < ownedElements.length; _i16++) {
-        _loop4(_i16);
+      for (var _i15 = 0; _i15 < ownedElements.length; _i15++) {
+        _loop4(_i15);
       }
       return ownedRoles;
     }
@@ -15537,8 +15552,8 @@
           return !expandedChildRoles.includes(requiredRole) || expanded && requiredRole === popupRole;
         });
       }
-      for (var _i17 = 0; _i17 < ownedRoles.length; _i17++) {
-        var ownedRole = ownedRoles[_i17];
+      for (var _i16 = 0; _i16 < ownedRoles.length; _i16++) {
+        var ownedRole = ownedRoles[_i16];
         if (required.includes(ownedRole)) {
           required = required.filter(function(requiredRole) {
             return requiredRole !== ownedRole;
@@ -15574,7 +15589,7 @@
       return false;
     }
     var aria_required_children_evaluate_default = ariaRequiredChildrenEvaluate;
-    function getMissingContext(virtualNode, reqContext, includeElement) {
+    function getMissingContext(virtualNode, ownGroupRoles, reqContext, includeElement) {
       var explicitRole2 = get_explicit_role_default(virtualNode);
       if (!reqContext) {
         reqContext = required_context_default(explicitRole2);
@@ -15586,6 +15601,9 @@
       while (vNode) {
         var parentRole = get_role_default(vNode);
         if (reqContext.includes('group') && parentRole === 'group') {
+          if (ownGroupRoles.includes(explicitRole2)) {
+            reqContext.push(explicitRole2);
+          }
           vNode = vNode.parent;
           continue;
         }
@@ -15614,14 +15632,15 @@
       return owners.length ? owners : null;
     }
     function ariaRequiredParentEvaluate(node, options, virtualNode) {
-      var missingParents = getMissingContext(virtualNode);
+      var ownGroupRoles = options && Array.isArray(options.ownGroupRoles) ? options.ownGroupRoles : [];
+      var missingParents = getMissingContext(virtualNode, ownGroupRoles);
       if (!missingParents) {
         return true;
       }
       var owners = getAriaOwners(node);
       if (owners) {
-        for (var i = 0, l = owners.length; i < l; i++) {
-          missingParents = getMissingContext(get_node_from_tree_default(owners[i]), missingParents, true);
+        for (var _i17 = 0, l = owners.length; _i17 < l; _i17++) {
+          missingParents = getMissingContext(get_node_from_tree_default(owners[_i17]), ownGroupRoles, missingParents, true);
           if (!missingParents) {
             return true;
           }
@@ -16823,6 +16842,7 @@
       var allowedTypesMap = {
         bday: [ 'text', 'search', 'date' ],
         email: [ 'text', 'search', 'email' ],
+        username: [ 'text', 'search', 'email' ],
         'street-address': [ 'text' ],
         tel: [ 'text', 'search', 'tel' ],
         'tel-country-code': [ 'text', 'search', 'tel' ],
@@ -21059,8 +21079,8 @@
           help: 'Form field must not have multiple label elements'
         },
         'frame-focusable-content': {
-          description: 'Ensures <frame> and <iframe> elements with tabindex=-1 do not have focusable content',
-          help: 'Frames with tabindex=-1 must not have focusable content'
+          description: 'Ensures <frame> and <iframe> elements with focusable content do not have tabindex=-1',
+          help: 'Frames with focusable content must not have tabindex=-1'
         },
         'frame-tested': {
           description: 'Ensures <iframe> and <frame> elements contain the axe-core script',
@@ -21340,10 +21360,10 @@
           }
         },
         'aria-prohibited-attr': {
-          impact: 'critical',
+          impact: 'serious',
           messages: {
             pass: 'ARIA attribute is allowed',
-            fail: 'ARIA attribute cannot be used: ${data.values}',
+            fail: 'ARIA attribute cannot be used, add a role attribute or use a different element: ${data.values}',
             incomplete: 'ARIA attribute is not well supported on the element and the text content will be used instead: ${data.values}'
           }
         },
@@ -22203,7 +22223,12 @@
       tags: [ 'cat.aria', 'wcag2a', 'wcag412' ],
       all: [],
       any: [ 'aria-allowed-attr' ],
-      none: [ 'aria-unsupported-attr', 'aria-prohibited-attr' ]
+      none: [ 'aria-unsupported-attr', {
+        options: {
+          elementsAllowedAriaLabel: [ 'audio', 'applet', 'canvas', 'dl', 'embed', 'iframe', 'input', 'label', 'meter', 'object', 'svg', 'video' ]
+        },
+        id: 'aria-prohibited-attr'
+      } ]
     }, {
       id: 'aria-allowed-role',
       excludeHidden: false,
@@ -22328,7 +22353,12 @@
       matches: 'aria-required-parent-matches',
       tags: [ 'cat.aria', 'wcag2a', 'wcag131' ],
       all: [],
-      any: [ 'aria-required-parent' ],
+      any: [ {
+        options: {
+          ownGroupRoles: [ 'listitem', 'treeitem' ]
+        },
+        id: 'aria-required-parent'
+      } ],
       none: []
     }, {
       id: 'aria-roledescription',
@@ -23237,7 +23267,10 @@
       evaluate: 'aria-hidden-body-evaluate'
     }, {
       id: 'aria-prohibited-attr',
-      evaluate: 'aria-prohibited-attr-evaluate'
+      evaluate: 'aria-prohibited-attr-evaluate',
+      options: {
+        elementsAllowedAriaLabel: [ 'audio', 'applet', 'canvas', 'dl', 'embed', 'iframe', 'input', 'label', 'meter', 'object', 'svg', 'video' ]
+      }
     }, {
       id: 'aria-required-attr',
       evaluate: 'aria-required-attr-evaluate'
@@ -23249,7 +23282,10 @@
       }
     }, {
       id: 'aria-required-parent',
-      evaluate: 'aria-required-parent-evaluate'
+      evaluate: 'aria-required-parent-evaluate',
+      options: {
+        ownGroupRoles: [ 'listitem', 'treeitem' ]
+      }
     }, {
       id: 'aria-roledescription',
       evaluate: 'aria-roledescription-evaluate',