aws-iam-language-server 0.0.12 → 0.0.14

package/src/lib/treesitter/hcl.js

@@ -11,7 +11,9 @@ export class TreeHcl extends TreeBase {
         const node = this.getNodeAtPosition(uri, position);
         if (!node)
             return null;
-        const nodeBefore = position.column > 0 ? this.getNodeAtPosition(uri, { line: position.line, column: position.column - 1 }) : null;
+        const nodeBefore = position.character > 0
+            ? this.getNodeAtPosition(uri, { line: position.line, character: position.character - 1 })
+            : null;
         // Try jsonencode mode first (more specific structure)
         const jsonencodeContext = this.#tryJsonencodeMode(node, nodeBefore, position);
         if (jsonencodeContext)
@@ -174,8 +176,8 @@ export class TreeHcl extends TreeBase {
                 const valueRange = expression
                     ? nodeRange(expression)
                     : {
-                        start: { line: child.endPosition.row, column: child.endPosition.column },
-                        end: { line: child.endPosition.row, column: child.endPosition.column },
+                        start: { line: child.endPosition.row, character: child.endPosition.column },
+                        end: { line: child.endPosition.row, character: child.endPosition.column },
                     };
                 entries.push({ key: id.text, keyRange, values, valueRange });
             }
@@ -242,8 +244,8 @@ export class TreeHcl extends TreeBase {
             const valueRange = valueExpression
                 ? nodeRange(valueExpression)
                 : {
-                    start: { line: child.endPosition.row, column: child.endPosition.column },
-                    end: { line: child.endPosition.row, column: child.endPosition.column },
+                    start: { line: child.endPosition.row, character: child.endPosition.column },
+                    end: { line: child.endPosition.row, character: child.endPosition.column },
                 };
             const nestedKeys = new Set(['Condition', 'Principal', 'NotPrincipal']);
             let children;
@@ -310,8 +312,8 @@ export class TreeHcl extends TreeBase {
             const valueRange = valueExpression
                 ? nodeRange(valueExpression)
                 : {
-                    start: { line: child.endPosition.row, column: child.endPosition.column },
-                    end: { line: child.endPosition.row, column: child.endPosition.column },
+                    start: { line: child.endPosition.row, character: child.endPosition.column },
+                    end: { line: child.endPosition.row, character: child.endPosition.column },
                 };
             let nestedObject;
             if (valueExpression) {
@@ -424,8 +426,8 @@ export class TreeHcl extends TreeBase {
         }
         if (role === null)
             role = 'key';
-        const { partial, value } = this.#extractJsonencodePartialAndValue(cursorNode, position);
-        return { keys, role, partial, value };
+        const { partial, value, range } = this.#extractJsonencodePartialAndValue(cursorNode, position);
+        return { keys, role, partial, value, range };
     }
     #getObjectElemKey(element) {
         const keyExpression = element.namedChildren.find((child) => child.type === 'expression');
@@ -457,10 +459,11 @@ export class TreeHcl extends TreeBase {
         while (current) {
             if (current.type === 'identifier' || current.type === 'template_literal') {
                 const value = current.text;
+                const range = nodeRange(current);
                 if (position.line === current.startPosition.row) {
-                    return { partial: value.slice(0, position.column - current.startPosition.column), value };
+                    return { partial: value.slice(0, position.character - current.startPosition.column), value, range };
                 }
-                return { partial: value, value };
+                return { partial: value, value, range };
             }
             if (current.type === 'object' || current.type === 'object_elem')
                 break;
@@ -488,7 +491,7 @@ export class TreeHcl extends TreeBase {
             return this.#pickBestCursorContext(context1, context2);
         }
         // Cursor is on the block itself (outside body span) — statement-key level
-        const { partial, value } = this.#extractBlockPartialAndValue(node, position);
+        const { partial, value, range } = this.#extractBlockPartialAndValue(node, position);
         // Check for incomplete attributes on the same line (may be in ERROR nodes
         // when tree-sitter can't parse the body due to a missing value)
         const searchParent = statementBody ?? statementBlock;
@@ -515,6 +518,7 @@ export class TreeHcl extends TreeBase {
             role: 'key',
             partial,
             value,
+            range,
             policyFormat: 'hcl-block',
         };
     }
@@ -603,8 +607,8 @@ export class TreeHcl extends TreeBase {
         }
         if (role === null)
             role = 'key';
-        const { partial, value } = this.#extractBlockPartialAndValue(cursorNode, position);
-        return { keys, role, partial, value };
+        const { partial, value, range } = this.#extractBlockPartialAndValue(cursorNode, position);
+        return { keys, role, partial, value, range };
     }
     #findEnclosingBlock(node, blockName, statementBody) {
         let current = node;
@@ -659,10 +663,11 @@ export class TreeHcl extends TreeBase {
         while (current) {
             if (current.type === 'identifier' || current.type === 'template_literal') {
                 const value = current.text;
+                const range = nodeRange(current);
                 if (position.line === current.startPosition.row) {
-                    return { partial: value.slice(0, position.column - current.startPosition.column), value };
+                    return { partial: value.slice(0, position.character - current.startPosition.column), value, range };
                 }
-                return { partial: value, value };
+                return { partial: value, value, range };
             }
             if (current.type === 'body' || current.type === 'attribute' || current.type === 'block')
                 break;
@@ -711,7 +716,7 @@ export class TreeHcl extends TreeBase {
             (nodeBefore && this.#isInsideQuote(nodeBefore)) ||
             errorNode.children.some((child) => child.type === 'quoted_template_start' &&
                 child.startPosition.row === position.line &&
-                child.endPosition.column <= position.column);
+                child.endPosition.column <= position.character);
         if (!hasQuoteOnLine)
             return null;
         let foundStatement = false;
@@ -804,12 +809,13 @@ export class TreeHcl extends TreeBase {
         // extract from the template_literal. Otherwise extract from ERROR node text.
         let partial = '';
         let value = '';
+        let range;
         if (!lastKeyFromAttribute) {
             if (this.#isInsideQuote(node)) {
-                ({ partial, value } = this.#extractQuotedPartialAndValue(node, position));
+                ({ partial, value, range } = this.#extractQuotedPartialAndValue(node, position));
             }
             else if (nodeBefore && this.#isInsideQuote(nodeBefore)) {
-                ({ partial, value } = this.#extractQuotedPartialAndValue(nodeBefore, position));
+                ({ partial, value, range } = this.#extractQuotedPartialAndValue(nodeBefore, position));
             }
             else {
                 ({ partial, value } = this.#extractPartialAndValueFromErrorNode(errorNode, position));
@@ -828,6 +834,7 @@ export class TreeHcl extends TreeBase {
             role: 'value',
             partial,
             value,
+            range,
             policyFormat,
         };
     }
@@ -840,10 +847,11 @@ export class TreeHcl extends TreeBase {
         while (current) {
             if (current.type === 'template_literal') {
                 const value = current.text;
+                const range = nodeRange(current);
                 if (position.line === current.startPosition.row) {
-                    return { partial: value.slice(0, position.column - current.startPosition.column), value };
+                    return { partial: value.slice(0, position.character - current.startPosition.column), value, range };
                 }
-                return { partial: '', value };
+                return { partial: '', value, range };
             }
             if (current.type === 'quoted_template_start')
                 return { partial: '', value: '' };
@@ -865,10 +873,10 @@ export class TreeHcl extends TreeBase {
             // like attributes have endPosition from a different row)
             if (child.endPosition.row !== position.line)
                 continue;
-            if (child.endPosition.column <= position.column) {
+            if (child.endPosition.column <= position.character) {
                 afterColumn = child.endPosition.column;
             }
-            else if (nextChildColumn === null && child.startPosition.column > position.column) {
+            else if (nextChildColumn === null && child.startPosition.column > position.character) {
                 nextChildColumn = child.startPosition.column;
             }
         }
@@ -878,7 +886,7 @@ export class TreeHcl extends TreeBase {
             return { partial: '', value: '' };
         const line = lines[lineIndex];
         const startColumn = lineIndex === 0 ? errorNode.startPosition.column : 0;
-        const partial = line.slice(afterColumn - startColumn, position.column - startColumn);
+        const partial = line.slice(afterColumn - startColumn, position.character - startColumn);
         const valueEnd = nextChildColumn !== null ? nextChildColumn - startColumn : line.length;
         const value = line.slice(afterColumn - startColumn, valueEnd);
         return { partial, value };

package/src/lib/treesitter/json.js

@@ -11,7 +11,9 @@ export class TreeJson extends TreeBase {
         const node = this.getNodeAtPosition(uri, position);
         if (!node)
             return null;
-        const nodeBefore = position.column > 0 ? this.getNodeAtPosition(uri, { line: position.line, column: position.column - 1 }) : null;
+        const nodeBefore = position.character > 0
+            ? this.getNodeAtPosition(uri, { line: position.line, character: position.character - 1 })
+            : null;
         // Cursor right after closing quote — no completions
         if (this.#isCursorAfterClosingQuote(nodeBefore))
             return null;
@@ -36,8 +38,8 @@ export class TreeJson extends TreeBase {
         if (!node)
             return null;
         let statementObject = this.#findStatementObject(node);
-        if (!statementObject && position.column > 0) {
-            const nodeBefore = this.getNodeAtPosition(uri, { line: position.line, column: position.column - 1 });
+        if (!statementObject && position.character > 0) {
+            const nodeBefore = this.getNodeAtPosition(uri, { line: position.line, character: position.character - 1 });
             if (nodeBefore)
                 statementObject = this.#findStatementObject(nodeBefore);
         }
@@ -50,8 +52,8 @@ export class TreeJson extends TreeBase {
         if (!node)
             return [];
         let statementObject = this.#findStatementObject(node);
-        if (!statementObject && position.column > 0) {
-            const nodeBefore = this.getNodeAtPosition(uri, { line: position.line, column: position.column - 1 });
+        if (!statementObject && position.character > 0) {
+            const nodeBefore = this.getNodeAtPosition(uri, { line: position.line, character: position.character - 1 });
             if (nodeBefore)
                 statementObject = this.#findStatementObject(nodeBefore);
         }
@@ -178,8 +180,8 @@ export class TreeJson extends TreeBase {
         const valueNode = pair.namedChildren[1];
         if (!valueNode) {
             return {
-                start: { line: pair.endPosition.row, column: pair.endPosition.column },
-                end: { line: pair.endPosition.row, column: pair.endPosition.column },
+                start: { line: pair.endPosition.row, character: pair.endPosition.column },
+                end: { line: pair.endPosition.row, character: pair.endPosition.column },
             };
         }
         return nodeRange(valueNode);
@@ -247,8 +249,8 @@ export class TreeJson extends TreeBase {
         }
         if (role === null)
             role = 'key';
-        const { partial, value } = this.#extractPartialAndValue(cursorNode, position);
-        return { keys, role, partial, value };
+        const { partial, value, range } = this.#extractPartialAndValue(cursorNode, position);
+        return { keys, role, partial, value, range };
     }
     /**
      * Walk up from a node to find an object that sits inside a Statement array.
@@ -367,10 +369,11 @@ export class TreeJson extends TreeBase {
         while (current) {
             if (current.type === 'string_content') {
                 const value = current.text;
+                const range = nodeRange(current);
                 if (position.line === current.startPosition.row) {
-                    return { partial: value.slice(0, position.column - current.startPosition.column), value };
+                    return { partial: value.slice(0, position.character - current.startPosition.column), value, range };
                 }
-                return { partial: value, value };
+                return { partial: value, value, range };
             }
             if (current.type === 'object' || current.type === 'pair')
                 break;

package/src/lib/treesitter/yaml.js

@@ -11,7 +11,9 @@ export class TreeYaml extends TreeBase {
         const node = this.getNodeAtPosition(uri, position);
         if (!node)
             return null;
-        const nodeBefore = position.column > 0 ? this.getNodeAtPosition(uri, { line: position.line, column: position.column - 1 }) : null;
+        const nodeBefore = position.character > 0
+            ? this.getNodeAtPosition(uri, { line: position.line, character: position.character - 1 })
+            : null;
         const root = this.getTree(uri)?.rootNode;
         if (!root)
             return null;
@@ -189,8 +191,8 @@ export class TreeYaml extends TreeBase {
         if (pair.namedChildren.length < 2) {
             // No value — zero-width range at key end
             return {
-                start: { line: pair.endPosition.row, column: pair.endPosition.column },
-                end: { line: pair.endPosition.row, column: pair.endPosition.column },
+                start: { line: pair.endPosition.row, character: pair.endPosition.column },
+                end: { line: pair.endPosition.row, character: pair.endPosition.column },
             };
         }
         return nodeRange(pair.namedChildren[1]);
@@ -236,10 +238,10 @@ export class TreeYaml extends TreeBase {
         let extendedMatch = null;
         for (const mapping of candidates) {
             const pastEnd = position.line > mapping.endPosition.row ||
-                (position.line === mapping.endPosition.row && position.column >= mapping.endPosition.column);
+                (position.line === mapping.endPosition.row && position.character >= mapping.endPosition.column);
             if (!pastEnd)
                 continue;
-            if (position.column < mapping.startPosition.column)
+            if (position.character < mapping.startPosition.column)
                 continue;
             // Don't extend across sibling statement items. If a sibling block_sequence_item
             // starts between this mapping's end and the cursor, the cursor is in a different statement.
@@ -284,12 +286,13 @@ export class TreeYaml extends TreeBase {
         const resolved = this.#resolveWithinMapping(statementMapping, position);
         if (!resolved)
             return null;
-        const { partial, value } = this.#extractPartialAndValue(cursorNode, position);
+        const { partial, value, range } = this.#extractPartialAndValue(cursorNode, position);
         return {
             keys: resolved.keys,
             role: resolved.role,
             partial,
             value,
+            range,
             policyFormat: 'standard',
         };
     }
@@ -413,7 +416,7 @@ export class TreeYaml extends TreeBase {
                 const keyColumn = ancestorMapping
                     ? ancestorMapping.startPosition.column
                     : statementMapping.startPosition.column;
-                if (position.column > keyColumn)
+                if (position.character > keyColumn)
                     return null;
             }
         }
@@ -443,7 +446,7 @@ export class TreeYaml extends TreeBase {
                 const pairOnLine = current.namedChildren.find((child) => child.type === 'block_mapping_pair' &&
                     child.startPosition.row === position.line &&
                     child.namedChildren.length === 1 &&
-                    position.column > child.endPosition.column);
+                    position.character > child.endPosition.column);
                 if (pairOnLine) {
                     const pairKey = this.#getPairKeyText(pairOnLine);
                     if (pairKey) {
@@ -457,7 +460,7 @@ export class TreeYaml extends TreeBase {
                 // When cursor lands on an inner block_mapping (not the statement mapping),
                 // check if the cursor is actually outside this mapping (column < key column).
                 // If so, skip it — the cursor belongs to a parent mapping level.
-                if (current.id !== statementMapping.id && position.column < current.startPosition.column) {
+                if (current.id !== statementMapping.id && position.character < current.startPosition.column) {
                     previous = current;
                     current = current.parent;
                     continue;
@@ -500,7 +503,7 @@ export class TreeYaml extends TreeBase {
                     // If the cursor column matches the parent mapping's key column, the user
                     // is typing a new sibling key, not editing this pair's value.
                     const parentMapping = current.parent;
-                    const isAtParentKeyColumn = parentMapping?.type === 'block_mapping' && position.column === parentMapping.startPosition.column;
+                    const isAtParentKeyColumn = parentMapping?.type === 'block_mapping' && position.character === parentMapping.startPosition.column;
                     if (isOnKey || isAtParentKeyColumn) {
                         role = 'key';
                     }
@@ -532,10 +535,10 @@ export class TreeYaml extends TreeBase {
         }
         if (role === null)
             role = 'key';
-        const { partial: extractedPartial, value: extractedValue } = this.#extractPartialAndValue(cursorNode, position);
+        const { partial: extractedPartial, value: extractedValue, range, } = this.#extractPartialAndValue(cursorNode, position);
         const partial = colonPartial || extractedPartial;
         const value = colonPartial ? colonPartial : extractedValue;
-        return { keys, role, partial, value };
+        return { keys, role, partial, value, range };
     }
     /**
      * Resolve the cursor's position within a block_mapping by finding the pair covering
@@ -543,9 +546,9 @@ export class TreeYaml extends TreeBase {
      */
     #resolveWithinMapping(mapping, position) {
         const keyColumn = mapping.startPosition.column;
-        if (position.column < keyColumn)
+        if (position.character < keyColumn)
             return null;
-        if (position.column === keyColumn)
+        if (position.character === keyColumn)
             return { keys: [], role: 'key' };
         let pairBeforeCursor = null;
         for (const child of mapping.namedChildren) {
@@ -582,7 +585,7 @@ export class TreeYaml extends TreeBase {
             const valueSequence = this.#findValueBlockSequence(pairBeforeCursor);
             if (valueSequence &&
                 position.line <= valueSequence.endPosition.row &&
-                position.column >= valueSequence.startPosition.column) {
+                position.character >= valueSequence.startPosition.column) {
                 return { keys: [pairKey], role: 'value' };
             }
             return null;
@@ -737,10 +740,10 @@ export class TreeYaml extends TreeBase {
         let current = node;
         while (current) {
             if (current.type === 'string_scalar') {
-                return this.#sliceToPositionAndValue(current.text, current.startPosition.column, position, node);
+                return this.#sliceToPositionAndValue(current.text, current.startPosition.column, position, node, current);
             }
             if (current.type === 'double_quote_scalar' || current.type === 'single_quote_scalar') {
-                return this.#sliceToPositionAndValue(current.text.slice(1, -1), current.startPosition.column + 1, position, node);
+                return this.#sliceToPositionAndValue(current.text.slice(1, -1), current.startPosition.column + 1, position, node, current);
             }
             if (current.type === 'block_mapping' || current.type === 'block_mapping_pair')
                 break;
@@ -748,11 +751,11 @@ export class TreeYaml extends TreeBase {
         }
         return { partial: '', value: '' };
     }
-    #sliceToPositionAndValue(text, startColumn, position, node) {
+    #sliceToPositionAndValue(text, startColumn, position, node, scalarNode) {
         if (position.line === node.startPosition.row) {
-            return { partial: text.slice(0, position.column - startColumn), value: text };
+            return { partial: text.slice(0, position.character - startColumn), value: text, range: nodeRange(scalarNode) };
         }
-        return { partial: text, value: text };
+        return { partial: text, value: text, range: nodeRange(scalarNode) };
     }
     /**
      * When tree-sitter produces a root-level ERROR (e.g., unterminated quote in
@@ -796,8 +799,8 @@ export class TreeYaml extends TreeBase {
                 if (!keyText)
                     continue;
                 // Cursor within the key text — still typing the key
-                if (position.column < child.endPosition.column) {
-                    const partial = keyText.slice(0, position.column - child.startPosition.column);
+                if (position.character < child.endPosition.column) {
+                    const partial = keyText.slice(0, position.character - child.startPosition.column);
                     return {
                         keys: [],
                         role: 'key',
@@ -807,7 +810,7 @@ export class TreeYaml extends TreeBase {
                     };
                 }
                 // Cursor at key end — key is complete but ":" hasn't been typed yet
-                if (position.column === child.endPosition.column) {
+                if (position.character === child.endPosition.column) {
                     return null;
                 }
                 return {
@@ -826,7 +829,7 @@ export class TreeYaml extends TreeBase {
                     continue;
                 const valueText = this.#getPairValueText(child) ?? '';
                 // If cursor is past the ERROR end (colon continuation), append ":"
-                const colonSuffix = errorNode.endPosition.row === position.line && position.column > errorNode.endPosition.column ? ':' : '';
+                const colonSuffix = errorNode.endPosition.row === position.line && position.character > errorNode.endPosition.column ? ':' : '';
                 const fullValue = valueText + colonSuffix;
                 return {
                     keys: [pairKey],
@@ -873,10 +876,10 @@ export class TreeYaml extends TreeBase {
         for (const child of errorNode.children) {
             if (child.startPosition.row !== position.line)
                 continue;
-            if (child.endPosition.column <= position.column) {
+            if (child.endPosition.column <= position.character) {
                 afterColumn = child.endPosition.column;
             }
-            else if (nextChildColumn === null && child.startPosition.column > position.column) {
+            else if (nextChildColumn === null && child.startPosition.column > position.character) {
                 nextChildColumn = child.startPosition.column;
             }
         }
@@ -887,7 +890,7 @@ export class TreeYaml extends TreeBase {
             return { partial: '', value: '' };
         const line = lines[lineIndex];
         const startColumn = lineIndex === 0 ? errorNode.startPosition.column : 0;
-        const partial = line.slice(afterColumn - startColumn, position.column - startColumn);
+        const partial = line.slice(afterColumn - startColumn, position.character - startColumn);
         const valueEnd = nextChildColumn !== null ? nextChildColumn - startColumn : line.length;
         const value = line.slice(afterColumn - startColumn, valueEnd);
         return { partial, value };

package/src/server.js

@@ -1,11 +1,12 @@
 #!/usr/bin/env node
-import { createConnection, ProposedFeatures, TextDocumentSyncKind, TextDocuments } from 'vscode-languageserver/node.js';
+import { createConnection, TextDocumentSyncKind, TextDocuments } from 'vscode-languageserver/node.js';
 import { TextDocument } from 'vscode-languageserver-textdocument';
 import { handleCompletionRequest } from "./handlers/completion/index.js";
 import { diagnosticsHandler } from "./handlers/diagnostics/diagnostics.js";
 import { documentLinkHandler } from "./handlers/document-link/document-link.js";
+import { hoverHandler } from "./handlers/hover/index.js";
 import { TreeManager } from "./lib/treesitter/manager.js";
-const connection = createConnection(ProposedFeatures.all);
+const connection = createConnection();
 const documents = new TextDocuments(TextDocument);
 const treeManager = new TreeManager(connection);
 connection.onInitialize(async () => {
@@ -16,7 +17,7 @@ connection.onInitialize(async () => {
             completionProvider: {
                 triggerCharacters: ['"', ':', '*'],
             },
-            hoverProvider: false,
+            hoverProvider: true,
             documentLinkProvider: {},
         },
     };
@@ -34,5 +35,6 @@ documents.onDidClose(async ({ document }) => {
 });
 connection.onCompletion((params) => handleCompletionRequest(params, documents, treeManager, connection));
 connection.onDocumentLinks((params) => documentLinkHandler(params, documents, treeManager, connection));
+connection.onHover((params) => hoverHandler(params, treeManager, connection));
 documents.listen(connection);
 connection.listen();