aws-iam-language-server 0.0.11 → 0.0.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aws-iam-language-server",
-  "version": "0.0.11",
+  "version": "0.0.13",
   "type": "module",
   "bin": "./src/server.js",
   "publisher": "MichaelBarney",

package/readme.md

@@ -69,3 +69,4 @@ This language server will provide diagnostics for some IAM policy issues, includ
 - ensuring `Sid` uniqueness within a policy document
 - effect has a valid value
 - defined actions are valid, or wildcards resolve to valid actions
+- arn parts are valid (partition, region, account id)

package/src/handlers/diagnostics/resource.js

@@ -1,7 +1,59 @@
+import { isRegionValidForPartition, isValidPartition, partitions } from "../../lib/iam-policy/partitions.js";
 import { ElementValidator } from "./base.js";
+import { createDiagnostic } from "./utils.js";
+const validPartitions = Object.keys(partitions);
+const accountIdPattern = /^\d{12}$/;
+function segmentRange(value, segmentIndex) {
+    const segments = value.text.split(':');
+    let offset = 0;
+    for (let i = 0; i < segmentIndex; i++) {
+        offset += segments[i].length + 1;
+    }
+    const startColumn = value.range.start.column + offset;
+    const endColumn = startColumn + segments[segmentIndex].length;
+    return {
+        start: { line: value.range.start.line, column: startColumn },
+        end: { line: value.range.start.line, column: endColumn },
+    };
+}
+function validateArn(value) {
+    const text = value.text;
+    const diagnostics = [];
+    if (!text.startsWith('arn:'))
+        return [];
+    const segments = text.split(':');
+    if (segments.length > 1) {
+        const partition = segments[1];
+        if (partition === '') {
+            diagnostics.push(createDiagnostic('partition is required', segmentRange(value, 1)));
+        }
+        else if (partition !== '*' && !Object.keys(partitions).includes(partition)) {
+            diagnostics.push(createDiagnostic(`partition must be one of: ${[...validPartitions].join(',')}`, segmentRange(value, 1)));
+        }
+    }
+    if (segments.length > 3) {
+        const partition = segments[1];
+        const region = segments[3];
+        if (isValidPartition(partition)) {
+            if (region !== '*' && region !== '' && !isRegionValidForPartition(partition, region)) {
+                diagnostics.push(createDiagnostic('invalid region for this partition', segmentRange(value, 3)));
+            }
+        }
+    }
+    if (segments.length > 4) {
+        const account = segments[4];
+        if (account !== '*' && account !== '' && !accountIdPattern.test(account)) {
+            diagnostics.push(createDiagnostic('expected account id to be 12 digits', segmentRange(value, 4)));
+        }
+    }
+    return diagnostics;
+}
 export class ResourceValidator extends ElementValidator {
     validate(entry) {
-        const diagnostics = super.validate(entry);
+        let diagnostics = super.validate(entry);
+        for (const value of entry.values) {
+            diagnostics = diagnostics.concat(validateArn(value));
+        }
         return diagnostics;
     }
 }

package/src/lib/iam-policy/partitions.d.ts

@@ -114,3 +114,7 @@ export declare const partitions: {
         }];
     };
 };
+type Partition = keyof typeof partitions;
+export declare function isValidPartition(input: string): input is Partition;
+export declare function isRegionValidForPartition<T extends Partition>(partition: T, input: string): input is (typeof partitions)[T]['regions'][number]['id'];
+export {};

package/src/lib/iam-policy/partitions.js

@@ -49,3 +49,9 @@ export const partitions = {
         ],
     },
 };
+export function isValidPartition(input) {
+    return Object.keys(partitions).includes(input);
+}
+export function isRegionValidForPartition(partition, input) {
+    return partitions[partition].regions.some((r) => r.id === input);
+}