ava 3.12.0 → 3.12.1

package/lib/cli.js

@@ -430,7 +430,7 @@ exports.run = async () => { // eslint-disable-line complexity
 		reporter.startRun(plan);
 
 		if (process.env.AVA_EMIT_RUN_STATUS_OVER_IPC === 'I\'ll find a payphone baby / Take some time to talk to you') {
-			if (process.versions.node >= '12.17.0') {
+			if (process.versions.node >= '12.16.0') {
 				plan.status.on('stateChange', evt => {
 					process.send(evt);
 				});

package/lib/fork.js

@@ -3,7 +3,6 @@ const childProcess = require('child_process');
 const path = require('path');
 const fs = require('fs');
 const Emittery = require('emittery');
-const {controlFlow} = require('./ipc-flow-control');
 
 if (fs.realpathSync(__filename) !== __filename) {
 	console.warn('WARNING: `npm link ava` and the `--preserve-symlink` flag are incompatible. We have detected that AVA is linked via `npm link`, and that you are using either an early version of Node 6, or the `--preserve-symlink` flag. This breaks AVA. You should upgrade to Node 6.2.0+, avoid the `--preserve-symlink` flag, or avoid using `npm link ava`.');
@@ -15,12 +14,6 @@ const AVA_PATH = path.resolve(__dirname, '..');
 
 const workerPath = require.resolve('./worker/subprocess');
 
-const useAdvanced = process.versions.node >= '12.17.0';
-// FIXME: Fix this in api.js or cli.js.
-const serializeOptions = useAdvanced ?
-	options => JSON.parse(JSON.stringify(options)) : // Use JSON serialization to remove non-clonable values.
-	options => options;
-
 module.exports = (file, options, execArgv = process.execArgv) => {
 	let finished = false;
 
@@ -41,8 +34,7 @@ module.exports = (file, options, execArgv = process.execArgv) => {
 		cwd: options.projectDir,
 		silent: true,
 		env: {NODE_ENV: 'test', ...process.env, ...options.environmentVariables, AVA_PATH},
-		execArgv,
-		serialization: useAdvanced ? 'advanced' : 'json'
+		execArgv
 	});
 
 	subprocess.stdout.on('data', chunk => {
@@ -53,12 +45,12 @@ module.exports = (file, options, execArgv = process.execArgv) => {
 		emitStateChange({type: 'worker-stderr', chunk});
 	});
 
-	const bufferedSend = controlFlow(subprocess);
-
 	let forcedExit = false;
 	const send = evt => {
-		if (!finished && !forcedExit) {
-			bufferedSend({ava: evt});
+		if (subprocess.connected && !finished && !forcedExit) {
+			subprocess.send({ava: evt}, () => {
+				// Disregard errors.
+			});
 		}
 	};
 
@@ -74,7 +66,7 @@ module.exports = (file, options, execArgv = process.execArgv) => {
 			}
 
 			if (message.ava.type === 'ready-for-options') {
-				send({type: 'options', options: serializeOptions(options)});
+				send({type: 'options', options});
 				return;
 			}
 

package/lib/worker/ipc.js

@@ -1,6 +1,5 @@
 'use strict';
 const Emittery = require('emittery');
-const {controlFlow} = require('../ipc-flow-control');
 
 const emitter = new Emittery();
 process.on('message', message => {
@@ -26,9 +25,10 @@ process.on('message', message => {
 exports.options = emitter.once('options');
 exports.peerFailed = emitter.once('peerFailed');
 
-const bufferedSend = controlFlow(process);
 function send(evt) {
-	bufferedSend({ava: evt});
+	if (process.connected) {
+		process.send({ava: evt});
+	}
 }
 
 exports.send = send;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "ava",
-	"version": "3.12.0",
+	"version": "3.12.1",
 	"description": "Node.js test runner that lets you develop with confidence.",
 	"license": "MIT",
 	"repository": "avajs/ava",

package/lib/ipc-flow-control.js

@@ -1,42 +0,0 @@
-// Manage how quickly messages are delivered to the channel. In theory, we
-// should be able to call `send()` until it returns `false` but this leads to
-// crashes with advanced serialization, see
-// <https://github.com/nodejs/node/issues/34797>.
-//
-// Even if that's fixed (and the Node.js versions with the fixes are the
-// minimally supported versions) we need flow control based on `send()`'s return
-// value.
-
-const nowAndTimers = require('./now-and-timers');
-
-function controlFlow(channel) {
-	let sending = false;
-
-	const buffer = [];
-	const deliverNext = () => {
-		if (!channel.connected) {
-			buffer.length = 0;
-		}
-
-		if (buffer.length === 0) {
-			sending = false;
-			return;
-		}
-
-		channel.send(buffer.shift(), deliverNext);
-	};
-
-	return message => {
-		if (!channel.connected) {
-			return;
-		}
-
-		buffer.push(message);
-		if (!sending) {
-			sending = true;
-			nowAndTimers.setImmediate(deliverNext);
-		}
-	};
-}
-
-exports.controlFlow = controlFlow;