autosnippet 2.12.0 → 2.13.0

package/lib/service/guard/GuardFeedbackLoop.js

@@ -0,0 +1,125 @@
+/**
+ * GuardFeedbackLoop — Guard ↔ Recipe 闭环联动
+ *
+ * 功能:
+ *   1. 对比当前和历史 violations，检测已修复的违规
+ *   2. 已修复违规如有 fixSuggestion → 自动 confirmUsage（记录 Recipe 使用）
+ *   3. 集成到 guardAuditFiles MCP handler 和 GuardHandler (FileWatcher)
+ */
+
+import Logger from '../../infrastructure/logging/Logger.js';
+
+export class GuardFeedbackLoop {
+  /**
+   * @param {import('./ViolationsStore.js').ViolationsStore} violationsStore
+   * @param {import('../quality/FeedbackCollector.js').FeedbackCollector} feedbackCollector
+   * @param {object} [options]
+   * @param {import('./GuardCheckEngine.js').GuardCheckEngine} [options.guardCheckEngine] - 用于查找规则
+   */
+  constructor(violationsStore, feedbackCollector, options = {}) {
+    this.violationsStore = violationsStore;
+    this.feedbackCollector = feedbackCollector;
+    this.guardCheckEngine = options.guardCheckEngine || null;
+    this.logger = Logger.getInstance();
+  }
+
+  /**
+   * 对比当前和历史 violations，检测已修复的违规
+   * @param {{ violations: Array<{ruleId: string}> }} currentResult - 本次检查结果
+   * @param {string} filePath - 文件路径
+   * @returns {Array<{ ruleId: string, filePath: string, fixRecipeId: string }>} 已修复且有 Recipe 关联的列表
+   */
+  detectFixedViolations(currentResult, filePath) {
+    if (!this.violationsStore) return [];
+
+    try {
+      const previousRuns = this.violationsStore.getRunsByFile(filePath);
+      if (previousRuns.length === 0) return [];
+
+      // 取最近一次运行结果
+      const lastRun = previousRuns[previousRuns.length - 1];
+      const lastRuleIds = new Set((lastRun.violations || []).map(v => v.ruleId));
+      const currentRuleIds = new Set((currentResult.violations || []).map(v => v.ruleId));
+
+      const fixed = [];
+      for (const ruleId of lastRuleIds) {
+        if (!currentRuleIds.has(ruleId)) {
+          // 该规则的违规已消失 → 修复了
+          const fixRecipeId = this._findFixRecipe(ruleId, lastRun.violations);
+          if (fixRecipeId) {
+            fixed.push({ ruleId, filePath, fixRecipeId });
+          }
+        }
+      }
+
+      return fixed;
+    } catch (err) {
+      this.logger.debug(`[GuardFeedbackLoop] detectFixedViolations error: ${err.message}`);
+      return [];
+    }
+  }
+
+  /**
+   * 对已修复的违规自动确认使用
+   * @param {Array<{ ruleId: string, filePath: string, fixRecipeId: string }>} fixedList
+   */
+  autoConfirmUsage(fixedList) {
+    if (!this.feedbackCollector || !fixedList?.length) return;
+
+    for (const { ruleId, fixRecipeId, filePath } of fixedList) {
+      try {
+        this.feedbackCollector.record('insert', fixRecipeId, {
+          source: 'guard_fix_detection',
+          automatic: true,
+          ruleId,
+          filePath,
+        });
+        this.logger.info(`[GuardFeedbackLoop] Auto-confirmed usage: recipe=${fixRecipeId} from fixing rule=${ruleId}`);
+      } catch (err) {
+        this.logger.debug(`[GuardFeedbackLoop] autoConfirmUsage error: ${err.message}`);
+      }
+    }
+  }
+
+  /**
+   * 一站式处理：检测修复 + 自动确认
+   * 供 MCP handler 和 GuardHandler 集成调用
+   * @param {{ violations: Array }} currentResult
+   * @param {string} filePath
+   */
+  processFixDetection(currentResult, filePath) {
+    const fixed = this.detectFixedViolations(currentResult, filePath);
+    if (fixed.length > 0) {
+      this.autoConfirmUsage(fixed);
+      this.logger.info(`[GuardFeedbackLoop] Detected ${fixed.length} fixed violations in ${filePath}`);
+    }
+    return fixed;
+  }
+
+  /**
+   * 从 violation 或 GuardCheckEngine 查找 fixRecipeId
+   */
+  _findFixRecipe(ruleId, violations) {
+    // 先从 violation 本身的 fixSuggestion 查找
+    for (const v of (violations || [])) {
+      if (v.ruleId === ruleId && v.fixSuggestion) {
+        return v.fixSuggestion.replace(/^recipe:/, '');
+      }
+    }
+
+    // 再从 GuardCheckEngine 的规则定义中查找
+    if (this.guardCheckEngine) {
+      try {
+        const rules = this.guardCheckEngine.getRules();
+        const rule = rules.find(r => r.id === ruleId);
+        if (rule?.fixSuggestion) {
+          return rule.fixSuggestion.replace(/^recipe:/, '');
+        }
+      } catch { /* ignore */ }
+    }
+
+    return null;
+  }
+}
+
+export default GuardFeedbackLoop;

package/lib/service/guard/GuardService.js

@@ -44,9 +44,12 @@ export class GuardService {
           preconditions: [],
           sideEffects: [],
           guards: [{
-            pattern: data.pattern,
+            ...(data.pattern ? { pattern: data.pattern } : {}),
             severity: data.severity || 'warning',
             message: data.description || '',
+            type: data.type || 'regex',
+            ...(data.astQuery ? { astQuery: data.astQuery } : {}),
+            ...(data.fixSuggestion ? { fixSuggestion: data.fixSuggestion } : {}),
           }],
         },
         tags: data.languages || [],
@@ -241,6 +244,7 @@ export class GuardService {
 
   /**
    * 验证创建输入
+   * type='regex' 时 pattern 必须提供；type='ast' 时 astQuery 必须提供
    */
   _validateCreateInput(data) {
     if (!data.name || data.name.trim().length === 0) {
@@ -249,8 +253,16 @@ export class GuardService {
     if (!data.description || data.description.trim().length === 0) {
       throw new ValidationError('Rule description is required');
     }
-    if (!data.pattern || data.pattern.trim().length === 0) {
-      throw new ValidationError('Pattern is required');
+
+    const ruleType = data.type || 'regex';
+    if (ruleType === 'ast') {
+      if (!data.astQuery || !data.astQuery.queryType) {
+        throw new ValidationError('AST query with queryType is required for type=ast rules');
+      }
+    } else {
+      if (!data.pattern || data.pattern.trim().length === 0) {
+        throw new ValidationError('Pattern is required for regex rules');
+      }
     }
   }
 }

package/lib/service/guard/RuleLearner.js

@@ -31,7 +31,9 @@ export class RuleLearner {
   recordTrigger(ruleId, context = {}) {
     const stat = this.#ensureStat(ruleId);
     stat.triggers++;
-    stat.lastTriggered = new Date().toISOString();
+    const now = new Date().toISOString();
+    stat.lastTriggered = now;
+    if (!stat.firstTriggered) stat.firstTriggered = now;
     this.#save();
   }
 
@@ -123,6 +125,118 @@ export class RuleLearner {
     this.#save();
   }
 
+  /**
+   * 基于历史数据提出规则优化建议
+   * 策略 1: 高误报规则 → 建议调整
+   * 策略 2: 高触发且高精度 → 建议创建项目特化版本
+   * @returns {Array<{ type: string, ruleId: string, message: string, confidence: number, evidence: object }>}
+   */
+  suggestRules() {
+    const suggestions = [];
+
+    // 策略 1: 从高误报规则推导改进建议
+    const problematic = this.getProblematicRules();
+    for (const p of problematic) {
+      if (p.recommendation === 'tune') {
+        suggestions.push({
+          type: 'tune_existing',
+          ruleId: p.ruleId,
+          message: `规则 ${p.ruleId} 误报率 ${(p.metrics.falsePositiveRate * 100).toFixed(0)}%，建议调整正则或收窄语言范围`,
+          confidence: 0.7,
+          evidence: p.metrics,
+        });
+      } else if (p.recommendation === 'disable') {
+        suggestions.push({
+          type: 'disable',
+          ruleId: p.ruleId,
+          message: `规则 ${p.ruleId} 误报率 ${(p.metrics.falsePositiveRate * 100).toFixed(0)}%，建议禁用`,
+          confidence: 0.8,
+          evidence: p.metrics,
+        });
+      }
+    }
+
+    // 策略 2: 高触发 + 高精度内置规则 → 建议创建项目定制版
+    const allStats = this.getAllStats();
+    for (const [ruleId, stat] of Object.entries(allStats)) {
+      if (stat.triggers > 50 && (stat.metrics?.precision ?? 1) > 0.8) {
+        suggestions.push({
+          type: 'specialize',
+          ruleId,
+          message: `规则 ${ruleId} 触发 ${stat.triggers} 次且精准度高 (${((stat.metrics?.precision ?? 1) * 100).toFixed(0)}%)，建议创建项目定制版本`,
+          confidence: 0.6,
+          evidence: stat.metrics,
+        });
+      }
+    }
+
+    // 策略 3: 长期无触发的规则 → 可能不适用
+    for (const [ruleId, stat] of Object.entries(allStats)) {
+      if (stat.triggers === 0 && stat.lastTriggered) {
+        const daysSinceLastTrigger = (Date.now() - new Date(stat.lastTriggered).getTime()) / 86400000;
+        if (daysSinceLastTrigger > 30) {
+          suggestions.push({
+            type: 'review_unused',
+            ruleId,
+            message: `规则 ${ruleId} 超过 30 天未触发，建议审查是否仍需保留`,
+            confidence: 0.4,
+            evidence: { daysSinceLastTrigger: Math.round(daysSinceLastTrigger), triggers: stat.triggers },
+          });
+        }
+      }
+    }
+
+    return suggestions.sort((a, b) => b.confidence - a.confidence);
+  }
+
+  /**
+   * 追踪规则创建后的效果
+   * 对比首次触发后的表现，判断规则是否有效
+   * @param {string} ruleId
+   * @returns {{ status: string, triggers: number, precision: number, recommendation: string, daysSinceFirstTrigger?: number }}
+   */
+  trackRuleEffectiveness(ruleId) {
+    const stat = this.#data.ruleStats[ruleId];
+    if (!stat) return { status: 'no_data', triggers: 0, precision: 1, recommendation: 'monitor' };
+
+    const firstTriggered = stat.firstTriggered || stat.lastTriggered;
+    if (!firstTriggered) return { status: 'no_triggers', triggers: 0, precision: 1, recommendation: 'monitor' };
+
+    const daysSinceFirstTrigger = (Date.now() - new Date(firstTriggered).getTime()) / 86400000;
+
+    // 不足 14 天 → 观察期
+    if (daysSinceFirstTrigger < 14) {
+      return {
+        status: 'monitoring',
+        triggers: stat.triggers,
+        precision: this.getMetrics(ruleId).precision,
+        recommendation: 'wait',
+        daysSinceFirstTrigger: Math.round(daysSinceFirstTrigger),
+      };
+    }
+
+    const metrics = this.getMetrics(ruleId);
+
+    // 14 天后判定
+    if (metrics.precision < 0.5 && stat.triggers >= PROBLEMATIC_THRESHOLD.minTriggers) {
+      return {
+        status: 'ineffective',
+        triggers: stat.triggers,
+        precision: metrics.precision,
+        recommendation: 'review_or_disable',
+        daysSinceFirstTrigger: Math.round(daysSinceFirstTrigger),
+      };
+    }
+
+    return {
+      status: 'effective',
+      triggers: stat.triggers,
+      precision: metrics.precision,
+      recommendation: 'keep',
+      daysSinceFirstTrigger: Math.round(daysSinceFirstTrigger),
+    };
+  }
+
   // ─── 私有 ─────────────────────────────────────────────
 
   #ensureStat(ruleId) {
@@ -132,6 +246,7 @@ export class RuleLearner {
         correct: 0,
         falsePositive: 0,
         falseNegative: 0,
+        firstTriggered: null,
         lastTriggered: null,
         lastFeedback: null,
       };

package/lib/service/guard/SourceFileCollector.js

@@ -0,0 +1,94 @@
+/**
+ * SourceFileCollector — 递归收集项目源文件
+ * 
+ * 从 GuardHandler 提取的公共工具，供 ComplianceReporter / guard:ci / guard:staged 复用
+ */
+
+import { join, extname } from 'node:path';
+import { readdir, readFile } from 'node:fs/promises';
+
+/** 支持审计的源文件扩展名 */
+export const SOURCE_EXTS = new Set([
+  '.m', '.mm', '.h', '.swift',
+  '.c', '.cpp', '.cc', '.cxx', '.hpp',
+  '.js', '.ts', '.jsx', '.tsx',
+  '.java', '.kt', '.py', '.rb', '.go', '.rs',
+]);
+
+/** 跳过的目录 */
+const SKIP_DIRS = new Set([
+  'node_modules', '.git', 'build', 'DerivedData',
+  'Pods', '.build', 'vendor', 'dist', '.next',
+  'Carthage', 'xcuserdata', '__pycache__',
+]);
+
+/**
+ * 递归收集目录下所有源文件路径
+ * @param {string} dir - 根目录
+ * @param {object} options
+ * @param {Set<string>} [options.extensions] - 允许的扩展名（默认 SOURCE_EXTS）
+ * @param {Set<string>} [options.skipDirs] - 跳过的目录名（默认 SKIP_DIRS）
+ * @param {number} [options.maxFiles] - 最大文件数量（默认无限制）
+ * @returns {Promise<string[]>} 文件路径列表
+ */
+export async function collectSourceFiles(dir, options = {}) {
+  const {
+    extensions = SOURCE_EXTS,
+    skipDirs = SKIP_DIRS,
+    maxFiles = Infinity,
+  } = options;
+
+  const files = [];
+
+  async function walk(currentDir) {
+    if (files.length >= maxFiles) return;
+
+    let entries;
+    try {
+      entries = await readdir(currentDir, { withFileTypes: true });
+    } catch {
+      return; // 权限不足等情况跳过
+    }
+
+    for (const entry of entries) {
+      if (files.length >= maxFiles) return;
+      if (entry.name.startsWith('.') && entry.name !== '.') continue;
+
+      const fullPath = join(currentDir, entry.name);
+      if (entry.isDirectory()) {
+        if (!skipDirs.has(entry.name)) {
+          await walk(fullPath);
+        }
+      } else if (entry.isFile() && extensions.has(extname(entry.name).toLowerCase())) {
+        files.push(fullPath);
+      }
+    }
+  }
+
+  await walk(dir);
+  return files;
+}
+
+/**
+ * 收集源文件并读取内容
+ * @param {string} dir - 根目录
+ * @param {object} options - collectSourceFiles 选项
+ * @returns {Promise<Array<{path: string, content: string}>>}
+ */
+export async function collectSourceFilesWithContent(dir, options = {}) {
+  const paths = await collectSourceFiles(dir, options);
+  const results = [];
+
+  for (const filePath of paths) {
+    try {
+      const content = await readFile(filePath, 'utf-8');
+      results.push({ path: filePath, content });
+    } catch {
+      // 读取失败跳过
+    }
+  }
+
+  return results;
+}
+
+export default { collectSourceFiles, collectSourceFilesWithContent, SOURCE_EXTS };

package/lib/service/guard/ViolationsStore.js

@@ -77,7 +77,7 @@ export class ViolationsStore {
    */
   getRecentRuns(n = 20) {
     const rows = this.#db.prepare(
-      'SELECT * FROM guard_violations ORDER BY created_at DESC LIMIT ?'
+      'SELECT * FROM guard_violations ORDER BY created_at DESC, rowid DESC LIMIT ?'
     ).all(n);
     return rows.reverse().map(r => this.#rowToRun(r));
   }
@@ -104,6 +104,64 @@ export class ViolationsStore {
     };
   }
 
+  /**
+   * 按规则 ID 聚合统计
+   * 利用 SQLite json_each 展开 violations_json 数组
+   * @returns {Array<{ruleId: string, severity: string, count: number}>}
+   */
+  getStatsByRule() {
+    try {
+      return this.#db.prepare(`
+        SELECT
+          json_extract(j.value, '$.ruleId') AS ruleId,
+          json_extract(j.value, '$.severity') AS severity,
+          COUNT(*) AS count
+        FROM guard_violations gv, json_each(gv.violations_json) j
+        WHERE json_extract(j.value, '$.ruleId') IS NOT NULL
+        GROUP BY ruleId, severity
+        ORDER BY count DESC
+      `).all();
+    } catch {
+      return [];
+    }
+  }
+
+  /**
+   * 获取趋势数据 — 对比最近两次运行
+   * @returns {{ errorsChange: number, warningsChange: number, latestErrors: number, latestWarnings: number, previousErrors: number, previousWarnings: number }}
+   */
+  getTrend() {
+    const recent = this.getRecentRuns(2);
+    if (recent.length < 2) {
+      const latest = recent[0]?.violations || [];
+      return {
+        errorsChange: 0,
+        warningsChange: 0,
+        latestErrors: latest.filter(v => v.severity === 'error').length,
+        latestWarnings: latest.filter(v => v.severity === 'warning').length,
+        previousErrors: 0,
+        previousWarnings: 0,
+        hasHistory: false,
+      };
+    }
+
+    const [prev, latest] = recent;
+    const latestErrors = latest.violations.filter(v => v.severity === 'error').length;
+    const latestWarnings = latest.violations.filter(v => v.severity === 'warning').length;
+    const previousErrors = prev.violations.filter(v => v.severity === 'error').length;
+    const previousWarnings = prev.violations.filter(v => v.severity === 'warning').length;
+
+    return {
+      errorsChange: latestErrors - previousErrors,
+      warningsChange: latestWarnings - previousWarnings,
+      latestErrors,
+      latestWarnings,
+      previousErrors,
+      previousWarnings,
+      hasHistory: true,
+    };
+  }
+
   // ─── 清除 ─────────────────────────────────────────────
 
   /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "autosnippet",
-  "version": "2.12.0",
+  "version": "2.13.0",
   "description": "AutoSnippet - 连接开发者、AI 与项目知识库的工具",
   "type": "module",
   "main": "lib/bootstrap.js",

package/templates/guard-ci.yml

@@ -0,0 +1,80 @@
+# AutoSnippet Guard CI/CD Check
+# 在 push 和 PR 时自动运行 Guard 合规检查
+#
+# 使用方法：将此文件复制到项目的 .github/workflows/ 目录
+
+name: AutoSnippet Guard Check
+
+on:
+  push:
+    branches: [main, develop]
+  pull_request:
+    branches: [main, develop]
+
+jobs:
+  guard:
+    runs-on: ubuntu-latest
+    name: Guard Compliance Check
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install AutoSnippet
+        run: npm install -g autosnippet
+
+      - name: Initialize workspace
+        run: asd setup --dir .
+
+      - name: Run Guard CI check
+        run: |
+          asd guard:ci . \
+            --report json \
+            --output guard-report.json \
+            --max-warnings 20 \
+            --min-score 70
+
+      - name: Upload Guard Report
+        uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: guard-report
+          path: guard-report.json
+          retention-days: 30
+
+      - name: Comment PR with results
+        if: github.event_name == 'pull_request' && always()
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const fs = require('fs');
+            try {
+              const report = JSON.parse(fs.readFileSync('guard-report.json', 'utf8'));
+              const { qualityGate, summary } = report;
+              const icon = qualityGate.status === 'PASS' ? '✅' : qualityGate.status === 'WARN' ? '⚠️' : '❌';
+              
+              const body = [
+                `## ${icon} Guard Compliance Report`,
+                '',
+                `| Metric | Value |`,
+                `|--------|-------|`,
+                `| Quality Gate | ${qualityGate.status} (Score: ${qualityGate.score}/100) |`,
+                `| Files Scanned | ${summary.filesScanned} |`,
+                `| Errors | ${summary.errors} |`,
+                `| Warnings | ${summary.warnings} |`,
+              ].join('\n');
+
+              await github.rest.issues.createComment({
+                issue_number: context.issue.number,
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                body,
+              });
+            } catch (err) {
+              console.log('Could not post PR comment:', err.message);
+            }

package/templates/pre-commit-guard.sh

@@ -0,0 +1,33 @@
+#!/bin/sh
+# AutoSnippet Guard pre-commit hook
+# 
+# 安装方法：
+#   cp templates/pre-commit-guard.sh .git/hooks/pre-commit
+#   chmod +x .git/hooks/pre-commit
+#
+# 或使用 husky:
+#   npx husky add .husky/pre-commit "sh templates/pre-commit-guard.sh"
+
+# 检查 asd 是否可用
+if ! command -v asd &> /dev/null; then
+  echo "⚠️  AutoSnippet (asd) not found. Skipping Guard check."
+  echo "   Install: npm install -g autosnippet"
+  exit 0
+fi
+
+echo "🛡️  Running Guard check on staged files..."
+
+# 运行 guard:staged 检查
+asd guard:staged --fail-on-error
+
+EXIT_CODE=$?
+
+if [ $EXIT_CODE -ne 0 ]; then
+  echo ""
+  echo "❌ Guard check failed. Fix violations before committing."
+  echo "   Use 'git commit --no-verify' to bypass (not recommended)."
+  exit $EXIT_CODE
+fi
+
+echo "✅ Guard check passed."
+exit 0