autodev-cli 1.4.30 → 1.4.32

package/out/taskLoop.js

@@ -445,6 +445,11 @@ class TaskLoopRunner {
         }
         if (this._webhookPoller) {
             this._webhookPoller.setGitEnabled(settings.gitEnabled ?? false);
+            this._webhookPoller.setFileBrowserEnabled(settings.enableFileBrowser ?? false);
+            // VNC / RDP session bridges are honored only when explicitly enabled —
+            // an ungated frame would let a remote party open outbound bridges.
+            this._webhookPoller.setVncEnabled(settings.vncEnabled ?? false);
+            this._webhookPoller.setRdpEnabled(settings.rdpEnabled ?? false);
             // Wake the idle no-task sleep instantly when a WS-pushed task arrives.
             this._webhookPoller.setOnTaskAppend(() => this._wakeIdleSleep());
             this._webhookPoller.setOnSteer((text) => this._handleSteer(text));
@@ -636,11 +641,25 @@ class TaskLoopRunner {
         const root = this._workspaceRoot;
         if (!root)
             return;
-        this._cb?.log('🔧 mcp_update received — writing .mcp.json and syncing providers…');
+        // Opt-in gate: writing remote-supplied MCP config spawns stdio child
+        // processes on restart (code-execution surface). Ignore unless explicitly
+        // enabled, mirroring enableFileBrowser / gitEnabled.
+        if (!this._settings?.mcpUpdateEnabled) {
+            this._cb?.log('🔒 mcp_update ignored — mcpUpdateEnabled is off (set it in .autodev/settings.json to allow)');
+            return;
+        }
+        this._cb?.log('🔧 mcp_update received — validating and writing .mcp.json…');
+        // Reject entries that would execute an arbitrary shell / path command.
+        const { safe, rejected } = (0, projectMcp_1.sanitizeRemoteMcpEntries)(entries);
+        if (rejected.length) {
+            this._cb?.log(`⚠️ mcp_update dropped ${rejected.length} unsafe entr${rejected.length === 1 ? 'y' : 'ies'}: ${rejected.join(', ')}`);
+        }
+        if (Object.keys(safe).length === 0) {
+            this._cb?.log('⚠️ mcp_update had no safe entries — not writing config or restarting.');
+            return;
+        }
         try {
-            // Cast to the shape saveProjectUserMcp expects
-            const typed = entries;
-            (0, projectMcp_1.saveProjectUserMcp)(root, typed);
+            (0, projectMcp_1.saveProjectUserMcp)(root, safe);
             configManager_1.ConfigManager.syncProjectMcpServers(root, (m) => this._cb?.log(m));
             void configManager_1.ConfigManager.reportProjectMcp(root, (m) => this._cb?.log(m));
             this._cb?.log('✅ MCP config synced to .mcp.json, opencode.json, .vscode/mcp.json — restarting loop…');
@@ -686,6 +705,13 @@ class TaskLoopRunner {
             this._cb?.log('⚠️ restore_request ignored — serverApiKey not configured');
             return;
         }
+        // The download carries the agent's Bearer credential and overwrites the
+        // workspace, so the URL must point at the configured server origin — never
+        // an attacker-chosen host from the WS frame.
+        if (!(0, agentBackup_1.isTrustedDownloadUrl)(downloadUrl, settings.serverBaseUrl)) {
+            this._cb?.log(`🔒 restore_request refused — downloadUrl origin does not match the configured server: ${downloadUrl}`);
+            return;
+        }
         this._cb?.log(`🔄 restore_request received — downloading backup from ${downloadUrl}…`);
         const tmpPath = path.join(os.tmpdir(), `agent-restore-${agentId}-${Date.now()}.zip`);
         try {
@@ -1686,6 +1712,33 @@ class TaskLoopRunner {
                 }
             }
             catch (err) {
+                // --- Auth required: pause INDEFINITELY, never mark the task done ----
+                // A logged-out / out-of-credit CLI is not a task failure. Put the task
+                // back to [ ], flip the office to a distinct 'needs reauth' state, and
+                // block until the operator re-authenticates and clicks Retry.
+                if (err instanceof rateLimit_1.AuthError) {
+                    const rawMsg = err.rawMessage.slice(0, 300);
+                    const currentProvider = this._cb?.getActiveProvider() ?? 'unknown';
+                    this._cb?.log(`🔑 Authentication required (${currentProvider}) — pausing loop until re-auth. ${rawMsg}`);
+                    this._notifyDiscord(`🔑 **Authentication required** (${currentProvider}) — loop paused until you re-authenticate.\n\`\`\`\n${rawMsg}\n\`\`\``);
+                    this._notifyWebhook('reauth_required', {
+                        iteration: this._iterations,
+                        task: { text: task.text },
+                        message: rawMsg,
+                        provider: currentProvider,
+                        workDir: this._workspaceRoot,
+                        gitRepo: this._gitRepo,
+                        gitBranch: this._gitBranch,
+                    });
+                    // Never markDone — restore the task so it is retried after re-auth.
+                    await todoWriteManager_1.todoWriter.resetToTodo(todoPath, task).catch(() => { });
+                    // Pause indefinitely (no auto-resume) — operator must re-auth + Retry.
+                    await this._pauseLoop();
+                    if (this._state !== 'running') {
+                        break;
+                    }
+                    continue;
+                }
                 // --- Rate limit: pause loop, schedule auto-resume -----------------
                 if (err instanceof rateLimit_1.RateLimitError) {
                     // Two flavours:
@@ -1978,6 +2031,13 @@ class TaskLoopRunner {
         const iscopilotSdkProvider = this._cb?.getActiveProvider() === 'copilot-sdk';
         const isOpenCodeCli = this._cb?.getActiveProvider() === 'opencode-cli';
         const isOpencodeSdk = this._cb?.getActiveProvider() === 'opencode-sdk';
+        // grok-cli / grok-tui / copilot-cli all tee stdout too — without these flags
+        // the rate-limit / context-length / thrash detectors never ran for them, so
+        // a throttled or context-blown turn was silently walked to give_up and the
+        // task was falsely marked [x].
+        const isGrokCli = this._cb?.getActiveProvider() === 'grok-cli';
+        const isGrokTui = this._cb?.getActiveProvider() === 'grok-tui';
+        const isCopilotCli = this._cb?.getActiveProvider() === 'copilot-cli';
         return new Promise((resolve, reject) => {
             if (this._state !== 'running') {
                 resolve();
@@ -2111,10 +2171,15 @@ class TaskLoopRunner {
             // Track how many characters of the stdout file we've already forwarded
             let lastStdoutLen = 0;
             // Check stdout file: forward any new content to Discord/webhook, detect rate limit / context errors
+            // Providers that write a stdout capture file we can scan for failure
+            // banners (rate-limit / context-length / thrash). Every CLI/TUI provider
+            // tees stdout; the two Claude ones and OpenCode also stream/parse extra.
+            const teesStdout = isClaudeCli || isClaudeTui || iscopilotSdkProvider || isOpenCodeCli
+                || isGrokCli || isGrokTui || isCopilotCli;
             const checkStdout = () => {
-                if (!isClaudeCli && !isClaudeTui && !iscopilotSdkProvider && !isOpenCodeCli) {
+                if (!teesStdout) {
                     return;
-                } // only CLI providers tee stdout
+                }
                 const content = readStdoutFile();
                 // Forward new output lines to Discord / webhook.
                 // claude-cli: stream partial chunks so the operator can see live progress.
@@ -2139,8 +2204,22 @@ class TaskLoopRunner {
                 else {
                     lastStdoutLen = content.length; // keep cursor up to date
                 }
-                // Rate limit detection (Claude CLI + TUI)
-                if (isClaudeCli || isClaudeTui) {
+                // Auth failure detection — highest priority. A logged-out / out-of-credit
+                // CLI exits fast with no rate-limit or context signal, so without this it
+                // was walked remind->give_up and the whole backlog was falsely marked [x].
+                {
+                    const authErr = rateLimit_1.AuthDetector.detect(content);
+                    if (authErr) {
+                        cleanup();
+                        reject(authErr);
+                        return;
+                    }
+                }
+                // Rate limit detection — run for every stdout-teeing provider. The
+                // RateLimitDetector phrases are scoped to error/banner forms, so this
+                // is safe to apply provider-agnostically (grok/copilot were previously
+                // excluded, letting a throttle slip through to a false [x]).
+                {
                     const rlErr = rateLimit_1.RateLimitDetector.detect(content);
                     if (rlErr) {
                         cleanup();
@@ -2157,28 +2236,13 @@ class TaskLoopRunner {
                         return;
                     }
                 }
-                // Context length error detection (Claude). Patterns observed:
+                // Context-length / thrash detection for the remaining CLI+TUI providers.
+                // Patterns observed:
                 //   "prompt is too long: 1018289 tokens > 1000000 maximum"
                 //   "Prompt is too long" (last_assistant_message in StopFailure hook)
-                //   "context_length_exceeded"
+                //   "context_length_exceeded" / "maximum context length"
                 //   "Autocompact is thrashing" (context refills immediately after compact)
-                if (isClaudeCli) {
-                    const lc = content.toLowerCase();
-                    if (lc.includes('autocompact is thrashing')) {
-                        cleanup();
-                        reject(new ThrashingError(content.trim()));
-                        return;
-                    }
-                    if (lc.includes('prompt is too long')
-                        || lc.includes('context_length_exceeded')
-                        || /tokens?\s*>\s*\d+\s*maximum/.test(lc)) {
-                        cleanup();
-                        reject(new ContextLengthError(content.trim()));
-                        return;
-                    }
-                }
-                // Context length detection for claude-tui (same patterns)
-                if (isClaudeTui) {
+                if (isClaudeCli || isClaudeTui || isGrokCli || isGrokTui || isCopilotCli) {
                     const lc = content.toLowerCase();
                     if (lc.includes('autocompact is thrashing')) {
                         cleanup();
@@ -2187,6 +2251,7 @@ class TaskLoopRunner {
                     }
                     if (lc.includes('prompt is too long')
                         || lc.includes('context_length_exceeded')
+                        || lc.includes('maximum context length')
                         || /tokens?\s*>\s*\d+\s*maximum/.test(lc)) {
                         cleanup();
                         reject(new ContextLengthError(content.trim()));
@@ -2226,9 +2291,17 @@ class TaskLoopRunner {
                     return;
                 }
                 // Fast-path: if the stdout capture file already contains a rate-limit
-                // or context-length phrase at exit time, raise immediately.
+                // or context-length phrase at exit time, raise immediately. Applies to
+                // every stdout-teeing provider so a throttled grok/copilot exit pauses
+                // instead of being force-marked done.
                 const exitStdout = readStdoutFile();
-                if (isClaudeCli) {
+                if (teesStdout) {
+                    const authFromStdout = rateLimit_1.AuthDetector.detect(exitStdout);
+                    if (authFromStdout) {
+                        cleanup();
+                        reject(authFromStdout);
+                        return;
+                    }
                     const rlFromStdout = rateLimit_1.RateLimitDetector.detect(exitStdout);
                     if (rlFromStdout) {
                         cleanup();
@@ -2440,8 +2513,9 @@ class TaskLoopRunner {
                         return;
                     }
                 }
-                // Also check stdout capture file as poller fallback (watcher handles most cases)
-                checkStdout();
+                // (stdout capture file is already checked once at the top of this tick via
+                // checkStdout() at line ~2215; a second scan here was redundant and doubled
+                // the per-tick cost of re-reading the growing stdout file.)
                 // Track JSONL activity
                 const currentSize = (0, dispatcher_1.getClaudeSessionCursor)(this._workspaceRoot);
                 if (currentSize !== lastJSONLSize) {