autobee 2.3.0 → 2.3.1

package/lib/fast-forward.js

@@ -167,15 +167,18 @@ module.exports = class FastForward {
     // ensure local key is locally available always
     promises.push(this.system.get(this.auto.local.key, { timeout: this.timeout }))
 
-    const view = this.auto.store.get({ key: this.system.view.key, active: true })
-    this.cores.push(view)
-
-    promises.push(
-      view.get(this.system.view.length - 1, {
-        timeout: this.timeout,
-        activeRequests: this.activeRequests
-      })
-    )
+    // a legacy system without the designated view migrates onto an empty view
+    if (this.system.view.length) {
+      const view = this.auto.store.get({ key: this.system.view.key, active: true })
+      this.cores.push(view)
+
+      promises.push(
+        view.get(this.system.view.length - 1, {
+          timeout: this.timeout,
+          activeRequests: this.activeRequests
+        })
+      )
+    }
 
     for (const head of this.system.heads) {
       promises.push(this.system.get(head.key, { timeout: this.timeout }))

package/lib/migrations.js

@@ -25,11 +25,13 @@ module.exports = {
   coreLength
 }
 
-async function getCoreManifest(store, key, { timeout, wait = true } = {}) {
+// a peer with a sparse copy may not hold block 0, but the recorded tail is the
+// block it most likely has, so fetch the manifest through that when known
+async function getCoreManifest(store, key, { timeout, wait = true, length = 0 } = {}) {
   const core = store.get(key)
   await core.ready()
   try {
-    if (!core.manifest && core.length === 0) await core.get(0, { timeout, wait })
+    if (!core.manifest) await core.get(length ? length - 1 : 0, { timeout, wait })
     return core.manifest
   } finally {
     await core.close()

package/lib/system.js

@@ -158,7 +158,7 @@ module.exports = class Systembee {
     if (!info) return EMPTY_HEAD
     const a = this.auto
 
-    const toManifests = ({ key }) => getCoreManifest(a.store, key, { timeout })
+    const toManifests = ({ key, length }) => getCoreManifest(a.store, key, { timeout, length })
     const promises = [...info.indexers.map(toManifests), ...info.views.map(toManifests)]
 
     await Promise.all(promises)
@@ -168,13 +168,10 @@ module.exports = class Systembee {
     // the handler only runs once the head is locked in - see auto._runMigration
     this.migration = { views, head: this.bee.head() }
 
-    // legacyViews is ordered by preference, so the first one that resolved wins
-    for (const name of a.legacyViews) {
-      const view = views.get(name)
-      if (view) return view
-    }
-
-    return EMPTY_HEAD
+    // only the designated view may become the autobee view: the view bee decrypts
+    // with the key for its own name, so any other legacy view reads as garbage
+    const name = a.legacyViews.length ? a.legacyViews[0] : null
+    return (name && views.get(name)) || EMPTY_HEAD
   }
 
   bootRecord() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "autobee",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "Bee based autobase",
   "license": "Apache-2.0",
   "author": "Holepunch Inc.",