auto-cr-rules 2.0.105 → 2.0.107

package/README.md

@@ -43,7 +43,7 @@ Common flags:
 - `--language <zh|en>`: Switch CLI output language (defaults to auto-detection).
 - `--rule-dir <directory>`: Load additional custom rules from a directory or package.
 - `--output <text|json>`: Choose between human-friendly text logs or structured JSON results (defaults to `text`).
-- `--progress [tty-only|yes|no]`: Progress mode (text output only, default `tty-only`); output goes to `stderr`.
+- `--progress [tty-only|yes|no]`: Progress mode (text output only, default `no`); output goes to `stderr`.
 - `--config <path>`: Point to a `.autocrrc.json` or `.autocrrc.js` file to enable/disable rules.
 - `--ignore-path <path>`: Point to a `.autocrignore.json` or `.autocrignore.js` file to exclude files/directories from scanning.
 - `--tsconfig <path>`: Use a custom `tsconfig.json` (defaults to `<cwd>/tsconfig.json`).

package/dist/rules/noCircularDependencies.js

@@ -865,6 +865,7 @@ var readFileSafe = function (filePath) {
 // 用正则匹配常见的导入写法，覆盖 import / dynamic import / require / export-from。
 var extractImportSpecifiers = function (source) {
     var results = [];
+    var sanitized = stripJsComments(source);
     var patterns = [
         /import\s+(?:[^'"]+\s+from\s+)?['"]([^'"]+)['"]/g,
         /import\s*\(\s*['"]([^'"]+)['"]\s*\)/g,
@@ -874,12 +875,71 @@ var extractImportSpecifiers = function (source) {
     for (var _i = 0, patterns_2 = patterns; _i < patterns_2.length; _i++) {
         var pattern = patterns_2[_i];
         var match = void 0;
-        while ((match = pattern.exec(source)) !== null) {
+        while ((match = pattern.exec(sanitized)) !== null) {
             results.push(match[1]);
         }
     }
     return results;
 };
+// 轻量移除 JS/TS 注释，避免注释里的 import/require 被正则误判。
+var stripJsComments = function (content) {
+    var result = '';
+    var inString = false;
+    var stringChar = '';
+    var inLineComment = false;
+    var inBlockComment = false;
+    var escaped = false;
+    for (var index = 0; index < content.length; index += 1) {
+        var char = content[index];
+        var next = content[index + 1];
+        if (inLineComment) {
+            if (char === '\n') {
+                inLineComment = false;
+                result += char;
+            }
+            continue;
+        }
+        if (inBlockComment) {
+            if (char === '*' && next === '/') {
+                inBlockComment = false;
+                index += 1;
+                result += ' ';
+            }
+            else if (char === '\n') {
+                result += char;
+            }
+            continue;
+        }
+        if (inString) {
+            result += char;
+            if (!escaped && char === stringChar) {
+                inString = false;
+                stringChar = '';
+            }
+            escaped = !escaped && char === '\\';
+            continue;
+        }
+        if (char === '"' || char === "'" || char === '`') {
+            inString = true;
+            stringChar = char;
+            result += char;
+            continue;
+        }
+        if (char === '/' && next === '/') {
+            inLineComment = true;
+            index += 1;
+            continue;
+        }
+        if (char === '/' && next === '*') {
+            inBlockComment = true;
+            index += 1;
+            result += ' ';
+            continue;
+        }
+        result += char;
+    }
+    return result;
+};
 // 解析相对路径到真实文件：支持自动补全扩展名与目录 index。
 // 并确保解析结果在项目根目录内。
 var resolveImportFile = function (fromFile, specifier, root) {

package/dist/rules/noN2ArrayLookup.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noN2ArrayLookup = void 0;
+var sourceIndex_1 = require("../sourceIndex");
 var types_1 = require("../types");
 // 线性查找方法集合：filter/some/every 也按线性查找处理。
 var LINEAR_LOOKUP_METHODS = new Set([
@@ -16,7 +17,7 @@ var LINEAR_LOOKUP_METHODS = new Set([
 // 检测热路径中对数组进行线性查找的调用，避免潜在 O(n^2) 访问。
 // 不强制校验 receiver 是否真实数组（静态分析阶段难以确定）。
 exports.noN2ArrayLookup = (0, types_1.defineRule)('no-n2-array-lookup', { tag: 'performance', severity: types_1.RuleSeverity.Optimizing }, function (_a) {
-    var analysis = _a.analysis, helpers = _a.helpers, language = _a.language, messages = _a.messages;
+    var analysis = _a.analysis, helpers = _a.helpers, language = _a.language, messages = _a.messages, source = _a.source, sourceIndex = _a.sourceIndex;
     var suggestions = language === 'zh'
         ? [
             { text: '预先构建 Map/Set 进行 O(1) 查找。' },
@@ -33,10 +34,14 @@ exports.noN2ArrayLookup = (0, types_1.defineRule)('no-n2-array-lookup', { tag: '
         if (!method || !LINEAR_LOOKUP_METHODS.has(method)) {
             continue;
         }
+        var line = callExpression.span
+            ? (0, sourceIndex_1.resolveLineFromByteOffset)(source, sourceIndex, callExpression.span.start)
+            : undefined;
         helpers.reportViolation({
             description: messages.noN2ArrayLookup({ method: method }),
             code: method,
             suggestions: suggestions,
+            line: line,
             span: callExpression.span,
         }, callExpression.span);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "auto-cr-rules",
-  "version": "2.0.105",
+  "version": "2.0.107",
   "description": "Extensible static analysis rule set for the auto-cr automated code review toolkit",
   "main": "dist/index.js",
   "types": "dist/types/index.d.ts",