audit-tools 0.51.6 → 0.51.9

package/dist/shared/decompose/charterClarification.js

@@ -1,28 +1,25 @@
+// sites-pinned: tests/audit/charter-clarification.test.ts
 // Phase D — the charter-alignment TRIANGULATION LOOP (shared pure assembly).
 //
-// Where Phase C (charterExtraction.ts) assembles the routed charter deltas, this
-// module turns the clarification/human-routed deltas into decidable, symmetric,
-// VOI-ranked, risk-gated questions and splits them by the attention appetite:
-// interactive questions to ASK vs findings to BANK (design of record
-// spec/conceptual-design-review-design.md §"The triangulation loop" + §"Control
-// surface — three currencies, three dials"). Zero attention = the autonomous mode
-// (every question banked as a finding). It consumes the pure D1/D2 primitives that
-// live audit-side (blastRadius/voiQueue/riskGate/dials/partition) via the injected
-// `deps` below, so this shared module stays free of an audit → shared import and
-// phase-e can drive the same loop with the same primitives.
+// Where the charter layer (charterLayer.ts) assembles the verified difference
+// records, this module turns the clarification/human-routed, fidelity-SUPPORTED
+// differences into decidable, symmetric, n-ary, VOI-ranked, risk-gated questions
+// and splits them by the attention appetite: interactive questions to ASK vs
+// findings to BANK (design of record spec/conceptual-design-review-design.md
+// §"The triangulation loop" + §"Control surface — three currencies, three
+// dials"). Zero attention = the autonomous mode (every question banked as a
+// finding). It consumes the pure D1/D2 primitives that live audit-side
+// (blastRadius/voiQueue/riskGate/dials/partition) via the injected `deps`.
 //
-// PURE + deterministic + language-neutral: no IO, no LLM. The host LLM's only role
-// upstream was JUDGMENT (the charters/deltas in Phase C); the loop itself is
-// deterministic enforcement — partition, rank, gate, split.
+// PURE + deterministic + language-neutral: no IO, no LLM.
 import { z } from "zod";
-import { CharterClarificationAnswerSchema, } from "../types/charter.js";
+import { CharterDifferenceAnswerSchema, } from "../types/charter.js";
 import { compareCodeUnits } from "../compareCodeUnits.js";
 /**
- * The host answers submission (what the host writes to
- * the `charter_clarification` lane): one symmetric answer per interactive
- * question. A question with no answer in the submission defaults to `leave_open`
- * (the interruptible-loop rule — a user who taps out leaves the rest open), which
- * guarantees the queue drains and the loop terminates in one round-trip.
+ * The host answers submission (what the host writes to the
+ * `charter_clarification` lane): one n-ary answer per interactive question. A
+ * question with no answer in the submission defaults to `leave_open` (the
+ * interruptible-loop rule), which guarantees the queue drains in one round-trip.
  */
 export const ClarificationAnswersSubmissionSchema = z
     .object({
@@ -30,67 +27,63 @@ export const ClarificationAnswersSubmissionSchema = z
         .array(z
         .object({
         request_id: z.string(),
-        answer: CharterClarificationAnswerSchema,
+        answer: CharterDifferenceAnswerSchema,
     })
         .strict())
         .default([]),
 })
     .strict();
+/** A difference sources a question when the tool routed it to a decision and fidelity holds. */
+export function sourcesQuestion(difference) {
+    return ((difference.routed_to === "clarification" || difference.routed_to === "human") &&
+        difference.fidelity?.verdict === "supported");
+}
 /**
- * Assemble the charter-clarification loop from the Phase-C routed deltas.
+ * Assemble the charter-clarification loop from the verified differences.
  *
- * 1. PARTITION the clarification/human-routed deltas into symmetric questions with
- *    their VOI axes (blast radius + cascade count) — remediator-routed spec-drift
- *    deltas are NOT questions and are recorded as a validation note.
+ * 1. PARTITION the clarification/human-routed, supported differences into
+ *    n-ary questions with their VOI axes — remediator-routed records are fixes,
+ *    not questions, and are recorded as a routine note; unsupported records never
+ *    become questions.
  * 2. RISK-GATE the questions (high-blast → higher adversarial bar → `finding_only`).
- * 3. SPLIT by the attention appetite into `asked` (the VOI-ranked interactive
- *    queue) vs `banked` (written as findings; everything under appetite 0).
+ * 3. SPLIT by the attention appetite into `asked` vs `banked`.
  * 4. SURFACE the banked questions as Finding leads for synthesis.
  *
- * Deterministic: same deltas + same graph + same appetite → same register.
+ * Deterministic: same differences + same graphs + same appetite → same register.
  */
-export function assembleClarificationRegister(deltas, goalGraph, attention, deps, priorAnswers = new Map()) {
+export function assembleClarificationRegister(inputs, graphs, attention, deps, priorAnswers = new Map()) {
     const validation_issues = [];
-    const membersByNode = new Map();
-    for (const d of deltas)
-        membersByNode.set(d.node_id, d.members);
-    const remediatorRouted = deltas.filter((d) => d.delta.routed_to === "remediator");
-    for (const d of remediatorRouted) {
-        validation_issues.push(`delta "${d.delta.delta_id}" routes to the remediator (spec drift) — not a charter question; handled by the remediator, not the attention loop`);
+    const membersByRequest = new Map();
+    for (const input of inputs) {
+        const d = input.difference;
+        if (d.routed_to === "remediator") {
+            validation_issues.push(`difference "${d.difference_id}" routes to the remediator (doc rot / drift) — not a charter question; handled by the remediator, not the attention loop`);
+        }
+        if (input.members.length === 0 && sourcesQuestion(d)) {
+            validation_issues.push(`difference "${d.difference_id}" cites no scoped files — its question is kept, but the Finding it surfaces will cite no affected_files`);
+        }
+    }
+    const questions = deps.partitionDifferencesToQuestions(inputs, graphs);
+    for (const q of questions) {
+        const input = inputs.find((i) => i.difference.difference_id === q.difference_id);
+        membersByRequest.set(q.request_id, input?.members ?? []);
     }
-    const questions = deps.partitionDeltasToQuestions(deltas.map((d) => ({
-        delta: d.delta,
-        node_id: d.node_id,
-        goal_node_id: d.goal_node_id,
-    })), goalGraph);
     const gated = deps.applyRiskGate(questions);
     const split = deps.splitByAttention(gated, attention);
-    // Carry any prior answers onto the re-derived questions, matched by `request_id`
-    // — an answered question keeps its `answer` across re-assembly, so a round never
-    // loses a decision already recorded. Applied to BOTH sides of the split: a
-    // question the attention dial moves from `asked` to `banked` (or back) between
-    // rounds must not drop its answer for having changed buckets.
-    //
-    // A user who taps out mid-loop leaves the rest unanswered. Nothing is synthesized
-    // here: the caller decides when a submission exists at all, and on that submission
-    // defaults every still-unanswered question it previously asked to `leave_open`
-    // (a first-class decision) so the queue drains and the loop terminates in one
-    // round-trip. Absent a submission the map is empty and every question stays open.
     const applyAnswer = (r) => {
         const answer = priorAnswers.get(r.request_id);
         return answer ? { ...r, answer } : r;
     };
     const asked = split.asked.map(applyAnswer);
     const banked = split.banked.map(applyAnswer);
-    const findings = banked.map((request) => questionToFinding(request, membersByNode.get(request.node_id) ?? []));
-    findings.sort((a, b) => compareCodeUnits(a.id, b.id));
+    const findings = banked
+        .map((request) => questionToFinding(request, membersByRequest.get(request.request_id) ?? []))
+        .sort((a, b) => compareCodeUnits(a.id, b.id));
     return { asked, banked, findings, validation_issues };
 }
 /**
- * Surface a BANKED charter-clarification question as a Finding LEAD (leads-not-
- * verdicts — the owner judges it). `severity` scales with blast radius (a wrong-goal
- * provocation ripples furthest); `lens` is `architecture` (a charter-alignment gap
- * is a design defect). Members of the subsystem are the affected files.
+ * Surface a BANKED charter question as a Finding LEAD (leads-not-verdicts).
+ * `severity` scales with blast radius; `lens` is `architecture`.
  */
 function questionToFinding(request, members) {
     const severity = request.value.blast_radius >= 3
@@ -100,7 +93,7 @@ function questionToFinding(request, members) {
             : "low";
     return {
         id: request.request_id,
-        title: `Unresolved charter question in subsystem ${request.node_id}`,
+        title: `Unresolved charter question (${request.dimension})${request.subsystem_id ? ` in subsystem ${request.subsystem_id}` : ""}`,
         category: "charter_clarification",
         severity,
         confidence: "medium",

package/dist/shared/decompose/charterClarification.js.map

@@ -1 +1 @@
-{"version":3,"file":"charterClarification.js","sourceRoot":"","sources":["../../../src/shared/decompose/charterClarification.ts"],"names":[],"mappings":"AAAA,6EAA6E;AAC7E,EAAE;AACF,iFAAiF;AACjF,gFAAgF;AAChF,8EAA8E;AAC9E,qEAAqE;AACrE,gFAAgF;AAChF,kFAAkF;AAClF,mFAAmF;AACnF,mFAAmF;AACnF,iFAAiF;AACjF,4DAA4D;AAC5D,EAAE;AACF,mFAAmF;AACnF,6EAA6E;AAC7E,4DAA4D;AAE5D,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AACxB,OAAO,EACL,gCAAgC,GAIjC,MAAM,qBAAqB,CAAC;AAE7B,OAAO,EAAE,gBAAgB,EAAE,MAAM,wBAAwB,CAAC;AAE1D;;;;;;GAMG;AACH,MAAM,CAAC,MAAM,oCAAoC,GAAG,CAAC;KAClD,MAAM,CAAC;IACN,OAAO,EAAE,CAAC;SACP,KAAK,CACJ,CAAC;SACE,MAAM,CAAC;QACN,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE;QACtB,MAAM,EAAE,gCAAgC;KACzC,CAAC;SACD,MAAM,EAAE,CACZ;SACA,OAAO,CAAC,EAAE,CAAC;CACf,CAAC;KACD,MAAM,EAAE,CAAC;AAqDZ;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,6BAA6B,CAC3C,MAAiC,EACjC,SAAoB,EACpB,SAAiC,EACjC,IAA2B,EAC3B,eAAmE,IAAI,GAAG,EAAE;IAE5E,MAAM,iBAAiB,GAAa,EAAE,CAAC;IACvC,MAAM,aAAa,GAAG,IAAI,GAAG,EAAoB,CAAC;IAClD,KAAK,MAAM,CAAC,IAAI,MAAM;QAAE,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC;IAEhE,MAAM,gBAAgB,GAAG,MAAM,CAAC,MAAM,CACpC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,SAAS,KAAK,YAAY,CAC1C,CAAC;IACF,KAAK,MAAM,CAAC,IAAI,gBAAgB,EAAE,CAAC;QACjC,iBAAiB,CAAC,IAAI,CACpB,UAAU,CAAC,CAAC,KAAK,CAAC,QAAQ,qHAAqH,CAChJ,CAAC;IACJ,CAAC;IAED,MAAM,SAAS,GAAG,IAAI,CAAC,0BAA0B,CAC/C,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;QACjB,KAAK,EAAE,CAAC,CAAC,KAAK;QACd,OAAO,EAAE,CAAC,CAAC,OAAO;QAClB,YAAY,EAAE,CAAC,CAAC,YAAY;KAC7B,CAAC,CAAC,EACH,SAAS,CACV,CAAC;IACF,MAAM,KAAK,GAAG,IAAI,CAAC,aAAa,CAAC,SAAS,CAAC,CAAC;IAC5C,MAAM,KAAK,GAAG,IAAI,CAAC,gBAAgB,CAAC,KAAK,EAAE,SAAS,CAAC,CAAC;IACtD,iFAAiF;IACjF,iFAAiF;IACjF,2EAA2E;IAC3E,+EAA+E;IAC/E,8DAA8D;IAC9D,EAAE;IACF,kFAAkF;IAClF,mFAAmF;IACnF,+EAA+E;IAC/E,8EAA8E;IAC9E,kFAAkF;IAClF,MAAM,WAAW,GAAG,CAClB,CAA8B,EACD,EAAE;QAC/B,MAAM,MAAM,GAAG,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;QAC9C,OAAO,MAAM,CAAC,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACvC,CAAC,CAAC;IACF,MAAM,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;IAC3C,MAAM,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;IAE7C,MAAM,QAAQ,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CACtC,iBAAiB,CAAC,OAAO,EAAE,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,CACrE,CAAC;IACF,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IAEtD,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,QAAQ,EAAE,iBAAiB,EAAE,CAAC;AACxD,CAAC;AAED;;;;;GAKG;AACH,SAAS,iBAAiB,CACxB,OAAoC,EACpC,OAAiB;IAEjB,MAAM,QAAQ,GACZ,OAAO,CAAC,KAAK,CAAC,YAAY,IAAI,CAAC;QAC7B,CAAC,CAAC,MAAM;QACR,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,YAAY,IAAI,CAAC;YAC/B,CAAC,CAAC,QAAQ;YACV,CAAC,CAAC,KAAK,CAAC;IACd,OAAO;QACL,EAAE,EAAE,OAAO,CAAC,UAAU;QACtB,KAAK,EAAE,4CAA4C,OAAO,CAAC,OAAO,EAAE;QACpE,QAAQ,EAAE,uBAAuB;QACjC,QAAQ;QACR,UAAU,EAAE,QAAQ;QACpB,IAAI,EAAE,cAAc;QACpB,OAAO,EAAE,OAAO,CAAC,QAAQ;QACzB,cAAc,EAAE,OAAO,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC;QACjD,QAAQ,EAAE,IAAI;KACf,CAAC;AACJ,CAAC"}
+{"version":3,"file":"charterClarification.js","sourceRoot":"","sources":["../../../src/shared/decompose/charterClarification.ts"],"names":[],"mappings":"AAAA,0DAA0D;AAC1D,6EAA6E;AAC7E,EAAE;AACF,8EAA8E;AAC9E,gFAAgF;AAChF,iFAAiF;AACjF,6EAA6E;AAC7E,6EAA6E;AAC7E,0EAA0E;AAC1E,4EAA4E;AAC5E,uEAAuE;AACvE,2EAA2E;AAC3E,EAAE;AACF,0DAA0D;AAE1D,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AACxB,OAAO,EACL,6BAA6B,GAM9B,MAAM,qBAAqB,CAAC;AAE7B,OAAO,EAAE,gBAAgB,EAAE,MAAM,wBAAwB,CAAC;AAE1D;;;;;GAKG;AACH,MAAM,CAAC,MAAM,oCAAoC,GAAG,CAAC;KAClD,MAAM,CAAC;IACN,OAAO,EAAE,CAAC;SACP,KAAK,CACJ,CAAC;SACE,MAAM,CAAC;QACN,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE;QACtB,MAAM,EAAE,6BAA6B;KACtC,CAAC;SACD,MAAM,EAAE,CACZ;SACA,OAAO,CAAC,EAAE,CAAC;CACf,CAAC;KACD,MAAM,EAAE,CAAC;AA8CZ,gGAAgG;AAChG,MAAM,UAAU,eAAe,CAAC,UAA6B;IAC3D,OAAO,CACL,CAAC,UAAU,CAAC,SAAS,KAAK,eAAe,IAAI,UAAU,CAAC,SAAS,KAAK,OAAO,CAAC;QAC9E,UAAU,CAAC,QAAQ,EAAE,OAAO,KAAK,WAAW,CAC7C,CAAC;AACJ,CAAC;AAED;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,6BAA6B,CAC3C,MAA+C,EAC/C,MAAmC,EACnC,SAAiC,EACjC,IAA2B,EAC3B,eAAqD,IAAI,GAAG,EAAE;IAE9D,MAAM,iBAAiB,GAAa,EAAE,CAAC;IACvC,MAAM,gBAAgB,GAAG,IAAI,GAAG,EAAoB,CAAC;IAErD,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;QAC3B,MAAM,CAAC,GAAG,KAAK,CAAC,UAAU,CAAC;QAC3B,IAAI,CAAC,CAAC,SAAS,KAAK,YAAY,EAAE,CAAC;YACjC,iBAAiB,CAAC,IAAI,CACpB,eAAe,CAAC,CAAC,aAAa,0HAA0H,CACzJ,CAAC;QACJ,CAAC;QACD,IAAI,KAAK,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC,IAAI,eAAe,CAAC,CAAC,CAAC,EAAE,CAAC;YACrD,iBAAiB,CAAC,IAAI,CACpB,eAAe,CAAC,CAAC,aAAa,yGAAyG,CACxI,CAAC;QACJ,CAAC;IACH,CAAC;IAED,MAAM,SAAS,GAAG,IAAI,CAAC,+BAA+B,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACvE,KAAK,MAAM,CAAC,IAAI,SAAS,EAAE,CAAC;QAC1B,MAAM,KAAK,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,aAAa,KAAK,CAAC,CAAC,aAAa,CAAC,CAAC;QACjF,gBAAgB,CAAC,GAAG,CAAC,CAAC,CAAC,UAAU,EAAE,KAAK,EAAE,OAAO,IAAI,EAAE,CAAC,CAAC;IAC3D,CAAC;IACD,MAAM,KAAK,GAAG,IAAI,CAAC,aAAa,CAAC,SAAS,CAAC,CAAC;IAC5C,MAAM,KAAK,GAAG,IAAI,CAAC,gBAAgB,CAAC,KAAK,EAAE,SAAS,CAAC,CAAC;IACtD,MAAM,WAAW,GAAG,CAAC,CAA4B,EAA6B,EAAE;QAC9E,MAAM,MAAM,GAAG,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;QAC9C,OAAO,MAAM,CAAC,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACvC,CAAC,CAAC;IACF,MAAM,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;IAC3C,MAAM,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;IAE7C,MAAM,QAAQ,GAAG,MAAM;SACpB,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,iBAAiB,CAAC,OAAO,EAAE,gBAAgB,CAAC,GAAG,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC;SAC5F,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IAEhD,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,QAAQ,EAAE,iBAAiB,EAAE,CAAC;AACxD,CAAC;AAED;;;GAGG;AACH,SAAS,iBAAiB,CACxB,OAAkC,EAClC,OAAiB;IAEjB,MAAM,QAAQ,GACZ,OAAO,CAAC,KAAK,CAAC,YAAY,IAAI,CAAC;QAC7B,CAAC,CAAC,MAAM;QACR,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,YAAY,IAAI,CAAC;YAC/B,CAAC,CAAC,QAAQ;YACV,CAAC,CAAC,KAAK,CAAC;IACd,OAAO;QACL,EAAE,EAAE,OAAO,CAAC,UAAU;QACtB,KAAK,EAAE,gCAAgC,OAAO,CAAC,SAAS,IAAI,OAAO,CAAC,YAAY,CAAC,CAAC,CAAC,iBAAiB,OAAO,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE;QACjI,QAAQ,EAAE,uBAAuB;QACjC,QAAQ;QACR,UAAU,EAAE,QAAQ;QACpB,IAAI,EAAE,cAAc;QACpB,OAAO,EAAE,OAAO,CAAC,QAAQ;QACzB,cAAc,EAAE,OAAO,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC;QACjD,QAAQ,EAAE,IAAI;KACf,CAAC;AACJ,CAAC"}