audit-tools 0.50.19 → 0.50.21

package/dist/audit/systemic/secondOrderAdversaryPrompt.js

@@ -1,84 +1,165 @@
-// Phase E — the SECOND-ORDER ADVERSARY prompt (host_delegation).
+// Phase E — SECOND-ORDER ADVERSARY prompt (host_delegation).
 //
-// The adversary runs as a SEPARATE agent ([[delegate-adversarial-phases-to-separate-
-// agent]]) — an author marking its own homework misses the gaps. Its mandate is
-// OPTIMIZATION / BETTER-WAY, not defect-finding: it must actively seek SUPERIOR
-// ALTERNATIVES to things that currently WORK (the class no correctness lens flags
-// because nothing is broken) — what's redundant, serial-that-could-be-parallel,
-// duplicated, over-built; what assumption went unquestioned; is there a categorically
-// better approach (design of record spec + backlog "Systemic reviewers must be pushed
-// adversarially for improvement"). LOOP-UNTIL-DRY: this is round N of a loop that ends
-// only when CONSECUTIVE rounds surface NOTHING NEW (the register's convergence_rule).
-//
-// The aggregate-metrics digest is NECESSARY supporting evidence, explicitly NOT
-// SUFFICIENT alone — the adversary reasons from the whole system, using the counts as
-// leads, not conclusions.
+// The adversary is a SEPARATE agent and receives the evidence the earlier
+// design-review contributors actually produced. Aggregate metrics remain leads,
+// never a substitute for charters, candidate dispositions, prior findings, and
+// direct repository/source verification.
+function priorFindings(bundle) {
+    const candidates = [
+        ...(bundle.design_assessment?.contract_findings ?? []),
+        ...(bundle.design_assessment?.conceptual_findings ?? []),
+        ...(bundle.charter_register?.findings ?? []),
+        ...(bundle.systemic_challenge?.findings ?? []),
+    ];
+    const seen = new Set();
+    return candidates.filter((finding) => {
+        const key = `${finding.lens}\u0000${finding.category}\u0000${finding.title}`;
+        if (seen.has(key))
+            return false;
+        seen.add(key);
+        return true;
+    });
+}
+function renderPriorFindings(findings) {
+    if (findings.length === 0)
+        return ["No prior findings were banked."];
+    return findings.map((finding) => {
+        const files = finding.affected_files.map((entry) => entry.path).join(", ");
+        return `- **${finding.id} — ${finding.title}** (${finding.lens}/${finding.severity}): ${finding.summary} [${files || "no files"}]`;
+    });
+}
+function renderCharterProjection(bundle) {
+    const register = bundle.charter_register;
+    if (!register || register.status === "omitted") {
+        return ["No charter register was produced for this run."];
+    }
+    const projection = {
+        subsystems: register.subsystems.map((subsystem) => ({
+            node_id: subsystem.node_id,
+            members: subsystem.members,
+            charters: subsystem.charters.map((charter) => ({
+                charter_id: charter.charter_id,
+                kind: charter.kind,
+                purpose: charter.purpose,
+                confidence: charter.confidence,
+                provenance: charter.provenance,
+                nominated_alternative: charter.nominated_alternative,
+                nominated_cost: charter.nominated_cost,
+            })),
+        })),
+        goal_graph: register.goal_graph,
+        deltas: register.deltas.map((delta) => ({
+            delta_id: delta.delta_id,
+            node_id: delta.node_id,
+            goal_node_id: delta.goal_node_id,
+            pair: delta.pair,
+            kind: delta.kind,
+            routed_to: delta.routed_to,
+            summary: delta.summary,
+        })),
+        triangulated: register.triangulated,
+        disagreement: register.disagreement,
+        validation_issues: register.validation_issues,
+    };
+    return ["```json", JSON.stringify(projection, null, 2), "```"];
+}
+function renderAdjudication(bundle) {
+    const adjudication = bundle.conceptual_review_adjudication;
+    if (!adjudication) {
+        return ["No deep conceptual adjudication record was produced."];
+    }
+    return [
+        `Round: \`${adjudication.round_id}\``,
+        "",
+        "```json",
+        JSON.stringify({
+            contributors: adjudication.contributors.map((contributor) => contributor.role === "judge"
+                ? { ...contributor, result_path: undefined }
+                : contributor),
+            candidate_dispositions: adjudication.candidate_dispositions,
+            final_finding_shares: adjudication.final_finding_shares,
+        }, null, 2),
+        "```",
+    ];
+}
 /**
- * Render the second-order-adversary LANE prompt for one challenge round. `round` is
- * the 1-based loop ordinal; `priorFindingCount` orients the adversary on what already
- * surfaced (so it pushes for NEW improvements, not re-statements). `submissionPath`
- * is where the agent writes its findings; an EMPTY findings array marks a QUIET
- * round (this round found nothing new) — the loop converges after consecutive
- * quiet rounds, per the register's `convergence_rule`.
- *
- * Advance-free (design resolution 2): the lane prompt is materialized to a file
- * and carries no continue-command — the step prompt owns the advance, so a lane
- * executor can never become a second orchestrator driver.
+ * Render one systemic challenge round. `evidencePaths` are also granted in the
+ * host step's read set; the prompt names them so the adversary can inspect the
+ * full perspective artifacts and persisted judge adjudication rather than
+ * reasoning from counts.
  */
 export function renderSecondOrderAdversaryPrompt(opts) {
-    const metricLines = opts.metrics.rollups.map((r) => `- ${r.label}: ${r.count} ${r.unit}`);
+    const metricLines = opts.metrics.rollups.map((rollup) => `- ${rollup.label}: ${rollup.count} ${rollup.unit}`);
     metricLines.push(`- Max fan-out (out-degree): ${opts.metrics.max_fan_out}`);
+    const bankedFindings = priorFindings(opts.bundle);
+    const evidencePaths = [...new Set(opts.evidencePaths)].sort();
     return [
         "# Design review — systemic improvement-seeking challenge (second-order adversary)",
         "",
         `You are a SEPARATE second-order adversary. This is challenge round ${opts.round}.`,
-        `The pass has already surfaced ${opts.priorFindingCount} improvement(s); your job is`,
-        "to push HARDER and find what earlier rounds missed.",
+        `The audit already banked ${bankedFindings.length} distinct finding(s). Push HARDER for what those findings and their contributors missed.`,
         "",
         "## Mandate — optimization / better-way, NOT defect-finding",
-        "Do NOT hunt for bugs (other lenses own that). Re-interrogate the system with",
-        "human-grade pressure and seek SUPERIOR ALTERNATIVES to things that currently WORK:",
-        "- What is **redundant** — done more than once, or more than needed?",
+        "",
+        "Do NOT hunt ordinary bugs (other lenses own that). Re-interrogate the system with human-grade pressure for SUPERIOR ALTERNATIVES to things that currently work:",
+        "- What is **redundant** — done more than once or more than needed?",
         "- What is **serial that could be parallel**?",
-        "- What is **duplicated** across places that should share?",
+        "- What is **duplicated** across places that should share one mechanism?",
         "- What is **over-built** — complexity with no payload?",
         "- What **assumption went unquestioned**?",
-        "- Is there a **categorically better approach** to a whole subsystem?",
+        "- Is there a **categorically better approach** for a whole subsystem?",
+        "",
+        "## Required evidence files",
+        "",
+        "Read these full artifacts before concluding the round. They include the charter register, persisted conceptual judge/adjudication record, and every current-round perspective result:",
+        ...evidencePaths.map((path) => `- \`${path}\``),
+        "",
+        "## Stated-purpose / goal / delta projection",
+        "",
+        "This projection comes from `charter_register.json`, not `docs_digest.json`. Treat triangulated telos as a lead, preserve disagreement, and inspect the full artifact when the projection raises a question:",
+        ...renderCharterProjection(opts.bundle),
+        "",
+        "## Conceptual contributors, dispositions, and attribution",
+        "",
+        ...renderAdjudication(opts.bundle),
+        "",
+        "## Actual banked findings",
+        "",
+        ...renderPriorFindings(bankedFindings),
+        "",
+        "## Repository/source verification (required)",
+        "",
+        "Use the repository and the strongest structural tools available. For every proposed improvement, inspect exact source sites, trace relevant callers and callees in both directions, and verify the affected paths. Before any negative or exhaustive claim, check structural-index coverage/freshness and directly read every reported gap. If equivalent symbol search, bidirectional tracing, exact snippets, or coverage accounting is unavailable, state that limitation and do not present the claim as comprehensive. Aggregate counts and prior-review consensus are never proof.",
         "",
         "## Aggregate metrics (supporting evidence — necessary, NOT sufficient)",
-        "These abstract, language-neutral counts are LEADS, not conclusions. Reason from",
-        "the whole system; use them only to aim your attention:",
+        "",
+        "These abstract, language-neutral counts are leads only:",
         ...metricLines,
         "",
         "## True lens (required)",
-        "Tag each finding with its TRUE lens — a test-parallelization finding is `tests`",
-        "or `performance`; an ops finding is `operability`. Do NOT default to",
-        "`architecture`. The lens routes the improvement to the right place in synthesis.",
+        "",
+        "Tag each finding with its TRUE lens — for example, test parallelization is `tests` or `performance`, and operational simplification is `operability`. Do not default everything to `architecture`.",
         "",
         "## Loop-until-dry",
-        "The review is done only when consecutive rounds yield NOTHING NEW — not when it",
-        "first has an answer. If, after genuine pressure, you find no NEW improvement this",
-        "round, submit an EMPTY findings array; that marks a quiet round, and the loop",
-        "converges after consecutive quiet rounds. Otherwise submit the new",
-        "improvements (each pointing at at least one real component).",
+        "",
+        "The review is done only when consecutive rounds yield NOTHING NEW. If genuine source-backed pressure finds no new improvement this round, submit an empty `findings` array. Otherwise submit only new improvements, each anchored to at least one real component.",
         "",
         "## Output",
+        "",
         `Write JSON to \`${opts.submissionPath}\` with this shape:`,
         "",
         "```json",
         "{",
-        '  "findings": [',
-        "    {",
-        '      "id": "<stable id>",',
-        '      "title": "<the improvement>",',
-        '      "category": "systemic_improvement",',
-        '      "severity": "low|medium|high",',
-        '      "confidence": "low|medium|high",',
-        '      "lens": "<the TRUE lens: tests|performance|operability|...>",',
-        '      "summary": "<what to do and why it is better>",',
-        '      "affected_files": [{ "path": "<a real repo path>" }]',
-        "    }",
-        "  ]",
+        '  "findings": [{',
+        '    "id": "<stable id>",',
+        '    "title": "<the improvement>",',
+        '    "category": "systemic_improvement",',
+        '    "severity": "low|medium|high",',
+        '    "confidence": "low|medium|high",',
+        '    "lens": "<the TRUE lens: tests|performance|operability|...>",',
+        '    "summary": "<what to do, why it is better, and source verification>",',
+        '    "affected_files": [{ "path": "<a real repo path>" }]',
+        "  }]",
         "}",
         "```",
         "",

package/dist/audit/systemic/secondOrderAdversaryPrompt.js.map

@@ -1 +1 @@
-{"version":3,"file":"secondOrderAdversaryPrompt.js","sourceRoot":"","sources":["../../../src/audit/systemic/secondOrderAdversaryPrompt.ts"],"names":[],"mappings":"AAAA,iEAAiE;AACjE,EAAE;AACF,qFAAqF;AACrF,gFAAgF;AAChF,gFAAgF;AAChF,kFAAkF;AAClF,gFAAgF;AAChF,sFAAsF;AACtF,sFAAsF;AACtF,uFAAuF;AACvF,sFAAsF;AACtF,EAAE;AACF,gFAAgF;AAChF,sFAAsF;AACtF,0BAA0B;AAI1B;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,gCAAgC,CAAC,IAKhD;IACC,MAAM,WAAW,GAAG,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,GAAG,CAC1C,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,CAAC,KAAK,KAAK,CAAC,CAAC,KAAK,IAAI,CAAC,CAAC,IAAI,EAAE,CAC5C,CAAC;IACF,WAAW,CAAC,IAAI,CAAC,+BAA+B,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,CAAC,CAAC;IAE5E,OAAO;QACL,mFAAmF;QACnF,EAAE;QACF,sEAAsE,IAAI,CAAC,KAAK,GAAG;QACnF,iCAAiC,IAAI,CAAC,iBAAiB,8BAA8B;QACrF,qDAAqD;QACrD,EAAE;QACF,4DAA4D;QAC5D,8EAA8E;QAC9E,oFAAoF;QACpF,qEAAqE;QACrE,8CAA8C;QAC9C,2DAA2D;QAC3D,wDAAwD;QACxD,0CAA0C;QAC1C,sEAAsE;QACtE,EAAE;QACF,wEAAwE;QACxE,iFAAiF;QACjF,wDAAwD;QACxD,GAAG,WAAW;QACd,EAAE;QACF,yBAAyB;QACzB,iFAAiF;QACjF,sEAAsE;QACtE,kFAAkF;QAClF,EAAE;QACF,mBAAmB;QACnB,iFAAiF;QACjF,mFAAmF;QACnF,+EAA+E;QAC/E,oEAAoE;QACpE,8DAA8D;QAC9D,EAAE;QACF,WAAW;QACX,mBAAmB,IAAI,CAAC,cAAc,qBAAqB;QAC3D,EAAE;QACF,SAAS;QACT,GAAG;QACH,iBAAiB;QACjB,OAAO;QACP,4BAA4B;QAC5B,qCAAqC;QACrC,2CAA2C;QAC3C,sCAAsC;QACtC,wCAAwC;QACxC,qEAAqE;QACrE,uDAAuD;QACvD,4DAA4D;QAC5D,OAAO;QACP,KAAK;QACL,GAAG;QACH,KAAK;QACL,EAAE;KACH,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACf,CAAC"}
+{"version":3,"file":"secondOrderAdversaryPrompt.js","sourceRoot":"","sources":["../../../src/audit/systemic/secondOrderAdversaryPrompt.ts"],"names":[],"mappings":"AAAA,6DAA6D;AAC7D,EAAE;AACF,0EAA0E;AAC1E,gFAAgF;AAChF,+EAA+E;AAC/E,yCAAyC;AAMzC,SAAS,aAAa,CAAC,MAAsB;IAC3C,MAAM,UAAU,GAAG;QACjB,GAAG,CAAC,MAAM,CAAC,iBAAiB,EAAE,iBAAiB,IAAI,EAAE,CAAC;QACtD,GAAG,CAAC,MAAM,CAAC,iBAAiB,EAAE,mBAAmB,IAAI,EAAE,CAAC;QACxD,GAAG,CAAC,MAAM,CAAC,gBAAgB,EAAE,QAAQ,IAAI,EAAE,CAAC;QAC5C,GAAG,CAAC,MAAM,CAAC,kBAAkB,EAAE,QAAQ,IAAI,EAAE,CAAC;KAC/C,CAAC;IACF,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,OAAO,UAAU,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE;QACnC,MAAM,GAAG,GAAG,GAAG,OAAO,CAAC,IAAI,SAAS,OAAO,CAAC,QAAQ,SAAS,OAAO,CAAC,KAAK,EAAE,CAAC;QAC7E,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAO,KAAK,CAAC;QAChC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QACd,OAAO,IAAI,CAAC;IACd,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,mBAAmB,CAAC,QAA4B;IACvD,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,CAAC,gCAAgC,CAAC,CAAC;IACrE,OAAO,QAAQ,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE;QAC9B,MAAM,KAAK,GAAG,OAAO,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3E,OAAO,OAAO,OAAO,CAAC,EAAE,MAAM,OAAO,CAAC,KAAK,OAAO,OAAO,CAAC,IAAI,IAAI,OAAO,CAAC,QAAQ,MAAM,OAAO,CAAC,OAAO,KAAK,KAAK,IAAI,UAAU,GAAG,CAAC;IACrI,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,uBAAuB,CAAC,MAAsB;IACrD,MAAM,QAAQ,GAAG,MAAM,CAAC,gBAAgB,CAAC;IACzC,IAAI,CAAC,QAAQ,IAAI,QAAQ,CAAC,MAAM,KAAK,SAAS,EAAE,CAAC;QAC/C,OAAO,CAAC,gDAAgD,CAAC,CAAC;IAC5D,CAAC;IACD,MAAM,UAAU,GAAG;QACjB,UAAU,EAAE,QAAQ,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC;YAClD,OAAO,EAAE,SAAS,CAAC,OAAO;YAC1B,OAAO,EAAE,SAAS,CAAC,OAAO;YAC1B,QAAQ,EAAE,SAAS,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;gBAC7C,UAAU,EAAE,OAAO,CAAC,UAAU;gBAC9B,IAAI,EAAE,OAAO,CAAC,IAAI;gBAClB,OAAO,EAAE,OAAO,CAAC,OAAO;gBACxB,UAAU,EAAE,OAAO,CAAC,UAAU;gBAC9B,UAAU,EAAE,OAAO,CAAC,UAAU;gBAC9B,qBAAqB,EAAE,OAAO,CAAC,qBAAqB;gBACpD,cAAc,EAAE,OAAO,CAAC,cAAc;aACvC,CAAC,CAAC;SACJ,CAAC,CAAC;QACH,UAAU,EAAE,QAAQ,CAAC,UAAU;QAC/B,MAAM,EAAE,QAAQ,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;YACtC,QAAQ,EAAE,KAAK,CAAC,QAAQ;YACxB,OAAO,EAAE,KAAK,CAAC,OAAO;YACtB,YAAY,EAAE,KAAK,CAAC,YAAY;YAChC,IAAI,EAAE,KAAK,CAAC,IAAI;YAChB,IAAI,EAAE,KAAK,CAAC,IAAI;YAChB,SAAS,EAAE,KAAK,CAAC,SAAS;YAC1B,OAAO,EAAE,KAAK,CAAC,OAAO;SACvB,CAAC,CAAC;QACH,YAAY,EAAE,QAAQ,CAAC,YAAY;QACnC,YAAY,EAAE,QAAQ,CAAC,YAAY;QACnC,iBAAiB,EAAE,QAAQ,CAAC,iBAAiB;KAC9C,CAAC;IACF,OAAO,CAAC,SAAS,EAAE,IAAI,CAAC,SAAS,CAAC,UAAU,EAAE,IAAI,EAAE,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;AACjE,CAAC;AAED,SAAS,kBAAkB,CAAC,MAAsB;IAChD,MAAM,YAAY,GAAG,MAAM,CAAC,8BAA8B,CAAC;IAC3D,IAAI,CAAC,YAAY,EAAE,CAAC;QAClB,OAAO,CAAC,sDAAsD,CAAC,CAAC;IAClE,CAAC;IACD,OAAO;QACL,YAAY,YAAY,CAAC,QAAQ,IAAI;QACrC,EAAE;QACF,SAAS;QACT,IAAI,CAAC,SAAS,CACZ;YACE,YAAY,EAAE,YAAY,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,EAAE,CAC1D,WAAW,CAAC,IAAI,KAAK,OAAO;gBAC1B,CAAC,CAAC,EAAE,GAAG,WAAW,EAAE,WAAW,EAAE,SAAS,EAAE;gBAC5C,CAAC,CAAC,WAAW,CAChB;YACD,sBAAsB,EAAE,YAAY,CAAC,sBAAsB;YAC3D,oBAAoB,EAAE,YAAY,CAAC,oBAAoB;SACxD,EACD,IAAI,EACJ,CAAC,CACF;QACD,KAAK;KACN,CAAC;AACJ,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,gCAAgC,CAAC,IAMhD;IACC,MAAM,WAAW,GAAG,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,GAAG,CAC1C,CAAC,MAAM,EAAE,EAAE,CAAC,KAAK,MAAM,CAAC,KAAK,KAAK,MAAM,CAAC,KAAK,IAAI,MAAM,CAAC,IAAI,EAAE,CAChE,CAAC;IACF,WAAW,CAAC,IAAI,CAAC,+BAA+B,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,CAAC,CAAC;IAC5E,MAAM,cAAc,GAAG,aAAa,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAClD,MAAM,aAAa,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAE9D,OAAO;QACL,mFAAmF;QACnF,EAAE;QACF,sEAAsE,IAAI,CAAC,KAAK,GAAG;QACnF,4BAA4B,cAAc,CAAC,MAAM,0FAA0F;QAC3I,EAAE;QACF,4DAA4D;QAC5D,EAAE;QACF,iKAAiK;QACjK,oEAAoE;QACpE,8CAA8C;QAC9C,yEAAyE;QACzE,wDAAwD;QACxD,0CAA0C;QAC1C,uEAAuE;QACvE,EAAE;QACF,4BAA4B;QAC5B,EAAE;QACF,uLAAuL;QACvL,GAAG,aAAa,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,IAAI,IAAI,CAAC;QAC/C,EAAE;QACF,6CAA6C;QAC7C,EAAE;QACF,6MAA6M;QAC7M,GAAG,uBAAuB,CAAC,IAAI,CAAC,MAAM,CAAC;QACvC,EAAE;QACF,2DAA2D;QAC3D,EAAE;QACF,GAAG,kBAAkB,CAAC,IAAI,CAAC,MAAM,CAAC;QAClC,EAAE;QACF,2BAA2B;QAC3B,EAAE;QACF,GAAG,mBAAmB,CAAC,cAAc,CAAC;QACtC,EAAE;QACF,8CAA8C;QAC9C,EAAE;QACF,0jBAA0jB;QAC1jB,EAAE;QACF,wEAAwE;QACxE,EAAE;QACF,yDAAyD;QACzD,GAAG,WAAW;QACd,EAAE;QACF,yBAAyB;QACzB,EAAE;QACF,oMAAoM;QACpM,EAAE;QACF,mBAAmB;QACnB,EAAE;QACF,mQAAmQ;QACnQ,EAAE;QACF,WAAW;QACX,EAAE;QACF,mBAAmB,IAAI,CAAC,cAAc,qBAAqB;QAC3D,EAAE;QACF,SAAS;QACT,GAAG;QACH,kBAAkB;QAClB,0BAA0B;QAC1B,mCAAmC;QACnC,yCAAyC;QACzC,oCAAoC;QACpC,sCAAsC;QACtC,mEAAmE;QACnE,2EAA2E;QAC3E,0DAA0D;QAC1D,MAAM;QACN,GAAG;QACH,KAAK;QACL,EAAE;KACH,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACf,CAAC"}