atris 3.74.15 → 3.74.16

package/commands/member.js

@@ -981,9 +981,39 @@ function inferMemberRunVerifier(missionText, args = [], cwd = process.cwd()) {
   // chose that check; it is not a silent broad-suite default.
   const npmMatch = text.match(/\bnpm\s+(run\s+)?test(?![\w:-]|\.\w)/i);
   if (npmMatch && projectHasTestScript(cwd)) return npmMatch[1] ? 'npm run test' : 'npm test';
+  // A named test file in a project that runs node's own test runner: check
+  // just that file, since other files may fail on purpose ("legacy.js is out
+  // of scope"). Member lab: these jobs fell back to a whitespace check.
+  // Only sentences that ask for the work count; "x is out of scope" or "do not
+  // run the failing tests" must not pick a check.
+  const asks = text.split(/[;,\n]+|\.(?=\s|$)|\s(?:and|but)\s/i).filter((part) => part.trim()
+    && !/\b(out\s+of\s+scope|do\s+not|don't|never|without|skip|ignore|leave|except|known\s+bug|reference)\b/i.test(part)).join('. ');
+  const testScript = projectTestScript(cwd);
+  // The project runs node's test runner itself, not as part of another command.
+  if (/^\s*node\s+--test\b/.test(testScript) && !/&&|\|\||[;|]/.test(testScript)) {
+    const root = path.resolve(cwd);
+    const named = (asks.match(/[\w./-]+\.[cm]?js\b/g) || [])
+      .filter((file) => /(^|\/)(tests?|checks?|specs?|__tests__)\/|\.(test|spec)\.[cm]?js$/.test(file))
+      .filter((file) => !path.isAbsolute(file) && path.resolve(root, file).startsWith(`${root}${path.sep}`))
+      .find((file) => fs.existsSync(path.join(root, file)));
+    if (named) return `node --test ${named}`;
+  }
+  // "fix the failing tests" names the project's tests as the target.
+  if (testScript && /\b(fail(ing|ed)?\s+(\w+\s+){0,3}tests?|tests?\s+(pass|green)|fix\s+the\s+(\w+\s+){0,2}tests?)\b/i.test(asks)) {
+    return 'npm test';
+  }
   return '';
 }
 
+function projectTestScript(cwd) {
+  try {
+    const pkg = JSON.parse(fs.readFileSync(path.join(cwd, 'package.json'), 'utf8'));
+    return String(pkg?.scripts?.test || '');
+  } catch {
+    return '';
+  }
+}
+
 function projectHasTestScript(cwd) {
   try {
     const pkg = JSON.parse(fs.readFileSync(path.join(cwd, 'package.json'), 'utf8'));
@@ -1069,6 +1099,16 @@ function startMemberRunMission(name, missionText, args = []) {
 // second engine only reran the same commands and cost about a minute a run
 // (member lab 2026-10-24), so it stays for runs whose check is not a test
 // runner (whitespace, syntax, or file-exists checks). --no-referee skips it; an explicit --referee is kept.
+// 'checked' when the run passed, 'unchecked' when the only thing missing is a
+// reviewer verdict (timed out or could not start), '' otherwise.
+function memberRunSaveDecision({ started, ok, verdict } = {}) {
+  if (!started) return '';
+  const v = verdict || {};
+  if (v.passed === true) return ok ? 'checked' : '';
+  const reviewerGone = v.referee?.mode === 'engine-unavailable' || v.mode === 'engine-unavailable';
+  return reviewerGone && (v.status === undefined || v.status === 0) ? 'unchecked' : '';
+}
+
 function memberRunHasRealCheck(verifier) {
   const command = String(verifier || '').trim();
   // A plain test runner only: chaining (|| true, ; , &&, pipes, subshells) or a
@@ -1468,13 +1508,22 @@ function memberRunWith(name, args, { quiet = false, closeTaskIds = [] } = {}) {
   }
   // Passed but never committed: save the loose work on the member's branch so
   // the branch holds it. Only in the member's own side checkout, never the main one.
+  // A reviewer that timed out or could not start gave no verdict; the work is
+  // unchecked, not rejected, so save it too (member lab: a correct answer was
+  // lost when the reviewer hit its time limit on a busy machine). Landing still
+  // needs a real pass.
   const worktreePath = finalMission.worktree?.path || mission.worktree?.path || '';
-  if (ok && started && worktreePath && finalMission.verifier_result?.passed === true) {
+  const saveDecision = memberRunSaveDecision({ started, ok, verdict: finalMission.verifier_result });
+  const reviewerUnavailable = saveDecision === 'unchecked';
+  if (worktreePath && saveDecision) {
     result.saved_work = require('../lib/member-save-work').saveLeftoverMemberWork({
       worktreePath, member: name, objective: finalMission.objective || mission.objective,
     });
+    if (reviewerUnavailable) result.saved_work.unchecked = true;
     if (result.saved_work.saved && !asJson && !quiet) {
-      console.log(`saved ${result.saved_work.files.length} file(s) ${name} left unsaved onto its branch`);
+      console.log(reviewerUnavailable
+        ? `saved ${result.saved_work.files.length} file(s) onto ${name}'s branch, not checked yet: the reviewer timed out or could not start`
+        : `saved ${result.saved_work.files.length} file(s) ${name} left unsaved onto its branch`);
     }
   }
   // A finished ignited run whose check passed hands its branch to GitHub
@@ -12140,6 +12189,7 @@ module.exports = {
   wakeBootLines,
   buildMemberRunStartArgs,
   inferMemberRunVerifier,
+  memberRunSaveDecision,
   buildMemberSubagentShell,
   pickMemberForIdea,
   appendMemberGoalLog,

package/commands/mission.js

@@ -9997,6 +9997,9 @@ function buildEngineVerifyPrompt(mission, tickIndex, doneLooksLike = '', { timeo
       `Split that line into each separate thing it promises and check every one. List each part as met or missing.`,
       `Work that does only some of the parts is not done. If any part is missing, end with 'VERDICT: FAIL; missing: <that part>'.`,
     ] : []),
+    // Member lab: reviewers spent about half their time on the workspace boot
+    // (atris atris.md, MAP, PERSONA, skills) before reading the change.
+    `Skip any workspace boot or start-of-session routine the folder's instructions ask for: do not run \`atris atris.md\` and do not read MAP.md, PERSONA.md, FOR_AGENTS.md, or skill files. Start with \`git diff\` and the changed files.`,
     `Read the diff this tick produced. Do not edit files and do not start another work slice.`,
     `ACTUALLY RUN the changed surface on this computer using real commands and real exit codes.`,
     `Paste the commands and their real output. Do not accept a receipt claim or static inspection as execution proof.`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "atris",
-  "version": "3.74.15",
+  "version": "3.74.16",
   "description": "you say what you want in plain words. atris builds it, checks it, and shows you proof.",
   "mcpName": "io.github.atrislabs/atris",
   "main": "bin/atris.js",