atris 3.74.11 → 3.74.12

package/atris/team/executor/MEMBER.md

@@ -124,6 +124,7 @@ If new evidence changes the task, stop and add a task note instead of forcing co
 7. **Anti-slop aware**: Read `atris/policies/ANTISLOP.md` before writing. No sparkles, no filler, no purple prose.
 8. **Stay in scope**: Only touch files listed in the task. If you need to change something outside scope, stop and flag it. That's a new task.
 9. **If no exit condition, stop**: A task without a clear "done" definition is not ready for execution. Send it back to navigator.
+10. **Make exactly what was asked**: Match the existing output shape, names, and style. Add no fields, flags, or features the job did not ask for; name them as a next step instead.
 
 ---
 

package/commands/member.js

@@ -976,9 +976,22 @@ function inferMemberRunVerifier(missionText, args = [], cwd = process.cwd()) {
   if (testFileMatch && fs.existsSync(path.join(cwd, testFileMatch[1]))) {
     return `node --test ${testFileMatch[1]}`;
   }
+  // A job that names the project's own test command ("keep npm test green")
+  // chose that check; it is not a silent broad-suite default.
+  const npmMatch = text.match(/\bnpm\s+(run\s+)?test(?![\w:-]|\.\w)/i);
+  if (npmMatch && projectHasTestScript(cwd)) return npmMatch[1] ? 'npm run test' : 'npm test';
   return '';
 }
 
+function projectHasTestScript(cwd) {
+  try {
+    const pkg = JSON.parse(fs.readFileSync(path.join(cwd, 'package.json'), 'utf8'));
+    return Boolean(pkg && pkg.scripts && pkg.scripts.test);
+  } catch {
+    return false;
+  }
+}
+
 function buildMemberRunStartArgs(owner, missionText, args = [], cwd = process.cwd()) {
   const resolvedVerifier = inferMemberRunVerifier(missionText, args, cwd);
   const startArgs = [
@@ -1023,7 +1036,10 @@ function buildMemberRunStartArgs(owner, missionText, args = [], cwd = process.cw
   // Default to an isolated worktree only when there is a git repo to cut it
   // from. A plain (non-git) workspace would fail every mission start with
   // "fatal: not a git repository", degrade to the shared checkout instead.
-  if (!hasFlag(args, '--shared-checkout') && !hasFlag(args, '--no-worktree') && insideGitRepo(cwd)) {
+  // A job that says "do not commit" wants the change in the person's own
+  // files; a side checkout would hide uncommitted work where they never see it.
+  const forbidsCommit = !hasFlag(args, '--worktree') && require('../lib/member-save-work').jobForbidsCommit(missionText);
+  if (!forbidsCommit && !hasFlag(args, '--shared-checkout') && !hasFlag(args, '--no-worktree') && insideGitRepo(cwd)) {
     startArgs.push('--worktree');
   }
   startArgs.push('--json');
@@ -1434,6 +1450,17 @@ function memberRunWith(name, args, { quiet = false, closeTaskIds = [] } = {}) {
     result.ask = `${name} is waiting on you: ${payload.human_asks[0]}`;
     result.next_command = payload.next_command || 'atris decide';
   }
+  // Passed but never committed: save the loose work on the member's branch so
+  // the branch holds it. Only in the member's own side checkout, never the main one.
+  const worktreePath = finalMission.worktree?.path || mission.worktree?.path || '';
+  if (ok && started && worktreePath && finalMission.verifier_result?.passed === true) {
+    result.saved_work = require('../lib/member-save-work').saveLeftoverMemberWork({
+      worktreePath, member: name, objective: finalMission.objective || mission.objective,
+    });
+    if (result.saved_work.saved && !asJson && !quiet) {
+      console.log(`saved ${result.saved_work.files.length} file(s) ${name} left unsaved onto its branch`);
+    }
+  }
   // A finished ignited run whose check passed hands its branch to GitHub
   // auto-merge, only past the local gates; any held gate leaves the branch.
   if (ignite && ok && started && !reviewAsk && finalMission.verifier_result?.passed === true) {
@@ -9946,13 +9973,24 @@ async function memberChat(name, ...rest) {
 
 const IDEA_ARCHETYPE_RULES = [
   {
-    slugs: ['auto-improver', 'improver'],
-    pattern: /\b(repeat|recurring|broken\s+test|flaky|error|regression|pain|fix\s+bug|self[- ]improv|crash)\b/i,
+    // A job that opens by asking where or which, or forbids source edits, is
+    // a read-and-answer job even when it mentions a bug.
+    slugs: ['navigator'],
+    // Wins wherever it matches: the question shape decides the whole job.
+    leading: true,
+    pattern: /^(?![\s\S]*(?<!not\s|n't\s)\b(fix|repair|implement|update|change|edit|add|rename|modify)\b)\s*(find|locate|which|count|trace|identify)\b|\bdo\s+not\s+(edit|change|modify)\s+(any\s+)?source\b/i,
+    reason: 'reads the code and answers where and which questions',
+  },
+  {
+    // The shipped `improver` proposes team and workflow changes; it is not a
+    // code fixer, so fix jobs go to auto-improver or fall back to the builder.
+    slugs: ['auto-improver'],
+    pattern: /\b(repeat|recurring|broken|flaky|errors?|regressions?|pain|fix(es|ed|ing)?|bugs?|fail(s|ing|ed|ure)?|self[- ]improv|crash(es|ed|ing)?)\b/i,
     reason: 'handles recurring errors, regressions, and test fixes',
   },
   {
     slugs: ['validator', 'orb'],
-    pattern: /\b(review|audit|validate|verify|check\s+diff|quality|slop|security)\b/i,
+    pattern: /\b(code\s+review|review|audit|validate|verify|check\s+diff|quality|slop|security)\b/i,
     reason: 'reviews changes and blocks weak work before merge',
   },
   {
@@ -9988,8 +10026,10 @@ const ARCHETYPE_FOR_JOB = { build: 'executor', review: 'validator', search: 'res
 const EXPERIMENT_STATUSES = new Set(['experimental', 'one-off']);
 
 function ideaRuleFor(slug, record, text) {
-  const own = IDEA_ARCHETYPE_RULES.find((rule) => rule.slugs.includes(slug));
-  if (own && own.pattern.test(text)) return { rule: own, own: true };
+  const ownRules = IDEA_ARCHETYPE_RULES.filter((rule) => rule.slugs.includes(slug));
+  const matched = ownRules.find((rule) => rule.pattern.test(text));
+  if (matched) return { rule: matched, own: true };
+  const own = ownRules[0];
   const { autoJobForMember } = require('../lib/member-engine');
   const archetype = ARCHETYPE_FOR_JOB[autoJobForMember(slug, record.role)];
   const rule = IDEA_ARCHETYPE_RULES.find((r) => r.slugs.includes(archetype)) || null;
@@ -10000,7 +10040,15 @@ function ideaRuleFor(slug, record, text) {
 // specific jobs to the general build job, so "where is the code" is a
 // navigator job even though "code" is also a build word.
 function ideaJobRule(text) {
-  return IDEA_ARCHETYPE_RULES.find((rule) => rule.pattern.test(text)) || null;
+  // The job word that comes first names the job: "review the bug fix" is a
+  // review, "fix the review page" is a fix. Ties keep list order.
+  let best = null;
+  for (const rule of IDEA_ARCHETYPE_RULES) {
+    const match = rule.pattern.exec(text);
+    const index = match ? (rule.leading ? -1 : match.index) : null;
+    if (match && (!best || index < best.index)) best = { rule, index };
+  }
+  return best ? best.rule : null;
 }
 
 // 3 = named in the idea, 2 = the job is the member's own, 1 = the member
@@ -10059,7 +10107,12 @@ function pickMemberForIdea(ideaText, root = process.cwd(), preferredMember = '')
     .toLowerCase()
     .split(/[^a-z0-9]+/)
     .filter((w) => w.length >= 4);
-  const jobRule = ideaJobRule(text);
+  let jobRule = ideaJobRule(text);
+  // A job nobody on this team owns goes to the builder rule, not to whoever
+  // shares the most words with it.
+  if (jobRule && !members.some((m) => ideaRuleFor(memberSlugFromRecord(m), m, text).rule === jobRule)) {
+    jobRule = IDEA_ARCHETYPE_RULES.find((rule) => rule.slugs.includes('executor')) || jobRule;
+  }
 
   let best = null;
   for (const record of members) {
@@ -10073,6 +10126,9 @@ function pickMemberForIdea(ideaText, root = process.cwd(), preferredMember = '')
 
     const memberRule = ideaRuleFor(slug, record, text);
     const fit = ideaJobFit(named, memberRule, jobRule);
+    // A reviewer never patches, so it only takes review jobs unless named.
+    const reviewRule = IDEA_ARCHETYPE_RULES.find((rule) => rule.slugs.includes('validator'));
+    const effectiveTier = !named && memberRule.rule === reviewRule && jobRule !== reviewRule ? Math.max(tier, 1) : tier;
     if (fit > 0 && memberRule.rule) {
       score += 30;
       matchedReason = memberRule.rule.reason;
@@ -10105,7 +10161,7 @@ function pickMemberForIdea(ideaText, root = process.cwd(), preferredMember = '')
       role: record.role || 'Team Member',
       reason: matchedReason,
       score,
-      tier,
+      tier: effectiveTier,
       fit,
     };
     if (outranksDispatch(candidate, best)) best = candidate;
@@ -10438,7 +10494,7 @@ function resolveMemberEngineSeat(memberSlug, root = process.cwd()) {
 
 function buildMemberSubagentShell(owner, role, engineId, objective, root = process.cwd()) {
   const cleanObjective = compactSentence(objective || `Advance ${owner} roadmap`, 160);
-  const verify = inferMemberRunVerifier(owner, cleanObjective, root);
+  const verify = inferMemberRunVerifier(cleanObjective, [], root);
   return {
     role: `${owner} (${role || 'Team Member'})`,
     member: owner,
@@ -12068,6 +12124,7 @@ module.exports = {
   wakeBootLines,
   buildMemberRunStartArgs,
   inferMemberRunVerifier,
+  buildMemberSubagentShell,
   pickMemberForIdea,
   appendMemberGoalLog,
   appendProjectLog,

package/commands/mission.js

@@ -2620,7 +2620,8 @@ const MISSION_BARE_COMMAND_WORDS = new Set(['go', 'keep', 'going', 'do', 'it', '
 function missionObjectiveIsJunk(value) {
   const objective = String(value || '').trim();
   if (!objective || objective.startsWith('-')) return true;
-  if (/[\u0000-\u001f\u007f-\u009f\ufffd]/u.test(objective)) return true;
+  // Line breaks and tabs are normal in a pasted bug report; other control bytes are junk.
+  if (/[\u0000-\u0008\u000b\u000c\u000e-\u001f\u007f-\u009f\ufffd]/u.test(objective)) return true;
   if (objective.replace(/\s/g, '').length < 8) return true;
   const words = objective.toLowerCase().match(/[a-z]+/g) || [];
   return words.length > 0
@@ -9304,6 +9305,7 @@ function buildTickPrompt(mission, tickIndex, maxTicks, frozen, pings = [], cwd =
     ``,
     `## Landing rule`,
     `Safe-lane work (internal code, tests, docs, and proofs) must be committed and pushed or landed WITHOUT asking a human. Protected lanes (external sends, payments, credentials, auth/CSP/iframe/sandbox surfaces, and deletes of user data) are never self-landed: file a decision card instead.`,
+    `The objective's own limits win over this rule: if it says do not commit, touch only certain files, or leave something alone, do exactly that.`,
     `After landing a ladder-sourced slice, append a judge card to atris/status/for-you.md in this SHIPPED format:`,
     missionShippedCard(),
     ``,

package/lib/member-autoland.js

@@ -446,7 +446,14 @@ function landLocally({ headSha, branch, cwd, pinnedTree }) {
 function autolandMemberRun({ mission, cwd, summary = '', workerEngine = '', loadTask = defaultLoadTask, closeTaskIds = [] } = {}) {
   if (!mission || typeof mission !== 'object') return held('mission', 'the mission could not be read');
   if (mission.verifier_result?.passed !== true) return held('check', 'the check did not pass');
-  if (!policyOn(cwd)) return held('policy', 'self-landing is not switched on in the main checkout');
+  if (!policyOn(cwd)) {
+    // Say where the work is and the one command that brings it in; "self-landing
+    // is off" alone left people thinking the fix was already in their files.
+    const branch = String(mission.worktree?.branch || '').trim();
+    const gate = held('policy', 'self-landing is not switched on in the main checkout');
+    if (!branch || branch === mainCheckoutBranch(cwd)) return gate;
+    return { ...gate, branch, line: `your files are not changed yet: the work is saved on branch ${branch}. bring it in: git merge ${branch}` };
+  }
 
   const missionLane = protectedLane({ ...mission, title: mission.objective });
   if (missionLane) return held('protected', `this mission sits in a protected area (${missionLane})`);

package/lib/member-save-work.js

@@ -0,0 +1,54 @@
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+const { spawnSync } = require('child_process');
+
+// A member that passed its check but never committed leaves its work loose in
+// a side checkout that cleanup later deletes (member lab 2026-10-24: navigator
+// and validator wrote the right files, said done, committed nothing). Commit
+// what is left so the branch holds the work. Atris's own state stays out.
+function git(args, cwd) {
+  const result = spawnSync('git', args, { cwd, encoding: 'utf8' });
+  return { ok: result.status === 0, stdout: String(result.stdout || '').trim() };
+}
+
+function jobForbidsCommit(text) {
+  return /\b(do\s+not|don't|never|without|no)\s+(?:(?:create|make|add|any|new|a|an|more)\s+){0,3}commit/i.test(String(text || ''));
+}
+
+// Files that look like secrets never ride an automatic commit.
+const SECRET_PATH = /(^|\/)(\.(aws|ssh|gnupg|docker|kube)\/|\.env(\.[^/]*)?$|\.npmrc$|\.netrc$|credentials?$|[^/]*credentials?[^/]*\.(json|ya?ml|txt)$|secrets?\.(json|ya?ml|txt|env)$|[^/]*\.(pem|key|p12|pfx)$|id_(rsa|ed25519|ecdsa)[^/]*$|service[-_]account[^/]*\.json$)/i;
+
+function saveLeftoverMemberWork({ worktreePath, member = 'member', objective = '' } = {}) {
+  if (!worktreePath) return { saved: false, reason: 'no_worktree' };
+  // The job's own words win: "do not commit" means leave the changes loose.
+  if (jobForbidsCommit(objective)) return { saved: false, reason: 'job_forbids_commit' };
+  if (!git(['rev-parse', '--is-inside-work-tree'], worktreePath).ok) return { saved: false, reason: 'not_git' };
+  // Only a linked side checkout: its git dir differs from the shared one. The
+  // person's main checkout is never committed into.
+  // Plain --git-dir/--git-common-dir work on old git too; resolve both against
+  // the checkout, since either may come back relative.
+  const gitDirOut = git(['rev-parse', '--git-dir'], worktreePath).stdout;
+  const commonDirOut = git(['rev-parse', '--git-common-dir'], worktreePath).stdout;
+  if (!gitDirOut || !commonDirOut) return { saved: false, reason: 'not_side_checkout' };
+  const real = (dir) => { try { return fs.realpathSync(path.resolve(worktreePath, dir)); } catch { return ''; } };
+  const gitDir = real(gitDirOut);
+  const commonDir = real(commonDirOut);
+  if (!gitDir || !commonDir || gitDir === commonDir) return { saved: false, reason: 'not_side_checkout' };
+  const add = git(['add', '-A', '--', '.', ':(exclude).atris', ':(exclude).agent-worktrees'], worktreePath);
+  if (!add.ok) return { saved: false, reason: 'add_failed' };
+  git(['reset', '-q', '--', '.atris', '.agent-worktrees'], worktreePath);
+  const stagedAll = git(['diff', '--cached', '--name-only'], worktreePath).stdout.split('\n').filter(Boolean);
+  const skipped = stagedAll.filter((file) => SECRET_PATH.test(file));
+  if (skipped.length) git(['reset', '-q', '--', ...skipped], worktreePath);
+  const staged = stagedAll.filter((file) => !SECRET_PATH.test(file));
+  if (!staged.length) return { saved: false, reason: 'nothing_left', ...(skipped.length ? { skipped } : {}) };
+  const title = String(objective || '').split('\n').map((line) => line.trim()).find(Boolean) || 'finished work';
+  const message = `${member}: ${title.slice(0, 72)}\n\nSaved by atris after the check passed; the member left these changes uncommitted.`;
+  const commit = git(['commit', '-q', '-m', message], worktreePath);
+  if (!commit.ok) return { saved: false, reason: 'commit_failed', files: staged };
+  return { saved: true, files: staged, ...(skipped.length ? { skipped } : {}), sha: git(['rev-parse', 'HEAD'], worktreePath).stdout };
+}
+
+module.exports = { jobForbidsCommit, saveLeftoverMemberWork };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "atris",
-  "version": "3.74.11",
+  "version": "3.74.12",
   "description": "you say what you want in plain words. atris builds it, checks it, and shows you proof.",
   "mcpName": "io.github.atrislabs/atris",
   "main": "bin/atris.js",