atris 3.16.0 → 3.17.0

package/commands/brain.js

@@ -3,6 +3,8 @@ const path = require('path');
 const crypto = require('crypto');
 const { spawnSync } = require('child_process');
 const { refreshNowFile } = require('./now');
+const escapeRegExp = require('../lib/escape-regexp');
+const { hasRenderedSections, isOpenSection, isDoneSection } = require('../lib/todo-sections');
 
 const GENERATED_START = '<!-- ATRIS_BRAIN_COMPILE:START -->';
 const GENERATED_END = '<!-- ATRIS_BRAIN_COMPILE:END -->';
@@ -296,7 +298,8 @@ function resolveStateRoot(root) {
 
 function countTodoItems(todoText) {
   const text = String(todoText || '');
-  const hasRenderedSections = /^##\s+(Backlog|In Progress|Blocked|Completed)\s*$/m.test(text);
+  // Section classification (incl. emoji-decorated headings) lives in lib/todo-sections.
+  const rendered = hasRenderedSections(text);
   let section = null;
   let unchecked = 0;
   let checked = 0;
@@ -317,22 +320,46 @@ function countTodoItems(todoText) {
     const isTitled = /^\s*-\s+(?:\[[ xX]\]\s+)?\*\*[^*]+:?\*\*/.test(line);
     if (isUnchecked) unchecked += 1;
     if (isChecked) checked += 1;
-    if (!hasRenderedSections && (isUnchecked || (isTitled && !isChecked))) legacyOpen += 1;
+    if (!rendered && (isUnchecked || (isTitled && !isChecked))) legacyOpen += 1;
     if (!isTitled) continue;
 
     titled += 1;
-    if (hasRenderedSections && ['Backlog', 'In Progress'].includes(section)) renderedOpen += 1;
-    if (hasRenderedSections && section === 'Completed') renderedDone += 1;
+    if (rendered && isOpenSection(section)) renderedOpen += 1;
+    if (rendered && isDoneSection(section)) renderedDone += 1;
   }
 
   return {
-    open: hasRenderedSections ? renderedOpen : legacyOpen,
+    open: rendered ? renderedOpen : legacyOpen,
     checked,
     titled,
-    done: hasRenderedSections ? renderedDone : checked + (text.match(/~~|DONE|✅/g) || []).length,
+    done: rendered ? renderedDone : checked + (text.match(/~~|DONE|✅/g) || []).length,
   };
 }
 
+function parseTodoEndgame(todoText) {
+  const text = String(todoText || '');
+  const fields = {};
+  let inEndgame = false;
+
+  for (const line of text.split(/\r?\n/)) {
+    const heading = line.match(/^##\s+(.+?)\s*$/);
+    if (heading) {
+      inEndgame = heading[1].trim().toLowerCase() === 'endgame';
+      continue;
+    }
+    if (!inEndgame) continue;
+
+    const field = line.match(/^\*\*(Slug|Horizon|Source):\*\*\s*(.*?)\s*$/i);
+    if (field) fields[field[1].toLowerCase()] = field[2].trim();
+  }
+
+  const slug = fields.slug || null;
+  const horizon = fields.horizon || null;
+  const source = fields.source || null;
+  if (!slug && !horizon && !source) return null;
+  return { slug, horizon, source };
+}
+
 const EXECUTABLE_TASK_STATUSES = new Set(['open', 'claimed']);
 const COMPLETED_TASK_STATUSES = new Set(['done', 'completed', 'accepted']);
 
@@ -350,15 +377,33 @@ function isCertifiedReviewTask(task) {
   return Boolean(metadata.agent_certified || review.agent_certified || passCount >= 2);
 }
 
+function isAgentNeededReviewTask(task) {
+  if (String(task?.status || '').toLowerCase() !== 'review') return false;
+  if (isCertifiedReviewTask(task)) return false;
+  const metadata = task.metadata || {};
+  const review = task.review || {};
+  const approvalStatus = String(metadata.approval_status || review.approval_status || 'pending').toLowerCase();
+  if (approvalStatus && approvalStatus !== 'pending') return false;
+  const passCount = Number(metadata.agent_review_pass_count || review.agent_review_pass_count || 0);
+  return passCount < 2;
+}
+
 function summarizeTaskProjection(root) {
   const tasks = readTaskProjectionTasks(root);
   if (!tasks) return null;
 
   const counts = {};
   const certifiedReviewTasks = [];
+  const agentNeededReviewTasks = [];
   for (const task of tasks) {
     const status = String(task?.status || '').toLowerCase();
     counts[status] = (counts[status] || 0) + 1;
+    if (isAgentNeededReviewTask(task)) {
+      agentNeededReviewTasks.push({
+        ref: task.display_id || task.legacy_ref || task.id,
+        title: task.title || 'Untitled task',
+      });
+    }
     if (isCertifiedReviewTask(task)) {
       certifiedReviewTasks.push({
         ref: task.display_id || task.legacy_ref || task.id,
@@ -370,6 +415,7 @@ function summarizeTaskProjection(root) {
   return {
     tasks,
     counts,
+    agentNeededReviewTasks,
     certifiedReviewTasks,
   };
 }
@@ -466,6 +512,7 @@ function collectState(root) {
     slug: business.slug || path.basename(root),
     business,
     todo: countWorkItems(root, todoText),
+    endgame: parseTodoEndgame(todoText),
     taskProjection: summarizeTaskProjection(root),
     hasNow: nowText.length > 0,
     nowHeading: firstHeading(nowText, null),
@@ -628,7 +675,7 @@ function parseContributionCard(text, member) {
   if (!text || !member) return null;
   const firstName = String(member.name || member.slug || '').split(/\s+/)[0].toLowerCase();
   const sections = String(text).split(/\n(?=##\s+)/);
-  const memberSections = sections.filter(section => new RegExp(`^##\\s+${firstName}\\b`, 'i').test(section.trim()));
+  const memberSections = sections.filter(section => new RegExp(`^##\\s+${escapeRegExp(firstName)}\\b`, 'i').test(section.trim()));
   const section = (
     memberSections.find(candidate => /current_score_signal\s*:/i.test(candidate))
     || memberSections[0]
@@ -708,12 +755,25 @@ function memberNextMove(member, state = null) {
   const name = member.name || member.slug;
   const context = `${member.startHere}\n${member.goals}`;
   const identity = `${member.slug}\n${member.name}`;
+  const agentNeededReview = state?.taskProjection?.agentNeededReviewTasks?.[0] || null;
+  const agentNeededReviewMove = agentNeededReview
+    ? `${name}: run the agent-safe review lane for ${agentNeededReview.ref}: ` +
+      `\`atris task review-chat ${agentNeededReview.ref} --as codex-review\`, then run the verifier named in the review packet and certify or revise without accepting XP.`
+    : null;
   const certifiedReview = state?.taskProjection?.certifiedReviewTasks?.[0] || null;
+  const certifiedReviewRefs = (state?.taskProjection?.certifiedReviewTasks || [])
+    .map(task => task.ref)
+    .filter(Boolean);
   const certifiedReviewMove = certifiedReview
     ? `${name}: hand off certified review ${certifiedReview.ref} to the operator: run ` +
       `\`atris task accept ${certifiedReview.ref}\` if approved or ` +
       `\`atris task revise ${certifiedReview.ref} --note "<what must change>"\` if not; do not create new work until this checkpoint is clear.`
     : null;
+  const codexEndgameMove = certifiedReviewRefs.length > 0 && member.slug === 'codex-executor'
+    ? `${name}: certified reviews ${certifiedReviewRefs.slice(0, 3).join(', ')} are human-only; do not accept XP. ` +
+      `Create the next bounded Codex task from Endgame ${state?.endgame?.slug || 'current-horizon'}: ` +
+      `${state?.endgame?.horizon || 'the highest-leverage system gap'}; include files, verifier, and stop rule before editing.`
+    : null;
   if (member.slug === 'justin' || /justin/i.test(member.name || '')) {
     return `${name}: run one customer-moving GTM rep, update the relevant workspace state within 10 minutes, and leave a scorecard.`;
   }
@@ -728,6 +788,7 @@ function memberNextMove(member, state = null) {
     return `${name}: choose or create one bounded mission step, run its verifier, and close it with proof, a scorecard, and the next move.`;
   }
   if (/validator|reviewer/i.test(identity)) {
+    if (agentNeededReviewMove) return agentNeededReviewMove;
     if (certifiedReviewMove) return certifiedReviewMove;
     if ((state?.todo?.open || 0) === 0 && (state?.todo?.done || 0) === 0) {
       return `${name}: wait for one concrete artifact or ask Navigator to create a reviewable task with verifier, proof target, and residual-risk checklist.`;
@@ -736,6 +797,8 @@ function memberNextMove(member, state = null) {
   }
   if (/executor|builder/i.test(identity)) {
     if ((state?.todo?.open || 0) === 0) {
+      if (agentNeededReviewMove) return agentNeededReviewMove;
+      if (codexEndgameMove) return codexEndgameMove;
       if (certifiedReviewMove) return certifiedReviewMove;
       return `${name}: ask Navigator to create one bounded task with files, verifier, and stop rule before making a patch.`;
     }
@@ -745,6 +808,7 @@ function memberNextMove(member, state = null) {
     return `${name}: turn one messy or unclaimed intent into a MAP-backed plan with ASCII visualization, exact files, verifier, rollback, and a review-ready task.`;
   }
   if (/launcher|closer/i.test(identity)) {
+    if (agentNeededReviewMove) return agentNeededReviewMove;
     if (certifiedReviewMove) return certifiedReviewMove;
     if ((state?.todo?.done || 0) === 0) {
       return `${name}: wait for one validated task receipt before closeout, or ask Validator to produce a review decision with proof.`;
@@ -1571,4 +1635,7 @@ module.exports = {
   verifyActivationCard,
   verifyActivationGallery,
   verifyBrain,
+  parseContributionCard,
+  escapeRegExp,
+  countTodoItems,
 };

package/commands/brainstorm.js

@@ -2,6 +2,15 @@ const fs = require('fs');
 const path = require('path');
 const readline = require('readline');
 const { getLogPath, ensureLogDirectory, createLogFile } = require('../lib/journal');
+// Inbox helpers live canonically (and CRLF-tolerant) in lib/file-ops; brainstorm
+// used to carry byte-identical local copies that silently missed CRLF journals.
+const {
+  parseInboxItems,
+  replaceInboxSection,
+  addInboxItemToContent,
+  getNextInboxId,
+  addInboxIdea,
+} = require('../lib/file-ops');
 const { loadConfig } = require('../utils/config');
 const { loadCredentials, ensureValidCredentials } = require('../utils/auth');
 const { apiRequestJson } = require('../utils/api');
@@ -351,69 +360,11 @@ function brainstormAbortError() {
   return error;
 }
 
-function addInboxIdea(logFile, summary) {
-  const content = fs.readFileSync(logFile, 'utf8');
-  const nextId = getNextInboxId(content);
-  const updated = addInboxItemToContent(content, nextId, summary);
-  fs.writeFileSync(logFile, updated);
-  return nextId;
-}
-
-function parseInboxItems(content) {
-  const match = content.match(/## Inbox\n([\s\S]*?)(?=\n##|\n---|$)/);
-  if (!match) {
-    return [];
-  }
-  const body = match[1];
-  const lines = body.split('\n');
-  const items = [];
-  lines.forEach((line) => {
-    const trimmed = line.trim();
-    if (!trimmed) return;
-    if (trimmed.startsWith('(Empty')) return;
-    const parsed = trimmed.match(/^- \*\*I(\d+):\*\*\s*(.+)$|^- \*\*I(\d+):\s+(.+)$/);
-    if (parsed) {
-      const id = parseInt(parsed[1] || parsed[3], 10);
-      const text = parsed[2] || parsed[4];
-      items.push({ id, text, line: trimmed });
-    }
-  });
-  return items;
-}
-
-function replaceInboxSection(content, items) {
-  const regex = /(## Inbox\n)([\s\S]*?)(\n---|\n##|$)/;
-  if (!regex.test(content)) {
-    const lines = items.length ? items.map((item) => item.line).join('\n') : '(Empty - inbox zero achieved)';
-    return `${content}\n\n## Inbox\n\n${lines}\n`;
-  }
-
-  return content.replace(regex, (match, header, body, suffix) => {
-    const inner = items.length
-      ? `\n${items.map((item) => item.line).join('\n')}\n`
-      : '\n(Empty - inbox zero achieved)\n';
-    return `${header}${inner}${suffix}`;
-  });
-}
-
-function addInboxItemToContent(content, id, summary) {
-  const items = parseInboxItems(content).filter((item) => item.id !== id);
-  const newItem = { id, text: summary, line: `- **I${id}:** ${summary}` };
-  const updatedItems = [newItem, ...items];
-  return replaceInboxSection(content, updatedItems);
-}
-
 function removeInboxItemFromContent(content, id) {
   const items = parseInboxItems(content).filter((item) => item.id !== id);
   return replaceInboxSection(content, items);
 }
 
-function getNextInboxId(content) {
-  const items = parseInboxItems(content);
-  if (items.length === 0) return 1;
-  return items.reduce((max, item) => (item.id > max ? item.id : max), 0) + 1;
-}
-
 function insertIntoNotesSection(content, block) {
   const regex = /(## Notes\n)([\s\S]*?)(\n---|\n##|$)/;
   const match = content.match(regex);

package/commands/clean.js

@@ -1,5 +1,6 @@
 const fs = require('fs');
 const path = require('path');
+const escapeRegExp = require('../lib/escape-regexp');
 
 /**
  * atris clean - Workspace housekeeping with auto-heal
@@ -396,10 +397,6 @@ function findSymbolLine(fileContent, symbol) {
   return null;
 }
 
-function escapeRegExp(string) {
-  return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-}
-
 /**
  * Find wiki pages whose sources have been modified after last_compiled.
  * Scans all .md files under atris/ for frontmatter with last_compiled + sources.