atom.io 0.19.2 → 0.19.4

package/eslint-plugin/src/rules/synchronous-selector-dependencies.ts

@@ -0,0 +1,190 @@
+import type { Rule } from "eslint"
+import type * as ESTree from "estree"
+
+function walk(
+	node: ESTree.Node,
+	callback: (node: ESTree.Node, depth: number) => void,
+	depth = 0,
+) {
+	callback(node, depth)
+
+	switch (node.type) {
+		case `FunctionDeclaration`:
+		case `FunctionExpression`:
+		case `ArrowFunctionExpression`:
+			for (const param of node.params) {
+				walk(param, callback, depth + 1)
+			}
+			walk(node.body, callback, depth + 1)
+			break
+		case `BlockStatement`:
+			for (const statement of node.body) {
+				walk(statement, callback, depth + 1)
+			}
+			break
+		case `IfStatement`:
+			walk(node.test, callback, depth)
+			walk(node.consequent, callback, depth)
+			if (node.alternate) {
+				walk(node.alternate, callback, depth)
+			}
+			break
+		case `SwitchStatement`:
+			walk(node.discriminant, callback, depth + 1)
+			for (const caseOrDefault of node.cases) {
+				walk(caseOrDefault, callback, depth)
+			}
+			break
+		case `ReturnStatement`:
+			if (node.argument) {
+				walk(node.argument, callback, depth)
+			}
+			break
+		case `SwitchCase`:
+			if (node.test) {
+				walk(node.test, callback, depth)
+			}
+			for (const statement of node.consequent) {
+				walk(statement, callback, depth)
+			}
+			break
+		case `VariableDeclaration`:
+			for (const declaration of node.declarations) {
+				walk(declaration, callback, depth)
+				if (declaration.init) {
+					walk(declaration.init, callback, depth)
+				}
+			}
+			break
+		case `BinaryExpression`:
+			walk(node.left, callback, depth)
+			walk(node.right, callback, depth)
+			break
+		case `MemberExpression`:
+			walk(node.object, callback, depth)
+			walk(node.property, callback, depth)
+			break
+	}
+}
+
+export const synchronousSelectorDependencies = {
+	meta: {
+		type: `problem`,
+		docs: {
+			description: `disallow await before calling get on the parameter's get method inside selector`,
+			category: `Possible Errors`,
+			recommended: false,
+			url: ``, // URL to documentation page for this rule
+		},
+		schema: [], // no options
+	},
+	create(context) {
+		return {
+			CallExpression(node) {
+				let selectorComputation: ESTree.Node | undefined
+				if (`name` in node.callee && node.callee.name === `selectorFamily`) {
+					if (node.arguments[0].type === `ObjectExpression`) {
+						const selectorLookupProperty = node.arguments[0].properties.find(
+							(prop): prop is ESTree.Property => {
+								return (
+									`key` in prop && `name` in prop.key && prop.key.name === `get`
+								)
+							},
+						)
+						const selectorLookup = selectorLookupProperty?.value
+						if (
+							selectorLookup?.type === `FunctionExpression` ||
+							selectorLookup?.type === `ArrowFunctionExpression`
+						) {
+							if (selectorLookup.body.type === `BlockStatement`) {
+								for (const statement of selectorLookup.body.body) {
+									if (
+										statement.type === `ReturnStatement` &&
+										statement.argument
+									) {
+										selectorComputation = statement.argument
+									}
+								}
+							} else if (
+								selectorLookup.body.type === `FunctionExpression` ||
+								selectorLookup.body.type === `ArrowFunctionExpression`
+							) {
+								selectorComputation = selectorLookup.body
+							}
+						}
+					}
+				}
+				if (`name` in node.callee && node.callee.name === `selector`) {
+					if (node.arguments[0].type === `ObjectExpression`) {
+						const selectorComputationProperty =
+							node.arguments[0].properties.find(
+								(prop): prop is ESTree.Property => {
+									return (
+										`key` in prop &&
+										`name` in prop.key &&
+										prop.key.name === `get`
+									)
+								},
+							)
+						selectorComputation = selectorComputationProperty?.value
+					}
+				}
+				if (
+					selectorComputation?.type === `FunctionExpression` ||
+					selectorComputation?.type === `ArrowFunctionExpression`
+				) {
+					const nonDestructuredTransactorsName =
+						selectorComputation.params[0] &&
+						`name` in selectorComputation.params[0]
+							? selectorComputation.params[0].name
+							: undefined
+					let awaited: number | undefined
+					let awaitNode: ESTree.AwaitExpression | undefined
+					walk(selectorComputation, (n, depth) => {
+						// console.log(`${`\t`.repeat(depth)}${n.type} ${n.name ?? ``}`)
+						if (typeof awaited === `number`) {
+							if (awaited > depth) {
+								awaited = undefined
+								awaitNode = undefined
+							}
+						}
+						switch (n.type) {
+							case `AwaitExpression`:
+								awaited = depth
+								awaitNode = n
+								break
+							case `CallExpression`:
+								if (awaitNode) {
+									let willReport = false
+									switch (n.callee.type) {
+										case `MemberExpression`:
+											if (
+												n.callee.object.type === `Identifier` &&
+												n.callee.object.name ===
+													nonDestructuredTransactorsName &&
+												n.callee.property.type === `Identifier` &&
+												n.callee.property.name === `get`
+											) {
+												willReport = true
+											}
+											break
+										case `Identifier`:
+											if (n.callee.name === `get`) {
+												willReport = true
+											}
+											break
+									}
+									if (willReport) {
+										context.report({
+											node: awaitNode,
+											message: `Using await before calling the 'get' transactor is not allowed.`,
+										})
+									}
+								}
+						}
+					})
+				}
+			},
+		}
+	},
+} satisfies Rule.RuleModule

package/internal/dist/index.js

@@ -1,5 +1,5 @@
 import { Junction } from '../../dist/chunk-FTONNX2R.js';
-import { __spreadValues, __spreadProps } from '../../dist/chunk-U2IICNHQ.js';
+import { __spreadValues, __spreadProps } from '../../dist/chunk-F2X4B4VY.js';
 import { stringifyJson, selectJson, parseJson, selectJsonFamily } from 'atom.io/json';
 import { AtomIOLogger } from 'atom.io';
 

package/internal/package.json

@@ -3,7 +3,7 @@
 	"type": "module",
 	"private": true,
 	"main": "dist/index.cjs",
-	"module": "dist/index.mjs",
+	"module": "dist/index.js",
 	"types": "dist/index.d.ts",
 	"exports": {
 		".": {

package/introspection/dist/index.js

@@ -1,4 +1,4 @@
-import { __spreadValues, __spreadProps } from '../../dist/chunk-U2IICNHQ.js';
+import { __spreadValues, __spreadProps } from '../../dist/chunk-F2X4B4VY.js';
 import * as Internal from 'atom.io/internal';
 import { createRegularAtom, newest, createStandaloneSelector, IMPLICIT, createRegularAtomFamily, Subject, createSelectorFamily } from 'atom.io/internal';
 

package/introspection/package.json

@@ -3,7 +3,7 @@
 	"type": "module",
 	"private": true,
 	"main": "dist/index.cjs",
-	"module": "dist/index.mjs",
+	"module": "dist/index.js",
 	"types": "dist/index.d.ts",
 	"exports": {
 		".": {

package/json/dist/index.cjs

@@ -56,18 +56,18 @@ var selectJson = (atom, transform, store = internal.IMPLICIT.STORE) => {
     store
   );
 };
-function selectJsonFamily(atomFamily, transform, store = internal.IMPLICIT.STORE) {
+function selectJsonFamily(family, transform, store = internal.IMPLICIT.STORE) {
   const jsonFamily = internal.createSelectorFamily(
     {
-      key: `${atomFamily.key}:JSON`,
-      get: (key) => ({ get }) => transform.toJson(get(atomFamily(key))),
+      key: `${family.key}:JSON`,
+      get: (key) => ({ get }) => transform.toJson(get(family(key))),
       set: (key) => ({ set }, newValue) => {
-        set(atomFamily(key), transform.fromJson(newValue));
+        set(family(key), transform.fromJson(newValue));
       }
     },
     store
   );
-  atomFamily.subject.subscribe(
+  family.subject.subscribe(
     `store=${store.config.name}::json-selector-family`,
     (token) => {
       if (token.family) {

package/json/dist/index.js

@@ -1,6 +1,6 @@
 import { parseJson } from '../../dist/chunk-BF4MVQF6.js';
 export { JSON_DEFAULTS, JSON_TYPE_NAMES, isBoolean, isNull, isNumber, isPrimitive, isString, parseJson, stringSetJsonInterface, stringifyJson } from '../../dist/chunk-BF4MVQF6.js';
-import '../../dist/chunk-U2IICNHQ.js';
+import '../../dist/chunk-F2X4B4VY.js';
 import { createStandaloneSelector, IMPLICIT, createSelectorFamily } from 'atom.io/internal';
 
 var selectJson = (atom, transform, store = IMPLICIT.STORE) => {
@@ -15,18 +15,18 @@ var selectJson = (atom, transform, store = IMPLICIT.STORE) => {
     store
   );
 };
-function selectJsonFamily(atomFamily, transform, store = IMPLICIT.STORE) {
+function selectJsonFamily(family, transform, store = IMPLICIT.STORE) {
   const jsonFamily = createSelectorFamily(
     {
-      key: `${atomFamily.key}:JSON`,
-      get: (key) => ({ get }) => transform.toJson(get(atomFamily(key))),
+      key: `${family.key}:JSON`,
+      get: (key) => ({ get }) => transform.toJson(get(family(key))),
       set: (key) => ({ set }, newValue) => {
-        set(atomFamily(key), transform.fromJson(newValue));
+        set(family(key), transform.fromJson(newValue));
       }
     },
     store
   );
-  atomFamily.subject.subscribe(
+  family.subject.subscribe(
     `store=${store.config.name}::json-selector-family`,
     (token) => {
       if (token.family) {

package/json/package.json

@@ -3,7 +3,7 @@
 	"type": "module",
 	"private": true,
 	"main": "dist/index.cjs",
-	"module": "dist/index.mjs",
+	"module": "dist/index.js",
 	"types": "dist/index.d.ts",
 	"exports": {
 		".": {

package/json/src/select-json-family.ts

@@ -28,7 +28,7 @@ export function selectJsonFamily<
 	J extends Json.Serializable,
 	K extends Json.Serializable,
 >(
-	atomFamily:
+	family:
 		| AtomIO.MutableAtomFamily<T extends Transceiver<any> ? T : never, J, K>
 		| AtomIO.RegularAtomFamily<T, K>,
 	transform: JsonInterface<T, J>,
@@ -36,20 +36,20 @@ export function selectJsonFamily<
 ): AtomIO.WritableSelectorFamily<J, K> {
 	const jsonFamily = createSelectorFamily<J, K>(
 		{
-			key: `${atomFamily.key}:JSON`,
+			key: `${family.key}:JSON`,
 			get:
 				(key) =>
 				({ get }) =>
-					transform.toJson(get(atomFamily(key))),
+					transform.toJson(get(family(key))),
 			set:
 				(key) =>
 				({ set }, newValue) => {
-					set(atomFamily(key), transform.fromJson(newValue))
+					set(family(key), transform.fromJson(newValue))
 				},
 		},
 		store,
 	)
-	atomFamily.subject.subscribe(
+	family.subject.subscribe(
 		`store=${store.config.name}::json-selector-family`,
 		(token) => {
 			if (token.family) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "atom.io",
-  "version": "0.19.2",
+  "version": "0.19.4",
   "description": "Composable and testable reactive data library.",
   "homepage": "https://atom.io.fyi",
   "sideEffects": false,
@@ -48,17 +48,24 @@
     }
   },
   "devDependencies": {
-    "@testing-library/react": "15.0.0",
+    "@testing-library/react": "15.0.2",
+    "@types/eslint": "npm:@types/eslint@8.56.9",
+    "@types/eslint-9": "npm:@types/eslint@8.56.9",
+    "@types/estree": "1.0.5",
     "@types/http-proxy": "1.17.14",
     "@types/npmlog": "7.0.0",
-    "@types/react": "18.2.75",
+    "@types/react": "18.2.79",
     "@types/tmp": "0.2.6",
-    "@vitest/coverage-v8": "1.4.0",
-    "@vitest/ui": "1.4.0",
+    "@typescript-eslint/parser": "7.7.0",
+    "@typescript-eslint/rule-tester": "7.7.0",
+    "@vitest/coverage-v8": "1.5.0",
+    "@vitest/ui": "1.5.0",
     "concurrently": "8.2.2",
     "drizzle-kit": "0.20.14",
-    "drizzle-orm": "0.30.7",
-    "framer-motion": "11.0.27",
+    "drizzle-orm": "0.30.8",
+    "eslint": "npm:eslint@8.57.0",
+    "eslint-v9": "npm:eslint@9.0.0",
+    "framer-motion": "11.1.1",
     "happy-dom": "14.7.1",
     "http-proxy": "1.18.1",
     "npmlog": "7.0.1",
@@ -72,9 +79,9 @@
     "tmp": "0.2.3",
     "tsup": "8.0.2",
     "typescript": "5.4.5",
-    "vite": "5.2.8",
+    "vite": "5.2.9",
     "vite-tsconfig-paths": "4.3.2",
-    "vitest": "1.4.0"
+    "vitest": "1.5.0"
   },
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -85,6 +92,9 @@
     "data/dist",
     "data/package.json",
     "data/src",
+    "eslint-plugin/dist",
+    "eslint-plugin/package.json",
+    "eslint-plugin/src",
     "internal/dist",
     "internal/package.json",
     "internal/src",
@@ -134,6 +144,13 @@
       "import": "./data/dist/index.js",
       "require": "./data/dist/index.cjs"
     },
+    "./eslint-plugin/package.json": "./eslint-plugin/package.json",
+    "./eslint-plugin": {
+      "types": "./eslint-plugin/dist/index.d.ts",
+      "browser": "./eslint-plugin/dist/index.js",
+      "import": "./eslint-plugin/dist/index.js",
+      "require": "./eslint-plugin/dist/index.cjs"
+    },
     "./internal/package.json": "./internal/package.json",
     "./internal": {
       "types": "./internal/dist/index.d.ts",
@@ -232,6 +249,7 @@
     "build:transceivers:set-rtx": "cd transceivers/set-rtx && tsup",
     "lint:biome": "biome check -- .",
     "lint:eslint": "eslint .",
+    "lint:eslint:build": "bun run build:main",
     "lint:types": "tsc --noEmit",
     "lint": "bun run lint:biome && bun run lint:eslint && bun run lint:types",
     "test": "vitest",

package/react/dist/index.js

@@ -1,4 +1,4 @@
-import '../../dist/chunk-U2IICNHQ.js';
+import '../../dist/chunk-F2X4B4VY.js';
 import { IMPLICIT, findInStore, setIntoStore, subscribeToState, getFromStore, getJsonToken, withdraw, subscribeToTimeline } from 'atom.io/internal';
 import * as React5 from 'react';
 import { jsx } from 'react/jsx-runtime';

package/react/package.json

@@ -3,7 +3,7 @@
 	"type": "module",
 	"private": true,
 	"main": "dist/index.cjs",
-	"module": "dist/index.mjs",
+	"module": "dist/index.js",
 	"types": "dist/index.d.ts",
 	"exports": {
 		".": {