ata-validator 1.21.0 → 1.22.1

package/lib/suggestions.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const { levenshtein } = require('./levenshtein');
+const { resolvePointer: walk, UNRESOLVED } = require('./pointer');
 
 // Hand-coded format hints. Keep <=60 chars per text.
 const FORMAT_HINTS = {
@@ -46,8 +47,15 @@ function suggestEnumTypo (received, enumValues) {
   return null;
 }
 
+// The widest container a typo hint is offered on. `suggestEnumTypo` caps its
+// candidate list for the same two reasons: past a certain width the nearest
+// key stops being evidence of a typo, and the scan is a distance computation
+// per key on a value the caller has already rejected.
+const MAX_TYPO_CANDIDATES = 64;
+
 function suggestRequiredTypo (missing, presentKeys) {
   if (!missing || !Array.isArray(presentKeys)) return null;
+  if (presentKeys.length > MAX_TYPO_CANDIDATES) return null;
   for (const k of presentKeys) {
     if (typeof k !== 'string') continue;
     const d = levenshtein(missing, k, 2);
@@ -58,22 +66,14 @@ function suggestRequiredTypo (missing, presentKeys) {
   return null;
 }
 
-function suggestFormat (format, received) {
+function suggestFormat (format, raw) {
   const fn = FORMAT_HINTS[format];
   if (!fn) return null;
-  // received is repr-truncated string like '"foo"'; unwrap for testing
-  let raw = received;
-  if (typeof raw === 'string' && raw.startsWith('"') && raw.endsWith('"')) {
-    try { raw = JSON.parse(raw); } catch {}
-  }
   const text = fn(raw);
   return text ? { text, kind: 'format' } : null;
 }
 
-function suggestCoercion (expectedType, received) {
-  if (typeof received !== 'string' || !received.startsWith('"') || !received.endsWith('"')) return null;
-  let raw;
-  try { raw = JSON.parse(received); } catch { return null; }
+function suggestCoercion (expectedType, raw) {
   if (typeof raw !== 'string') return null;
   if (expectedType === 'integer' && /^-?\d+$/.test(raw)) {
     return { text: 'value would coerce; enable `coerceTypes` or pass an integer', kind: 'coercion' };
@@ -91,26 +91,37 @@ function suggestCoercion (expectedType, received) {
  * Apply suggestion sources in priority order. Returns the first hit, or null.
  * @param err Enriched ValidationError (with `received`, `params`, `keyword`)
  * @param data The full input data (for required-typo)
+ * @param at The value at `err.path`, already resolved by the caller, or
+ *   UNRESOLVED when the caller has none to offer
  */
-function suggestFor (err, data) {
+function suggestFor (err, data, at = UNRESOLVED) {
+  // The offending value itself. The caller resolves it once per error and
+  // passes it here rather than having each source walk the document again.
+  // A caller that passes only an enriched error falls back to un-quoting the
+  // repr, which is what every source used to read.
+  const raw = at !== UNRESOLVED ? at : parseReceived(err.received);
   if (err.keyword === 'enum') {
-    return suggestEnumTypo(parseReceived(err.received), err.params && err.params.allowedValues);
+    return suggestEnumTypo(raw, err.params && err.params.allowedValues);
   }
   if (err.keyword === 'required') {
     const missing = err.params && err.params.missingProperty;
-    let parentPath = err.path || '';
+    const path = err.path || '';
+    let parentPath = path;
     if (parentPath.endsWith('/' + missing)) parentPath = parentPath.slice(0, -missing.length - 1);
-    const parent = walk(data, parentPath);
+    // A `required` error usually names the container it failed on, so the
+    // value the caller already resolved is the parent. Only the spelling that
+    // points at the missing key itself needs a second walk.
+    const parent = (parentPath === path && at !== UNRESOLVED) ? at : walk(data, parentPath);
     if (parent && typeof parent === 'object') {
       return suggestRequiredTypo(missing, Object.keys(parent));
     }
     return null;
   }
   if (err.keyword === 'format') {
-    return suggestFormat(err.params && err.params.format, err.received);
+    return suggestFormat(err.params && err.params.format, raw);
   }
   if (err.keyword === 'type') {
-    return suggestCoercion(err.params && err.params.type, err.received);
+    return suggestCoercion(err.params && err.params.type, raw);
   }
   return null;
 }
@@ -121,12 +132,4 @@ function parseReceived (r) {
   return r;
 }
 
-function walk (data, pointer) {
-  if (!pointer) return data;
-  const parts = pointer.replace(/^\//, '').split('/').map(s => s.replace(/~1/g, '/').replace(/~0/g, '~'));
-  let cur = data;
-  for (const p of parts) { if (cur == null) return undefined; cur = cur[p]; }
-  return cur;
-}
-
 module.exports = { suggestFor, suggestEnumTypo, suggestRequiredTypo, suggestFormat, suggestCoercion };

package/lib/version.js

@@ -7,4 +7,4 @@
 //
 // Kept in lockstep with package.json by `tests/test_version_sync.js`.
 
-module.exports = '1.21.0';
+module.exports = '1.22.1';

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "ata-validator",
-  "version": "1.21.0",
-  "description": "JSON Schema validation with first-class TypeScript and zero runtime cost. AOT compile to per-schema ESM modules with zero validator dependency. Generic Validator<T> for TypeBox/Zod/Valibot composition. Optional runtime API. Standard Schema V1 compatible.",
+  "version": "1.22.1",
+  "description": "JSON Schema validation that compiles for speed and still runs where code generation is blocked. Compiled and interpreted engines answer identically at 100% of the official suite. TypeScript inference, Standard Schema V1, and a build step that emits dependency-free modules.",
   "main": "index.js",
   "module": "index.mjs",
   "types": "index.d.ts",
@@ -51,7 +51,7 @@
     "release:check": "node scripts/regen-safe-regex-source.js && node tests/test_pack_purity.js && node scripts/check-doc-coverage.js && node tests/test_error_codes_lock.js && node tests/test_safe_regex_source_sync.js && node tests/test_version_sync.js",
     "build": "cmake-js build --target ata",
     "rebuild": "cmake-js rebuild --target ata",
-    "test": "node test.js && node tests/test_removed_aot_methods.js && node tests/test_no_native.js && node tests/test_no_eval.js && node tests/test_property_dependencies.js && node tests/test_v1_dialect.js && node tests/test_buffer_path_parity.js && node tests/test_buffer_gate.js && node tests/test_buffer_reject_cost.js && node tests/test_nan_verdict.js && node tests/test_remove_additional_nested.js && node tests/test_exclusive_bounds.js && node tests/test_engine_differential.js && node tests/test_error_shape_differential.js && node tests/test_output_format.js && node tests/test_retry_message.js && node tests/test_describe_schema.js && node tests/test_aot_parse.js && node tests/test_draft7_semantics.js && node tests/test_metaschema_ref.js && node tests/test_pure_js_unsupported.js && node tests/test_native_load_order.js && node tests/test_pack_purity.js && node tests/test_make_native_package.js && node tests/test_browser_nofs.js && node tests/test_browser_imports_guard.js && node tests/test_version_sync.js && node tests/test_native_loaded.js && node tests/test_safe_regex_source_sync.js && node tests/test_t_builder.js && node tests/test_async_refine.js && node tests/test_safe_regex.js && node tests/test_safe_regex_integration.js && node tests/test_aot_build.js && node tests/test_aot_differential.js && node tests/test_aot_cli_build.js && node tests/test_aot_cli_smoke.js && node tests/test_bundle_standalone.js && node tests/test_standalone_anyof.js && node tests/test_standalone_formats.js && node tests/test_aot_format_mode.js && node tests/test_aot_additional_props_errors.js && node tests/test_id_anchor_refs.js && node tests/test_engine_routing.js && node tests/test_engine_diagnostic.js && node tests/test_format_engine_parity.js && node tests/test_formats_single_pass.js && node tests/test_format_single_error.js && node tests/test_defs_pointer_alias.js && node tests/test_cross_doc_root_ref.js && node tests/test_codegen_entrypoint_agreement.js && node tests/test_hybrid_agreement.js && node tests/test_codegen_edge_shapes.js && node tests/test_ajv_errors.js && node tests/test_custom_keywords.js && node tests/test_aot_external_checks.js && node tests/test_ajv_parity.js && node tests/test_user_format_error_path.js && node tests/test_unevaluated_error_path.js && node tests/test_pattern_properties_errors.js && node tests/test_no_input_mutation.js && node tests/test_typed_validator_runner.js && node tests/test_define_schema.js && node tests/test_error_codes_lock.js && node tests/test_error_code_lookup.js && node tests/test_error_order.js && node tests/test_error_order_ordinal.js && node tests/test_rejection_shape.js && node tests/test_lazy_normalization.js && node tests/test_value_equality.js && node tests/test_vocabulary.js && node tests/test_schema_scan.js && node tests/test_lazy_errors.js && node tests/test_lazy_instance.js && node tests/test_cyclic_input.js && node tests/test_native_error_codes.js && node tests/test_verdict_preprocess.js && node tests/test_plan_compiler.js && node tests/test_nullable.js && node tests/test_validate_and_parse.js && node tests/test_validate_data.js && node tests/test_enrich_error.js && node tests/test_enrich_received.js && node tests/test_rich_errors_optout.js && node tests/test_error_messages.js && node tests/test_source_positions.js && node tests/fuzz_positions.js && node tests/test_data_positions.js && node tests/test_render_shared.js && node tests/test_renderers.js && node tests/test_additive_fields.js && node tests/test_diagnostic_source.js && node tests/test_diagnose.js && node tests/test_correlate.js && node tests/test_diagnostics_score.js && node tests/test_runtime_error_dx.js && node tests/test_aot_error_dx.js && node tests/test_abort_early.js && node tests/test_branch_collapse.js && node tests/test_suggestions.js && node tests/test_cli_validate.js && node tests/test_cli_version.js && node benchmark/bench_aot_size.mjs",
+    "test": "node test.js && node tests/test_removed_aot_methods.js && node tests/test_no_native.js && node tests/test_no_eval.js && node tests/test_property_dependencies.js && node tests/test_v1_dialect.js && node tests/test_buffer_path_parity.js && node tests/test_buffer_gate.js && node tests/test_buffer_reject_cost.js && node tests/test_nan_verdict.js && node tests/test_remove_additional_nested.js && node tests/test_exclusive_bounds.js && node tests/test_engine_differential.js && node tests/test_error_shape_differential.js && node tests/test_output_format.js && node tests/test_retry_message.js && node tests/test_describe_schema.js && node tests/test_aot_parse.js && node tests/test_draft7_semantics.js && node tests/test_metaschema_ref.js && node tests/test_pure_js_unsupported.js && node tests/test_native_load_order.js && node tests/test_pack_purity.js && node tests/test_make_native_package.js && node tests/test_browser_nofs.js && node tests/test_browser_imports_guard.js && node tests/test_version_sync.js && node tests/test_native_loaded.js && node tests/test_safe_regex_source_sync.js && node tests/test_t_builder.js && node tests/test_async_refine.js && node tests/test_safe_regex.js && node tests/test_safe_regex_integration.js && node tests/test_aot_build.js && node tests/test_aot_differential.js && node tests/test_aot_cli_build.js && node tests/test_aot_cli_smoke.js && node tests/test_bundle_standalone.js && node tests/test_standalone_anyof.js && node tests/test_standalone_formats.js && node tests/test_aot_format_mode.js && node tests/test_aot_additional_props_errors.js && node tests/test_id_anchor_refs.js && node tests/test_engine_routing.js && node tests/test_compile_cache_order.js && node tests/test_engine_diagnostic.js && node tests/test_format_engine_parity.js && node tests/test_uri_helper_parity.js && node tests/test_formats_single_pass.js && node tests/test_format_single_error.js && node tests/test_defs_pointer_alias.js && node tests/test_cross_doc_root_ref.js && node tests/test_codegen_entrypoint_agreement.js && node tests/test_hybrid_agreement.js && node tests/test_codegen_edge_shapes.js && node tests/test_ajv_errors.js && node tests/test_custom_keywords.js && node tests/test_aot_external_checks.js && node tests/test_ajv_parity.js && node tests/test_user_format_error_path.js && node tests/test_unevaluated_error_path.js && node tests/test_unevaluated_error_shape.js && node tests/test_pattern_properties_errors.js && node tests/test_additional_properties_scaling.js && node tests/test_no_input_mutation.js && node tests/test_typed_validator_runner.js && node tests/test_define_schema.js && node tests/test_error_codes_lock.js && node tests/test_error_code_lookup.js && node tests/test_error_order.js && node tests/test_error_order_ordinal.js && node tests/test_rejection_shape.js && node tests/test_lazy_normalization.js && node tests/test_value_equality.js && node tests/test_vocabulary.js && node tests/test_schema_scan.js && node tests/test_lazy_errors.js && node tests/test_lazy_instance.js && node tests/test_cyclic_input.js && node tests/test_native_error_codes.js && node tests/test_verdict_preprocess.js && node tests/test_plan_compiler.js && node tests/test_nullable.js && node tests/test_validate_and_parse.js && node tests/test_validate_data.js && node tests/test_enrich_error.js && node tests/test_enrich_received.js && node tests/test_rich_errors_optout.js && node tests/test_error_messages.js && node tests/test_source_positions.js && node tests/fuzz_positions.js && node tests/test_malformed_json_termination.js && node tests/test_data_positions.js && node tests/test_render_shared.js && node tests/test_renderers.js && node tests/test_additive_fields.js && node tests/test_diagnostic_source.js && node tests/test_diagnose.js && node tests/test_correlate.js && node tests/test_diagnostics_score.js && node tests/test_runtime_error_dx.js && node tests/test_aot_error_dx.js && node tests/test_abort_early.js && node tests/test_branch_collapse.js && node tests/test_suggestions.js && node tests/test_cli_validate.js && node tests/test_cli_version.js && node benchmark/bench_aot_size.mjs",
     "bench:size": "node benchmark/bench_aot_size.mjs",
     "test:suite": "node tests/run_suite.js && node tests/run_suite.js draft7 && node tests/run_suite.js v1",
     "test:compat": "node tests/test_compat.js",
@@ -122,13 +122,13 @@
     "LICENSE"
   ],
   "optionalDependencies": {
-    "@ata-validator/native-darwin-arm64": "1.21.0",
-    "@ata-validator/native-darwin-x64": "1.21.0",
-    "@ata-validator/native-linux-arm64-gnu": "1.21.0",
-    "@ata-validator/native-linux-arm64-musl": "1.21.0",
-    "@ata-validator/native-linux-x64-gnu": "1.21.0",
-    "@ata-validator/native-linux-x64-musl": "1.21.0",
-    "@ata-validator/native-win32-x64": "1.21.0"
+    "@ata-validator/native-darwin-arm64": "1.22.1",
+    "@ata-validator/native-darwin-x64": "1.22.1",
+    "@ata-validator/native-linux-arm64-gnu": "1.22.1",
+    "@ata-validator/native-linux-arm64-musl": "1.22.1",
+    "@ata-validator/native-linux-x64-gnu": "1.22.1",
+    "@ata-validator/native-linux-x64-musl": "1.22.1",
+    "@ata-validator/native-win32-x64": "1.22.1"
   },
   "peerDependencies": {
     "yaml": "^2.0.0"