async-reactivity 2.0.29 → 2.0.30

package/lib/computed.js

@@ -30,7 +30,7 @@ export default class Computed extends Effect {
             const newValue = this.run();
             if (newValue !== InSyncSymbol) {
                 this._value = newValue;
-                if (this.isEqual(this._value, oldValue)) {
+                if (this.dependents.size > 0 && this.isEqual(this._value, oldValue)) {
                     this.validateDependents();
                 }
             }
@@ -38,7 +38,7 @@ export default class Computed extends Effect {
         return this._value;
     }
     validateDependents() {
-        for (const dependent of this.dependents.keys()) {
+        for (const dependent of this.dependents) {
             dependent.validate(this);
         }
     }

package/lib/computed.test.js

@@ -152,14 +152,18 @@ describe('computed', function () {
         });
         it('isEqual', function () {
             const a = new Ref(1);
-            const b = new Computed((value) => {
-                return value(a);
-            }, (_newValue, oldValue) => oldValue !== undefined);
+            let isEqual = false;
+            const b = new Computed((value) => value(a), () => isEqual);
             const c = new Computed(value => value(b));
             assert.strictEqual(c.value, 1);
+            isEqual = true;
             a.value = 2;
             assert.strictEqual(c.value, 1);
         });
+        it('should not call isEqual when there are no dependents (optimization)', function () {
+            const a = new Computed(() => 5, () => assert.fail());
+            assert.strictEqual(a.value, 5);
+        });
     });
     describe('async', function () {
         it('getter', async function () {

package/lib/ref.test.js

@@ -18,7 +18,7 @@ describe('ref', function () {
         }, false);
         a.value = 4;
     });
-    it('should not call isEqual when there are no dependents', function () {
+    it('should not call isEqual when there are no dependents (optimization)', function () {
         const a = new Ref(5, () => assert.fail());
         a.value = 4;
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "async-reactivity",
-  "version": "2.0.29",
+  "version": "2.0.30",
   "description": "",
   "main": "lib/index.js",
   "types": "types/index.d.ts",

package/src/computed.test.ts

@@ -179,16 +179,22 @@ describe('computed', function () {
 
         it('isEqual', function () {
             const a = new Ref(1);
-            const b = new Computed((value) => {
-                return value(a);
-            }, (_newValue, oldValue) => oldValue !== undefined);
+            let isEqual = false;
+            const b = new Computed((value) => value(a), () => isEqual);
             const c = new Computed(value => value(b));
 
             assert.strictEqual(c.value, 1);
-
+            isEqual = true;
             a.value = 2;
+
             assert.strictEqual(c.value, 1);
         });
+
+        it('should not call isEqual when there are no dependents (optimization)', function () {
+            const a = new Computed(() => 5, () => assert.fail());
+
+            assert.strictEqual(a.value, 5);
+        });
     });
 
     describe('async', function () {

package/src/computed.ts

@@ -42,7 +42,7 @@ export default class Computed<T> extends Effect implements Dependent, Dependency
             const newValue = this.run() as T;
             if (newValue !== InSyncSymbol) {
                 this._value = newValue;
-                if (this.isEqual(this._value!, oldValue)) {
+                if (this.dependents.size > 0 && this.isEqual(this._value!, oldValue)) {
                     this.validateDependents();
                 }
             }
@@ -52,7 +52,7 @@ export default class Computed<T> extends Effect implements Dependent, Dependency
     }
 
     private validateDependents() {
-        for (const dependent of this.dependents.keys()) {
+        for (const dependent of this.dependents) {
             dependent.validate(this);
         }
     }

package/src/ref.test.ts

@@ -22,7 +22,7 @@ describe('ref', function () {
         a.value = 4;
     });
 
-    it('should not call isEqual when there are no dependents', function () {
+    it('should not call isEqual when there are no dependents (optimization)', function () {
         const a = new Ref(5, () => assert.fail());
         a.value = 4;
     });

package/lib/tracker.js

@@ -1,18 +0,0 @@
-export default class Tracker {
-    dependents = new Set();
-    _value;
-    addDependent(dependent) {
-        this.dependents.add(dependent);
-    }
-    removeDependent(dependent) {
-        this.dependents.delete(dependent);
-    }
-    invalidate() {
-        for (const dependent of [...this.dependents.keys()]) {
-            dependent.invalidate(this);
-        }
-    }
-    get value() {
-        return this._value;
-    }
-}

package/types/tracker.d.ts

@@ -1,10 +0,0 @@
-import Dependent from "./dependent.js";
-export default class Tracker<T> {
-    protected dependents: Set<Dependent>;
-    protected _value?: T;
-    addDependent(dependent: Dependent): void;
-    removeDependent(dependent: Dependent): void;
-    invalidate(): void;
-    get value(): T | undefined;
-}
-//# sourceMappingURL=tracker.d.ts.map

package/types/tracker.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"tracker.d.ts","sourceRoot":"","sources":["../src/tracker.ts"],"names":[],"mappings":"AAAA,OAAO,SAAS,MAAM,gBAAgB,CAAC;AAEvC,MAAM,CAAC,OAAO,OAAO,OAAO,CAAC,CAAC;IAC1B,SAAS,CAAC,UAAU,iBAAwB;IAC5C,SAAS,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAEd,YAAY,CAAC,SAAS,EAAE,SAAS;IAIjC,eAAe,CAAC,SAAS,EAAE,SAAS;IAIpC,UAAU,IAAI,IAAI;IAMzB,IAAW,KAAK,kBAEf;CACJ"}