async-reactivity 2.0.28 → 2.0.30

package/lib/computed.js

@@ -30,7 +30,7 @@ export default class Computed extends Effect {
             const newValue = this.run();
             if (newValue !== InSyncSymbol) {
                 this._value = newValue;
-                if (this.isEqual(this._value, oldValue)) {
+                if (this.dependents.size > 0 && this.isEqual(this._value, oldValue)) {
                     this.validateDependents();
                 }
             }
@@ -38,7 +38,7 @@ export default class Computed extends Effect {
         return this._value;
     }
     validateDependents() {
-        for (const dependent of this.dependents.keys()) {
+        for (const dependent of this.dependents) {
             dependent.validate(this);
         }
     }

package/lib/computed.test.js

@@ -152,14 +152,18 @@ describe('computed', function () {
         });
         it('isEqual', function () {
             const a = new Ref(1);
-            const b = new Computed((value) => {
-                return value(a);
-            }, (_newValue, oldValue) => oldValue !== undefined);
+            let isEqual = false;
+            const b = new Computed((value) => value(a), () => isEqual);
             const c = new Computed(value => value(b));
             assert.strictEqual(c.value, 1);
+            isEqual = true;
             a.value = 2;
             assert.strictEqual(c.value, 1);
         });
+        it('should not call isEqual when there are no dependents (optimization)', function () {
+            const a = new Computed(() => 5, () => assert.fail());
+            assert.strictEqual(a.value, 5);
+        });
     });
     describe('async', function () {
         it('getter', async function () {

package/lib/ref.js

@@ -3,14 +3,14 @@ export default class Ref {
     isEqual;
     dependents = new Set();
     _value;
-    constructor(_value, isEqual = (defaultIsEqual)) {
-        this._value = _value;
+    constructor(value, isEqual = (defaultIsEqual)) {
+        this._value = value;
         this.isEqual = isEqual;
     }
-    set value(_value) {
+    set value(value) {
         const oldValue = this._value;
-        this._value = _value;
-        if (!this.isEqual(_value, oldValue)) {
+        this._value = value;
+        if (this.dependents.size > 0 && !this.isEqual(value, oldValue)) {
             this.invalidate();
         }
     }

package/lib/ref.test.js

@@ -11,11 +11,15 @@ describe('ref', function () {
         a.value = 4;
         assert.strictEqual(a.value, 4);
     });
-    it('setter isEqual', function () {
+    it('should not invalidate when isEqual returns true', function () {
         const a = new Ref(5, () => true);
         new Watcher(a, () => {
             assert.fail();
         }, false);
         a.value = 4;
     });
+    it('should not call isEqual when there are no dependents (optimization)', function () {
+        const a = new Ref(5, () => assert.fail());
+        a.value = 4;
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "async-reactivity",
-  "version": "2.0.28",
+  "version": "2.0.30",
   "description": "",
   "main": "lib/index.js",
   "types": "types/index.d.ts",

package/src/computed.test.ts

@@ -179,16 +179,22 @@ describe('computed', function () {
 
         it('isEqual', function () {
             const a = new Ref(1);
-            const b = new Computed((value) => {
-                return value(a);
-            }, (_newValue, oldValue) => oldValue !== undefined);
+            let isEqual = false;
+            const b = new Computed((value) => value(a), () => isEqual);
             const c = new Computed(value => value(b));
 
             assert.strictEqual(c.value, 1);
-
+            isEqual = true;
             a.value = 2;
+
             assert.strictEqual(c.value, 1);
         });
+
+        it('should not call isEqual when there are no dependents (optimization)', function () {
+            const a = new Computed(() => 5, () => assert.fail());
+
+            assert.strictEqual(a.value, 5);
+        });
     });
 
     describe('async', function () {

package/src/computed.ts

@@ -42,7 +42,7 @@ export default class Computed<T> extends Effect implements Dependent, Dependency
             const newValue = this.run() as T;
             if (newValue !== InSyncSymbol) {
                 this._value = newValue;
-                if (this.isEqual(this._value!, oldValue)) {
+                if (this.dependents.size > 0 && this.isEqual(this._value!, oldValue)) {
                     this.validateDependents();
                 }
             }
@@ -52,7 +52,7 @@ export default class Computed<T> extends Effect implements Dependent, Dependency
     }
 
     private validateDependents() {
-        for (const dependent of this.dependents.keys()) {
+        for (const dependent of this.dependents) {
             dependent.validate(this);
         }
     }

package/src/ref.test.ts

@@ -14,11 +14,16 @@ describe('ref', function () {
         assert.strictEqual(a.value, 4);
     });
 
-    it('setter isEqual', function () {
+    it('should not invalidate when isEqual returns true', function () {
         const a = new Ref(5, () => true);
         new Watcher(a, () => {
             assert.fail();
         }, false);
         a.value = 4;
     });
+
+    it('should not call isEqual when there are no dependents (optimization)', function () {
+        const a = new Ref(5, () => assert.fail());
+        a.value = 4;
+    });
 });

package/src/ref.ts

@@ -7,15 +7,15 @@ export default class Ref<T> implements Dependency<T> {
     protected dependents = new Set<Dependent>();
     protected _value?: T;
 
-    constructor(_value: T, isEqual = defaultIsEqual<T>) {
-        this._value = _value;
+    constructor(value: T, isEqual = defaultIsEqual<T>) {
+        this._value = value;
         this.isEqual = isEqual;
     }
 
-    public set value(_value: T) {
+    public set value(value: T) {
         const oldValue = this._value!;
-        this._value = _value;
-        if (!this.isEqual(_value, oldValue)) {
+        this._value = value;
+        if (this.dependents.size > 0 && !this.isEqual(value, oldValue)) {
             this.invalidate();
         }
     }

package/types/ref.d.ts

@@ -4,8 +4,8 @@ export default class Ref<T> implements Dependency<T> {
     private isEqual;
     protected dependents: Set<Dependent>;
     protected _value?: T;
-    constructor(_value: T, isEqual?: (v1: T, v2: T) => boolean);
-    set value(_value: T);
+    constructor(value: T, isEqual?: (v1: T, v2: T) => boolean);
+    set value(value: T);
     get value(): T;
     addDependent(dependent: Dependent): void;
     removeDependent(dependent: Dependent): void;

package/types/ref.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ref.d.ts","sourceRoot":"","sources":["../src/ref.ts"],"names":[],"mappings":"AAAA,OAAO,UAAU,MAAM,iBAAiB,CAAC;AAEzC,OAAO,EAAE,SAAS,EAAE,MAAM,YAAY,CAAC;AAEvC,MAAM,CAAC,OAAO,OAAO,GAAG,CAAC,CAAC,CAAE,YAAW,UAAU,CAAC,CAAC,CAAC;IAChD,OAAO,CAAC,OAAO,CAA2B;IAC1C,SAAS,CAAC,UAAU,iBAAwB;IAC5C,SAAS,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;gBAET,MAAM,EAAE,CAAC,EAAE,OAAO,4BAAoB;IAKlD,IAAW,KAAK,CAAC,MAAM,EAAE,CAAC,EAMzB;IAED,IAAW,KAAK,IAAI,CAAC,CAEpB;IAEM,YAAY,CAAC,SAAS,EAAE,SAAS;IAIjC,eAAe,CAAC,SAAS,EAAE,SAAS;IAIpC,UAAU,IAAI,IAAI;CAK5B"}
+{"version":3,"file":"ref.d.ts","sourceRoot":"","sources":["../src/ref.ts"],"names":[],"mappings":"AAAA,OAAO,UAAU,MAAM,iBAAiB,CAAC;AAEzC,OAAO,EAAE,SAAS,EAAE,MAAM,YAAY,CAAC;AAEvC,MAAM,CAAC,OAAO,OAAO,GAAG,CAAC,CAAC,CAAE,YAAW,UAAU,CAAC,CAAC,CAAC;IAChD,OAAO,CAAC,OAAO,CAA2B;IAC1C,SAAS,CAAC,UAAU,iBAAwB;IAC5C,SAAS,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;gBAET,KAAK,EAAE,CAAC,EAAE,OAAO,4BAAoB;IAKjD,IAAW,KAAK,CAAC,KAAK,EAAE,CAAC,EAMxB;IAED,IAAW,KAAK,IAAI,CAAC,CAEpB;IAEM,YAAY,CAAC,SAAS,EAAE,SAAS;IAIjC,eAAe,CAAC,SAAS,EAAE,SAAS;IAIpC,UAAU,IAAI,IAAI;CAK5B"}