astrocode-workflow 0.3.0 → 0.3.2

package/dist/tools/workflow.js

@@ -1,13 +1,15 @@
 // src/tools/workflow.ts
 import { tool } from "@opencode-ai/plugin/tool";
+import { withTx } from "../state/db";
 import { buildContextSnapshot } from "../workflow/context";
-import { decideNextAction, createRunForStory, startStage, completeRun, getActiveRun, EVENT_TYPES } from "../workflow/state-machine";
+import { decideNextAction, createRunForStory, startStage, completeRun, failRun, getActiveRun, EVENT_TYPES, } from "../workflow/state-machine";
 import { buildStageDirective, directiveHash } from "../workflow/directives";
 import { injectChatPrompt } from "../ui/inject";
 import { nowISO } from "../shared/time";
 import { newEventId } from "../state/ids";
 import { debug } from "../shared/log";
 import { createToastManager } from "../ui/toasts";
+import { acquireRepoLock } from "../state/repo-lock";
 // Agent name mapping for case-sensitive resolution
 export const STAGE_TO_AGENT_MAP = {
     frame: "Frame",
@@ -104,6 +106,46 @@ function buildDelegationPrompt(opts) {
     debug(`Delegating stage ${stage_key} to agent ${stage_agent_name}`, { prompt_length: prompt.length });
     return prompt;
 }
+function buildUiMessage(e) {
+    switch (e.kind) {
+        case "stage_started": {
+            const agent = e.agent_name ? ` (${e.agent_name})` : "";
+            const title = "Astrocode";
+            const message = `Stage started: ${e.stage_key}${agent}`;
+            const chatText = [
+                `[SYSTEM DIRECTIVE: ASTROCODE — STAGE_STARTED]`,
+                ``,
+                `Run: ${e.run_id}`,
+                `Stage: ${e.stage_key}${agent}`,
+            ].join("\n");
+            return { title, message, variant: "info", chatText };
+        }
+        case "run_completed": {
+            const title = "Astrocode";
+            const message = `Run completed: ${e.run_id}`;
+            const chatText = [
+                `[SYSTEM DIRECTIVE: ASTROCODE — RUN_COMPLETED]`,
+                ``,
+                `Run: ${e.run_id}`,
+                `Story: ${e.story_key}`,
+            ].join("\n");
+            return { title, message, variant: "success", chatText };
+        }
+        case "run_failed": {
+            const title = "Astrocode";
+            const message = `Run failed: ${e.run_id} (${e.stage_key})`;
+            const chatText = [
+                `[SYSTEM DIRECTIVE: ASTROCODE — RUN_FAILED]`,
+                ``,
+                `Run: ${e.run_id}`,
+                `Story: ${e.story_key}`,
+                `Stage: ${e.stage_key}`,
+                `Error: ${e.error_text}`,
+            ].join("\n");
+            return { title, message, variant: "error", chatText };
+        }
+    }
+}
 export function createAstroWorkflowProceedTool(opts) {
     const { ctx, config, db, agents } = opts;
     const toasts = createToastManager({ ctx, throttleMs: config.ui.toasts.throttle_ms });
@@ -114,247 +156,200 @@ export function createAstroWorkflowProceedTool(opts) {
             max_steps: tool.schema.number().int().positive().default(config.workflow.default_max_steps),
         },
         execute: async ({ mode, max_steps }) => {
-            const sessionId = ctx.sessionID;
-            const steps = Math.min(max_steps, config.workflow.loop_max_steps_hard_cap);
-            const actions = [];
-            const warnings = [];
-            const startedAt = nowISO();
-            for (let i = 0; i < steps; i++) {
-                const next = decideNextAction(db, config);
-                if (next.kind === "idle") {
-                    actions.push("idle: no approved stories");
-                    break;
-                }
-                if (next.kind === "start_run") {
-                    // NOTE: createRunForStory owns its own tx (state-machine.ts).
-                    const { run_id } = createRunForStory(db, config, next.story_key);
-                    actions.push(`started run ${run_id} for story ${next.story_key}`);
-                    if (config.ui.toasts.enabled && config.ui.toasts.show_run_started) {
-                        await toasts.show({ title: "Astrocode", message: `Run started (${run_id})`, variant: "success" });
+            // Acquire repo lock to ensure no concurrent workflow operations
+            const lockPath = `${ctx.directory}/.astro/astro.lock`;
+            const repoLock = acquireRepoLock(lockPath);
+            try {
+                const sessionId = ctx.sessionID;
+                const steps = Math.min(max_steps, config.workflow.loop_max_steps_hard_cap);
+                const actions = [];
+                const warnings = [];
+                const startedAt = nowISO();
+                // Collect UI events emitted inside state-machine functions, then flush AFTER tx.
+                const uiEvents = [];
+                const emit = (e) => uiEvents.push(e);
+                for (let i = 0; i < steps; i++) {
+                    const next = decideNextAction(db, config);
+                    if (next.kind === "idle") {
+                        actions.push("idle: no approved stories");
+                        break;
                     }
-                    if (sessionId) {
-                        await injectChatPrompt({
-                            ctx,
-                            sessionId,
-                            agent: "Astro",
-                            text: [
-                                `[SYSTEM DIRECTIVE: ASTROCODE — RUN_STARTED]`,
-                                ``,
-                                `Run started: \`${run_id}\``,
-                                `Story: \`${next.story_key}\``,
-                                ``,
-                                `Next: call **astro_workflow_proceed** again to delegate the first stage.`,
-                            ].join("\n"),
-                        });
-                        actions.push(`injected run started message for ${run_id}`);
+                    if (next.kind === "start_run") {
+                        // SINGLE tx boundary: caller owns tx, state-machine is pure.
+                        const { run_id } = withTx(db, () => createRunForStory(db, config, next.story_key));
+                        actions.push(`started run ${run_id} for story ${next.story_key}`);
+                        if (mode === "step")
+                            break;
+                        continue;
                     }
-                    if (mode === "step")
-                        break;
-                    continue;
-                }
-                if (next.kind === "complete_run") {
-                    // NOTE: completeRun owns its own tx (state-machine.ts).
-                    completeRun(db, next.run_id);
-                    actions.push(`completed run ${next.run_id}`);
-                    if (config.ui.toasts.enabled && config.ui.toasts.show_run_completed) {
-                        await toasts.show({ title: "Astrocode", message: `Run completed (${next.run_id})`, variant: "success" });
+                    if (next.kind === "complete_run") {
+                        withTx(db, () => completeRun(db, next.run_id, emit));
+                        actions.push(`completed run ${next.run_id}`);
+                        if (mode === "step")
+                            break;
+                        continue;
                     }
-                    // ✅ explicit injection on completeRun (requested)
-                    if (sessionId) {
-                        await injectChatPrompt({
-                            ctx,
-                            sessionId,
-                            agent: "Astro",
-                            text: [
-                                `[SYSTEM DIRECTIVE: ASTROCODE — RUN_COMPLETED]`,
-                                ``,
-                                `Run \`${next.run_id}\` completed.`,
-                                ``,
-                                `Next: call **astro_workflow_proceed** (mode=step) to start the next approved story (if any).`,
-                            ].join("\n"),
-                        });
-                        actions.push(`injected run completed message for ${next.run_id}`);
+                    if (next.kind === "failed") {
+                        // Ensure DB state reflects failure in one tx; emit UI event.
+                        withTx(db, () => failRun(db, next.run_id, next.stage_key, next.error_text, emit));
+                        actions.push(`failed: ${next.stage_key} — ${next.error_text}`);
+                        if (mode === "step")
+                            break;
+                        continue;
                     }
-                    if (mode === "step")
-                        break;
-                    continue;
-                }
-                if (next.kind === "delegate_stage") {
-                    const active = getActiveRun(db);
-                    if (!active)
-                        throw new Error("Invariant: delegate_stage but no active run.");
-                    const run = db.prepare("SELECT * FROM runs WHERE run_id=?").get(active.run_id);
-                    const story = db.prepare("SELECT * FROM stories WHERE story_key=?").get(run.story_key);
-                    let agentName = resolveAgentName(next.stage_key, config, agents, warnings);
-                    const agentExists = (name) => {
-                        if (agents && agents[name])
-                            return true;
-                        const knownStageAgents = ["Frame", "Plan", "Spec", "Implement", "Review", "Verify", "Close", "General", "Astro", "general"];
-                        if (knownStageAgents.includes(name))
-                            return true;
-                        return false;
-                    };
-                    if (!agentExists(agentName)) {
-                        const originalAgent = agentName;
-                        console.warn(`[Astrocode] Agent ${agentName} not found. Falling back to orchestrator.`);
-                        agentName = config.agents?.orchestrator_name || "Astro";
+                    if (next.kind === "delegate_stage") {
+                        const active = getActiveRun(db);
+                        if (!active)
+                            throw new Error("Invariant: delegate_stage but no active run.");
+                        const run = db.prepare("SELECT * FROM runs WHERE run_id=?").get(active.run_id);
+                        const story = db.prepare("SELECT * FROM stories WHERE story_key=?").get(run.story_key);
+                        let agentName = resolveAgentName(next.stage_key, config, agents, warnings);
+                        const agentExists = (name) => {
+                            if (agents && agents[name])
+                                return true;
+                            const knownStageAgents = ["Frame", "Plan", "Spec", "Implement", "Review", "Verify", "Close", "General", "Astro", "general"];
+                            if (knownStageAgents.includes(name))
+                                return true;
+                            return false;
+                        };
                         if (!agentExists(agentName)) {
-                            console.warn(`[Astrocode] Orchestrator ${agentName} not available. Falling back to General.`);
-                            agentName = "General";
+                            const originalAgent = agentName;
+                            console.warn(`[Astrocode] Agent ${agentName} not found. Falling back to orchestrator.`);
+                            agentName = config.agents?.orchestrator_name || "Astro";
                             if (!agentExists(agentName)) {
-                                throw new Error(`Critical: No agents available for delegation. Primary: ${originalAgent}, Orchestrator: ${config.agents?.orchestrator_name || "Astro"}, General: unavailable`);
+                                console.warn(`[Astrocode] Orchestrator ${agentName} not available. Falling back to General.`);
+                                agentName = "General";
+                                if (!agentExists(agentName)) {
+                                    throw new Error(`Critical: No agents available for delegation. Primary: ${originalAgent}, Orchestrator: ${config.agents?.orchestrator_name || "Astro"}, General: unavailable`);
+                                }
                             }
                         }
-                    }
-                    // NOTE: startStage owns its own tx (state-machine.ts).
-                    startStage(db, active.run_id, next.stage_key, { subagent_type: agentName });
-                    actions.push(`stage started: ${next.stage_key}`);
-                    if (config.ui.toasts.enabled && config.ui.toasts.show_stage_started) {
-                        await toasts.show({ title: "Astrocode", message: `Stage started: ${next.stage_key}`, variant: "info" });
-                    }
-                    // ✅ explicit injection on startStage (requested)
-                    if (sessionId) {
-                        await injectChatPrompt({
-                            ctx,
-                            sessionId,
-                            agent: "Astro",
-                            text: [
-                                `[SYSTEM DIRECTIVE: ASTROCODE — STAGE_STARTED]`,
-                                ``,
-                                `Run: \`${active.run_id}\``,
-                                `Stage: \`${next.stage_key}\``,
-                                `Delegated to: \`${agentName}\``,
-                            ].join("\n"),
+                        // NOTE: startStage owns its own tx (state-machine.ts).
+                        withTx(db, () => {
+                            startStage(db, active.run_id, next.stage_key, { subagent_type: agentName }, emit);
                         });
-                        actions.push(`injected stage started message for ${next.stage_key}`);
-                    }
-                    const context = buildContextSnapshot({
-                        db,
-                        config,
-                        run_id: active.run_id,
-                        next_action: `delegate stage ${next.stage_key}`,
-                    });
-                    const stageDirective = buildStageDirective({
-                        config,
-                        stage_key: next.stage_key,
-                        run_id: active.run_id,
-                        story_key: run.story_key,
-                        story_title: story?.title ?? "(missing)",
-                        stage_agent_name: agentName,
-                        stage_goal: stageGoal(next.stage_key, config),
-                        stage_constraints: stageConstraints(next.stage_key, config),
-                        context_snapshot_md: context,
-                    }).body;
-                    const delegatePrompt = buildDelegationPrompt({
-                        stageDirective,
-                        run_id: active.run_id,
-                        stage_key: next.stage_key,
-                        stage_agent_name: agentName,
-                    });
-                    // Best-effort: continuations table may not exist on older DBs.
-                    try {
+                        const context = buildContextSnapshot({
+                            db,
+                            config,
+                            run_id: active.run_id,
+                            next_action: `delegate stage ${next.stage_key}`,
+                        });
+                        const stageDirective = buildStageDirective({
+                            config,
+                            stage_key: next.stage_key,
+                            run_id: active.run_id,
+                            story_key: run.story_key,
+                            story_title: story?.title ?? "(missing)",
+                            stage_agent_name: agentName,
+                            stage_goal: stageGoal(next.stage_key, config),
+                            stage_constraints: stageConstraints(next.stage_key, config),
+                            context_snapshot_md: context,
+                        }).body;
+                        const delegatePrompt = buildDelegationPrompt({
+                            stageDirective,
+                            run_id: active.run_id,
+                            stage_key: next.stage_key,
+                            stage_agent_name: agentName,
+                        });
+                        // Record continuation (best-effort; no tx wrapper needed but safe either way)
                         const h = directiveHash(delegatePrompt);
                         const now = nowISO();
                         if (sessionId) {
+                            // This assumes continuations table exists in vNext schema.
                             db.prepare("INSERT INTO continuations (session_id, run_id, directive_hash, kind, reason, created_at) VALUES (?, ?, ?, 'stage', ?, ?)").run(sessionId, active.run_id, h, `delegate ${next.stage_key}`, now);
                         }
+                        // Visible injection so user can see state (awaited)
+                        if (sessionId) {
+                            await injectChatPrompt({ ctx, sessionId, text: delegatePrompt, agent: "Astro" });
+                            const continueMessage = [
+                                `[SYSTEM DIRECTIVE: ASTROCODE — AWAIT_STAGE_COMPLETION]`,
+                                ``,
+                                `Stage \`${next.stage_key}\` delegated to \`${agentName}\`.`,
+                                ``,
+                                `When \`${agentName}\` completes, call:`,
+                                `astro_stage_complete(run_id="${active.run_id}", stage_key="${next.stage_key}", output_text="[paste subagent output here]")`,
+                                ``,
+                                `This advances the workflow.`,
+                            ].join("\n");
+                            await injectChatPrompt({ ctx, sessionId, text: continueMessage, agent: "Astro" });
+                        }
+                        actions.push(`delegated stage ${next.stage_key} via ${agentName}`);
+                        // Stop here; subagent needs to run.
+                        break;
                     }
-                    catch (e) {
-                        warnings.push(`continuations insert failed (non-fatal): ${String(e)}`);
-                    }
-                    // Visible injection so user can see state
-                    if (sessionId) {
-                        await injectChatPrompt({ ctx, sessionId, text: delegatePrompt, agent: "Astro" });
-                        const continueMessage = [
-                            `[SYSTEM DIRECTIVE: ASTROCODE — AWAIT_STAGE_COMPLETION]`,
-                            ``,
-                            `Stage \`${next.stage_key}\` delegated to \`${agentName}\`.`,
-                            ``,
-                            `When \`${agentName}\` completes, call:`,
-                            `astro_stage_complete(run_id="${active.run_id}", stage_key="${next.stage_key}", output_text="[paste subagent output here]")`,
-                            ``,
-                            `Then run **astro_workflow_proceed** again.`,
-                        ].join("\n");
-                        await injectChatPrompt({ ctx, sessionId, text: continueMessage, agent: "Astro" });
-                    }
-                    actions.push(`delegated stage ${next.stage_key} via ${agentName}`);
-                    // Stop here; subagent needs to run.
-                    break;
-                }
-                if (next.kind === "await_stage_completion") {
-                    actions.push(`await stage completion: ${next.stage_key}`);
-                    if (sessionId) {
-                        const context = buildContextSnapshot({
-                            db,
-                            config,
-                            run_id: next.run_id,
-                            next_action: `complete stage ${next.stage_key}`,
-                        });
-                        const prompt = [
-                            `[SYSTEM DIRECTIVE: ASTROCODE — AWAIT_STAGE_OUTPUT]`,
-                            ``,
-                            `Run \`${next.run_id}\` is waiting for stage \`${next.stage_key}\` output.`,
-                            `If you have the subagent output, call astro_stage_complete with output_text=the FULL output.`,
-                            ``,
-                            `Context snapshot:`,
-                            context,
-                        ].join("\n").trim();
-                        try {
+                    if (next.kind === "await_stage_completion") {
+                        actions.push(`await stage completion: ${next.stage_key}`);
+                        if (sessionId) {
+                            const context = buildContextSnapshot({
+                                db,
+                                config,
+                                run_id: next.run_id,
+                                next_action: `complete stage ${next.stage_key}`,
+                            });
+                            const prompt = [
+                                `[SYSTEM DIRECTIVE: ASTROCODE — AWAIT_STAGE_OUTPUT]`,
+                                ``,
+                                `Run \`${next.run_id}\` is waiting for stage \`${next.stage_key}\` output.`,
+                                `If you have the subagent output, call astro_stage_complete with output_text=the FULL output.`,
+                                ``,
+                                `Context snapshot:`,
+                                context,
+                            ].join("\n").trim();
                             const h = directiveHash(prompt);
                             const now = nowISO();
                             db.prepare("INSERT INTO continuations (session_id, run_id, directive_hash, kind, reason, created_at) VALUES (?, ?, ?, 'continue', ?, ?)").run(sessionId, next.run_id, h, `await ${next.stage_key}`, now);
+                            await injectChatPrompt({ ctx, sessionId, text: prompt, agent: "Astro" });
                         }
-                        catch (e) {
-                            warnings.push(`continuations insert failed (non-fatal): ${String(e)}`);
-                        }
-                        await injectChatPrompt({ ctx, sessionId, text: prompt, agent: "Astro" });
+                        break;
                     }
+                    actions.push(`unhandled next action: ${next.kind}`);
                     break;
                 }
-                if (next.kind === "failed") {
-                    actions.push(`failed: ${next.stage_key} — ${next.error_text}`);
-                    if (sessionId) {
-                        await injectChatPrompt({
-                            ctx,
-                            sessionId,
-                            agent: "Astro",
-                            text: [
-                                `[SYSTEM DIRECTIVE: ASTROCODE — RUN_FAILED]`,
-                                ``,
-                                `Run \`${next.run_id}\` failed at stage \`${next.stage_key}\`.`,
-                                `Error: ${next.error_text}`,
-                            ].join("\n"),
-                        });
-                        actions.push(`injected run failed message for ${next.run_id}`);
+                // Flush UI events (toast + prompt) AFTER state transitions
+                if (uiEvents.length > 0) {
+                    for (const e of uiEvents) {
+                        const msg = buildUiMessage(e);
+                        if (config.ui.toasts.enabled) {
+                            await toasts.show({
+                                title: msg.title,
+                                message: msg.message,
+                                variant: msg.variant,
+                            });
+                        }
+                        if (ctx?.sessionID) {
+                            await injectChatPrompt({
+                                ctx,
+                                sessionId: ctx.sessionID,
+                                text: msg.chatText,
+                                agent: "Astro",
+                            });
+                        }
                     }
-                    break;
+                    actions.push(`ui: flushed ${uiEvents.length} event(s)`);
                 }
-                actions.push(`unhandled next action: ${next.kind}`);
-                break;
-            }
-            // Housekeeping event (best-effort)
-            try {
+                // Housekeeping event
                 db.prepare("INSERT INTO events (event_id, run_id, stage_key, type, body_json, created_at) VALUES (?, NULL, NULL, ?, ?, ?)").run(newEventId(), EVENT_TYPES.WORKFLOW_PROCEED, JSON.stringify({ started_at: startedAt, mode, max_steps: steps, actions }), nowISO());
+                const active = getActiveRun(db);
+                const lines = [];
+                lines.push(`# astro_workflow_proceed`);
+                lines.push(`- mode: ${mode}`);
+                lines.push(`- steps requested: ${max_steps} (cap=${steps})`);
+                if (active)
+                    lines.push(`- active run: \`${active.run_id}\` (stage=${active.current_stage_key ?? "?"})`);
+                lines.push(``, `## Actions`);
+                for (const a of actions)
+                    lines.push(`- ${a}`);
+                if (warnings.length > 0) {
+                    lines.push(``, `## Warnings`);
+                    for (const w of warnings)
+                        lines.push(`⚠️ ${w}`);
+                }
+                return lines.join("\n").trim();
             }
-            catch (e) {
-                warnings.push(`workflow.proceed event insert failed (non-fatal): ${String(e)}`);
-            }
-            const active = getActiveRun(db);
-            const lines = [];
-            lines.push(`# astro_workflow_proceed`);
-            lines.push(`- mode: ${mode}`);
-            lines.push(`- steps requested: ${max_steps} (cap=${steps})`);
-            if (active)
-                lines.push(`- active run: \`${active.run_id}\` (stage=${active.current_stage_key ?? "?"})`);
-            lines.push(``, `## Actions`);
-            for (const a of actions)
-                lines.push(`- ${a}`);
-            if (warnings.length > 0) {
-                lines.push(``, `## Warnings`);
-                for (const w of warnings)
-                    lines.push(`⚠️ ${w}`);
+            finally {
+                // Always release the lock
+                repoLock.release();
             }
-            return lines.join("\n").trim();
         },
     });
 }

package/dist/ui/inject.d.ts

@@ -1,3 +1,9 @@
+/**
+ * Inject a visible prompt into the conversation.
+ * - Deterministic ordering per session
+ * - Correct SDK binding (prevents `this._client` undefined)
+ * - Awaitable: resolves when delivered, rejects after max retries
+ */
 export declare function injectChatPrompt(opts: {
     ctx: any;
     sessionId?: string;