astrocode-workflow 0.1.59 → 0.3.0

package/dist/tools/workflow.js

@@ -1,5 +1,5 @@
+// src/tools/workflow.ts
 import { tool } from "@opencode-ai/plugin/tool";
-import { withTx } from "../state/db";
 import { buildContextSnapshot } from "../workflow/context";
 import { decideNextAction, createRunForStory, startStage, completeRun, getActiveRun, EVENT_TYPES } from "../workflow/state-machine";
 import { buildStageDirective, directiveHash } from "../workflow/directives";
@@ -31,24 +31,20 @@ export function resolveAgentName(stageKey, config, agents, warnings) {
     // Validate that the agent actually exists in the registry
     if (agents && !agents[candidate]) {
         const warning = `Agent "${candidate}" not found in registry for stage "${stageKey}". Falling back to General.`;
-        if (warnings) {
+        if (warnings)
             warnings.push(warning);
-        }
-        else {
+        else
             console.warn(`[Astrocode] ${warning}`);
-        }
         candidate = "General";
     }
     // Final guard: ensure General exists, fallback to built-in "general" if not
     if (agents && !agents[candidate]) {
         const finalWarning = `Critical: General agent not found in registry. Falling back to built-in "general".`;
-        if (warnings) {
+        if (warnings)
             warnings.push(finalWarning);
-        }
-        else {
+        else
             console.warn(`[Astrocode] ${finalWarning}`);
-        }
-        return "general"; // built-in, guaranteed by OpenCode
+        return "general";
     }
     return candidate;
 }
@@ -84,9 +80,6 @@ function stageConstraints(stage, cfg) {
     }
     return common;
 }
-function agentNameForStage(stage, cfg) {
-    return cfg.agents.stage_agent_names[stage];
-}
 function buildDelegationPrompt(opts) {
     const { stageDirective, run_id, stage_key, stage_agent_name } = opts;
     const stageUpper = stage_key.toUpperCase();
@@ -108,7 +101,6 @@ function buildDelegationPrompt(opts) {
         ``,
         `Important: do NOT do any stage work yourself in orchestrator mode.`,
     ].join("\n").trim();
-    // Debug log the delegation prompt to troubleshoot agent output issues
     debug(`Delegating stage ${stage_key} to agent ${stage_agent_name}`, { prompt_length: prompt.length });
     return prompt;
 }
@@ -134,59 +126,54 @@ export function createAstroWorkflowProceedTool(opts) {
                     break;
                 }
                 if (next.kind === "start_run") {
-                    const { run_id } = withTx(db, () => createRunForStory(db, config, next.story_key));
+                    // NOTE: createRunForStory owns its own tx (state-machine.ts).
+                    const { run_id } = createRunForStory(db, config, next.story_key);
                     actions.push(`started run ${run_id} for story ${next.story_key}`);
                     if (config.ui.toasts.enabled && config.ui.toasts.show_run_started) {
                         await toasts.show({ title: "Astrocode", message: `Run started (${run_id})`, variant: "success" });
                     }
+                    if (sessionId) {
+                        await injectChatPrompt({
+                            ctx,
+                            sessionId,
+                            agent: "Astro",
+                            text: [
+                                `[SYSTEM DIRECTIVE: ASTROCODE — RUN_STARTED]`,
+                                ``,
+                                `Run started: \`${run_id}\``,
+                                `Story: \`${next.story_key}\``,
+                                ``,
+                                `Next: call **astro_workflow_proceed** again to delegate the first stage.`,
+                            ].join("\n"),
+                        });
+                        actions.push(`injected run started message for ${run_id}`);
+                    }
                     if (mode === "step")
                         break;
                     continue;
                 }
                 if (next.kind === "complete_run") {
-                    withTx(db, () => completeRun(db, next.run_id));
+                    // NOTE: completeRun owns its own tx (state-machine.ts).
+                    completeRun(db, next.run_id);
                     actions.push(`completed run ${next.run_id}`);
                     if (config.ui.toasts.enabled && config.ui.toasts.show_run_completed) {
                         await toasts.show({ title: "Astrocode", message: `Run completed (${next.run_id})`, variant: "success" });
                     }
-                    // Inject continuation directive for workflow resumption
+                    // ✅ explicit injection on completeRun (requested)
                     if (sessionId) {
-                        const continueDirective = [
-                            `[SYSTEM DIRECTIVE: ASTROCODE — CONTINUE]`,
-                            ``,
-                            `Run ${next.run_id} completed successfully.`,
-                            ``,
-                            `The Clara Forms implementation run has finished all stages. The spec has been analyzed and decomposed into prioritized implementation stories.`,
-                            ``,
-                            `Next actions: Review the generated stories and approve the next one to continue development.`,
-                        ].join("\n");
-                        await injectChatPrompt({
-                            ctx,
-                            sessionId,
-                            text: continueDirective,
-                            agent: "Astro"
-                        });
-                        actions.push(`injected continuation directive for completed run ${next.run_id}`);
-                    }
-                    // Check for next approved story to start
-                    const nextStory = db.prepare("SELECT story_key, title FROM stories WHERE state = 'approved' ORDER BY priority DESC, created_at ASC LIMIT 1").get();
-                    if (nextStory && sessionId) {
-                        const nextDirective = [
-                            `[SYSTEM DIRECTIVE: ASTROCODE — START_NEXT_STORY]`,
-                            ``,
-                            `The previous run completed successfully. Start the next approved story.`,
-                            ``,
-                            `Next Story: ${nextStory.story_key} — ${nextStory.title}`,
-                            ``,
-                            `Action: Call astro_story_approve with story_key="${nextStory.story_key}" to start it, or select a different story.`,
-                        ].join("\n");
                         await injectChatPrompt({
                             ctx,
                             sessionId,
-                            text: nextDirective,
-                            agent: "Astro"
+                            agent: "Astro",
+                            text: [
+                                `[SYSTEM DIRECTIVE: ASTROCODE — RUN_COMPLETED]`,
+                                ``,
+                                `Run \`${next.run_id}\` completed.`,
+                                ``,
+                                `Next: call **astro_workflow_proceed** (mode=step) to start the next approved story (if any).`,
+                            ].join("\n"),
                         });
-                        actions.push(`injected directive to start next story ${nextStory.story_key}`);
+                        actions.push(`injected run completed message for ${next.run_id}`);
                     }
                     if (mode === "step")
                         break;
@@ -198,53 +185,55 @@ export function createAstroWorkflowProceedTool(opts) {
                         throw new Error("Invariant: delegate_stage but no active run.");
                     const run = db.prepare("SELECT * FROM runs WHERE run_id=?").get(active.run_id);
                     const story = db.prepare("SELECT * FROM stories WHERE story_key=?").get(run.story_key);
-                    // Mark stage started + set subagent_type to the stage agent.
                     let agentName = resolveAgentName(next.stage_key, config, agents, warnings);
-                    // Validate agent availability with fallback chain
-                    const systemConfig = config;
-                    // Check both the system config agent map (if present) OR the local agents map passed to the tool
                     const agentExists = (name) => {
-                        // Check local agents map first (populated from src/index.ts)
-                        if (agents && agents[name]) {
+                        if (agents && agents[name])
                             return true;
-                        }
-                        // Check system config agent map
-                        if (systemConfig.agent && systemConfig.agent[name]) {
-                            return true;
-                        }
-                        // For known stage agents, assume they exist (they are system-provided subagents)
-                        const knownStageAgents = ["Frame", "Plan", "Spec", "Implement", "Review", "Verify", "Close"];
-                        if (knownStageAgents.includes(name)) {
+                        const knownStageAgents = ["Frame", "Plan", "Spec", "Implement", "Review", "Verify", "Close", "General", "Astro", "general"];
+                        if (knownStageAgents.includes(name))
                             return true;
-                        }
                         return false;
                     };
                     if (!agentExists(agentName)) {
                         const originalAgent = agentName;
-                        console.warn(`[Astrocode] Agent ${agentName} not found in config. Falling back to orchestrator.`);
-                        // First fallback: orchestrator
+                        console.warn(`[Astrocode] Agent ${agentName} not found. Falling back to orchestrator.`);
                         agentName = config.agents?.orchestrator_name || "Astro";
                         if (!agentExists(agentName)) {
                             console.warn(`[Astrocode] Orchestrator ${agentName} not available. Falling back to General.`);
-                            // Final fallback: General (guaranteed to exist)
                             agentName = "General";
                             if (!agentExists(agentName)) {
                                 throw new Error(`Critical: No agents available for delegation. Primary: ${originalAgent}, Orchestrator: ${config.agents?.orchestrator_name || "Astro"}, General: unavailable`);
                             }
                         }
                     }
-                    withTx(db, () => {
-                        startStage(db, active.run_id, next.stage_key, { subagent_type: agentName });
-                        // Log delegation observability
-                        if (config.debug?.telemetry?.enabled) {
-                            // eslint-disable-next-line no-console
-                            console.log(`[Astrocode:delegate] run_id=${active.run_id} stage=${next.stage_key} agent=${agentName} fallback=${agentName !== resolveAgentName(next.stage_key, config, agents) ? 'yes' : 'no'}`);
-                        }
-                    });
+                    // NOTE: startStage owns its own tx (state-machine.ts).
+                    startStage(db, active.run_id, next.stage_key, { subagent_type: agentName });
+                    actions.push(`stage started: ${next.stage_key}`);
                     if (config.ui.toasts.enabled && config.ui.toasts.show_stage_started) {
                         await toasts.show({ title: "Astrocode", message: `Stage started: ${next.stage_key}`, variant: "info" });
                     }
-                    const context = buildContextSnapshot({ db, config, run_id: active.run_id, next_action: `delegate stage ${next.stage_key}` });
+                    // ✅ explicit injection on startStage (requested)
+                    if (sessionId) {
+                        await injectChatPrompt({
+                            ctx,
+                            sessionId,
+                            agent: "Astro",
+                            text: [
+                                `[SYSTEM DIRECTIVE: ASTROCODE — STAGE_STARTED]`,
+                                ``,
+                                `Run: \`${active.run_id}\``,
+                                `Stage: \`${next.stage_key}\``,
+                                `Delegated to: \`${agentName}\``,
+                            ].join("\n"),
+                        });
+                        actions.push(`injected stage started message for ${next.stage_key}`);
+                    }
+                    const context = buildContextSnapshot({
+                        db,
+                        config,
+                        run_id: active.run_id,
+                        next_action: `delegate stage ${next.stage_key}`,
+                    });
                     const stageDirective = buildStageDirective({
                         config,
                         stage_key: next.stage_key,
@@ -262,25 +251,29 @@ export function createAstroWorkflowProceedTool(opts) {
                         stage_key: next.stage_key,
                         stage_agent_name: agentName,
                     });
-                    // Record in continuations as a stage directive (dedupe by hash)
-                    const h = directiveHash(delegatePrompt);
-                    const now = nowISO();
-                    if (sessionId) {
-                        db.prepare("INSERT INTO continuations (session_id, run_id, directive_hash, kind, reason, created_at) VALUES (?, ?, ?, 'stage', ?, ?)").run(sessionId, active.run_id, h, `delegate ${next.stage_key}`, now);
+                    // Best-effort: continuations table may not exist on older DBs.
+                    try {
+                        const h = directiveHash(delegatePrompt);
+                        const now = nowISO();
+                        if (sessionId) {
+                            db.prepare("INSERT INTO continuations (session_id, run_id, directive_hash, kind, reason, created_at) VALUES (?, ?, ?, 'stage', ?, ?)").run(sessionId, active.run_id, h, `delegate ${next.stage_key}`, now);
+                        }
+                    }
+                    catch (e) {
+                        warnings.push(`continuations insert failed (non-fatal): ${String(e)}`);
                     }
                     // Visible injection so user can see state
                     if (sessionId) {
                         await injectChatPrompt({ ctx, sessionId, text: delegatePrompt, agent: "Astro" });
-                        // Inject continuation guidance
                         const continueMessage = [
                             `[SYSTEM DIRECTIVE: ASTROCODE — AWAIT_STAGE_COMPLETION]`,
                             ``,
-                            `Stage ${next.stage_key} delegated to ${agentName}.`,
+                            `Stage \`${next.stage_key}\` delegated to \`${agentName}\`.`,
                             ``,
-                            `When ${agentName} completes, call:`,
+                            `When \`${agentName}\` completes, call:`,
                             `astro_stage_complete(run_id="${active.run_id}", stage_key="${next.stage_key}", output_text="[paste subagent output here]")`,
                             ``,
-                            `This advances the workflow.`,
+                            `Then run **astro_workflow_proceed** again.`,
                         ].join("\n");
                         await injectChatPrompt({ ctx, sessionId, text: continueMessage, agent: "Astro" });
                     }
@@ -290,35 +283,62 @@ export function createAstroWorkflowProceedTool(opts) {
                 }
                 if (next.kind === "await_stage_completion") {
                     actions.push(`await stage completion: ${next.stage_key}`);
-                    // Optionally nudge with a short directive
                     if (sessionId) {
-                        const context = buildContextSnapshot({ db, config, run_id: next.run_id, next_action: `complete stage ${next.stage_key}` });
+                        const context = buildContextSnapshot({
+                            db,
+                            config,
+                            run_id: next.run_id,
+                            next_action: `complete stage ${next.stage_key}`,
+                        });
                         const prompt = [
                             `[SYSTEM DIRECTIVE: ASTROCODE — AWAIT_STAGE_OUTPUT]`,
                             ``,
-                            `Run ${next.run_id} is waiting for stage ${next.stage_key} output.`,
+                            `Run \`${next.run_id}\` is waiting for stage \`${next.stage_key}\` output.`,
                             `If you have the subagent output, call astro_stage_complete with output_text=the FULL output.`,
                             ``,
                             `Context snapshot:`,
                             context,
                         ].join("\n").trim();
-                        const h = directiveHash(prompt);
-                        const now = nowISO();
-                        db.prepare("INSERT INTO continuations (session_id, run_id, directive_hash, kind, reason, created_at) VALUES (?, ?, ?, 'continue', ?, ?)").run(sessionId, next.run_id, h, `await ${next.stage_key}`, now);
+                        try {
+                            const h = directiveHash(prompt);
+                            const now = nowISO();
+                            db.prepare("INSERT INTO continuations (session_id, run_id, directive_hash, kind, reason, created_at) VALUES (?, ?, ?, 'continue', ?, ?)").run(sessionId, next.run_id, h, `await ${next.stage_key}`, now);
+                        }
+                        catch (e) {
+                            warnings.push(`continuations insert failed (non-fatal): ${String(e)}`);
+                        }
                         await injectChatPrompt({ ctx, sessionId, text: prompt, agent: "Astro" });
                     }
                     break;
                 }
                 if (next.kind === "failed") {
                     actions.push(`failed: ${next.stage_key} — ${next.error_text}`);
+                    if (sessionId) {
+                        await injectChatPrompt({
+                            ctx,
+                            sessionId,
+                            agent: "Astro",
+                            text: [
+                                `[SYSTEM DIRECTIVE: ASTROCODE — RUN_FAILED]`,
+                                ``,
+                                `Run \`${next.run_id}\` failed at stage \`${next.stage_key}\`.`,
+                                `Error: ${next.error_text}`,
+                            ].join("\n"),
+                        });
+                        actions.push(`injected run failed message for ${next.run_id}`);
+                    }
                     break;
                 }
-                // safety
                 actions.push(`unhandled next action: ${next.kind}`);
                 break;
             }
-            // Housekeeping event
-            db.prepare("INSERT INTO events (event_id, run_id, stage_key, type, body_json, created_at) VALUES (?, NULL, NULL, ?, ?, ?)").run(newEventId(), EVENT_TYPES.WORKFLOW_PROCEED, JSON.stringify({ started_at: startedAt, mode, max_steps: steps, actions }), nowISO());
+            // Housekeeping event (best-effort)
+            try {
+                db.prepare("INSERT INTO events (event_id, run_id, stage_key, type, body_json, created_at) VALUES (?, NULL, NULL, ?, ?, ?)").run(newEventId(), EVENT_TYPES.WORKFLOW_PROCEED, JSON.stringify({ started_at: startedAt, mode, max_steps: steps, actions }), nowISO());
+            }
+            catch (e) {
+                warnings.push(`workflow.proceed event insert failed (non-fatal): ${String(e)}`);
+            }
             const active = getActiveRun(db);
             const lines = [];
             lines.push(`# astro_workflow_proceed`);

package/dist/ui/inject.d.ts

@@ -1,6 +1,6 @@
 export declare function injectChatPrompt(opts: {
     ctx: any;
-    sessionId: string;
+    sessionId?: string;
     text: string;
     agent?: string;
 }): Promise<void>;

package/dist/ui/inject.js

@@ -1,47 +1,88 @@
+// src/ui/inject.ts
 let isInjecting = false;
 const injectionQueue = [];
+function sleep(ms) {
+    return new Promise((r) => setTimeout(r, ms));
+}
+function resolveSessionId(ctx, sessionId) {
+    if (sessionId)
+        return sessionId;
+    const direct = ctx?.sessionID ?? ctx?.sessionId ?? ctx?.session?.id;
+    if (typeof direct === "string" && direct.length > 0)
+        return direct;
+    return null;
+}
+async function tryInjectOnce(opts) {
+    const { ctx, sessionId, text, agent } = opts;
+    // Prefer explicit chat prompt API
+    const promptApi = ctx?.client?.session?.prompt;
+    if (!promptApi) {
+        throw new Error("API not available (ctx.client.session.prompt)");
+    }
+    const prefixedText = `[${agent}]\n\n${text}`;
+    // Some hosts reject unknown fields; keep body minimal and stable.
+    await promptApi({
+        path: { id: sessionId },
+        body: {
+            parts: [{ type: "text", text: prefixedText }],
+        },
+    });
+}
 async function processQueue() {
-    if (isInjecting || injectionQueue.length === 0)
+    if (isInjecting)
         return;
-    isInjecting = true;
-    const opts = injectionQueue.shift();
-    if (!opts) {
-        isInjecting = false;
+    if (injectionQueue.length === 0)
         return;
-    }
+    isInjecting = true;
     try {
-        const { ctx, sessionId, text, agent = "Astro" } = opts;
-        const prefixedText = `[${agent}]\n\n${text}`;
-        // Basic validation
-        if (!sessionId) {
-            console.warn("[Astrocode] Skipping injection: No sessionId provided");
-            return;
-        }
-        if (!ctx?.client?.session?.prompt) {
-            console.warn("[Astrocode] Skipping injection: API not available (ctx.client.session.prompt)");
-            return;
+        while (injectionQueue.length > 0) {
+            const item = injectionQueue.shift();
+            if (!item)
+                continue;
+            const { ctx, text, agent = "Astro" } = item;
+            const sessionId = resolveSessionId(ctx, item.sessionId);
+            if (!sessionId) {
+                // Drop on floor: we cannot recover without a session id.
+                // Keep draining the queue so we don't stall.
+                // eslint-disable-next-line no-console
+                console.warn("[Astrocode] Injection skipped: no sessionId");
+                continue;
+            }
+            const maxAttempts = item.retry?.maxAttempts ?? 4;
+            const baseDelayMs = item.retry?.baseDelayMs ?? 250;
+            let lastErr = null;
+            for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+                try {
+                    await tryInjectOnce({ ctx, sessionId, text, agent });
+                    lastErr = null;
+                    break;
+                }
+                catch (e) {
+                    lastErr = e;
+                    const delay = baseDelayMs * Math.pow(2, attempt - 1); // 250, 500, 1000, 2000
+                    // eslint-disable-next-line no-console
+                    console.warn(`[Astrocode] Injection attempt ${attempt}/${maxAttempts} failed: ${String(e)}; retrying in ${delay}ms`);
+                    await sleep(delay);
+                }
+            }
+            if (lastErr) {
+                // eslint-disable-next-line no-console
+                console.warn(`[Astrocode] Injection failed permanently after ${maxAttempts} attempts: ${String(lastErr)}`);
+            }
         }
-        await ctx.client.session.prompt({
-            path: { id: sessionId },
-            body: {
-                parts: [{ type: "text", text: prefixedText }],
-                // Pass agent context for systems that support it
-                agent: agent,
-            },
-        });
-    }
-    catch (error) {
-        console.warn(`[Astrocode] Injection failed: ${error}`);
     }
     finally {
         isInjecting = false;
-        // Process next item immediately
-        if (injectionQueue.length > 0) {
-            setImmediate(processQueue);
-        }
     }
 }
 export async function injectChatPrompt(opts) {
-    injectionQueue.push(opts);
-    processQueue();
+    injectionQueue.push({
+        ctx: opts.ctx,
+        sessionId: opts.sessionId,
+        text: opts.text,
+        agent: opts.agent ?? "Astro",
+        retry: { maxAttempts: 4, baseDelayMs: 250 },
+    });
+    // Fire-and-forget; queue drain is serialized by isInjecting.
+    void processQueue();
 }

package/dist/workflow/state-machine.d.ts

@@ -1,6 +1,7 @@
 import type { AstrocodeConfig } from "../config/schema";
 import type { SqliteDb } from "../state/db";
 import type { RunRow, StageKey, StageRunRow, StoryRow } from "../state/types";
+import type { ToastOptions } from "../ui/toasts";
 export declare const EVENT_TYPES: {
     readonly RUN_STARTED: "run.started";
     readonly RUN_COMPLETED: "run.completed";
@@ -10,23 +11,28 @@ export declare const EVENT_TYPES: {
     readonly STAGE_STARTED: "stage.started";
     readonly WORKFLOW_PROCEED: "workflow.proceed";
 };
+/**
+ * UI HOOKS
+ * --------
+ * This workflow module is DB-first. UI emission is optional and happens AFTER the DB tx commits.
+ *
+ * Contract:
+ * - If you pass ui.ctx + ui.sessionId, we will inject a visible chat message deterministically.
+ * - If you pass ui.toast, we will also toast (throttling is handled by the toast manager).
+ */
+export type WorkflowUi = {
+    ctx: any;
+    sessionId: string;
+    agentName?: string;
+    toast?: (t: ToastOptions) => Promise<void>;
+};
 /**
  * PLANNING-FIRST REDESIGN
  * ----------------------
- * Old behavior: mutate an approved story into a planning/decomposition instruction.
- * New behavior: NEVER mutate story title/body.
- *
- * Planning-first is a run-scoped directive stored in `injects` (scope = run:<run_id>).
- *
- * Deterministic trigger (config-driven):
- * - config.workflow.genesis_planning:
- *    - "off"             => never attach directive
- *    - "first_story_only"=> attach only when story_key === "S-0001"
- *    - "always"          => attach for every run
- *
- * Contract: DB is already initialized before workflow is used:
- * - schema tables exist
- * - repo_state singleton row (id=1) exists
+ * - Never mutate story title/body.
+ * - Planning-first becomes a run-scoped inject stored in `injects` (scope = run:<run_id>).
+ * - Trigger is deterministic via config.workflow.genesis_planning:
+ *    - "off" | "first_story_only" | "always"
  */
 export type NextAction = {
     kind: "idle";
@@ -61,10 +67,20 @@ export declare function decideNextAction(db: SqliteDb, config: AstrocodeConfig):
 export declare function createRunForStory(db: SqliteDb, config: AstrocodeConfig, storyKey: string): {
     run_id: string;
 };
+/**
+ * STAGE MOVEMENT (START) — now async so UI injection is deterministic.
+ */
 export declare function startStage(db: SqliteDb, runId: string, stageKey: StageKey, meta?: {
     subagent_type?: string;
     subagent_session_id?: string;
-}): void;
-export declare function completeRun(db: SqliteDb, runId: string): void;
-export declare function failRun(db: SqliteDb, runId: string, stageKey: StageKey, errorText: string): void;
+    ui?: WorkflowUi;
+}): Promise<void>;
+/**
+ * STAGE CLOSED (RUN COMPLETED) — now async so UI injection is deterministic.
+ */
+export declare function completeRun(db: SqliteDb, runId: string, ui?: WorkflowUi): Promise<void>;
+/**
+ * STAGE CLOSED (RUN FAILED) — now async so UI injection is deterministic.
+ */
+export declare function failRun(db: SqliteDb, runId: string, stageKey: StageKey, errorText: string, ui?: WorkflowUi): Promise<void>;
 export declare function abortRun(db: SqliteDb, runId: string, reason: string): void;