assistme 0.8.6 → 0.8.8

package/dist/{chunk-ZBZWNZVA.js → chunk-T3DBLWUW.js}

@@ -2878,6 +2878,8 @@ var SkillManager = class {
   userId = null;
   /** Tracks the in-flight loadFromDb() promise so callers can await it. */
   loadPromise = null;
+  /** True once loadFromDb() completes without error (even with 0 skills). */
+  loaded = false;
   /** Bounded cache for findRelevant() — keyed by normalized prompt, invalidated on skill changes. */
   relevanceCache = new LRUCache(MAX_RELEVANCE_CACHE_ENTRIES);
   /** Bounded, TTL-aware cache for marketplace discover results. */
@@ -2896,11 +2898,31 @@ var SkillManager = class {
     }
   }
   /**
-   * Wait for any in-flight loadFromDb() to finish.
-   * Safe to call multiple times — resolves immediately if no load is pending.
+   * Guarantee that loadFromDb() has completed at least once.
+   * Awaits any in-flight load; retries once if the initial load failed.
+   * Safe and cheap to call repeatedly — no-ops after the first success.
    */
   async ensureLoaded() {
     if (this.loadPromise) await this.loadPromise;
+    if (!this.loaded && this.userId) {
+      await this.loadFromDb();
+    }
+  }
+  /**
+   * Get a skill by name, with a DB search fallback.
+   * Handles: race conditions, failed initial loads, and skills added externally
+   * after the initial load (e.g. created via UI while agent is running).
+   */
+  async getWithDbFallback(name) {
+    await this.ensureLoaded();
+    const skill = this.skills.get(name);
+    if (skill) return skill;
+    const dbResults = await searchSkillsInDb(name, 5);
+    const match = dbResults?.find((r) => r.name === name);
+    if (!match) return void 0;
+    this.loaded = false;
+    await this.loadFromDb();
+    return this.skills.get(name);
   }
   async _doLoadFromDb() {
     try {
@@ -2912,6 +2934,7 @@ var SkillManager = class {
         this.skills.set(row.name, this.rowToSkill(row));
       }
       this.rebuildIdfCache();
+      this.loaded = true;
       if (this.skills.size > 0) {
         log.info(`Loaded ${this.skills.size} skill(s) from DB`);
       }
@@ -3711,6 +3734,7 @@ export {
   executeShell,
   MemoryManager,
   LRUCache,
+  upsertAgentSkill,
   SkillManager,
   getLocalStore,
   getCredentialStore

package/dist/index.js

@@ -27,7 +27,7 @@ import {
   setSessionBusy,
   toggleScheduledTask,
   updateHeartbeat
-} from "./chunk-ZBZWNZVA.js";
+} from "./chunk-T3DBLWUW.js";
 import {
   HEARTBEAT_INTERVAL_MS,
   HEARTBEAT_LOG_MAX_ENTRIES,

package/dist/workers/entry.js

@@ -18,8 +18,9 @@ import {
   getNextRunTime,
   pollActionResponse,
   resetEventSequence,
-  setActionRequest
-} from "../chunk-ZBZWNZVA.js";
+  setActionRequest,
+  upsertAgentSkill
+} from "../chunk-T3DBLWUW.js";
 import {
   EDSGER_PRODUCT_SLUG,
   JobRunner,
@@ -1779,25 +1780,26 @@ function createAgentToolsServer(deps) {
         },
         async (args) => {
           await skillManager.ensureLoaded();
-          const existing = skillManager.get(args.name);
-          if (!existing) {
-            const available = skillManager.getAll().map((s) => s.name).join(", ");
+          if (skillManager.update(args.name, args.improved_instructions, args.description)) {
+            log.success(`Self-improvement: improved skill "${args.name}"`);
             return {
               content: [
                 {
                   type: "text",
-                  text: `Skill "${args.name}" not found. Available skills: ${available}`
+                  text: `Skill "${args.name}" improved and version bumped.`
                 }
               ]
             };
           }
-          const updated = skillManager.update(
-            args.name,
-            args.improved_instructions,
-            args.description
-          );
-          if (updated) {
-            log.success(`Self-improvement: improved skill "${args.name}"`);
+          const result = await upsertAgentSkill({
+            name: args.name,
+            description: args.description || "",
+            content: args.improved_instructions,
+            version: "1.0.1",
+            source: "auto_improved"
+          });
+          if (result) {
+            log.success(`Self-improvement: improved skill "${args.name}" (direct DB)`);
             return {
               content: [
                 {
@@ -1825,8 +1827,7 @@ function createAgentToolsServer(deps) {
           arguments: z2.string().optional().describe("Arguments to pass to the skill (replaces $ARGUMENTS placeholders)")
         },
         async (args) => {
-          await skillManager.ensureLoaded();
-          let skill = skillManager.get(args.name);
+          let skill = await skillManager.getWithDbFallback(args.name);
           if (!skill) {
             const confirmResult = await confirmMarketplaceSkill(
               skillManager,
@@ -2140,7 +2141,7 @@ Use \`ask_user\` to request these from the user, or create them yourself (e.g. r
           author_name: z2.string().optional().describe("Your display name as the author")
         },
         async (args) => {
-          const skill = skillManager.get(args.name);
+          const skill = await skillManager.getWithDbFallback(args.name);
           if (!skill) {
             return {
               content: [
@@ -3323,6 +3324,7 @@ var TaskProcessor = class {
     let tokenUsage;
     try {
       await emitEvent(task.id, "status_change", { status: "running" });
+      await this.skillManager.ensureLoaded();
       const systemPrompt = await buildSystemPrompt(task, {
         memoryManager: this.memoryManager,
         skillManager: this.skillManager,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "assistme",
-  "version": "0.8.6",
+  "version": "0.8.8",
   "description": "AssistMe CLI Agent - AI-powered agentic assistant for code, browser, and automation",
   "type": "module",
   "main": "dist/index.js",

package/src/agent/processor.ts

@@ -181,6 +181,9 @@ export class TaskProcessor {
     try {
       await emitEvent(task.id, "status_change", { status: "running" });
 
+      // Guarantee skills are loaded before building prompt or running tools
+      await this.skillManager.ensureLoaded();
+
       // Build system prompt with memories + skills + history
       const systemPrompt = await buildSystemPrompt(task, {
         memoryManager: this.memoryManager,

package/src/agent/skills.ts

@@ -65,6 +65,8 @@ export class SkillManager {
 
   /** Tracks the in-flight loadFromDb() promise so callers can await it. */
   private loadPromise: Promise<void> | null = null;
+  /** True once loadFromDb() completes without error (even with 0 skills). */
+  private loaded = false;
 
   /** Bounded cache for findRelevant() — keyed by normalized prompt, invalidated on skill changes. */
   private relevanceCache = new LRUCache<
@@ -94,11 +96,37 @@ export class SkillManager {
   }
 
   /**
-   * Wait for any in-flight loadFromDb() to finish.
-   * Safe to call multiple times — resolves immediately if no load is pending.
+   * Guarantee that loadFromDb() has completed at least once.
+   * Awaits any in-flight load; retries once if the initial load failed.
+   * Safe and cheap to call repeatedly — no-ops after the first success.
    */
   async ensureLoaded(): Promise<void> {
     if (this.loadPromise) await this.loadPromise;
+    if (!this.loaded && this.userId) {
+      await this.loadFromDb();
+    }
+  }
+
+  /**
+   * Get a skill by name, with a DB search fallback.
+   * Handles: race conditions, failed initial loads, and skills added externally
+   * after the initial load (e.g. created via UI while agent is running).
+   */
+  async getWithDbFallback(name: string): Promise<Skill | undefined> {
+    await this.ensureLoaded();
+
+    const skill = this.skills.get(name);
+    if (skill) return skill;
+
+    // In-memory miss: check if the skill exists in DB via search
+    const dbResults = await searchSkillsInDb(name, 5);
+    const match = dbResults?.find((r) => r.name === name);
+    if (!match) return undefined;
+
+    // Found in DB — reload all skills into memory and return
+    this.loaded = false; // force reload
+    await this.loadFromDb();
+    return this.skills.get(name);
   }
 
   private async _doLoadFromDb(): Promise<void> {
@@ -113,6 +141,7 @@ export class SkillManager {
       }
 
       this.rebuildIdfCache();
+      this.loaded = true;
 
       if (this.skills.size > 0) {
         log.info(`Loaded ${this.skills.size} skill(s) from DB`);

package/src/mcp/agent-tools-server.ts

@@ -10,6 +10,7 @@ import type { SkillManager } from "../agent/skills.js";
 import { substituteArguments, preprocessDynamicContext } from "../agent/skill-utils.js";
 import { validateSkillName } from "../agent/skill-utils.js";
 import { callMcpHandler } from "../db/api-client.js";
+import { upsertAgentSkill } from "../agent/skill-db.js";
 import { JobRunner } from "../agent/job-runner.js";
 import { createScheduledTask, getNextRunTime } from "../agent/scheduler.js";
 import { getCredentialStore, type CredentialType } from "../credentials/index.js";
@@ -173,32 +174,32 @@ export function createAgentToolsServer(deps: AgentToolsDeps): McpSdkServerConfig
           description: z.string().optional().describe("Updated description (optional)"),
         },
         async (args) => {
-          // Ensure DB skills are loaded (avoids race with async loadFromDb)
+          // Fast path: skill is in memory → update in-memory + DB
           await skillManager.ensureLoaded();
-
-          const existing = skillManager.get(args.name);
-          if (!existing) {
-            const available = skillManager
-              .getAll()
-              .map((s) => s.name)
-              .join(", ");
+          if (skillManager.update(args.name, args.improved_instructions, args.description)) {
+            log.success(`Self-improvement: improved skill "${args.name}"`);
             return {
               content: [
                 {
                   type: "text",
-                  text: `Skill "${args.name}" not found. Available skills: ${available}`,
+                  text: `Skill "${args.name}" improved and version bumped.`,
                 },
               ],
             };
           }
 
-          const updated = skillManager.update(
-            args.name,
-            args.improved_instructions,
-            args.description
-          );
-          if (updated) {
-            log.success(`Self-improvement: improved skill "${args.name}"`);
+          // Fallback: skill not in memory (e.g. loadFromDb failed, race condition,
+          // or invoked from detail page where prompt already contains full content).
+          // Write directly to agent_skills — the tool params already have everything needed.
+          const result = await upsertAgentSkill({
+            name: args.name,
+            description: args.description || "",
+            content: args.improved_instructions,
+            version: "1.0.1",
+            source: "auto_improved",
+          });
+          if (result) {
+            log.success(`Self-improvement: improved skill "${args.name}" (direct DB)`);
             return {
               content: [
                 {
@@ -231,10 +232,8 @@ export function createAgentToolsServer(deps: AgentToolsDeps): McpSdkServerConfig
             .describe("Arguments to pass to the skill (replaces $ARGUMENTS placeholders)"),
         },
         async (args) => {
-          // Ensure DB skills are loaded (avoids race with async loadFromDb)
-          await skillManager.ensureLoaded();
-
-          let skill = skillManager.get(args.name);
+          // Use DB fallback to handle race condition with async loadFromDb
+          let skill = await skillManager.getWithDbFallback(args.name);
 
           // If not in user's collection, try marketplace — requires user confirmation
           if (!skill) {
@@ -547,7 +546,7 @@ export function createAgentToolsServer(deps: AgentToolsDeps): McpSdkServerConfig
           author_name: z.string().optional().describe("Your display name as the author"),
         },
         async (args) => {
-          const skill = skillManager.get(args.name);
+          const skill = await skillManager.getWithDbFallback(args.name);
           if (!skill) {
             return {
               content: [