assistme 0.2.5 → 0.2.6

package/dist/index.js

@@ -3179,19 +3179,17 @@ ${content}`;
           response += `**Your task:** Analyze this job description and decompose it into 4-10 automatable skills.
 
 `;
-          response += `**IMPORTANT \u2014 Confirmation workflow:**
+          response += `**IMPORTANT \u2014 You MUST use request_user_confirmation before creating skills:**
 `;
-          response += `1. First, analyze the job and draft a list of proposed skills (name, emoji, one-line description for each).
+          response += `1. Analyze the job and draft a list of proposed skills (name, emoji, one-line description for each).
 `;
-          response += `2. Then call \`request_user_confirmation\` to present these skills to the user for approval BEFORE creating any.
+          response += `2. Call \`request_user_confirmation\` with the formatted skill list as "message" and these options:
 `;
-          response += `   - message: show a formatted list of all proposed skills
+          response += `   - options: [{label: "Approve All", action_key: "approve_all", description: "Create all proposed skills"}, {label: "Cancel", action_key: "cancel", description: "Do not create any skills"}]
 `;
-          response += `   - options: [{label: "Approve All", value: "approve_all"}, {label: "Cancel", value: "cancel"}]
+          response += `3. WAIT for the response. If action_key is "approve_all", create all skills using \`skill_create\`. If "cancel", stop.
 `;
-          response += `3. If the user approves, create all skills using \`skill_create\` for each.
-`;
-          response += `4. If the user cancels, stop without creating anything.
+          response += `4. Do NOT ask for confirmation in text. Do NOT create skills without calling request_user_confirmation first.
 
 `;
           response += `For each skill, call \`skill_create\` with:
@@ -3361,18 +3359,18 @@ ${content}`;
       // ── User Confirmation Tool ─────────────────────────────────
       tool(
         "request_user_confirmation",
-        "Pause and ask the user for approval or input via the web UI. Returns the user's response. Use this before creating skills, making irreversible changes, etc.",
+        "Pause and ask the user for approval or input via the web UI. Returns the user's chosen action_key. Use this BEFORE creating skills, making irreversible changes, etc. The agent will block until the user responds or the timeout expires.",
         {
           message: z.string().describe("What to show the user (supports markdown)"),
           options: z.array(z.object({
-            label: z.string(),
-            value: z.string(),
-            description: z.string().optional()
+            label: z.string().describe("Button label shown to user"),
+            action_key: z.string().describe("Machine-readable key returned when selected"),
+            description: z.string().optional().describe("Tooltip/description for this option")
           })).describe("Buttons/options to show the user"),
           timeout_seconds: z.number().optional().describe("How long to wait for response (default: 300)")
         },
         async (args) => {
-          const actionId = crypto.randomUUID();
+          const actionId = `action_${Date.now()}_${Math.random().toString(36).slice(2, 8)}`;
           const timeout = (args.timeout_seconds || 300) * 1e3;
           const actionData = {
             id: actionId,
@@ -3383,20 +3381,24 @@ ${content}`;
           };
           try {
             await setActionRequest(taskId, actionData);
-            await emitEvent(taskId, "user_action_request", actionData);
+            log.info(`Action request ${actionId} stored in metadata, waiting for user response...`);
+            emitEvent(taskId, "user_action_request", actionData).catch(() => {
+            });
             const startTime = Date.now();
             const pollInterval = 2e3;
             while (Date.now() - startTime < timeout) {
               const response = await pollActionResponse(taskId);
               if (response) {
-                log.info(`User responded to action request ${actionId}: ${JSON.stringify(response)}`);
+                const actionKey = response.action_key || response.action || "";
+                const label = response.label || actionKey;
+                log.info(`User responded: ${label} (${actionKey})`);
                 return {
                   content: [{
                     type: "text",
                     text: JSON.stringify({
                       status: "responded",
-                      action: response.action || response.value,
-                      response
+                      action_key: actionKey,
+                      label
                     })
                   }]
                 };
@@ -3414,6 +3416,7 @@ ${content}`;
               }]
             };
           } catch (err) {
+            log.error(`request_user_confirmation failed: ${err}`);
             return {
               content: [{
                 type: "text",
@@ -3721,7 +3724,7 @@ Available capabilities:
 
 5. JOB AUTOMATION:
    - When the user describes their job/role/daily work, use skill_generate to decompose it into automatable skills
-   - First call without auto_create to show the plan, then with auto_create:true after user confirms
+   - ALWAYS use request_user_confirmation to get user approval before creating skills \u2014 never create skills without approval
    - Use job_run to start a job \u2014 it gives you the job's goal and available skills as capabilities
    - When running a job, be AGENTIC: decide dynamically what to do based on what you discover
    - Do NOT follow a fixed sequence \u2014 if checking Slack reveals a task that needs GitHub, go do GitHub immediately

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "assistme",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "description": "AssistMe CLI Agent - AI-powered assistant that controls your real browser",
   "type": "module",
   "main": "dist/index.js",

package/src/agent/mcp-servers.ts

@@ -441,13 +441,12 @@ export function createAgentToolsServer(deps: AgentToolsDeps): McpSdkServerConfig
           }
 
           response += `**Your task:** Analyze this job description and decompose it into 4-10 automatable skills.\n\n`;
-          response += `**IMPORTANT — Confirmation workflow:**\n`;
-          response += `1. First, analyze the job and draft a list of proposed skills (name, emoji, one-line description for each).\n`;
-          response += `2. Then call \`request_user_confirmation\` to present these skills to the user for approval BEFORE creating any.\n`;
-          response += `   - message: show a formatted list of all proposed skills\n`;
-          response += `   - options: [{label: "Approve All", value: "approve_all"}, {label: "Cancel", value: "cancel"}]\n`;
-          response += `3. If the user approves, create all skills using \`skill_create\` for each.\n`;
-          response += `4. If the user cancels, stop without creating anything.\n\n`;
+          response += `**IMPORTANT — You MUST use request_user_confirmation before creating skills:**\n`;
+          response += `1. Analyze the job and draft a list of proposed skills (name, emoji, one-line description for each).\n`;
+          response += `2. Call \`request_user_confirmation\` with the formatted skill list as "message" and these options:\n`;
+          response += `   - options: [{label: "Approve All", action_key: "approve_all", description: "Create all proposed skills"}, {label: "Cancel", action_key: "cancel", description: "Do not create any skills"}]\n`;
+          response += `3. WAIT for the response. If action_key is "approve_all", create all skills using \`skill_create\`. If "cancel", stop.\n`;
+          response += `4. Do NOT ask for confirmation in text. Do NOT create skills without calling request_user_confirmation first.\n\n`;
           response += `For each skill, call \`skill_create\` with:\n`;
           response += `- name: kebab-case name (e.g. "slack-message-check")\n`;
           response += `- description: one-line description\n`;
@@ -610,18 +609,19 @@ export function createAgentToolsServer(deps: AgentToolsDeps): McpSdkServerConfig
       tool(
         "request_user_confirmation",
         "Pause and ask the user for approval or input via the web UI. " +
-          "Returns the user's response. Use this before creating skills, making irreversible changes, etc.",
+          "Returns the user's chosen action_key. Use this BEFORE creating skills, making irreversible changes, etc. " +
+          "The agent will block until the user responds or the timeout expires.",
         {
           message: z.string().describe("What to show the user (supports markdown)"),
           options: z.array(z.object({
-            label: z.string(),
-            value: z.string(),
-            description: z.string().optional(),
+            label: z.string().describe("Button label shown to user"),
+            action_key: z.string().describe("Machine-readable key returned when selected"),
+            description: z.string().optional().describe("Tooltip/description for this option"),
           })).describe("Buttons/options to show the user"),
           timeout_seconds: z.number().optional().describe("How long to wait for response (default: 300)"),
         },
         async (args) => {
-          const actionId = crypto.randomUUID();
+          const actionId = `action_${Date.now()}_${Math.random().toString(36).slice(2, 8)}`;
           const timeout = (args.timeout_seconds || 300) * 1000;
 
           const actionData = {
@@ -633,37 +633,38 @@ export function createAgentToolsServer(deps: AgentToolsDeps): McpSdkServerConfig
           };
 
           try {
-            // 1. Store action request in message metadata via RPC
+            // Store action request in message metadata via RPC — UI reads this
             await setActionRequest(taskId, actionData);
+            log.info(`Action request ${actionId} stored in metadata, waiting for user response...`);
 
-            // 2. Emit user_action_request event so web UI renders buttons
-            await emitEvent(taskId, "user_action_request", actionData);
+            // Also emit event for real-time notification (best-effort)
+            emitEvent(taskId, "user_action_request", actionData).catch(() => {});
 
-            // 3. Poll for response
+            // Poll for response
             const startTime = Date.now();
             const pollInterval = 2000;
 
             while (Date.now() - startTime < timeout) {
               const response = await pollActionResponse(taskId);
               if (response) {
-                log.info(`User responded to action request ${actionId}: ${JSON.stringify(response)}`);
+                const actionKey = (response.action_key || response.action || "") as string;
+                const label = (response.label || actionKey) as string;
+                log.info(`User responded: ${label} (${actionKey})`);
                 return {
                   content: [{
                     type: "text",
                     text: JSON.stringify({
                       status: "responded",
-                      action: response.action || response.value,
-                      response,
+                      action_key: actionKey,
+                      label,
                     }),
                   }],
                 };
               }
 
-              // Wait before next poll
               await new Promise((resolve) => setTimeout(resolve, pollInterval));
             }
 
-            // Timeout
             log.warn(`Action request ${actionId} timed out after ${args.timeout_seconds || 300}s`);
             return {
               content: [{
@@ -675,6 +676,7 @@ export function createAgentToolsServer(deps: AgentToolsDeps): McpSdkServerConfig
               }],
             };
           } catch (err) {
+            log.error(`request_user_confirmation failed: ${err}`);
             return {
               content: [{
                 type: "text",

package/src/agent/processor.ts

@@ -68,7 +68,7 @@ Available capabilities:
 
 5. JOB AUTOMATION:
    - When the user describes their job/role/daily work, use skill_generate to decompose it into automatable skills
-   - First call without auto_create to show the plan, then with auto_create:true after user confirms
+   - ALWAYS use request_user_confirmation to get user approval before creating skills — never create skills without approval
    - Use job_run to start a job — it gives you the job's goal and available skills as capabilities
    - When running a job, be AGENTIC: decide dynamically what to do based on what you discover
    - Do NOT follow a fixed sequence — if checking Slack reveals a task that needs GitHub, go do GitHub immediately