arui-scripts 23.9.1 → 23.9.3

package/.turbo/turbo-test.log

@@ -1,26 +1,28 @@
 ts-jest[versions] (WARN) Version 6.0.2 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=4.3.0 <6.0.0-0). Please do not report issues in ts-jest if you are using unsupported versions.
 ts-jest[versions] (WARN) Version 6.0.2 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=4.3.0 <6.0.0-0). Please do not report issues in ts-jest if you are using unsupported versions.
 ts-jest[versions] (WARN) Version 6.0.2 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=4.3.0 <6.0.0-0). Please do not report issues in ts-jest if you are using unsupported versions.
-PASS src/plugins/postcss-global-variables/utils/__tests__/add-global-variable.tests.ts (14.607 s)
+PASS src/commands/util/__tests__/run-compilers.tests.ts (19.192 s)
+PASS src/plugins/postcss-global-variables/utils/__tests__/add-global-variable.tests.ts
 PASS src/bin/__tests__/create-cli.tests.ts
 PASS src/configs/app-configs/__tests__/update-with-presets.tests.ts
 PASS src/configs/util/__tests__/create-watch-ignore-regex.tests.ts
 PASS src/configs/util/__tests__/apply-overrides.tests.ts
 PASS src/commands/util/__tests__/artifacts-deprecations.tests.ts
+PASS src/plugins/__tests__/attribute-module-css.tests.ts (38.033 s)
 PASS src/configs/app-configs/__tests__/update-with-env.tests.ts
-PASS src/plugins/__tests__/attribute-module-css.tests.ts (26.948 s)
+PASS src/configs/util/__tests__/find-plugin.tests.ts (40.904 s)
+PASS src/configs/__tests__/rspack-client-assets.tests.ts (18.834 s)
 PASS src/configs/app-configs/__tests__/update-with-package.tests.ts
-PASS src/configs/util/__tests__/compress-with-dcb.test.ts
 PASS src/configs/util/__tests__/get-polyfills.tests.ts
+PASS src/configs/__tests__/webpack-client-modules.tests.ts
 PASS src/plugins/postcss-global-variables/utils/__tests__/parse-variables.tests.ts
-PASS src/commands/util/__tests__/client-assets-sizes.tests.ts
-PASS src/plugins/postcss-global-variables/utils/__tests__/get-media-query-name.tests.ts
+PASS src/configs/util/__tests__/compress-with-dcb.test.ts
 PASS src/configs/app-configs/__tests__/validate-settings-keys.tests.ts
-PASS src/configs/util/__tests__/find-plugin.tests.ts (30.649 s)
-PASS src/configs/__tests__/webpack-client-modules.tests.ts (15.5 s)
+PASS src/plugins/postcss-global-variables/utils/__tests__/get-media-query-name.tests.ts
+PASS src/commands/util/__tests__/client-assets-sizes.tests.ts
 
-Test Suites: 17 passed, 17 total
-Tests:       47 passed, 47 total
+Test Suites: 19 passed, 19 total
+Tests:       54 passed, 54 total
 Snapshots:   0 total
-Time:        33.027 s
+Time:        42.588 s
 Ran all test suites.

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # arui-scripts
 
+## 23.9.3
+
+### Patch Changes
+
+-   [#605](https://github.com/core-ds/arui-scripts/pull/605) [`94ce42aa`](https://github.com/core-ds/arui-scripts/commit/94ce42aa67e8fa3e8c4f1f883c5aac179de9413e) Thanks [@dmitrbrvsk](https://github.com/dmitrbrvsk)! - Сборка больше не завершается успешно, если компилятор упал. Раньше при падении по сигналу (например, из-за нехватки памяти) `arui-scripts build` выходил с кодом 0 и CI/CD считал такую сборку успешной, хотя ассеты собраны не полностью.
+
+## 23.9.2
+
+### Patch Changes
+
+-   [#602](https://github.com/core-ds/arui-scripts/pull/602) [`0c7063af`](https://github.com/core-ds/arui-scripts/commit/0c7063af3b3c735a562962a4d56884399511f430) Thanks [@dmitrbrvsk](https://github.com/dmitrbrvsk)! - Минификация картинок не работала: правило стояло после общего svg правила в `oneOf` и использовало несуществующий тип модуля `assets`. Правило перенесено вперед, поправлен тип, у svgo отключен `removeViewBox`
+
+-   [#602](https://github.com/core-ds/arui-scripts/pull/602) [`d67562cb`](https://github.com/core-ds/arui-scripts/commit/d67562cb95db673cee84bf1b7e0df3a85a4ec503) Thanks [@dmitrbrvsk](https://github.com/dmitrbrvsk)! - для словарей сжатия не добавляется `CopyRspackPlugin`, если список словарей пуст
+
 ## 23.9.1
 
 ### Patch Changes

package/build/commands/util/run-compilers.js

@@ -12,26 +12,27 @@ function runCompilers(pathToCompilers) {
         fs_extra_1.default.removeSync(app_configs_1.configs.serverOutputPath);
     }
     const compilers = pathToCompilers.map((pathToCompiler) => {
-        if (Array.isArray(pathToCompiler)) {
-            const compiler = (0, child_process_1.spawn)('node', pathToCompiler, {
-                stdio: 'inherit',
-                cwd: app_configs_1.configs.cwd,
-            });
-            compiler.on('error', onProcessExit);
-            compiler.on('close', onProcessExit);
-            return compiler;
-        }
-        const compiler = (0, child_process_1.spawn)('node', [pathToCompiler], {
+        const compiler = (0, child_process_1.spawn)('node', Array.isArray(pathToCompiler) ? pathToCompiler : [pathToCompiler], {
             stdio: 'inherit',
+            cwd: app_configs_1.configs.cwd,
         });
-        compiler.on('error', onProcessExit);
-        compiler.on('close', onProcessExit);
+        compiler.on('error', onProcessError);
+        compiler.on('close', onProcessClose);
         return compiler;
     });
-    function onProcessExit(code) {
+    function stopCompilers(exitCode) {
+        compilers.forEach((compiler) => compiler.kill());
+        process.exit(exitCode);
+    }
+    // в error приходит объект ошибки, а не код для выхода
+    function onProcessError(error) {
+        console.error(error.message);
+        stopCompilers(1);
+    }
+    function onProcessClose(code) {
         if (code !== 0) {
-            compilers.forEach((compiler) => compiler.kill());
-            process.exit(code);
+            // code === null означает, что процесс убит сигналом
+            stopCompilers(code !== null && code !== void 0 ? code : 1);
         }
     }
 }

package/build/configs/config-extras/minimizers/imagemin/imagemin.d.ts

@@ -2,6 +2,11 @@ import ImageMinimizerPlugin from 'image-minimizer-webpack-plugin';
 export declare function getImageMinLoader(): false | {
     test: RegExp;
     type: string;
+    parser: {
+        dataUrlCondition: {
+            maxSize: number | undefined;
+        };
+    };
     use: {
         loader: string;
         options: {
@@ -17,6 +22,15 @@ export declare function getImageMinLoader(): false | {
                         colorTypeReduction: boolean | undefined;
                         paletteReduction: boolean | undefined;
                         interlaced: boolean | undefined;
+                    })[] | (string | {
+                        plugins: {
+                            name: string;
+                            params: {
+                                overrides: {
+                                    removeViewBox: boolean;
+                                };
+                            };
+                        }[];
                     })[] | (string | {
                         optimizationLevel: number | undefined;
                         interlaced: boolean;

package/build/configs/config-extras/minimizers/imagemin/imagemin.js

@@ -21,7 +21,13 @@ function getImageMinLoader() {
     ].filter(Boolean);
     return {
         test: new RegExp(`\\.(${loaderExtensions.join('|')})$`),
-        type: 'assets',
+        type: 'asset',
+        // правило стоит раньше общих asset правил, поэтому порог инлайна должен быть тем же
+        parser: {
+            dataUrlCondition: {
+                maxSize: app_configs_1.configs.dataUrlMaxSize,
+            },
+        },
         use: [
             {
                 loader: image_minimizer_webpack_plugin_1.default.loader,
@@ -47,7 +53,20 @@ function getImageMinLoader() {
                                         interlaced: png === null || png === void 0 ? void 0 : png.interlaced,
                                     },
                                 ],
-                                (svg === null || svg === void 0 ? void 0 : svg.enabled) && ['svgo'],
+                                (svg === null || svg === void 0 ? void 0 : svg.enabled) && [
+                                    'svgo',
+                                    {
+                                        plugins: [
+                                            {
+                                                name: 'preset-default',
+                                                params: {
+                                                    // preset-default в svgo вырезает viewBox, без него svg перестают масштабироваться
+                                                    overrides: { removeViewBox: false },
+                                                },
+                                            },
+                                        ],
+                                    },
+                                ],
                                 (gif === null || gif === void 0 ? void 0 : gif.enabled) && [
                                     'gifsicle',
                                     {

package/build/configs/rspack.client.js

@@ -249,6 +249,8 @@ const createSingleClientWebpackConfig = (mode, entry, configName) => (Object.ass
                             },
                         ],
                     },
+                    // В oneOf срабатывает первое подходящее правило, поэтому минификация картинок должна стоять раньше svg правила
+                    mode === 'prod' && (0, minimizers_1.getImageMinLoader)(),
                     {
                         test: /\.svg/,
                         type: 'asset',
@@ -258,7 +260,6 @@ const createSingleClientWebpackConfig = (mode, entry, configName) => (Object.ass
                             },
                         },
                     },
-                    mode === 'prod' && (0, minimizers_1.getImageMinLoader)(),
                     {
                         exclude: [/\.(js|jsx|mjs|cjs|ts|tsx)$/, /\.(html|ejs)$/, /\.json$/],
                         type: 'asset',
@@ -328,7 +329,7 @@ const createSingleClientWebpackConfig = (mode, entry, configName) => (Object.ass
                 filename: '../index.html',
             }),
         mode === 'dev' && app_configs_1.configs.clientOnly && new client_env_config_1.ClientConfigPlugin(),
-        app_configs_1.configs.compressionPredefinedDictionaryPath &&
+        app_configs_1.configs.compressionPredefinedDictionaryPath.length > 0 &&
             new core_1.CopyRspackPlugin({
                 patterns: app_configs_1.configs.compressionPredefinedDictionaryPath,
             }),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "arui-scripts",
-  "version": "23.9.1",
+  "version": "23.9.3",
   "main": "./build/index.js",
   "typings": "./build/index.d.ts",
   "exports": {